Re: [Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

On 30/04/17 16:55, Timothy Arceri wrote: Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix_columns and vector_elements were set to 0, making this else case a no-op. Commit 75a31a20af26 changed that, causing malloc corruption i

[Mesa-dev] [PATCH] i965: Don't allocate uniform space for samplers

Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix_columns and vector_elements were set to 0, making this else case a no-op. Commit 75a31a20af26 changed that, causing malloc corruption in thousands of tests on i965. Fixes: 75a31

Re: [Mesa-dev] [PATCH v2] nv50/ir: optimize shl(a, 0) to a

Maybe in a separate change. I'd want to double check on all gens. I think the thing I suggested is sufficient. On Apr 29, 2017 8:09 PM, "Karol Herbst" wrote: 2017-04-30 0:28 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 6:09 PM, Karol Herbst wrote: >> helps two alien isolation shaders >> >>

Re: [Mesa-dev] [PATCH] radv: Add NIR loop unrolling.

On 29/04/17 07:11, Bas Nieuwenhuizen wrote: Not much effect on dota2/talos, but positive on deferred. Yeah I had a similar patch but didn't send it because I didn't see any difference. Feral tend to have loop heavy shader maybe mad max will show something? Anyway. Reviewed-by: Timothy Arcer

Re: [Mesa-dev] [PATCH v2] nv50/ir: optimize shl(a, 0) to a

2017-04-30 0:28 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 6:09 PM, Karol Herbst wrote: >> helps two alien isolation shaders >> >> shader-db: >> total instructions in shared programs : 4251497 -> 4251494 (-0.00%) >> total gprs used in shared programs: 513962 -> 513962 (0.00%) >> total l

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On Fri, Apr 28, 2017 at 7:12 PM, Marek Olšák wrote: > These drivers need testing: > - nv30 > - nv50 > - nvc0 I'm going to try to test these by Wednesday May 3. If you don't hear from me (or anyone else regarding these drivers), don't wait. Cheers, -ilia ___

Re: [Mesa-dev] [PATCH v2] nv50/ir: optimize shl(a, 0) to a

On Sat, Apr 29, 2017 at 6:09 PM, Karol Herbst wrote: > helps two alien isolation shaders > > shader-db: > total instructions in shared programs : 4251497 -> 4251494 (-0.00%) > total gprs used in shared programs: 513962 -> 513962 (0.00%) > total local used in shared programs : 29797 -> 29797

[Mesa-dev] [PATCH v2] nv50/ir: optimize shl(a, 0) to a

helps two alien isolation shaders shader-db: total instructions in shared programs : 4251497 -> 4251494 (-0.00%) total gprs used in shared programs: 513962 -> 513962 (0.00%) total local used in shared programs : 29797 -> 29797 (0.00%) total bytes used in shared programs : 38960264 -> 38960

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

Hi Marek I've also tested this series with nine and STALKER: CoC. Sadly it segfaults. Bisected to this patch: "gallium: remove pipe_index_buffer and set_index_buffer" edmondo On Sat, Apr 29, 2017 at 1:12 AM, Marek Olšák wrote: > Hi, > > This series shrinks various gallium structures and remov

[Mesa-dev] [Bug 100876] Variable GALLIUM_HUD_DUMP_DIR is not working with Wine LFS

https://bugs.freedesktop.org/show_bug.cgi?id=100876 Edmondo Tommasina changed: What|Removed |Added CC||edmondo.tommas...@gmail.com --- Com

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 talonz changed: What|Removed |Added CC||talonz...@gmail.com --- Comment #11 from talon

Re: [Mesa-dev] [PATCH] nv50/ir: optimmize shl(a, 0) to a

2017-04-29 21:03 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 12:46 PM, Karol Herbst wrote: >> helps two alien isolation shaders >> >> shader-db: >> total instructions in shared programs : 4251497 -> 4251494 (-0.00%) >> total gprs used in shared programs: 513962 -> 513962 (0.00%) >> total

Re: [Mesa-dev] [PATCH] gm107/ir: add a missing assertion in emitISCADD()

Reviewed-by: Ilia Mirkin On Sat, Apr 29, 2017 at 11:40 AM, Samuel Pitoiset wrote: > For consistency, similar to the other emitters. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/s

Re: [Mesa-dev] [PATCH] nv50/ir: optimmize shl(a, 0) to a

On Sat, Apr 29, 2017 at 12:46 PM, Karol Herbst wrote: > helps two alien isolation shaders > > shader-db: > total instructions in shared programs : 4251497 -> 4251494 (-0.00%) > total gprs used in shared programs: 513962 -> 513962 (0.00%) > total local used in shared programs : 29797 -> 29797

Re: [Mesa-dev] [PATCH v3 06/37] genxml: Add alias for MOCS.

On April 29, 2017 01:02:28 Kenneth Graunke wrote: On Tuesday, April 25, 2017 1:59:15 PM PDT Rafael Antognolli wrote: Use an alias, so we can set the same value as the #define's. v3: - Call it "SO Buffer MOCS" to follow the most common naming scheme. - Add alias for gen7 and gen75 too (K

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 Vasyl Demin changed: What|Removed |Added CC||vasyl.de...@gmail.com -- You are receivin

Re: [Mesa-dev] [Nouveau] [PATCH] nv50/ir: optimmize shl(a, 0) to a

"optimmize" ? No need to resend just for that though. Reviewed-by: Samuel Pitoiset On 04/29/2017 06:46 PM, Karol Herbst wrote: helps two alien isolation shaders shader-db: total instructions in shared programs : 4251497 -> 4251494 (-0.00%) total gprs used in shared programs: 513962 -> 513

[Mesa-dev] [PATCH] nv50/ir: optimmize shl(a, 0) to a

helps two alien isolation shaders shader-db: total instructions in shared programs : 4251497 -> 4251494 (-0.00%) total gprs used in shared programs: 513962 -> 513962 (0.00%) total local used in shared programs : 29797 -> 29797 (0.00%) total bytes used in shared programs : 38960264 -> 38960

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

yes. I will follow up with a patch, which will optimize that stuff again 2017-04-29 18:20 GMT+02:00 Samuel Pitoiset : > > > On 04/29/2017 06:14 PM, Emil Velikov wrote: >> >> Hi Samuel, >> >> On 29 April 2017 at 17:01, Samuel Pitoiset >> wrote: >>> >>> Doing '(a << b) + c' when b is 0 is dumb, ADD

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

On 04/29/2017 06:14 PM, Emil Velikov wrote: Hi Samuel, On 29 April 2017 at 17:01, Samuel Pitoiset wrote: Doing '(a << b) + c' when b is 0 is dumb, ADD should be used instead. This fixes a compilation error with Alien Isolation because src(1) is expected to be an immediate value, and the rep

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

Hi Samuel, On 29 April 2017 at 17:01, Samuel Pitoiset wrote: > Doing '(a << b) + c' when b is 0 is dumb, ADD should be used > instead. > > This fixes a compilation error with Alien Isolation because > src(1) is expected to be an immediate value, and the > replaceZero logic will transform 0 to $r6

[Mesa-dev] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

Doing '(a << b) + c' when b is 0 is dumb, ADD should be used instead. This fixes a compilation error with Alien Isolation because src(1) is expected to be an immediate value, and the replaceZero logic will transform 0 to $r63 (or $r255). Signed-off-by: Samuel Pitoiset Cc: "13.0 17.0 17.1" ---

Re: [Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

2017-04-29 17:18 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 10:41 AM, Karol Herbst wrote: >> fixes a crash in Alien Isolation > > What crash? assertion, because shladd requires an immediate, there can't be a reg at src1 "shladd u32 $r0 $r0 $r63 $r36" is invalid for the emiter so we have t

[Mesa-dev] [PATCH] gm107/ir: add a missing assertion in emitISCADD()

For consistency, similar to the other emitters. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv

Re: [Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

On Sat, Apr 29, 2017 at 10:41 AM, Karol Herbst wrote: > fixes a crash in Alien Isolation What crash? How did the zero get there? Does this only happen if you do your optimization loop thing? In either case, we still want the replaceZero() logic. However that logic should be aware that the middle

[Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with the zero reg for SHLADD

fixes a crash in Alien Isolation Signed-off-by: Karol Herbst Cc: 13.0 17.0 17.1 --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/driv

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #10 from Gregor Münch --- I just tested it too, for me the world map is fixed. But Im waiting for your screenshots to see what you see. ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assi

[Mesa-dev] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

fixes a crash in Alien Isolation Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/

[Mesa-dev] [PATCH v2] mesa: Avoid leaking surface in st_renderbuffer_delete

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100741 Fixes: a5e733c6b52 mesa: drop current draw/read buffer when ctx is released CC: Rob Clark v2: add comment in code --- src/mesa/main/context.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

On Sat, Apr 29, 2017 at 5:00 AM, Lucas Stach wrote: > Am Freitag, den 28.04.2017, 14:17 -0400 schrieb Rob Clark: >> I guess this applies on top of one of Ben's in-flight patches? >> Perhaps it can be squashed into that? (Otherwise remind me about >> this >> when the modifiers patchset is merged)

[Mesa-dev] [Bug 100854] YUV to RGB Color Space Conversion result is not precise

https://bugs.freedesktop.org/show_bug.cgi?id=100854 --- Comment #2 from johnson@intel.com --- @Matt Turner Yes I have. Also piglit test has YUV2RGB test https://cgit.freedesktop.org/piglit/tree/tests/spec/ext_image_dma_buf_import/sample_yuv.c -- You are receiving this mail because: You are t

Re: [Mesa-dev] [PATCH 12/16] travis: split the make target to three separate ones

On 29 April 2017 at 00:02, Andres Gomez wrote: > With those 2 changes, this is: > Seems like I've squashed them in the wrong patch :-\ Fixed up and pushed the series. Thanks again for the comments and reviews! Emil ___ mesa-dev mailing list mesa-dev@li

Re: [Mesa-dev] [PATCH] egl: initialise dummy_thread via _eglInitThreadInfo

On Sat, Apr 29, 2017 at 10:04 AM, Emil Velikov wrote: > On 29 April 2017 at 14:51, Ilia Mirkin wrote: >> On Tue, Apr 25, 2017 at 12:07 PM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> Considering we cannot make dummy_thread a constant we might as well, >>> initialise by the same funct

Re: [Mesa-dev] [PATCH] egl: polish dri2_to_egl_attribute_map[]

On 28 April 2017 at 19:38, Matt Turner wrote: > Nice change. > Indeed - less code + smaller binary size. > Reviewed-by: Matt Turner Thanks! Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/me

Re: [Mesa-dev] [PATCH] egl: initialise dummy_thread via _eglInitThreadInfo

On 29 April 2017 at 14:51, Ilia Mirkin wrote: > On Tue, Apr 25, 2017 at 12:07 PM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Considering we cannot make dummy_thread a constant we might as well, >> initialise by the same function that handles the actual thread info. >> >> This way we don'

[Mesa-dev] [PATCH] c11/threads: rework Windows thrd_current() comment

From: Emil Velikov Drop the misleading "will not match the one returned by thread_create" hunk and provide more clarity as to what/why GetCurrentThread() isn't the solution we're looking for. Cc: José Fonseca Signed-off-by: Emil Velikov --- include/c11/threads_win32.h | 10 +++--- 1 file

Re: [Mesa-dev] [PATCH] egl: initialise dummy_thread via _eglInitThreadInfo

On Tue, Apr 25, 2017 at 12:07 PM, Emil Velikov wrote: > From: Emil Velikov > > Considering we cannot make dummy_thread a constant we might as well, > initialise by the same function that handles the actual thread info. > > This way we don't need to worry about mismatch between the initialiser > a

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

On 29 April 2017 at 14:24, Ilia Mirkin wrote: > On Sat, Apr 29, 2017 at 9:18 AM, Emil Velikov > wrote: >> On 18 April 2017 at 05:00, Ilia Mirkin wrote: >>> val_bool and val_int are in a union. val_bool gets the first byte, which >>> happens to work on LE when setting via the int, but breaks on

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Saturday, April 29, 2017 8:36 PM > To: Chad Versace ; Emil Velikov > ; Xu, Randy ; mesa- > d...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double > close issu

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

On Sat, Apr 29, 2017 at 9:18 AM, Emil Velikov wrote: > On 18 April 2017 at 05:00, Ilia Mirkin wrote: >> val_bool and val_int are in a union. val_bool gets the first byte, which >> happens to work on LE when setting via the int, but breaks on BE. By >> setting the value properly, we are able to us

Re: [Mesa-dev] [PATCH v2] scons: update for LLVM 4.0

Hi Ben, On 27 April 2017 at 21:31, Ben Boeckel wrote: > LLVMDemangle, LLVMGlobalISel, and LLVMDebugInfoMSF are new. > > Also update the comment to add irreader to the list of components. > > CC: > Reviewed-by: Chuck Atkins > Signed-off-by: Ben Boeckel Haven't tested this but is seems reasonabl

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

On 18 April 2017 at 05:00, Ilia Mirkin wrote: > val_bool and val_int are in a union. val_bool gets the first byte, which > happens to work on LE when setting via the int, but breaks on BE. By > setting the value properly, we are able to use DRI3 on BE architectures. > Tested by running glxgears wi

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Select pipeline and emit state base address in Gen8+ HiZ ops.

On 30 March 2017 at 23:32, Nanley Chery wrote: > On Mon, Mar 20, 2017 at 08:05:22PM -0700, Nanley Chery wrote: > > Okay, I've re-read the email. > >> On Mon, Mar 20, 2017 at 08:01:25PM -0700, Nanley Chery wrote: >> > On Thu, Mar 16, 2017 at 05:34:13PM -0700, Kenneth Graunke wrote: >> > > On Wednes

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

Hi I've just tested this with Nine. It causes a weird white strobing effect - I think there are other graphical glitches too but it's hard to tell I was testing the blizzard app http://eu.battle.net/en/app/ the same also happens when World of Warcraft is launched This doesn't happen if I use CSM

Re: [Mesa-dev] [PATCH] glsl: set vector_elements to 1 for samplers

On 04/28/2017 08:40 PM, Mark Janes wrote: Samuel Pitoiset writes: On 04/28/2017 06:58 PM, Mark Janes wrote: With this commit, a wide range of intel hardware began hanging during the GLES CTS, with dmesg errors like: [25488.739167] traps: glcts[15106] general protection ip:7fdac6484ba5 sp:

Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

On 28 April 2017 at 17:18, Chad Versace wrote: > On Thu 27 Apr 2017, Emil Velikov wrote: >> On 27 April 2017 at 12:14, Xu, Randy wrote: >> > Hi, Chad >> > >> > Please review this patch, we need it to solve some instability issues > > Randy and Tapani, could you provide a few dEQP test names that

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

Hey, Marek Olšák wrote on 29.04.2017 12:49: > On Apr 29, 2017 11:27 AM, "Timothy Arceri" wrote: > On 29/04/17 18:44, Marek Olšák wrote: >> [...] >> >> That's a good point. I didn't think of that. Still, if one game evicts all >> entries, the cache may be almost as good as disabled. >> > > I'm hap

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

On Apr 29, 2017 11:27 AM, "Timothy Arceri" wrote: On 29/04/17 18:44, Marek Olšák wrote: > > > On Apr 29, 2017 4:20 AM, "Michel Dänzer" mic...@daenzer.net>> wrote: > > On 28/04/17 09:11 PM, Marek Olšák wrote: > > On Thu, Apr 27, 2017 at 8:47 AM, Michel Dänzer > mailto:mic...@daenz

[Mesa-dev] [Bug 100882] dri2_lookup_egl_image crash dure to __DRIimageLookupExtension *loader is NULL

https://bugs.freedesktop.org/show_bug.cgi?id=100882 Bug ID: 100882 Summary: dri2_lookup_egl_image crash dure to __DRIimageLookupExtension *loader is NULL Product: Mesa Version: 17.0 Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

On 29/04/17 18:44, Marek Olšák wrote: On Apr 29, 2017 4:20 AM, "Michel Dänzer" > wrote: On 28/04/17 09:11 PM, Marek Olšák wrote: > On Thu, Apr 27, 2017 at 8:47 AM, Michel Dänzer mailto:mic...@daenzer.net>> wrote: >> On 27/04/17 10:15 AM, Timothy

Re: [Mesa-dev] [PATCH] util/disk_cache: remove percentage based max cache limit

On 28/04/17 22:29, Marek Olšák wrote: On Fri, Apr 28, 2017 at 5:05 AM, Timothy Arceri wrote: The more I think about it the more this seems like a bad idea. When we were deleting old cache dirs this wasn't so bad as it was unlikely we would ever hit the actual limit before things were cleaned up

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

Am Freitag, den 28.04.2017, 14:17 -0400 schrieb Rob Clark: > I guess this applies on top of one of Ben's in-flight patches? > Perhaps it can be squashed into that?  (Otherwise remind me about > this > when the modifiers patchset is merged) It applies on top of what is currently in FDO mesa/kmscube

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] disk_cache: reduce default cache size to 5% of filesystem

On Apr 29, 2017 4:20 AM, "Michel Dänzer" wrote: On 28/04/17 09:11 PM, Marek Olšák wrote: > On Thu, Apr 27, 2017 at 8:47 AM, Michel Dänzer wrote: >> On 27/04/17 10:15 AM, Timothy Arceri wrote: >>> Modern disks are extremely large and are only going to get bigger. >>> Usage has shown frequent Mesa

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #9 from talonz --- Just tested the patch ... while not fixing the problem completely it has fixed the graphic glitches replacing the red and green squares with minor graphic glitches on the campaign map and on the battle map it has c