[Mesa-dev] [PATCH 07/16] anv/cmd_buffer: return a VkResult in cmd_buffer_setup_attachments

--- src/intel/vulkan/genX_cmd_buffer.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index ae153d2..b46a922 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd

[Mesa-dev] [PATCH 13/16] anv/cmd_buffer: skip vkCmdDraw*() on broken command buffers

--- src/intel/vulkan/genX_cmd_buffer.c | 12 1 file changed, 12 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index cbad144..c78855b 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -1664

[Mesa-dev] [PATCH 02/16] blorp: handle out of memory without crashing in various batch emissions

--- src/intel/blorp/blorp_genX_exec.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h index 8f322b0..dc1b773 100644 --- a/src/intel/blorp/blorp_genX_exec.h +++ b/src/intel/blorp/blorp_genX_exec.h @@ -276,6 +276,8 @@

[Mesa-dev] [PATCH 15/16] anv/cmd_buffer: skip vkCmdExecuteCommands() on broken command buffers

--- src/intel/vulkan/genX_cmd_buffer.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 2c9aec8..8b752c4 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -640,6 +640,9

[Mesa-dev] [PATCH 08/16] anv/cmd_buffer: track error scenarios during command buffer recording

The vkCmd*() functions do not report errors, instead, any errors should be reported by the time we call vkEndCommandBuffer(). This means that we need to track things such as "out of host memory" and use that information to avoid executing code that could lead to crashes (due to the fact that the co

[Mesa-dev] [PATCH 11/16] anv: handle out of memory situations during queue submissions

--- src/intel/vulkan/anv_batch_chain.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index d0a1b03..aae5f78 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/src/intel/vulkan/anv_batch_chain

[Mesa-dev] [PATCH 16/16] anv/cmd_buffer: handle out of device memory during binding table emission

--- src/intel/vulkan/genX_cmd_buffer.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 8b752c4..23d7493 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 03/16] anv: don't crash if we fail to grow the reloc list

--- src/intel/vulkan/anv_batch_chain.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index 3f6039e..4cbfb4d 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/src/intel/vulkan/anv_batch_cha

[Mesa-dev] [PATCH 14/16] anv/cmd_buffer: skip vkCmdDispatch() on broken command buffers

--- src/intel/vulkan/genX_cmd_buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index c78855b..2c9aec8 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -1929,6 +1929,9

[Mesa-dev] [PATCH 09/16] anv: handle out of memory scenarios in anv_batch_emit_batch()

Fixes: dEQP-VK.api.out_of_host_memory.cmd_execute_commands --- src/intel/vulkan/anv_batch_chain.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index 162ef2e..d0a1b03 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 05/16] anv: do not try to ref/unref NULL shaders

This situation can happen if we failed to allocate memory for the shader. --- src/intel/vulkan/anv_private.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index c73196a..d3e32bc 100644 --- a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 01/16] blorp: handle out of memory in blorp_emitn()

--- src/intel/blorp/blorp_genX_exec.h | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h index f0c4f38..8f322b0 100644 --- a/src/intel/blorp/blorp_genX_exec.h +++ b/src/intel/blorp/blorp_gen

[Mesa-dev] [PATCH 12/16] anv: ensure that we don't ever try to adjust relocations more than once

There is a CTS tests that creates that situation by forcing OOM during a queue submision and then trying again without the OOM enforcement. The driver returns the appropriate out of memory error on the first try, but the relocations had already been computed and stored, so in the second attempt, we

[Mesa-dev] [PATCH 06/16] anv/blorp: return early if we failed to create the shader binary

--- src/intel/vulkan/anv_blorp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index d79c5e0..c871f03 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.c @@ -72,6 +72,9 @@ upload_blorp_shader(struct blorp

[Mesa-dev] [PATCH 04/16] anv: handle out of memory situations in anv_batch_emit_dwords()

--- src/intel/vulkan/anv_batch_chain.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c index 4cbfb4d..162ef2e 100644 --- a/src/intel/vulkan/anv_batch_chain.c +++ b/src/intel/vulkan/anv_batch_chain.c

[Mesa-dev] [PATCH 10/16] anv/cmd_buffer: handle out of memory during vkCmdPushConstants

Fixes: dEQP-VK.api.out_of_host_memory.cmd_push_constants --- src/intel/vulkan/anv_cmd_buffer.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index 01447b0..dd5e6c8 100644 --- a/src/intel/vu

[Mesa-dev] [PATCH 00/16] anv: Handle out of memory situations better

There are a number of work-in-progress CTS tests that check OOM handling and raised a number of issues that this series addresses. Particularly noteworthy is the case of command buffer recording: since the various vkCmd*() functions do not return errors, it is expected that drivers survive until v

[Mesa-dev] [PATCH] radv: disabled scaled formats for transfers.

From: Dave Airlie These really are only supported for vertex buffers. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 3742dcf.

[Mesa-dev] [PATCH 25/25] gallium: implement the backend of threaded GL dispatch

From: Marek Olšák --- src/gallium/include/state_tracker/st_api.h | 19 +++ src/gallium/state_trackers/dri/dri_context.c| 10 ++ src/gallium/state_trackers/dri/dri_drawable.c | 6 ++ src/gallium/state_trackers/dri/dri_screen.c | 21 +

[Mesa-dev] [PATCH 12/25] Revert "mesa: make _mesa_alloc_dispatch_table() static"

From: Marek Olšák This reverts commit 4009d22b61e76850b1b725f4e491da05c2406fa4. glthread needs it. --- src/mesa/main/api_exec.h | 4 src/mesa/main/context.c | 10 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/api_exec.h b/src/mesa/main/api_exec.h

[Mesa-dev] [PATCH 16/25] glapi: Mark vertex attrib pointer functions as async.

From: Eric Anholt These don't actually read data out of the pointers, they set the pointers (or offsets in a VBO) to be used in a later draw call. v2: Don't forget glVertexAttribIPointer, and don't bother with annotations on aliases. --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mapi/glapi

[Mesa-dev] [PATCH 17/25] mesa: Statically allocate glthread command buffer in the batch struct.

From: Eric Anholt This avoids an extra pointer dereference in the marshalling functions, which, with the instruction count doing in the low 30s, could actually matter for main-thread performance. --- src/mesa/main/glthread.c | 5 ++--- src/mesa/main/glthread.h | 8 2 files changed, 6 in

[Mesa-dev] [PATCH 22/25] mesa: Track the current vertex/element array buffers for glthread.

From: Eric Anholt We want to support glthread on GLES contexts with reasonable apps, and on desktop for apps that use VBOs but haven't completely moved to core GL. To do so, we have to deal with the "the user may or may not pass user pointers to draw calls" problem. --- src/mapi/glapi/gen/ARB_ba

[Mesa-dev] [PATCH 23/25] mesa/glthread: don't set a dispatch table if we aren't the owner

From: Gregory Hainaut Fix crashes when glxMakeCurrent is called. Signed-off-by: Gregory Hainaut Signed-off-by: Marek Olšák --- src/mesa/main/glthread.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c index

[Mesa-dev] [PATCH 24/25] mesa/glthread: restore the dispatch table when incompatible gl calls are detected

From: Gregory Hainaut While a context only has a single glthread, the context itself can be attached to several threads. Therefore the dispatch table must be updated in all threads before the destruction of glthread. In others words, glthread can only be destroyed safely when the context is delet

[Mesa-dev] [PATCH 13/25] mesa: Connect the generated GL command marshalling code to the build.

From: Eric Anholt v2: Rebase on the Begin/End changes, and just disable this feature on non-GL-core. v3: (Timothy Arceri) enable for non-GL-core contexts. Remove unrelated safe_mul() hunk. while loop style fix. --- src/mesa/Makefile.sources | 2 ++ src/mesa/main/glthread.c | 15 +++

[Mesa-dev] [PATCH 18/25] mesa: Add support for NULL arguments like in glBufferData() in marshalling.

From: Eric Anholt This will let us support things like glBufferData() that should be asynchronous. --- src/mapi/glapi/gen/gl_marshal.py | 38 ++ src/mapi/glapi/gen/marshal_XML.py | 5 - 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 15/25] mesa: Custom thread marshalling for Flush.

From: Paul Berry --- src/mapi/glapi/gen/gl_API.xml | 3 +-- src/mesa/main/marshal.c | 33 + src/mesa/main/marshal.h | 8 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_AP

[Mesa-dev] [PATCH 21/25] mesa: Disable glthread when glBegin() is called.

From: Eric Anholt glBegin() swaps dispatch tables, and we don't have any code in place for handling that in glthread (which also messes with dispatch tables), and I don't particularly care to at this point. --- src/mapi/glapi/gen/gl_API.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 11/25] mesa: Create pointers for multithread marshalling dispatch table.

From: Paul Berry This patch splits the context's CurrentDispatch pointer into two pointers, CurrentClientDispatch, and CurrentServerDispatch, so that when doing multithread marshalling, we can distinguish between the dispatch table that's being used by the client (to serialize GL calls into the m

[Mesa-dev] [PATCH 19/25] mesa: Add support for asynchronous glDraw* on GL core.

From: Eric Anholt --- src/mapi/glapi/gen/gl_marshal.py | 4 src/mapi/glapi/gen/marshal_XML.py | 9 ++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mapi/glapi/gen/gl_marshal.py b/src/mapi/glapi/gen/gl_marshal.py index 3b9868f..1a63343 100644 --- a/src/mapi/glapi

[Mesa-dev] [PATCH 14/25] mesa: Custom thread marshalling for ShaderSource.

From: Paul Berry --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/Makefile.sources | 1 + src/mesa/main/marshal.c | 123 ++ src/mesa/main/marshal.h | 10 4 files changed, 135 insertions(+), 1 deletion(-) create mode 100644 src/

[Mesa-dev] [PATCH 08/25] glapi: Generate GL API marshalling code from the XML.

From: Paul Berry This is not yet used in the build, just generated. v2: Add missing build dependencies. v3: Avoid mixing declarations and code, remove logic for avoiding emitting code that the compiler's optimizer can deal with anyway. v4: (Timothy Arceri) move safe_mul() genereation here fr

[Mesa-dev] [PATCH 09/25] mesa: Validate count parameters when marshalling.

From: Eric Anholt Otherwise, for example, glDeleteBuffers(-1, &bo) gets you a segfault instead of GL_INVALID_VALUE. --- src/mapi/glapi/gen/gl_marshal.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mapi/glapi/gen/gl_marshal.py b/src/mapi/glapi/gen/gl_marshal.py index

[Mesa-dev] [PATCH 20/25] mesa: Add an attribute for conditions to turn off threading.

From: Eric Anholt The threading for GL core is in place, but there are so few applications actually using a core GL context that it would be nice to extend support back. However, some of the features of compat GL (particularly user vertex arrays) would be so expensive to track state for that we

[Mesa-dev] [PATCH 10/25] mesa: Add infrastructure for a worker thread to process GL commands.

From: Eric Anholt v2: Keep an allocated buffer around instead of checking for one at the start of every GL command. Inline the now-small space allocation function. v3: Remove duplicate !glthread->shutdown check, process remaining work before shutdown. v4: Fix leaks on destroy. V5: (T

[Mesa-dev] Initial version of threaded GL dispatch V2

Since Marek is busy with other things at the moment I thought I'd try keep the momentum going on getting the initial implementation committed. Gregory Hainaut has fixed the piglit crashes in the previous version, and I've addressed the review feedback. I've also pushed some standalone patches. Th

[Mesa-dev] [PATCH 06/25] glapi: Annotate functions with "marshal" attribute.

From: Paul Berry Several API functions require special treatment in order to be marshalled to a background thread. Others can't be safely executed in a background thread and need to be executed synchronously (e.g. since they return data through a pointer argument). This annotation will be used

[Mesa-dev] [PATCH 07/25] glapi: Mark compressed teximage functions as sync.

From: Eric Anholt Without doing some additional tracking, we won't know whether the data will be immediate user data, or will be loaded from a PBO. The normal teximage functions will be sync by default because they don't know up front what the size of their image data is. But for compressed tex

[Mesa-dev] [PATCH 01/25] dri_interface: Add new marshalling interfaces to dri_interface.h

From: Paul Berry --- include/GL/internal/dri_interface.h | 39 + 1 file changed, 39 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 598d111..f419ec7 100644 --- a/include/GL/internal/dri_interface.h +

[Mesa-dev] [PATCH 05/25] egl: Implement __DRI_BACKGROUND_CALLABLE

From: Eric Anholt v2: (Timothy Arceri) use C99 initializers. --- src/egl/drivers/dri2/egl_dri2.c | 15 +++ src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/drivers/dri2/platform_x11.c | 2 ++ src/egl/main/eglcontext.c | 2 +- src/egl/main/eglcontext.h |

[Mesa-dev] [PATCH 04/25] glx: Implement __DRI_BACKGROUND_CALLABLE

From: Paul Berry v2: Marek: Add DRI3 support. v3: (Timothy Arceri) use C99 initializers. --- src/glx/dri2_glx.c | 17 - src/glx/dri3_glx.c | 14 ++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index d6eb281..f

[Mesa-dev] [PATCH 02/25] dri: Update dri_util to keep track of __DRI_BACKGROUND_CALLABLE

From: Paul Berry --- src/mesa/drivers/dri/common/dri_util.c | 2 ++ src/mesa/drivers/dri/common/dri_util.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index d18c458..f6df488 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [PATCH 03/25] mesa: Add SetBackgroundContext to dd_function_table

From: Paul Berry --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/dd.h| 18 ++ 2 files changed, 21 insertions(+) diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c index 6069138..642cd91 100644 --- a/s

[Mesa-dev] [Bug 100091] Failure to create folder for on-disk shader cache

https://bugs.freedesktop.org/show_bug.cgi?id=100091 --- Comment #3 from John --- That's right I have both folders. How do you create the identifier? I find it quite strange that the folder's number on disk is only one away from the one expected. Last week when I reported a similar issue on phoro

[Mesa-dev] [Bug 100093] configure: error: Package requirements (zlib >= 1.2.8) were not met:

https://bugs.freedesktop.org/show_bug.cgi?id=100093 --- Comment #2 from Timothy Arceri --- Probably RHEL 6/CentOS 6. Looks like they ship a heavily patched 1.2.3. However I don't think this is Mesa's problem. We should recommend a version of zlib that see's regular testing against the shader cac

[Mesa-dev] [PATCH] radv: disable mip point pre clamping.

From: Dave Airlie No idea what this does, but disabling it fixes a bunch of failing CTS tests in the lod area, so let's go with that. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/s

Re: [Mesa-dev] [PATCH 1/3] radv/amdgpu: Let addrlib calculate the HTILE parameters.

On 7 March 2017 at 10:44, Bas Nieuwenhuizen wrote: > Still not sure we can support miptrees when sampling from > HTILE enabled textures. > > Added the tcCompatible winsys stuff while I'm at it. Do we trust addrlib here? if so go for it. Reviewed-by: Dave Airlie > > Signed-off-by: Bas Nieuwenhui

[Mesa-dev] [Bug 100093] configure: error: Package requirements (zlib >= 1.2.8) were not met:

https://bugs.freedesktop.org/show_bug.cgi?id=100093 --- Comment #1 from Roland Scheidegger --- What distro ships prehistoric libz versions... libz 1.2.8 is 4 years old. Not sure this qualifies as a bug... (I think even MacOS now ships 1.2.8 albeit 10.11 indeed still shipped a prehistoric 1.2.5 wh

[Mesa-dev] [Bug 100093] configure: error: Package requirements (zlib >= 1.2.8) were not met:

https://bugs.freedesktop.org/show_bug.cgi?id=100093 Bug ID: 100093 Summary: configure: error: Package requirements (zlib >= 1.2.8) were not met: Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All

[Mesa-dev] [PATCH] radv/ac: move to new image intrinsics.

From: Dave Airlie This hooks up radv to the new image intrinsic builders. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 222 ++-- 1 file changed, 77 insertions(+), 145 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/co

Re: [Mesa-dev] assorted uint/unsigned -> enum clean-ups

Totally forgot to look at doing this, thanks Brian for going though. Reviewed-by: Edward O'Callaghan On 03/07/2017 01:08 PM, Brian Paul wrote: > Use gallium enum types in a bunch of places. > I compile tested most drivers, but not all. > Easy work to do on an airplane. > > __

[Mesa-dev] [PATCH 3/5] gbm: Create a gbm_device getter for stride

This will be used so we can query information per plane. Signed-off-by: Ben Widawsky Reviewed-by: Eric Engestrom Acked-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 7 +++ src/gbm/main/gbm.c | 2 +- src/gbm/main/gbmint.h | 1 + 3 files changed, 9 insertions(+),

[Mesa-dev] [PATCH 1/5] gbm: Export a plane getter function

This will be used by clients that need to know the number of planes allocated for them on behalf of the GL or other API. The best current example of this is when an extra "plane" is allocated to store compression data for the primary plane. v2: Return 1 for cases where there is no image, ie. dumb

[Mesa-dev] [PATCH 4/5] gbm: Export a per plane getter for stride

v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand) EINVAL when input plane is greater than total planes (Jason Ekstrand) Don't leak the image after fromPlanar (Daniel) Move bo->image check below plane count preventing bad index succeeding (Daniel) v3: Fix DRIimage leak (using Jason's re

[Mesa-dev] [PATCH 5/5] gbm: Export a per plane getter for offset

Unlike stride, there was no previous offset getter, so it can be right on the first try. v2: Return EINVAL when plane is greater than total planes to make it match the similar APIs. Avoid leak after fromPlanar (Daniel) Make sure when getting offsets we consider dumb images (Daniel) v3: Use Jason'

[Mesa-dev] [PATCH 2/5] gbm: Export a getter for per plane handles

v2: Make the error return be -1 instead of 0 because I think 0 is actually valid. v3: Set errno to EINVAL when the specified plane is above the total planes. (Jason Ekstrand) Return the bo's handle if there is no image ie. for dumb images like cursor (Daniel) Signed-off-by: Ben Widawsky Acked-b

[Mesa-dev] [PATCH 0/5] Per plane GBM functions

This was the first chunk of the Renderbuffer Decompression series (aka GBM modifiers). Splitting this up to make merging easier. These patches are just the new GBM entry points for the functions required to support modifiers. Cc: Kristian H. Kristensen Cc: Daniel Stone Cc: Eric Engestrom Cc: Ja

Re: [Mesa-dev] [PATCH 02/51] i965: Order write of query availablity with earlier writes

Chris Wilson writes: > Currently we signal the availabilty of the query result using an > unordered pipe-control write. As it is unordered, it may be executed > before the write of the query result itself - and so an observer may > read the query result too early. Fix this by requesting that the

Re: [Mesa-dev] [PATCH 6/6] configure.ac: Ensure libomxil-bellagio exists before invoking pkg-config.

On Mon, Mar 6, 2017 at 4:57 PM, Emil Velikov wrote: > On 6 March 2017 at 19:06, Matt Turner wrote: >> I was already tired of seeing the message >> >> Package libomxil-bellagio was not found in the pkg-config search path. >> Perhaps you should add the directory containing `libomxil-bellagi

[Mesa-dev] [Bug 100063] vsync setting of OpenGL programs is ignored

https://bugs.freedesktop.org/show_bug.cgi?id=100063 --- Comment #7 from Michel Dänzer --- E.g. the VSync setting in Unigine Valley works as expected for me (note that changing the setting only takes effect after clicking the OK button as well). -- You are receiving this mail because: You are th

[Mesa-dev] [PATCH 06/14] llvmpipe: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/llvmpipe/lp_state_sampler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_sampler.c b/src/gallium/drivers/llvmpipe/lp_state_sampler.c index 01af052..c9aba1a 100644 --- a/src/gallium/drivers/llvmpipe/lp_state_sampl

[Mesa-dev] [PATCH 12/14] gallium: s/uint/enum pipe_render_cond_flag/ for set_render_condition()

--- src/gallium/auxiliary/cso_cache/cso_context.c | 3 ++- src/gallium/auxiliary/cso_cache/cso_context.h | 3 ++- src/gallium/auxiliary/util/u_blitter.h | 2 +- src/gallium/drivers/ddebug/dd_context.c | 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 2 +- src/gallium/

[Mesa-dev] [PATCH 07/14] softpipe: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/softpipe/sp_state_derived.c | 2 +- src/gallium/drivers/softpipe/sp_state_sampler.c | 2 +- src/gallium/drivers/softpipe/sp_tex_sample.c| 3 ++- src/gallium/drivers/softpipe/sp_tex_sample.h| 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/g

[Mesa-dev] [PATCH 04/14] etnaviv: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/etnaviv/etnaviv_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture.c b/src/gallium/drivers/etnaviv/etnaviv_texture.c index 1d32c12..93b077b 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_texture.c

[Mesa-dev] [PATCH 03/14] draw: s/unsigned/enum pipe_shader_type/

and some s/uint/enum pipe_shader_type/ --- src/gallium/auxiliary/draw/draw_context.c | 10 +- src/gallium/auxiliary/draw/draw_context.h | 10 +- src/gallium/auxiliary/draw/draw_llvm.c| 4 ++-- src/gallium/auxiliary/draw/draw_llvm.h| 5 +++-- 4 files changed, 15 insertions

[Mesa-dev] [PATCH 01/14] gallium: s/unsigned/enum pipe_shader_type/ for pipe_screen::get_shader_param()

--- src/gallium/auxiliary/draw/draw_context.c| 5 +++-- src/gallium/auxiliary/draw/draw_context.h| 5 +++-- src/gallium/auxiliary/util/u_inlines.h | 3 ++- src/gallium/drivers/ddebug/dd_screen.c | 3 ++- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 ++-

[Mesa-dev] [PATCH 09/14] virgl: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/virgl/virgl_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_context.c b/src/gallium/drivers/virgl/virgl_context.c index 2ee89d7..65ca9b3 100644 --- a/src/gallium/drivers/virgl/virgl_context.c +++ b/src/gal

[Mesa-dev] [PATCH 08/14] swr: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/swr/swr_shader.cpp | 2 +- src/gallium/drivers/swr/swr_state.cpp | 4 ++-- src/gallium/drivers/swr/swr_tex_sample.cpp | 4 ++-- src/gallium/drivers/swr/swr_tex_sample.h | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/sw

[Mesa-dev] [PATCH 05/14] freedreno: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/freedreno/freedreno_texture.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/freedreno_texture.h b/src/gallium/drivers/freedreno/freedreno_texture.h index 6124532..b12ce2f 100644 --- a/src/gallium/drivers/freedreno/freedre

[Mesa-dev] [PATCH 11/14] gallium: s/uint/enum pipe_shader_type/ for set_constant_buffer()

--- src/gallium/drivers/ddebug/dd_context.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_state.c | 3 ++- src/gallium/drivers/freedreno/freedreno_state.c | 3 ++- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +- src/gallium/

[Mesa-dev] [PATCH 14/14] util/indices: minor clean-ups

--- src/gallium/auxiliary/indices/u_indices.c | 2 +- src/gallium/auxiliary/indices/u_indices_gen.py | 5 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/indices/u_indices.c b/src/gallium/auxiliary/indices/u_indices.c index cb9e460..3d1ebed 100644 -

[Mesa-dev] assorted uint/unsigned -> enum clean-ups

Use gallium enum types in a bunch of places. I compile tested most drivers, but not all. Easy work to do on an airplane. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 13/14] radeonsi: s/uint/enum pipe_shader_type/

This can probably be done in more places in the driver. --- src/gallium/drivers/radeonsi/si_descriptors.c | 3 ++- src/gallium/drivers/radeonsi/si_state.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/driv

[Mesa-dev] [PATCH 02/14] cso: s/unsigned/enum pipe_shader_type/

--- src/gallium/auxiliary/cso_cache/cso_context.c | 11 ++- src/gallium/auxiliary/cso_cache/cso_context.h | 11 ++- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index

[Mesa-dev] [PATCH 10/14] gallium: s/unsigned/enum pipe_shader_type/ for get_compiler_options()

--- src/gallium/drivers/vc4/vc4_program.c | 3 ++- src/gallium/drivers/vc4/vc4_screen.h | 3 ++- src/gallium/include/pipe/p_screen.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_program.c b/src/gallium/drivers/vc4/vc4_program.c index 217534

[Mesa-dev] [Bug 100063] vsync setting of OpenGL programs is ignored

https://bugs.freedesktop.org/show_bug.cgi?id=100063 Michel Dänzer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 100091] Failure to create folder for on-disk shader cache

https://bugs.freedesktop.org/show_bug.cgi?id=100091 Timothy Arceri changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Mesa core QA Contact|dri-devel

Re: [Mesa-dev] [PATCH] dir-locals.el: use appropriate c-file-style

On Mon, Mar 6, 2017 at 7:44 PM, Ilia Mirkin wrote: > What's the difference between c-file-style linux and stroustrup? The main differences are that stroustrup sets c-basic-offset to 4 while linux uses 8 and linux defines braces around "else" on single line, i.e.: "} else {". Even if these get tw

[Mesa-dev] [PATCH 1/3] util/disk_cache: use LRU eviction rather than random eviction (v2)

Still using random selection of two-character subdirectory in which to check cache files rather than scanning entire cache. v2: Factor out double strlen call --- src/util/disk_cache.c | 78 +++ 1 file changed, 35 insertions(+), 43 deletions(-) diff

[Mesa-dev] [PATCH v2] radv: Use the subresource range in HTILE initialization.

v2: fix levelCount assert. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 16 +++- src/amd/vulkan/radv_image.c | 3 +-- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c i

Re: [Mesa-dev] [PATCH 6/6] configure.ac: Ensure libomxil-bellagio exists before invoking pkg-config.

On 6 March 2017 at 19:06, Matt Turner wrote: > I was already tired of seeing the message > > Package libomxil-bellagio was not found in the pkg-config search path. > Perhaps you should add the directory containing `libomxil-bellagio.pc' > to the PKG_CONFIG_PATH environment variable >

[Mesa-dev] [PATCH 2/3] radv: fix the size of the dynamic_buffers array

A buffer descriptor is 16 bytes, not 16 dwords. Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 30201a67e7..ab7db88e8d 100644 --- a/src/amd/vul

[Mesa-dev] [PATCH 3/3] radv/ac: fix multiple descriptor sets with dynamic buffers

The dynamic_offset_offset in the descriptor set binding layout is relative to the dynamic_offset_start for the set in the pipeline layout. Cc: 17.0 Signed-off-by: Fredrik Höglund --- src/amd/common/ac_nir_to_llvm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 0/3] radv: fix descriptor set bugs with dynamic buffers

This series fixes some bugs related to multiple descriptor sets with dynamic buffers. I've run the dEQP-VK.*descriptor* tests with these changes, and there are no new passes and no new failures. This series is also available at: git://people.freedesktop.org/~fredrik/mesa radv Fredrik Fredrik

[Mesa-dev] [PATCH 1/3] radv: fix the dynamic buffer index in vkCmdBindDescriptorSets

This fixes the wrong dynamic buffer descriptors being updated when firstSet > 0. Cc: 17.0 Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c i

Re: [Mesa-dev] [PATCH 1/6] build: Replace NEED_RADEON_LLVM with HAVE_GALLIUM_LLVM.

IIRC all the HAVE_GALLIUM_LLVM can now become HAVE_LLVM, but we can do that later. Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeonsi: fix elimination of literal VS outputs

Yeah, "llvm.amdgcn.exp." is probably not what we want. :) Reviewed-by: Samuel Pitoiset On 03/07/2017 12:55 AM, Marek Olšák wrote: From: Marek Olšák broken when switched to the new intrinsics. --- src/gallium/drivers/radeonsi/si_shader.c | 11 +++ 1 file changed, 7 insertions(+), 4 d

Re: [Mesa-dev] [PATCH] gallium/util: replace pipe_condvar with cnd_t

On 5 March 2017 at 23:41, Timothy Arceri wrote: > pipe_condvar was made unnecessary with fd33a6bcd7f12. > > Cc: Emil Velikov Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH] radv: handle z offset for 3d image <-> buffer copies.

Reviewed-by: Bas Nieuwenhuizen On Tue, Mar 7, 2017 at 1:30 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > dEQP-VK.pipeline.render_to_image.3d.huge.depth.r8g8b8a8_unorm > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_meta_copy.c | 4 > 1 file changed, 4 insertions

Re: [Mesa-dev] [PATCH] radv: move fast clear before resolve into own loop.

Reviewed-by: Bas Nieuwenhuizen On Tue, Mar 7, 2017 at 12:33 AM, Dave Airlie wrote: > From: Dave Airlie > > Don't fast clear inside the meta loop as things get > confused, fixes a crash in: > dEQP-VK.api.copy_and_blit.resolve_image.whole_array_image.2_bit > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH 1/3] radv/amdgpu: Let addrlib calculate the HTILE parameters.

Still not sure we can support miptrees when sampling from HTILE enabled textures. Added the tcCompatible winsys stuff while I'm at it. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_radeon_winsys.h| 5 + src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 26

[Mesa-dev] [PATCH 3/3] radv: Use the subresource range in HTILE initialization.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 16 +++- src/amd/vulkan/radv_image.c | 3 +-- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 3796ae4b48c..39dd6e367e

[Mesa-dev] [PATCH 2/3] radv: Use winsys HTILE info.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 10 ++--- src/amd/vulkan/radv_device.c | 4 +- src/amd/vulkan/radv_image.c | 83 --- src/amd/vulkan/radv_meta_clear.c | 2 +- src/amd/vulkan/radv_meta_decompress.

Re: [Mesa-dev] [PATCH v3 07/24] i965/fs: generalize the legalization d2x pass

Samuel Iglesias Gonsálvez writes: > On 04/03/17 00:19, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> Add support to SEL instruction and add an assert to detect unsupported >>> instructions than do d2x conversions. >>> >>> Signed-off-by: Samuel Iglesias Gonsálvez >>> --- >>

[Mesa-dev] [PATCH] radv: handle z offset for 3d image <-> buffer copies.

From: Dave Airlie This fixes: dEQP-VK.pipeline.render_to_image.3d.huge.depth.r8g8b8a8_unorm Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_copy.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_meta_copy.c b/src/amd/vulkan/radv_meta_copy.c index 5473764..54

[Mesa-dev] [Bug 100037] [vmwgfx] Invalid SVGA3D command: 1202

https://bugs.freedesktop.org/show_bug.cgi?id=100037 --- Comment #1 from Deepak --- Hi, Do you used Ubuntu Zesty GNOME and then installed Plasma top of it or used the kubuntu (http://cdimage.ubuntu.com/kubuntu/releases/17.04/alpha-2/) which I guess comes with Plasma desktop. Thanks. -- You ar

[Mesa-dev] [PATCH] radeonsi: fix elimination of literal VS outputs

From: Marek Olšák broken when switched to the new intrinsics. --- src/gallium/drivers/radeonsi/si_shader.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index ba29661..2c98715 1

[Mesa-dev] [PATCH] radv: move fast clear before resolve into own loop.

From: Dave Airlie Don't fast clear inside the meta loop as things get confused, fixes a crash in: dEQP-VK.api.copy_and_blit.resolve_image.whole_array_image.2_bit Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_resolve_cs.c | 23 +++ 1 file changed, 15 insertions(+),

Re: [Mesa-dev] [PATCH 5/5] anv: Handle failure in make_hiz_surface_maybe()

On Mon, Mar 6, 2017 at 10:18 AM, Chad Versace wrote: > make_ccs_surface_maybe() correctly handles failure > isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still > valid, just without a ccs surface. > > Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). > > Fix make_hi

  1   2   3   >