Re: [Mesa-dev] [PATCH 6/6] tnl: remove unneeded #include "util/simple_list.h"

On Sat, Nov 19, 2016 at 6:26 PM, Brian Paul wrote: > --- > src/mesa/tnl/t_vertex_generic.c | 1 - > src/mesa/tnl/t_vertex_sse.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/mesa/tnl/t_vertex_generic.c b/src/mesa/tnl/t_vertex_generic.c > index 6c40c86..7f871a4 100644 > --- a/s

Re: [Mesa-dev] [PATCH 5/6] radeon: remove unneeded #include "util/simple_list.h"

On Sat, Nov 19, 2016 at 6:26 PM, Brian Paul wrote: > Compile tested only. > --- > src/mesa/drivers/dri/radeon/radeon_ioctl.h | 1 - > src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c | 1 - > src/mesa/drivers/dri/radeon/radeon_queryobj.c| 1 - > src/mesa/drivers/dri/radeon/radeon_swtcl.

Re: [Mesa-dev] [PATCH 4/6] r200: remove unneeded #include "util/simple_list.h"

On Sat, Nov 19, 2016 at 6:26 PM, Brian Paul wrote: > And include "util/simple_list.h" where it is needed in r200_state.c > Compile tested only. > --- > src/mesa/drivers/dri/r200/r200_context.c | 1 - > src/mesa/drivers/dri/r200/r200_ioctl.h | 2 -- > src/mesa/drivers/dri/r200/r200_state.c | 1

Re: [Mesa-dev] [PATCH 3/6] i915: remove unneeded #include "util/simple_list.h"

On Sat, Nov 19, 2016 at 6:26 PM, Brian Paul wrote: > Compile tested only. > --- > src/mesa/drivers/dri/i915/i830_texblend.c | 1 - > src/mesa/drivers/dri/i915/intel_syncobj.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i915/i830_texblend.c > b/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 2/6] mesa: remove unneeded #includes in errors.c

On Sat, Nov 19, 2016 at 6:26 PM, Brian Paul wrote: > --- > src/mesa/main/errors.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c > index 654343d..3a40c74 100644 > --- a/src/mesa/main/errors.c > +++ b/src/mesa/main/errors.c > @@ -35,12

Re: [Mesa-dev] [PATCH 1/6] mesa: remove trailing whitespace in errors.c

On Sat, Nov 19, 2016 at 6:26 PM, Brian Paul wrote: > --- > src/mesa/main/errors.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c > index 9932b4a..654343d 100644 > --- a/src/mesa/main/errors.c > +++ b/src/mesa/m

[Mesa-dev] [PATCH] intel: aubinator: Fix resource leak in gen_spec_load_from_path

This fixes resource leak in gen_spec_load_from_path XML_ParserCreate failure path CID 1373564 Signed-off-by: Mun Gwan-gyeong --- src/intel/tools/decoder.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/decoder.c b/src/intel/tools/decoder.c index 6bd02bf..633251a 100644 ---

[Mesa-dev] [PATCH] swr: call swr_update_derived unconditionally when drawing/clearing

Currently a sequence like draw/map/draw/map will cause the second map to not wait for the second draw. This is because the first map will clear the resource business bit, and the second draw won't reset it since no state has changed. swr_update_derived does a tiny bit of extra work, including upda

[Mesa-dev] list.h vs. simple_list.h

[resending, original msg didn't appear on list] It seems a bit silly to have two linked list utilities. git-grep indicates that list.h is used more than simple_list.h so maybe we can switch uses of the later to the former. In fact, I've already found a few files that include simple_list.h but

[Mesa-dev] [PATCH] radeonsi: Fix resource leak in gs_copy_shader allocation failure path

CID 1394028 Signed-off-by: Mun Gwan-gyeong --- src/gallium/drivers/radeonsi/si_shader.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 917e148..608cb72 100644 --- a/src/gallium/

Re: [Mesa-dev] [PATCH] anv: Implement a depth stall restriction on gen7

On Nov 19, 2016 6:56 PM, "Jordan Justen" wrote: > > On 2016-11-19 15:08:11, Jason Ekstrand wrote: > > Fixes 61 Vulkan CTS tests on Haswell > > > > Cc: "13.0" > > --- > > src/intel/vulkan/anv_genX.h| 2 ++ > > src/intel/vulkan/genX_blorp_exec.c | 2 ++ > > src/intel/vulkan/genX_cmd_buff

Re: [Mesa-dev] [PATCH] anv: Implement a depth stall restriction on gen7

On 2016-11-19 15:08:11, Jason Ekstrand wrote: > Fixes 61 Vulkan CTS tests on Haswell > > Cc: "13.0" > --- > src/intel/vulkan/anv_genX.h| 2 ++ > src/intel/vulkan/genX_blorp_exec.c | 2 ++ > src/intel/vulkan/genX_cmd_buffer.c | 31 +++ > 3 files changed, 35 i

[Mesa-dev] list.h vs. simple_list.h

It seems a bit silly to have two linked list utilities. git-grep indicates that list.h is used more than simple_list.h so maybe we can switch uses of the later to the former. In fact, I've already found a few files that include simple_list.h but don't actually need it. I may pick away at thi

[Mesa-dev] [PATCH] gallium: create a debug screen wrapper around swrast screens

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/target-helpers/inline_sw_helper.h | 3 +++ src/gallium/auxiliary/target-helpers/sw_helper.h| 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/gallium/auxiliary/target-helpers/inline_sw_helper.h b/src/gallium/auxiliary/target-h

[Mesa-dev] [PATCH 5/6] radeon: remove unneeded #include "util/simple_list.h"

Compile tested only. --- src/mesa/drivers/dri/radeon/radeon_ioctl.h | 1 - src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c | 1 - src/mesa/drivers/dri/radeon/radeon_queryobj.c| 1 - src/mesa/drivers/dri/radeon/radeon_swtcl.c | 1 - src/mesa/drivers/dri/radeon/radeon_tex.c

[Mesa-dev] [PATCH 6/6] tnl: remove unneeded #include "util/simple_list.h"

--- src/mesa/tnl/t_vertex_generic.c | 1 - src/mesa/tnl/t_vertex_sse.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex_generic.c b/src/mesa/tnl/t_vertex_generic.c index 6c40c86..7f871a4 100644 --- a/src/mesa/tnl/t_vertex_generic.c +++ b/src/mesa/tnl/t_vertex_generic.

[Mesa-dev] [PATCH 4/6] r200: remove unneeded #include "util/simple_list.h"

And include "util/simple_list.h" where it is needed in r200_state.c Compile tested only. --- src/mesa/drivers/dri/r200/r200_context.c | 1 - src/mesa/drivers/dri/r200/r200_ioctl.h | 2 -- src/mesa/drivers/dri/r200/r200_state.c | 1 + src/mesa/drivers/dri/r200/r200_swtcl.c | 1 - src/mesa/dri

[Mesa-dev] [PATCH 1/6] mesa: remove trailing whitespace in errors.c

--- src/mesa/main/errors.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index 9932b4a..654343d 100644 --- a/src/mesa/main/errors.c +++ b/src/mesa/main/errors.c @@ -122,7 +122,7 @@ flush_delayed_errors( struct gl_co

[Mesa-dev] [PATCH 3/6] i915: remove unneeded #include "util/simple_list.h"

Compile tested only. --- src/mesa/drivers/dri/i915/i830_texblend.c | 1 - src/mesa/drivers/dri/i915/intel_syncobj.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i830_texblend.c b/src/mesa/drivers/dri/i915/i830_texblend.c index 661e424..c29b572 100644 --- a/src/me

[Mesa-dev] [PATCH 2/6] mesa: remove unneeded #includes in errors.c

--- src/mesa/main/errors.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index 654343d..3a40c74 100644 --- a/src/mesa/main/errors.c +++ b/src/mesa/main/errors.c @@ -35,12 +35,6 @@ #include "imports.h" #include "context.h" #include "debu

[Mesa-dev] [Bug 98791] alpha back-and-forth between hot tiles picks up corruption

https://bugs.freedesktop.org/show_bug.cgi?id=98791 Bug ID: 98791 Summary: alpha back-and-forth between hot tiles picks up corruption Product: Mesa Version: git Hardware: Other OS: All Status: NEW

[Mesa-dev] [Bug 98790] clipping failures exposed by dEQP

https://bugs.freedesktop.org/show_bug.cgi?id=98790 Bug ID: 98790 Summary: clipping failures exposed by dEQP Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priorit

Re: [Mesa-dev] [PATCH] i965: remove dead code path in brw_tcs_precompile()

On Sun, 2016-11-20 at 09:40 +1100, Timothy Arceri wrote: > The glsl linker will have already failed if we tried linking a tcs > without a tes. Actually this used by SSO. Please ignore. > --- >  src/mesa/drivers/dri/i965/brw_tcs.c | 13 + >  1 file changed, 5 insertions(+), 8 deletions(

[Mesa-dev] [PATCH] anv: Implement a depth stall restriction on gen7

Fixes 61 Vulkan CTS tests on Haswell Cc: "13.0" --- src/intel/vulkan/anv_genX.h| 2 ++ src/intel/vulkan/genX_blorp_exec.c | 2 ++ src/intel/vulkan/genX_cmd_buffer.c | 31 +++ 3 files changed, 35 insertions(+) diff --git a/src/intel/vulkan/anv_genX.h b/src/i

[Mesa-dev] [PATCH] i965: remove dead code path in brw_tcs_precompile()

The glsl linker will have already failed if we tried linking a tcs without a tes. --- src/mesa/drivers/dri/i965/brw_tcs.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c b/src/mesa/drivers/dri/i965/brw_tcs.c index ec3f3cb..7e1a

[Mesa-dev] [Bug 98789] ./rasterizer/core/clip.h(429): ASSERT: numEmittedVerts <= 7

https://bugs.freedesktop.org/show_bug.cgi?id=98789 Bug ID: 98789 Summary: ./rasterizer/core/clip.h(429): ASSERT: numEmittedVerts <= 7 Product: Mesa Version: git Hardware: Other OS: All Status: NE

Re: [Mesa-dev] [PATCH] clover: Implement clSetCommandQueueProperty() from OpenCL 1.0

Edward O'Callaghan writes: > Signed-off-by: Edward O'Callaghan > --- > include/CL/cl.h| 6 > src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- > src/gallium/state_trackers/clover/api/queue.cpp| 34 > ++ > src/gallium/s

Re: [Mesa-dev] [PATCH v5 09/11] swr: Modify gen_knobs.{cpp|h} creation script

Hi George, Thanks for sorting things.. There's a pretty trivial nitpick below, but please don't bother addressing it. Things are pretty good as-is - check with Tim/others and land the series. On 18 November 2016 at 20:38, George Kyriazis wrote: > Modify gen_knobs.py so that each invocation creat

Re: [Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

Vedran Miletić writes: > The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM > 3.9 and older versionsin Clover. This patch restores it and refactors > the support using Clover compatibility layer for LLVM. > > Signed-off-by: Vedran Miletić > --- > .../state_trackers/clover/llv

Re: [Mesa-dev] [PATCH 3/3] glsl/lower_output_reads: remove unused mem_ctx

For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 17, 2016 at 11:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/compiler/glsl/lower_output_reads.cpp | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/compiler/glsl/lower_output_reads.cpp > b/src/compi

[Mesa-dev] [PATCH 7/7] anv: Enable fast clears on gen7-8

--- src/intel/vulkan/anv_image.c | 2 +- src/intel/vulkan/genX_cmd_buffer.c | 47 -- 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 6f19c84..e60373a 100644 --- a/src/intel

[Mesa-dev] [PATCH 6/7] anv: Add support for fast clears on gen9

--- src/intel/vulkan/anv_blorp.c | 102 - src/intel/vulkan/anv_private.h | 3 ++ src/intel/vulkan/genX_cmd_buffer.c | 100 ++-- 3 files changed, 176 insertions(+), 29 deletions(-) diff --git a/src/intel/vulkan/anv_blo

[Mesa-dev] [PATCH 2/7] anv/blorp: Add a vk_to_isl_color helper

--- src/intel/vulkan/anv_blorp.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 2fccf5c..ae650de 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.c @@ -786,6 +7

[Mesa-dev] [PATCH 1/7] anv/cmd_buffer: Make setup_attachments take a RenderPassBeginInfo

--- src/intel/vulkan/genX_cmd_buffer.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 0feae41..8e03cca 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_b

[Mesa-dev] [PATCH 3/7] anv/blorp: Use regular blorp clears for subpass clears

At vkCmdNextSubpass time, we have the actual framebuffer so we can use regular blorp_clear for subpass clears. For fast clears, there is no attachment version, so this will make fast clears a bit easier. --- src/intel/vulkan/anv_blorp.c | 29 +++-- 1 file changed, 19 inser

[Mesa-dev] [PATCH 0/7] anv: Add support for fast clears

This little series builds on top of the input attachment series I sent out earlier this week and adds support for fast clears in Vulkan. I've tested it on both Sky Lake and Haswell and it has no regressions over the input attachments series. Jason Ekstrand (7): anv/cmd_buffer: Make setup_attach

[Mesa-dev] [PATCH 4/7] anv/cmd_buffer: Apply remaining flushes in EndCommandBuffer

Otherwise, some pipe flushes may just never happen. This is unlikely to cause problems depending on how the kernel schedules batches, but we shouldn't count on it. --- src/intel/vulkan/genX_cmd_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/sr

[Mesa-dev] [PATCH 5/7] anv/blorp: Rework flushing around resolves

It turns out that the flushing required around resolves is a bit more extensive than I first thought. You actually need render cache flush and a CS stall both before *and* after the resolve. --- src/intel/vulkan/anv_blorp.c | 32 ++-- 1 file changed, 18 insertions(+),

Re: [Mesa-dev] [PATCH 07/12] docs/submittingpatches: flesh out "how to nominate" methods

On 11/16, Emil Velikov wrote: From: Emil Velikov Currently things are a bit buried within the text, making it harder to find out. Move at the top and be clear what is _not_ a good idea. We had some people consistently using the "bad" way and then being unhappy that their patches were missed/de

[Mesa-dev] [Bug 98783] Talos Principle rendering garbage in main menu animation when using Vulkan

https://bugs.freedesktop.org/show_bug.cgi?id=98783 Vedran Miletić changed: What|Removed |Added Summary|Talos rendering garbage in |Talos Principle rendering

[Mesa-dev] [Bug 98783] Talos rendering garbage in menu when using Vulkan

https://bugs.freedesktop.org/show_bug.cgi?id=98783 --- Comment #1 from Vedran Miletić --- Created attachment 128071 --> https://bugs.freedesktop.org/attachment.cgi?id=128071&action=edit Menu garbage -- You are receiving this mail because: You are the assignee for the bug. You are the QA Conta

[Mesa-dev] [Bug 98783] Talos rendering garbage in menu when using Vulkan

https://bugs.freedesktop.org/show_bug.cgi?id=98783 Bug ID: 98783 Summary: Talos rendering garbage in menu when using Vulkan Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: major

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #1 from Vedran Miletić --- There are rendering issues on R9 380X as well, but of different kind. What version of Mesa and LLVM are you using? -- You are receiving this mail because: You are the assignee for the bug. You are the QA C

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

https://bugs.freedesktop.org/show_bug.cgi?id=98714 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net -- You are receivin

[Mesa-dev] [PATCH v2] swr: calculate viewport width/height based on the scale

The former calculations were for min/max y. The width/height don't take translate into account. Signed-off-by: Ilia Mirkin --- v1 -> v2: also fix clamping logic to respect viewport offset src/gallium/drivers/swr/swr_state.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH] swr: report a reasonable max lod bias

This is the same value that llvmpipe uses. Since swr uses the same sampler logic, makes sense for this value to also be the same. Most applications don't care. Signed-off-by: Ilia Mirkin --- I kind of assume this is dependent on my layout patches since LODs weren't always properly handled before

[Mesa-dev] [PATCH] swr: calculate viewport width/height based on the scale

The former calculations were for min/max y. The width/height don't take translate into account. Signed-off-by: Ilia Mirkin --- Not sure that this fixes anything. However it probably should, since you're supposed to clip triangles at the viewport boundary. There are definitely dEQP tests for this

[Mesa-dev] [PATCH 2/4] swr: [rasterizer memory] hook up stencil clears for ClearTile

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp b/src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp index 8501e21

[Mesa-dev] [PATCH 4/4] swr: [rasterizer core] use ClearTile helper to store fast clears

No point in clearing the hot tile and then storing that - may as well just store the clear color to the surface directly. Use the helper that already exists for this purpose. Signed-off-by: Ilia Mirkin --- My theory is that this is going to be a very modest perf improvement. Instead of first cle

[Mesa-dev] [PATCH 1/4] swr: [rasterizer memory] add support for clearing Z32F_X32 and Z16

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp b/src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp index 717d12c..8501e21 100644 --- a/src/g

[Mesa-dev] [PATCH 3/4] swr: [rasterizer memory] only clear up to the LOD size

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp b/src/gallium/drivers/swr/rasterizer/memory/ClearTile.cpp index 31a40a3..e

Re: [Mesa-dev] [PATCH] swr: mark streamout buffers as written

Reviewed-by: Bruce Cherniak > On Nov 17, 2016, at 7:49 PM, Ilia Mirkin wrote: > > Signed-off-by: Ilia Mirkin > --- > src/gallium/drivers/swr/swr_state.cpp | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/gallium/drivers/swr/swr_state.cpp > b/src/gallium/drivers/swr/swr_sta

Re: [Mesa-dev] UDL & Modeset with Mesa 13.0.1 - Segmentation fault

On 18.11.2016 14:45, Emil Velikov wrote: > On 17 November 2016 at 20:15, poma wrote: >> >> Airlie solved everything concerning the kernel, >> so it seems, now it's user space turn. >> >> = mesa-libgbm-12.0.3 - works OK >> ... >> [ 714.429] (II) Loading sub module "glamoregl" >> [ 714.429] (II)

Re: [Mesa-dev] Stable release process

Hey Marek, On 18 November 2016 at 19:09, Marek Olšák wrote: > On Fri, Nov 18, 2016 at 7:45 PM, Kai Wasserbäch > wrote: >> wouldn't a tool like Phabricator be much better for reviewing and reliably >> tracking whether a patch has landed or not? Especially if you use it in >> combination with Arca