On 25/08/16 23:48, Tobias Klausmann wrote:
> This was found by obs:
> I: Program returns random data in a function
> E: Mesa no-return-in-nonvoid-function main/program_resource.c:109
>
> Signed-off-by: Tobias Klausmann
> Reviewed-by: Ian Romanick
> ---
> V2:
> Remove the !, cosmetic change, as
On 26/08/16 08:38, Alejandro Piñeiro wrote:
> On 25/08/16 22:38, Ian Romanick wrote:
>> On 08/25/2016 08:19 AM, Emil Velikov wrote:
>>> On 25 August 2016 at 13:24, Francesco Ansanelli wrote:
Signed-off-by: Francesco Ansanelli
---
src/mesa/main/program_resource.c |1 +
1 f
On 25/08/16 22:38, Ian Romanick wrote:
> On 08/25/2016 08:19 AM, Emil Velikov wrote:
>> On 25 August 2016 at 13:24, Francesco Ansanelli wrote:
>>> Signed-off-by: Francesco Ansanelli
>>> ---
>>> src/mesa/main/program_resource.c |1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src
On Fri, Aug 26, 2016 at 1:06 PM, Ryan Houdek wrote:
> Dolphin Emulator does ;)
Do we really have any devices that provide desktop OpenGL? If yes, any
idea how front buffers are implemented there? Android's windowing
system is quite specific and in my understanding it generally provides
only a bac
We use temporary buffers so that we don't read and write to the
same surface at the same time. We don't need to use linear
layout now.
Signed-off-by: Nayan Deshmukh
---
src/gallium/state_trackers/vdpau/mixer.c | 87 ++--
1 file changed, 59 insertions(+), 28 deletions(
On Aug 25, 2016 9:41 PM, "Pohjolainen, Topi"
wrote:
>
> On Thu, Aug 25, 2016 at 02:34:37PM -0700, Jason Ekstrand wrote:
> >On Thu, Aug 25, 2016 at 1:10 AM, Pohjolainen, Topi
> ><[1]topi.pohjolai...@gmail.com> wrote:
> >
> >On Fri, Aug 19, 2016 at 09:55:37AM -0700, Jason Ekstrand wrote:
On Thu, Aug 25, 2016 at 03:58:24PM -0700, Jason Ekstrand wrote:
> This probably isn't the only thing that needs to be done to get
> multisampled array textures working in Vulkan but I think this is all that
> ISL really needs and it does fix 8 of the new CTS tests.
Reviewed-by: Topi Pohjolainen
On Thu, Aug 25, 2016 at 02:34:37PM -0700, Jason Ekstrand wrote:
>On Thu, Aug 25, 2016 at 1:10 AM, Pohjolainen, Topi
><[1]topi.pohjolai...@gmail.com> wrote:
>
>On Fri, Aug 19, 2016 at 09:55:37AM -0700, Jason Ekstrand wrote:
>> This little patch series is even more blorp code churn.Ã
Dolphin Emulator does ;)
On Thu, Aug 25, 2016 at 4:47 PM, Tomasz Figa wrote:
> Hi Emil,
>
> On Fri, Aug 26, 2016 at 1:07 AM, Emil Velikov
> wrote:
> > Hi all,
> >
> > While in the area, I've noticed an odd behaviour (and somewhat of a bug)
> > in the egl/android code.
> >
> > Namely: although w
On Thu, Aug 25, 2016 at 12:57 AM, Francisco Jerez wrote:
> Ilia Mirkin writes:
>
>> On Thu, Aug 25, 2016 at 12:45 AM, Francisco Jerez
>> wrote:
>>> Ilia Mirkin writes:
>>>
On Wed, Aug 24, 2016 at 4:30 PM, Francisco Jerez
wrote:
> Ilia Mirkin writes:
>
>> I had trouble
On Thu, Aug 25, 2016 at 8:00 PM, Brian Paul wrote:
> If someone is looking for a simple task in gallium...
>
> In commit 0135bd44 Marek introduced some new enum types in p_defines.h
>
> In p_context.h we should replace several instances of "unsigned shader" with
> "enum pipe_shader_type shader" an
https://bugs.freedesktop.org/show_bug.cgi?id=97260
--- Comment #31 from Michel Dänzer ---
(In reply to Clésio Luiz from comment #30)
> Well, I'm too much a newbie to compile those things (I'm using Ubuntu...).
The change is in Mesa Git master now, so you can test it with a PPA using that.
--
Y
If someone is looking for a simple task in gallium...
In commit 0135bd44 Marek introduced some new enum types in p_defines.h
In p_context.h we should replace several instances of "unsigned shader"
with "enum pipe_shader_type shader" and propagate that change into the
driver functions which cor
From: Nicholas Bishop
- Changed "Mesa mailing list" to "mesa-dev mailing list" to clarify
which list patches should be sent to
- Added an explicit link to
https://lists.freedesktop.org/mailman/listinfo/mesa-dev to show
where to subscribe to the list
- Added a link to https://git-scm.com/d
Hi Emil,
On Fri, Aug 26, 2016 at 1:07 AM, Emil Velikov wrote:
> Hi all,
>
> While in the area, I've noticed an odd behaviour (and somewhat of a bug)
> in the egl/android code.
>
> Namely: although we allow binding the EGL_OPENGL_API we explicitly clear
> the OPENGL_BIT for all the configs at eglI
From: Nicholas Bishop
On Intel Pineview M hardware, the i915 gallium driver doesn't output
the correct gl_FragCoord. It seems to always have an X coord of 0.0
and a Y coord of the window's height in pixels, e.g. 600.0f or such.
I believe this is a regression caused in part by this commit:
afa035
Reviewed-by: Ilia Mirkin
On Thu, Aug 25, 2016 at 12:41 PM, Samuel Pitoiset
wrote:
> This fixes a divergent error found with F1 2015.
>
> GM107 emitter already sets that bit.
>
> Signed-off-by: Samuel Pitoiset
> Cc:
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 +
>
Although "silences" is more accurate than "fixes".
On Thu, Aug 25, 2016 at 7:05 PM, Ilia Mirkin wrote:
> Reviewed-by: Ilia Mirkin
>
> On Thu, Aug 25, 2016 at 12:41 PM, Samuel Pitoiset
> wrote:
>> This fixes a divergent error found with F1 2015.
>>
>> GM107 emitter already sets that bit.
>>
>> S
This probably isn't the only thing that needs to be done to get
multisampled array textures working in Vulkan but I think this is all that
ISL really needs and it does fix 8 of the new CTS tests.
---
src/intel/isl/isl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sr
On Fri, Aug 26, 2016 at 12:28 AM, Jason Ekstrand wrote:
> The original pipeline cache the Kristian wrote was based on a now-false
> premise that the shaders can be stored in the pipeline cache. The Vulkan
> 1.0 spec explicitly states that the pipeline cache object is transiant and
> you are allow
On Thu, Aug 25, 2016 at 3:19 PM, Matt Turner wrote:
> Both are
>
> Reviewed-by: Matt Turner
>
Thanks!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
We hash this data structure so we can't afford to have uninitialized data
even if it is just structure padding.
---
src/intel/vulkan/anv_descriptor_set.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_descriptor_set.c
b/src/intel/vulkan/anv_descriptor_s
This new anv_shader_bin struct stores the compiled kernel (as an anv_state)
as well as all of the metadata that is generated at shader compile time.
The storage for the kernels comes from a state pool. The struct itself is
reference-counted so that it can be used by multiple pipelines at a time
wi
Found by inspection.
---
src/intel/vulkan/anv_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c
index 48d267b..933e45b 100644
--- a/src/intel/vulkan/anv_pipeline.c
+++ b/src/intel/vulkan/anv_pipeline.c
@
All of these worked before because they were depending on prog_data to be
null. Soon, we won't be able to depend on a nice prog_data pointer and
it's nice to be more explicit anyway.
---
src/intel/vulkan/anv_cmd_buffer.c | 28 ++--
src/intel/vulkan/anv_private.h
The original pipeline cache the Kristian wrote was based on a now-false
premise that the shaders can be stored in the pipeline cache. The Vulkan
1.0 spec explicitly states that the pipeline cache object is transiant and
you are allowed to delete it after using it to create a pipeline with no
ill e
---
src/intel/vulkan/anv_private.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index f03dba0..c081c14 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -1458,11 +1458,9 @@ struct anv_pipeline
When looking at GPU hangs in the new dEQP-VK.syncronization.* tests, I
realized that our pipeline cache didn't follow the spec. The spec requires
that the user be able to delete the pipeline cache after creating a
pipeline using it and then go on to use the pipeline. This took me down
the followi
Both are
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Aug 25, 2016 at 01:43:53PM -0700, Ian Romanick wrote:
> On 08/24/2016 12:42 PM, Chris Wilson wrote:
> > +#define I915_PARAM_MMAP_GTT_VERSION 40 /* XXX delete me with new libdrm */
> > + if (intel_get_integer(intelScreen, I915_PARAM_MMAP_GTT_VERSION) >= 1) {
> > + /* Theorectically un
This was found by obs:
I: Program returns random data in a function
E: Mesa no-return-in-nonvoid-function main/program_resource.c:109
Signed-off-by: Tobias Klausmann
Reviewed-by: Ian Romanick
---
V2:
Remove the !, cosmetic change, as the macro expansion stringifies everything:
__assert_fail ("!
On Thu, Aug 25, 2016 at 10:53:22AM -0700, Gurchetan Singh wrote:
> >> unsigned int format_count[ARRAY_SIZE(visuals)] = {};
>
> Isn't this invalid in C?
> http://stackoverflow.com/questions/17589533/is-an-empty-initializer-list-valid-c-code
Agreed, that should probably be `{0}`
I'll wait for v2 t
On Thu, Aug 25, 2016 at 05:23:46PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/platform_drm.c | 22 --
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/src/egl/drivers/dri2/platform_drm.c
>
On Thu, Aug 25, 2016 at 05:23:42PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Iterate over the driver_configs first in order to cut down the number of
> getConfigAttrib() calls by a factor of 5.
>
> While we're here, also drop the sentinel of the visuals array. We
> already know its siz
On Thu, Aug 25, 2016 at 1:10 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Fri, Aug 19, 2016 at 09:55:37AM -0700, Jason Ekstrand wrote:
> > This little patch series is even more blorp code churn. The end
> objective
> > is in patch 31 which pulls blorp into its own directory com
On Thu, Aug 25, 2016 at 05:23:41PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Factor out and rework the existing code so that it prints a debug
> message if we have zero configs for any visual.
>
> As a nice side effect we now provide a correct (sequential ID) when
> creating a config (
On Thu, Aug 25, 2016 at 7:09 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Tue, Aug 23, 2016 at 11:08:00AM -0700, Jason Ekstrand wrote:
> > We were inferring the format from the surface but that doesn't always
> work
> > as the surface format is the texture format and we want the
Reviewed-by: Gurchetan Singh
On Thu, Aug 25, 2016 at 9:23 AM, Emil Velikov
wrote:
> From: Emil Velikov
>
> Currently we print a debug message if the total configs is non-zero only
> to do the same (at an error level) as we return from the function.
>
> Rework the message to print if we're miss
Reviewed-by: Gurchetan Singh
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov
wrote:
> From: Emil Velikov
>
> Remove a few gratious blank lines and use the correct level of
> indentation.
>
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/egl_dri2.h | 1 -
> src/egl/driver
Reviewed-by: Gurchetan Singh
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov
wrote:
> From: Emil Velikov
>
> Earlier commit introduced support for image_loader and left the
> dri2_loader code dangling/unused. Let's remove it.
>
> Fixes: 63c5d5c6c46 ("Added pbuffer hooks for surfaceless platform
On Thu, Aug 25, 2016 at 11:32 AM, Matt Turner wrote:
> On Wed, Aug 24, 2016 at 10:49 PM, Jason Ekstrand
> wrote:
> > In some programs, we can have very deep dominance trees and the recursion
> > can cause us to risk stack overflows. Instead, we replace the recursion
> > with a pair of loops, on
On Wed, Aug 24, 2016 at 9:04 PM, Matt Turner wrote:
> Prior to this commit rename_variables_block() is recursively called,
> performing a depth-first traversal of the control flow graph. The
> function uses a non-trivial amount of stack space for local variables,
> which puts us in danger of smas
On 08/24/2016 12:42 PM, Chris Wilson wrote:
> From about kernel 4.9, GTT mmaps are virtually unlimited. A new
> parameter, I915_PARAM_MMAP_GTT_VERSION, is added to advertise the
> feature so query it and use it to avoid limiting tiled allocations to
> only fit within the mappable aperture.
>
> Sig
On 08/25/2016 06:46 AM, Tobias Klausmann wrote:
> This was found by obs:
> I: Program returns random data in a function
> E: Mesa no-return-in-nonvoid-function main/program_resource.c:109
>
> Signed-off-by: Tobias Klausmann
> ---
> src/mesa/main/program_resource.c | 2 +-
> 1 file changed, 1 ins
On 08/25/2016 08:19 AM, Emil Velikov wrote:
> On 25 August 2016 at 13:24, Francesco Ansanelli wrote:
>> Signed-off-by: Francesco Ansanelli
>> ---
>> src/mesa/main/program_resource.c |1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/mesa/main/program_resource.c
>> b/src/mesa/mai
On Thu 25 Aug 2016, Kenneth Graunke wrote:
> On Thursday, August 25, 2016 11:06:01 AM PDT Chad Versace wrote:
> > Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes
> > failures on Chrome OS.
>
> Oh, sorry, I thought these had been reviewed a while ago. But I see it
> was ju
FYI, I've already committed this because our other team needs this bug fix.
Marek
On Thu, Aug 25, 2016 at 10:56 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> We can take advantage of the fact that multi_fence does the obvious thing
> with NULL fences.
>
> This fixes unflushed fences that can g
FYI, I've already committed this because our other team needs this bug fix.
Marek
On Thu, Aug 25, 2016 at 8:26 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> It crashes.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97413
> ---
> src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
Review ping.
Missed this in my original jitevents patch because I had built llvm as one lib.
> On Aug 2, 2016, at 12:54 PM, Rowley, Timothy O
> wrote:
>
> Needed to successfully link llvmpipe or swr when using shared llvm libs.
> ---
> configure.ac | 5 +
> 1 file changed, 5 insertions(+)
>
On Thu, Aug 25, 2016 at 11:38 AM, Chad Versace wrote:
> On Thu 25 Aug 2016, Martin Peres wrote:
>> This mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and
>> fixes many applications when using DRI3:
>> - Totem with libva on hw-accelerated decoding
>> - obs-studio, using Window Captur
https://bugs.freedesktop.org/show_bug.cgi?id=32946
--- Comment #2 from Rahul ---
Is there any update over this ?
I am also facing the same issue.
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-d
On Thu, Aug 25, 2016 at 2:26 PM, Matt Turner wrote:
> On Wed, Aug 24, 2016 at 11:25 PM, Connor Abbott wrote:
>> On Thu, Aug 25, 2016 at 12:04 AM, Matt Turner wrote:
>>> Prior to this commit rename_variables_block() is recursively called,
>>> performing a depth-first traversal of the control flow
Reviewed-by: Gurchetan Singh
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov
wrote:
> From: Emil Velikov
>
> The latter already does it for us.
>
> As we're here annotate the masks as const and use unsigned for the
> index(es).
>
> Cc: Gurchetan Singh
> Cc: Chad Versace
> Signed-off-by: Emil V
On Thursday, August 25, 2016 11:06:01 AM PDT Chad Versace wrote:
> Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes
> failures on Chrome OS.
Oh, sorry, I thought these had been reviewed a while ago. But I see it
was just chatter about running dEQP-EGL.
Both are:
Reviewed-
On Thu 25 Aug 2016, Martin Peres wrote:
> This mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and
> fixes many applications when using DRI3:
> - Totem with libva on hw-accelerated decoding
> - obs-studio, using Window Capture (Xcomposite) as a Source
> - gstreamer with VAAPI
>
> Bug
On Wed, Aug 24, 2016 at 10:49 PM, Jason Ekstrand wrote:
> In some programs, we can have very deep dominance trees and the recursion
> can cause us to risk stack overflows. Instead, we replace the recursion
> with a pair of loops, one at the start and one at the end. This is
> functionally equiva
Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes
failures on Chrome OS.
On Thu 04 Aug 2016, Chad Versace wrote:
> Hi Intel folks, could one of you please run this through Jenkins?
> I verified manually that it fixes the listed dEQP tests on Skylake.
>
> Chad Versace (2):
>
From: Marek Olšák
It crashes.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97413
---
src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
b/src/gallium/drivers/ra
On Wed, Aug 24, 2016 at 11:25 PM, Connor Abbott wrote:
> On Thu, Aug 25, 2016 at 12:04 AM, Matt Turner wrote:
>> Prior to this commit rename_variables_block() is recursively called,
>> performing a depth-first traversal of the control flow graph. The
>> function uses a non-trivial amount of stack
Bump.
On Thu 11 Aug 2016, Chad Versace wrote:
> If check_textarget() determined that textarget was incorrect, it emitted
> GL_INVALID_OPERATION. This is the correct behavior when target and
> textarget are mismatched but textarget is a valid textarget enum.
>
> When textarget is not a valid text
The offset should not always be 0. For example, if EGLImage is
created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the
offset should be the actual start of miplevel 1 in drm bo.
v2: version bump on the EGL image interface and add gallium pieces.
Signed-off-by: Chuanbo Weng
---
include/G
On Thu 25 Aug 2016, Pohjolainen, Topi wrote:
>
> In the title did you mean GEN_1D?
>
> Otherwise patches two and three look good also:
>
> Reviewed-by: Topi Pohjolainen
Yep. Patches 2 and 3 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mes
>> unsigned int format_count[ARRAY_SIZE(visuals)] = {};
Isn't this invalid in C?
http://stackoverflow.com/questions/17589533/is-an-empty-initializer-list-valid-c-code
Other than that, this patch is
Reviewed-by: Gurchetan Singh
On Thu, Aug 25, 2016 at 9:23 AM, Emil Velikov
wrote:
> From: Emil
On Thu 25 Aug 2016, Pohjolainen, Topi wrote:
> On Tue, Aug 23, 2016 at 09:53:46PM -0700, Jason Ekstrand wrote:
> > The Sky Lake 1D layout is only used if the surface is linear. For tiled
> > surfaces such as depth and stenil the old gen4 2D layout is used.
>
> stencil
Sorry, please ignore this patch. I'll send out a new one. Thanks.
-Original Message-
From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
Chuanbo Weng
Sent: Thursday, August 25, 2016 6:47 PM
To: mesa-dev@lists.freedesktop.org; airl...@redhat.com
Cc: emil.l.veli...@g
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/egl_dri2.c | 28 ++--
> 1 file changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/dri
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov wrote:
> From: Emil Velikov
>
> The dri3 version of commits 60e9c35b3a0 and 6de9a03bed4.
>
> CC:
> Signed-off-by: Emil Velikov
> ---
> src/egl/drivers/dri2/platform_x11.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> di
On Thu, Aug 25, 2016 at 9:18 AM, Emil Velikov wrote:
> From: Emil Velikov
>
> Analogous to the earlier android and wayland patches. As we're here we
> can drop exposing the old version of the extension.
>
> Any dri loader/driver interface use lower bound checking thus exposing
> dri2 loader v3 to
This fixes a divergent error found with F1 2015.
GM107 emitter already sets that bit.
Signed-off-by: Samuel Pitoiset
Cc:
---
src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 5 +
src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 5 +
2 files changed, 2 insertions
Kenneth Graunke writes:
> Jason suggested adding an assert(function->impl) here. All callers
> of this function actually want ->impl, so I decided just to change
> the API.
>
> We also change the nir_lower_io_to_temporaries API here. All but one
> caller passed nir_shader_get_entrypoint(), and
From: Emil Velikov
... in dri2_x11_add_configs_for_visuals().
Currently the latter does not consider that, thus in such cases it adds
"empty" configs in the list.
Properly account for things and as we do that we can reuse count,
instead of calling _eglGetArraySize to deterime if we've added any
From: Emil Velikov
Analogous to previous commits - with an extra bonus.
Current code, apart from not attributing the lack of 'per visual'
and overall configs also overwrites the newly added config.
Namely if the dpy supports two or more of the supported formats
(XRGB, ARGB and RGB565) e
From: Emil Velikov
Analogous to previous commit.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_surfaceless.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_surfaceless.c
b/src/egl/drivers/dri2/platform_surfacel
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_drm.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_drm.c
b/src/egl/drivers/dri2/platform_drm.c
index aa9a186..df711cf 100644
--- a/src/e
From: Emil Velikov
Currently we print a debug message if the total configs is non-zero only
to do the same (at an error level) as we return from the function.
Rework the message to print if we're missing a config for the given
format.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platf
From: Emil Velikov
Iterate over the driver_configs first in order to cut down the number of
getConfigAttrib() calls by a factor of 5.
While we're here, also drop the sentinel of the visuals array. We
already know its size so we can use that and save a few bytes.
Signed-off-by: Emil Velikov
---
Hi all,
This egl series depends on the previous one (although can be split and
applied independently).
It includes a bunch of polish and 'not big enough for -stable' bugfixes.
As always: speak up if you have a preference on splitting and/or folding
the patches.
Thanks
Emil
__
From: Emil Velikov
Factor out and rework the existing code so that it prints a debug
message if we have zero configs for any visual.
As a nice side effect we now provide a correct (sequential ID) when
creating a config (via dri2_add_config).
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri
From: Emil Velikov
Similar to the dri2 one - the extension stored in struct
dri2_egl_display is unused.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_
From: Emil Velikov
Consistently indent with space rather than a mix of tab and
spaces.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 286
src/egl/drivers/dri2/egl_dri2.h | 18 +--
2 files changed, 152 insertions(+), 152 deletions(-)
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index f41f9a9..6edee68 100644
--- a/src/egl/dri
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.h b/src/egl/drivers/dri2/egl_dri2.h
index 7156955..f902006 100644
--- a/src/egl/drivers/dri2/egl_dri2.h
+++ b/src/egl/drivers/dri
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 6edee68..3ec2c53 100644
--- a/src/egl/drivers/dri2/egl_dr
From: Emil Velikov
Earlier commit introduced support for image_loader and left the
dri2_loader code dangling/unused. Let's remove it.
Fixes: 63c5d5c6c46 ("Added pbuffer hooks for surfaceless platform")
Cc: Gurchetan Singh
Cc: Chad Versace
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/
From: Emil Velikov
Do not loop over all matches if we've already found one.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 3ec2c53..e638fc9 100644
--- a/
From: Emil Velikov
Introduce a helper and use it throughout the platform code. This allows
us to reduce the amount of ifdef(s) and (potentially) use
kms_swrast_dri.so for platform !drm (namely wayland and x11).
Note: in the future as other platforms (android, surfaceless) support
the extension t
From: Emil Velikov
Remove the error prone fixed size array.
While we're here also rename to loader_extensions like in the GLX code.
Signed-off-by: Emil Velikov
---
There's a single easter egg hidden within (functionality change)
which... I should keep separate, perhaps :-\
XXX:
- Any ideas why
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11_dri3.c | 2 +-
src/glx/dri3_glx.c | 2 +-
src/loader/loader_dri3_helper.c | 2 +-
src/loader/loader_dri3_helper.h | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(
From: Emil Velikov
The extension stored in struct dri2_egl_display isn't used, thus we can
create a static const instance of the extension and point extensions[]
to it.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_android.c | 16 +---
src/egl/drivers/dri2/platf
From: Emil Velikov
The core egl/dri2 already sets the extension bit _only_ when possible -
which in Android's case is always.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_android.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/sr
From: Emil Velikov
Will allow us to reuse the function for optional extensions and fold a
bit of code.
Cc: Rob Clark
Signed-off-by: Emil Velikov
---
Rob, you were thinking about a similar thing on the GBM front, correct ?
Low hanging fruit for anyone: move this, amongst others, to loader_dri.
From: Emil Velikov
To align with the name used in the EGL and GLX loaders.
Signed-off-by: Emil Velikov
---
src/gbm/backends/dri/gbm_dri.c| 12 ++--
src/gbm/backends/dri/gbm_driint.h | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/gbm/backends/dri/gbm_dri
From: Emil Velikov
Currently all callers are careful enough not to do that, yet that will
not be the case in the future.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/s
From: Emil Velikov
Analogous to the earlier android and wayland patches. As we're here we
can drop exposing the old version of the extension.
Any dri loader/driver interface use lower bound checking thus exposing
dri2 loader v3 to a v2 capable driver is perfectly normal.
Signed-off-by: Emil Vel
From: Emil Velikov
Analogous to earlier commits.
Note: the actual version of the extension is 1, since it does not
implement .putImage2.
Signed-off-by: Emil Velikov
---
We're safe since when 2 was used the actual struct defined in
dri_interface.h was greater thus the calloc was explicitly zero
From: Emil Velikov
The function already have the respective check within.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 89d2966..a
From: Emil Velikov
All the platforms are duplicating what should be a driver/dri2 thing -
refcounting. Just fold it accordingly.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 4
src/egl/drivers/dri2/platform_android.c | 3 ---
src/egl/drivers/dri2/platf
---
Not meant to be merged, but to inspire dicussion.
---
src/egl/main/egldisplay.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c
index bbc3063..30fb687 100644
--- a/src/egl/main/egldisplay.c
+++ b/src/egl/main/egldisplay.c
@@ -411
From: Emil Velikov
This way the only places that reference DriverData are the ones that
manipulate it.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/d
From: Emil Velikov
The dri3 version of commits 60e9c35b3a0 and 6de9a03bed4.
CC:
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/pl
1 - 100 of 153 matches
Mail list logo
