On Thu, Aug 25, 2016 at 12:57 AM, Francisco Jerez <curroje...@riseup.net> wrote: > Ilia Mirkin <imir...@alum.mit.edu> writes: > >> On Thu, Aug 25, 2016 at 12:45 AM, Francisco Jerez <curroje...@riseup.net> >> wrote: >>> Ilia Mirkin <imir...@alum.mit.edu> writes: >>> >>>> On Wed, Aug 24, 2016 at 4:30 PM, Francisco Jerez <curroje...@riseup.net> >>>> wrote: >>>>> Ilia Mirkin <imir...@alum.mit.edu> writes: >>>>> >>>>>> I had trouble getting these to apply, perhaps they were meant to go on >>>>>> top of something else. Anyways, should be fairly easy for you to test >>>>>> out with llvmpipe. >>>>>> >>>>> It should apply cleanly on latest master now. >>>> >>>> Indeed it does. Running these 3 patches: >>>> >>>> glsl: Calculate bitset of secondary outputs written in >>>> ir_set_program_inouts. >>>> st/glsl_to_tgsi: Translate fragment shader secondary outputs to TGSI >>>> outputs. >>>> glsl: Fix incorrect hard-coded location of the >>>> gl_SecondaryFragColorEXT built-in. >>>> >>> >>> So you didn't have PATCH 1 applied to your tree? I'd expect this change >>> to behave badly without it and possibly end up creating too many >>> outputs. I guess I'll have to squash this change into the others... >> >> Isn't patch 1 the last patch in that list? (I applied them in the >> wrong order, but I don't think it matters) > > Nope, I was referring to "[PATCH 1/3] glsl: Fix > gl_program::OutputsWritten computation for dual-source blending.".
Ah yeah, I couldn't apply that one, I think due to the order of things I did in. With all of those applied, the piglit in question passes now, along with the other arb_blend_func_extended piglits. I haven't actually looked at the contents of the patch. -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
