Re: [Mesa-dev] [PATCH v3 2/10] glsl: keep track of ssbo variable being accessed, add access params

On Sun, 2016-01-24 at 11:46 -0500, Ilia Mirkin wrote: > On Thu, Jan 21, 2016 at 3:27 AM, Iago Toral wrote: > >> *offset = new(mem_ctx) ir_constant(0u); > >> *row_major = is_dereferenced_thing_row_major(deref); > >> *matrix_columns = 1; > >> + if (struct_field) > >> + *struct_fie

Re: [Mesa-dev] [PATCH 5/6] glsl: don't sort varying in separate shader mode

On Mon, 2015-11-30 at 14:31 +0200, Tapani Pälli wrote: > Reviewed-by: Tapani Pälli > > On 11/25/2015 11:54 AM, Timothy Arceri wrote: > > From: Gregory Hainaut > > > > This fixes an issue where the addition of the FLAT qualifier in > > varying_matches::record() can break the expected varying ord

Re: [Mesa-dev] [PATCH] mapi: Fix build with clang

On Sun, Jan 24, 2016 at 2:53 AM, Armin K wrote: > From: Tomasz Paweł Gajc > > Currently, building with clang fails due to: > > error in backend: symbol 'x86_64_entry_start' is already defined > > This patch fixes it. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89599 What do I have

Re: [Mesa-dev] [PATCH v4 00/11] st/mesa: add shader buffer support

This whole series is now, Reviewed-by: Edward O'Callaghan On 2016-01-25 05:59, Ilia Mirkin wrote: I believe I've addressed the various feedback people had. There's the outstanding point of how to expose the atomic buffer bindings, but this is a larger issue and largely tangential to the actual

Re: [Mesa-dev] gallium r300 driver for PowerPC

So I believe I have all the debugging symbols installed. From what I am seeing in gdb and valgrind I am still thinking the issue is in the glx branch. For gdb I ran it twice and stopped it during it attempt to load the r300 driver and in it attempt to load the swrast driver. Both failed at the s

[Mesa-dev] [PATCH 18/18] trace: add all compute related functions

Signed-off-by: Samuel Pitoiset --- I have forgot this one... src/gallium/drivers/trace/tr_context.c| 80 +++ src/gallium/drivers/trace/tr_dump_state.c | 51 src/gallium/drivers/trace/tr_dump_state.h | 4 ++ src/gallium/drivers/trace/tr_scree

[Mesa-dev] [PATCH 05/17] gallium: reserve one shader buffer for shared storage

At least, one shader buffer must be available for compute shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_state.h | 2 +- src/mesa/state_tracker/st_extensions.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/include/pipe/p_state.

[Mesa-dev] [PATCH 14/17] st/mesa: add state validation for compute shaders

This binds atomics, constants, samplers, ssbos, textures and ubos. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom.c| 6 src/mesa/state_tracker/st_atom.h| 5 src/mesa/state_tracker/st_atom_atomicbuf.c | 18 +++ src/mesa/state_tracker

[Mesa-dev] [PATCH 11/17] st/mesa: add conversion for compute shaders

The size of shared variables needs to be stored in gl_compute_program in order to set up pipe_compute_state::req_local_mem. According to the spec, there are no predefined inputs nor any fixed-function outputs. Signed-off-by: Samuel Pitoiset --- src/mesa/main/mtypes.h | 5 +++

[Mesa-dev] [PATCH 13/17] st/mesa: add mappings for compute shader sysvals

LOCAL_INVOCATION_ID, WORK_GROUP_ID and NUM_WORK_GROUPS are respectively mapped to THREAD_ID, BLOCK_ID and GRID_SIZE. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 12/17] st/mesa: add intrinsics for shared variables

This adds GLSL intrinsics for load/store and atomic operations. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 3 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 95 ++ 2 files changed, 98 insertions(+) diff --git a/src/mesa/state_tra

[Mesa-dev] [PATCH 04/17] gallium: disable compute shaders for meta ops

Loosely based on tessellation shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_context.c| 3 +++ src/gallium/auxiliary/postprocess/pp_run.c | 3 +++ src/gallium/auxiliary/util/u_blit.c| 3 +++ src/mesa/state_tracker/st_cb_bitmap.c | 3 +++ src/mesa/state

[Mesa-dev] [PATCH 03/17] gallium/cso: add support for compute shaders

Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/cso_cache/cso_context.c | 53 +++ src/gallium/auxiliary/cso_cache/cso_context.h | 6 +++ 2 files changed, 59 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cac

[Mesa-dev] [PATCH 10/17] st/mesa: add compute shader states

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom.c| 2 +- src/mesa/state_tracker/st_atom.h| 1 + src/mesa/state_tracker/st_atom_shader.c | 36 + src/mesa/state_tracker/st_cb_program.c | 28 +++ src/mesa/state_tracker/st_context.c | 1 + sr

[Mesa-dev] [PATCH 07/17] gallium: add indirect compute parameters to pipe_grid_info

Like indirect draw, we need to store a resource and an offset that needs to be 4 byte aligned. When indirect is used, the size of the grid (in blocks) is stored with three 32-bit integers. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_state.h | 12 1 file changed, 12

[Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

This adds a new SHARED attribute to TGSI_FILE_BUFFER. Only one shared buffer can be declared and its size is defined by MAX_COMPUTE_SHARED_SIZE. Note that an atomic buffer can also be shared. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/tgsi/tgsi_build.c| 1 + src/gallium/auxili

[Mesa-dev] [PATCH 17/17] st/mesa: expose ARB_compute_shader when compute is supported

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 2374dcc..ec30d99 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/

[Mesa-dev] [PATCH 15/17] st/mesa: add a state tracker for compute

This state tracker implements DispatchCompute() and DispatchComputeIndirect(). Signed-off-by: Samuel Pitoiset --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_cb_compute.c | 85 ++ src/mesa/state_tracker/st_cb_compute.h | 38 +++

[Mesa-dev] [PATCH 01/17] mesa: make compute maximums reflect driver-provided values

From: Ilia Mirkin Looks like the various max's were never plumbed through. Signed-off-by: Ilia Mirkin Signed-off-by: Samuel Pitoiset --- src/glsl/builtin_variables.cpp | 15 ++- src/glsl/glsl_parser_extras.cpp | 7 +++ src/glsl/glsl_parser_extras.h| 5 + src/glsl/

[Mesa-dev] [PATCH 02/17] mesa: do not use a constant for MAX_COMPUTE_SHARED_SIZE

This will allow to query the underlying drivers for the maximum total storage size of all variables declared as with PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE. Signed-off-by: Samuel Pitoiset --- src/glsl/main.cpp| 1 + src/mesa/main/config.h | 5 - src/mesa/main/get_hash_par

[Mesa-dev] [PATCH 00/17] st/mesa: add compute shaders support

Hello, This series adds the core support for ARB_compute_shader which is required for OpenGL 4.3. This is based on the ssbo/atomics work of Ilia which introduces ARB_shader_atomic_counters and ARB_shader_storage_buffer_object. I don't include the nvc0 changes in that series but this currently som

[Mesa-dev] [PATCH 16/17] st/mesa: implement limits for ARB_compute_shader

According to the spec, this also increases the following minimum values: - MAX_COMBINED_TEXTURE_IMAGE_UNITS 96 (6*16), was 80 - MAX_UNIFORM_BUFFER_BINDINGS 72 (6*12), was 60 Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 24 ++-- 1

[Mesa-dev] [PATCH 06/17] gallium: add a new interface for pipe_context::launch_grid()

This introduces pipe_grid_info which contains all information to describe a launch_grid call. This will be used to implement indirect compute in the same fashion as indirect draw. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/ilo/ilo_gpgpu.c| 8 ++ src/gallium/drive

[Mesa-dev] [PATCH 09/17] st/mesa: add a second pipeline for compute

Compute needs a new and different validation path. Signed-off-by: Samuel Pitoiset --- src/gallium/include/state_tracker/st_api.h | 8 + src/mesa/state_tracker/st_atom.c | 48 -- src/mesa/state_tracker/st_atom.h | 4 ++- src/mesa/state_tracker

Re: [Mesa-dev] [PATCH v4 11/11] trace: add support for set_shader_buffers

Looks good know. Reviewed-by: Samuel Pitoiset On 01/24/2016 07:59 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák (v1) v1 -> v2: add arg_begin/arg_end around buffer array --- src/gallium/drivers/trace/tr_context.c| 40 +++ src/ga

Re: [Mesa-dev] [PATCH] radeonsi: add DCC buffer for sampler views on new CS

On Sun, Jan 24, 2016 at 5:40 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes a VM fault and possible lockup in high memory pressure situations. > > Cc: "11.0 11.1" Only Mesa 11.1 has DCC. Reviewed-by: Marek Olšák Good catch. Marek > --- > src/gallium/drivers/radeonsi/si_d

[Mesa-dev] [PATCH v4 08/11] st/mesa: add support for memory barrier intrinsics

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák (v2) v1 -> v2: use TGSI_MEMBAR defines --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 45 ++ 1 file changed, 45 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_g

[Mesa-dev] [PATCH v4 07/11] st/mesa: use RESQ to find buffer size

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Edward O'Callaghan --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH v4 10/11] st/mesa: enable ARB_shader_storage_buffer_object when supported

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 5695f27..d066784 100644 --- a/src/mesa/state_tracker/st_extens

[Mesa-dev] [PATCH v4 03/11] glsl: keep track of ssbo variable being accessed, add access params

Currently any access params (coherent/volatile/restrict) are being lost when lowering to the ssbo load/store intrinsics. Keep track of the variable being used, and bake its access params in as the last arg of the load/store intrinsics. If the variable is accessed via an instance block, then 'varia

[Mesa-dev] [PATCH v4 00/11] st/mesa: add shader buffer support

I believe I've addressed the various feedback people had. There's the outstanding point of how to expose the atomic buffer bindings, but this is a larger issue and largely tangential to the actual code changed in this series. No one has commented on my glsl_to_tgsi bits, which I sort of expected.

[Mesa-dev] [PATCH v4 04/11] mesa: add PROGRAM_IMMEDIATE, PROGRAM_BUFFER

This makes PROGRAM_IMMEDIATE a first-class gl_register_file type, and adds PROGRAM_BUFFER to the list. These are used purely inside glsl_to_tgsi conversion. Signed-off-by: Ilia Mirkin --- src/mesa/main/mtypes.h | 2 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 - 2 files

[Mesa-dev] [PATCH v4 09/11] st/mesa: add shader buffer barrier bit

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/gallium/include/pipe/p_defines.h | 1 + src/mesa/state_tracker/st_cb_texturebarrier.c | 4 2 files changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index b

[Mesa-dev] [PATCH v4 06/11] st/mesa: add support for SSBO binding and GLSL intrinsics

Signed-off-by: Ilia Mirkin v1 -> v2: some 80 char reformatting --- src/mesa/Makefile.sources| 1 + src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/st_atom.h | 5 + src/mesa/state_tracker/st_atom_storagebuf.c | 194

[Mesa-dev] [PATCH v4 11/11] trace: add support for set_shader_buffers

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák (v1) v1 -> v2: add arg_begin/arg_end around buffer array --- src/gallium/drivers/trace/tr_context.c| 40 +++ src/gallium/drivers/trace/tr_dump_state.c | 18 ++ src/gallium/drivers/trace/tr_dump_state

[Mesa-dev] [PATCH v4 05/11] st/mesa: add atomic counter support

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources| 1 + src/mesa/program/ir_to_mesa.cpp | 4 + src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/st_atom.h | 5 + src/mesa/state_tracker/s

[Mesa-dev] [PATCH v4 01/11] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák (v1) v1 -> v2: add defines for the various bits --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/docs/source/tgsi.rst | 17 + src/gallium/include/pipe/p_shader_tokens.h | 7 ++- 3 files changed

[Mesa-dev] [PATCH v4 02/11] glsl: always initialize image_* fields, copy them on interface init

Interfaces can have image properties set in case they are buffer interfaces. Make sure not to lose this information. Signed-off-by: Ilia Mirkin Reviewed-by: Iago Toral Quiroga --- src/glsl/builtin_variables.cpp | 5 + src/glsl/nir/glsl_types.cpp| 5 + src/glsl/nir/glsl_types.h

[Mesa-dev] [PATCH] appveyor: Bump shallow clone depth.

To prevent build failures when a large patch series is committed, like happened in https://ci.appveyor.com/project/jrfonseca-fdo/mesa/build/322 due to 10 commits between dac2964f3ebd96d5ac227984ab0cd79c2c3b2a1a and 6f428328d34bed16edb8709e4a117eb710d7893d where submitted before the build slave star

Re: [Mesa-dev] [PATCH] radeonsi: add DCC buffer for sampler views on new CS

Reviewed-by: Edward O'Callaghan On 2016-01-25 03:40, Nicolai Hähnle wrote: From: Nicolai Hähnle This fixes a VM fault and possible lockup in high memory pressure situations. Cc: "11.0 11.1" --- src/gallium/drivers/radeonsi/si_descriptors.c | 33 +++ 1 file chang

Re: [Mesa-dev] [PATCH v2] trace: fix a segfault when tracing indirect draw calls

Reviewed-by: Ilia Mirkin On Sun, Jan 24, 2016 at 11:50 AM, Samuel Pitoiset wrote: > Like other resources, the indirect draw buffer must be unwrapped. > > Changes from v2: > - do it for indirect_params > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/trace/tr_context.c | 17 ++

[Mesa-dev] [PATCH v2] trace: fix a segfault when tracing indirect draw calls

Like other resources, the indirect draw buffer must be unwrapped. Changes from v2: - do it for indirect_params Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/trac

Re: [Mesa-dev] [PATCH v3 2/10] glsl: keep track of ssbo variable being accessed, add access params

On Thu, Jan 21, 2016 at 3:27 AM, Iago Toral wrote: >> *offset = new(mem_ctx) ir_constant(0u); >> *row_major = is_dereferenced_thing_row_major(deref); >> *matrix_columns = 1; >> + if (struct_field) >> + *struct_field = NULL; > > Not sure how I feel about this... I think I'd rathe

[Mesa-dev] [PATCH] radeonsi: add DCC buffer for sampler views on new CS

From: Nicolai Hähnle This fixes a VM fault and possible lockup in high memory pressure situations. Cc: "11.0 11.1" --- src/gallium/drivers/radeonsi/si_descriptors.c | 33 +++ 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH] trace: fix a segfault when tracing indirect draw calls

On Sun, Jan 24, 2016 at 10:47 AM, Samuel Pitoiset wrote: > Like other resources, the indirect draw buffer must be unwrapped. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/trace/tr_context.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/

[Mesa-dev] [PATCH] trace: fix a segfault when tracing indirect draw calls

Like other resources, the indirect draw buffer must be unwrapped. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/trace/tr_context.c b/src/gallium/drivers/trace/tr_c

Re: [Mesa-dev] [PATCH v2 10/10] trace: add support for set_shader_buffers

On 01/19/2016 03:30 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/gallium/drivers/trace/tr_context.c| 38 +++ src/gallium/drivers/trace/tr_dump_state.c | 18 +++ src/gallium/drivers/trace/tr_dump_state.h | 2

Re: [Mesa-dev] [PATCH 2/4] mesa: enable enums for OES_geometry_shader

Hi, I have decided to revert this patch, because it breaks a bunch GS piglit tests. Next time please make sure there are no piglit regressions. Thanks, Marek On Sat, Jan 23, 2016 at 1:41 AM, Ilia Mirkin wrote: > On Thu, Jan 21, 2016 at 10:17 AM, Marta Lofstedt > wrote: >> From: Marta Lofstedt

[Mesa-dev] [Bug 25663] Compile Failures on Bluegene/L

https://bugs.freedesktop.org/show_bug.cgi?id=25663 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 50996] gnome-shell, video playing fail to work properly

https://bugs.freedesktop.org/show_bug.cgi?id=50996 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Mesa-dev] [Bug 38705] call glDrawElements (GL_LINES, 2, GL_UNSIGNED_BYTE, indices); will be exhaust memory

https://bugs.freedesktop.org/show_bug.cgi?id=38705 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEEDINFO

[Mesa-dev] [Bug 18643] Guild Wars with wine run but quickly return to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=18643 Timothy Arceri changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org

[Mesa-dev] [Bug 89238] "nir/nir.h", line 643: Error: In this declaration "src" is of an incomplete type "nir_alu_src[]".

https://bugs.freedesktop.org/show_bug.cgi?id=89238 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 89773, which changed state. Bug 89773 Summary: "builtin_functions.cpp", line 3218: Error: INFINITY is not defined. https://bugs.freedesktop.org/show_bug.cgi?id=89773 What|Removed |Added

[Mesa-dev] [Bug 89773] "builtin_functions.cpp", line 3218: Error: INFINITY is not defined.

https://bugs.freedesktop.org/show_bug.cgi?id=89773 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEEDINFO

[Mesa-dev] [PATCH] mapi: Fix build with clang

From: Tomasz Paweł Gajc Currently, building with clang fails due to: error in backend: symbol 'x86_64_entry_start' is already defined This patch fixes it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89599 --- src/mapi/entry_x86-64_tls.h | 4 ++-- src/mapi/entry_x86_tls.h| 4 ++-

[Mesa-dev] [Bug 13986] [REQUEST] VMGL (formerly Xen-GL) implementation in Mesa

https://bugs.freedesktop.org/show_bug.cgi?id=13986 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 34692] -xarch=sse2 option needed for Sun Studio build on x86

https://bugs.freedesktop.org/show_bug.cgi?id=34692 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 4965] Windows GDI driver doublebuffer + alpha triggers assertation

https://bugs.freedesktop.org/show_bug.cgi?id=4965 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Mesa-dev] [Bug 79852] Mesa-10.2.1/src/gallium/state_trackers/vega/api_params.c:60: possible bad if test ?

https://bugs.freedesktop.org/show_bug.cgi?id=79852 Timothy Arceri changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: [Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

On 2016-01-23 11:06:48, Kenneth Graunke wrote: > On Thursday, January 21, 2016 11:35:31 PM PST Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > > > I tested a release build. I think v1 produced comparable code to > > before the patch, but it was a bit larger. I found that this

[Mesa-dev] [Bug 59225] SIGSEGV src/mesa/program/symbol_table.c:200

https://bugs.freedesktop.org/show_bug.cgi?id=59225 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO