Re: [Mesa-dev] [PATCH v5 12/70] glsl: implement unsized array length

On Mon, 2015-12-14 at 08:00 +0100, Iago Toral wrote: > On Sun, 2015-12-13 at 23:10 -0500, Ilia Mirkin wrote: > > On Thu, Sep 10, 2015 at 9:35 AM, Iago Toral Quiroga > com> wrote: > > > +ir_expression * > > > +lower_ubo_reference_visitor::process_ssbo_unsized_array_length(i > > > r_rvalue **rvalue,

Re: [Mesa-dev] [PATCH v2] mesa: fix interface matching done in validate_io

On 12/15/2015 03:31 AM, Timothy Arceri wrote: On Mon, 2015-12-14 at 10:29 +0200, Tapani Pälli wrote: Patch makes following changes for interface matching: - do not try to match builtin variables - handle swizzle in input name, as example 'a.z' should match with 'a' - check tha

[Mesa-dev] [PATCH V3 1/2] glsl: fix overlapping of varying locations for arrays and structs

Previously we were only reserving a single location for arrays and structs. We also didn't take into account implicit locations clashing with explicit locations when assigning locations for their arrays or structs. This patch fixes both issues. V3: handle arrays of structs V2: also fix for array

Re: [Mesa-dev] SSBO + access qualifiers

On Mon, Dec 14, 2015 at 8:57 PM, Ilia Mirkin wrote: > On Mon, Dec 14, 2015 at 11:44 PM, Jason Ekstrand wrote: >> On Mon, Dec 14, 2015 at 8:03 PM, Ilia Mirkin wrote: >>> On Mon, Dec 14, 2015 at 10:50 PM, Jason Ekstrand >>> wrote: On Mon, Dec 14, 2015 at 4:10 PM, Ilia Mirkin wrote: > H

[Mesa-dev] [PATCH 2/2] glsl: don't try adding build-ins to explicit locations bitmask

Cc: Kenneth Graunke Cc: 11.1 --- src/glsl/link_varyings.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 5a3f53d..4944d19 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -1477,7 +1

[Mesa-dev] [PATCH 1/2] glsl: fix overlapping of varying locations for arrays and structs

Previously we were only reserving a single location for arrays and structs. We also didn't take into account implicit locations clashing with explicit locations when assigning locations for their arrays or structs. This patch fixes both issues. V2: also fix for arrays of arrays and structs. Cc:

Re: [Mesa-dev] SSBO + access qualifiers

On Mon, Dec 14, 2015 at 11:44 PM, Jason Ekstrand wrote: > On Mon, Dec 14, 2015 at 8:03 PM, Ilia Mirkin wrote: >> On Mon, Dec 14, 2015 at 10:50 PM, Jason Ekstrand >> wrote: >>> On Mon, Dec 14, 2015 at 4:10 PM, Ilia Mirkin wrote: Hello, I was going to add support for the various v

Re: [Mesa-dev] SSBO + access qualifiers

On Mon, Dec 14, 2015 at 8:03 PM, Ilia Mirkin wrote: > On Mon, Dec 14, 2015 at 10:50 PM, Jason Ekstrand wrote: >> On Mon, Dec 14, 2015 at 4:10 PM, Ilia Mirkin wrote: >>> Hello, >>> >>> I was going to add support for the various volatile/etc annotations in >>> my gallium impl (which is fairly far

Re: [Mesa-dev] SSBO + access qualifiers

On Mon, Dec 14, 2015 at 10:50 PM, Jason Ekstrand wrote: > On Mon, Dec 14, 2015 at 4:10 PM, Ilia Mirkin wrote: >> Hello, >> >> I was going to add support for the various volatile/etc annotations in >> my gallium impl (which is fairly far along), but it seems like those >> are currently being dropp

[Mesa-dev] [PATCH 3/3] nir/lower_system_values: Refactor and use the builder.

Now that we have a helper in the builder for system values and a helper in core NIR to get the intrinsic opcode, there's really no point in having things split out into a helper function. This commit "modernizes" this pass to use helpers better and look more like newer passes. --- src/glsl/nir/ni

[Mesa-dev] [PATCH 2/3] nir/builder: Add a load_system_value helper

While we're at it, go ahead and make nir_lower_clip use it. Cc: Rob Clark --- src/glsl/nir/nir_builder.h| 12 src/glsl/nir/nir_lower_clip.c | 13 +++-- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir/nir_builder.

[Mesa-dev] [PATCH 1/3] nir/lower_system_values: Stop supporting non-SSA

The one user of this (i965) only ever calls it while in SSA form. --- src/glsl/nir/nir_lower_system_values.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/glsl/nir/nir_lower_system_values.c b/src/glsl/nir/nir_lower_system_values.c index 21904f8..03a9814 10

Re: [Mesa-dev] SSBO + access qualifiers

On Mon, Dec 14, 2015 at 4:10 PM, Ilia Mirkin wrote: > Hello, > > I was going to add support for the various volatile/etc annotations in > my gallium impl (which is fairly far along), but it seems like those > are currently being dropped on the floor by lower_ubo_references, and > NIR has no suppor

[Mesa-dev] [PATCH] draw: handle edge flags in llvm path

From: Roland Scheidegger We just ignored them altogether. While this feature is rather old-fashioned supporting it is actually rather trivial. This fixes the associated piglit tests (2 gl-1.0-edgeflag, 2 gl-2.0-edgeflag and all (7) of point-vertex-id). --- src/gallium/auxiliary/draw/draw_llvm.c

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

On Mon, Dec 14, 2015 at 5:12 PM, Ian Romanick wrote: > On 12/14/2015 04:39 PM, Ilia Mirkin wrote: >> On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: >>> On 12/14/2015 03:38 PM, Ilia Mirkin wrote: It's a pretty standard feature of compilers to init things to 0 and not have the full

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

https://bugs.freedesktop.org/show_bug.cgi?id=80183 Roland Scheidegger changed: What|Removed |Added CC||cgerlac...@gmail.com -- You are re

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions > viewport width/height are not displayed

https://bugs.freedesktop.org/show_bug.cgi?id=80183 --- Comment #15 from Roland Scheidegger --- cgerlach42, does this still happen? There were some more clip fixes very recently. If this still happens you really need to provide either sample code or an apitrace. -- You are receiving this mail be

Re: [Mesa-dev] [PATCH 3/3] i965: Use MESA_FORMAT_B8G8R8X8_SRGB for RGB visuals

On Dec 13, 2015 2:06 PM, "Mike Lothian" wrote: > > Hi > > These three commits have stopped Plasma5's kwin working on my skylake system As another data point, it also breaks XWayland+DRI3 on my BDW. I can't even run glsgears without it segfaulting. > Reverting back to 7752bbc44e78e982de3cd4c3486

Re: [Mesa-dev] [PATCH v2] mesa: fix interface matching done in validate_io

On Mon, 2015-12-14 at 10:29 +0200, Tapani Pälli wrote: > Patch makes following changes for interface matching: > >- do not try to match builtin variables >- handle swizzle in input name, as example 'a.z' should > match with 'a' >- check that amount of inputs and outputs matches >

Re: [Mesa-dev] [PATCH] draw: don't set start_instance and instance id for pt emit

Just one minor nit below. Reviewed-by: Brian Paul On 12/14/2015 05:58 PM, srol...@vmware.com wrote: From: Roland Scheidegger This just adds confusion, these parameters are used when fetching vertices by translate, but certainly not when emitting hw vertices for drivers, they make no sense t

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

On 12/14/2015 04:39 PM, Ilia Mirkin wrote: > On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: >> On 12/14/2015 03:38 PM, Ilia Mirkin wrote: >>> It's a pretty standard feature of compilers to init things to 0 and >>> not have the full structure specified like that... what compiler are >>> you s

[Mesa-dev] [PATCH] draw: don't set start_instance and instance id for pt emit

From: Roland Scheidegger This just adds confusion, these parameters are used when fetching vertices by translate, but certainly not when emitting hw vertices for drivers, they make no sense there (setting them has no consequences otherwise since there won't be any elements with instance_divisor s

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

On Mon, Dec 14, 2015 at 7:28 PM, Ian Romanick wrote: > On 12/14/2015 03:38 PM, Ilia Mirkin wrote: >> It's a pretty standard feature of compilers to init things to 0 and >> not have the full structure specified like that... what compiler are >> you seeing these with? Can we just fix the glitch with

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

On 12/14/2015 03:38 PM, Ilia Mirkin wrote: > It's a pretty standard feature of compilers to init things to 0 and > not have the full structure specified like that... what compiler are > you seeing these with? Can we just fix the glitch with a > -Wno-stupid-warnings? I have observed this with sever

Re: [Mesa-dev] [PATCH] clover: Fix build against LLVM 3.8 SVN >= r255078

On Wed, Dec 9, 2015 at 5:30 AM, Francisco Jerez wrote: > Michel Dänzer writes: > >> From: Michel Dänzer >> >> Signed-off-by: Michel Dänzer > > Looks OK to me, > Reviewed-by: Francisco Jerez > >> --- >> src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 >> 1 file changed, 4 insert

[Mesa-dev] SSBO + access qualifiers

Hello, I was going to add support for the various volatile/etc annotations in my gallium impl (which is fairly far along), but it seems like those are currently being dropped on the floor by lower_ubo_references, and NIR has no support for them either. Both in GLSL IR and NIR, the variable is what

Re: [Mesa-dev] [PATCH 8/8] nir: Remove empty visit_call_src and visit_load_const_src functions

On Mon, Dec 14, 2015 at 3:34 PM, Ian Romanick wrote: > From: Ian Romanick > > The guts were removed in dfb3abba. It has been almost exactly a year, > so I dont think we're going to "decide we want [predication] back." Yeah, I think that bridge is burned. > Silences several "unused parameter" w

Re: [Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

It's a pretty standard feature of compilers to init things to 0 and not have the full structure specified like that... what compiler are you seeing these with? Can we just fix the glitch with a -Wno-stupid-warnings? On Mon, Dec 14, 2015 at 6:34 PM, Ian Romanick wrote: > From: Ian Romanick > > ni

[Mesa-dev] [PATCH 8/8] nir: Remove empty visit_call_src and visit_load_const_src functions

From: Ian Romanick The guts were removed in dfb3abba. It has been almost exactly a year, so I dont think we're going to "decide we want [predication] back." Silences several "unused parameter" warnings: nir/nir.c: In function ‘visit_call_src’: nir/nir.c:1052:32: warning: unused parameter ‘inst

[Mesa-dev] [PATCH 6/8] nir: Trivial clean ups in the generated nir_constant_expressions.c

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/nir/nir_constant_expressions.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/glsl/nir/nir_constant_expressions.py b/src/glsl/nir/nir_constant_expressions.py index a83c12e..d82b865 100644 --- a/

[Mesa-dev] [PATCH 2/8] nir: Silence missing field initializer warnings for nir_dest

From: Ian Romanick nir/nir.h:576:4: warning: missing initializer for field 'is_ssa' of 'nir_dest' [ -Wmissing-field-initializers] nir_dest dest = NIR_DEST_INIT; ^ nir/nir.h:538:10: note: 'is_ssa' declared here bool is_ssa; ^ nir/nir.h:576:55: warning: missing initializer for

[Mesa-dev] [PATCH 4/8] nir: Silence missing field initializer warnings for vectors in nir_constant_expressions

From: Ian Romanick nir/nir_constant_expressions.c: In function 'evaluate_ball2': nir/nir_constant_expressions.c:279:7: warning: missing initializer for field 'z' of 'struct bool_vec' [-Wmissing-field-initializers] }; ^ nir/nir_constant_expressions.c:234:10: note: 'z' declared here

[Mesa-dev] [PATCH 5/8] nir: Silence unused parameter warnings in nir_constant_expression.c

From: Ian Romanick nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter] evaluate_ball3(unsigned num_components, nir_const_value *_src) ^ nir/nir_constant_expressions.c: In function 'evaluate_fddx': nir/nir_constant_expre

[Mesa-dev] [PATCH 3/8] nir: Silence missing field initializer warnings for nir_alu_src

From: Ian Romanick nir/nir_builder.h:234:4: warning: missing initializer for field 'use_link' of 'n ir_src' [-Wmissing-field-initializers] nir_alu_src alu_src = { NIR_SRC_INIT }; ^ Number of total warnings in my build reduced from 1676 to 1643 (reduction of 33). Patch generated by:

[Mesa-dev] [PATCH 1/8] nir: Silence missing field initializer warnings for nir_src

From: Ian Romanick nir/nir.h: In function 'nir_src_for_ssa': nir/nir.h:552:4: warning: missing initializer for field 'use_link' of 'nir_src' [-Wmissing-field-initializers] nir_src src = NIR_SRC_INIT; ^ In file included from nir/nir.c:28:0: nir/nir.h:508:21: note: 'use_link' declared here

[Mesa-dev] [PATCH 7/8] nir: Silence unused parameter warnings

From: Ian Romanick These cases had the parameter removed: nir/nir_lower_vec_to_movs.c: In function ‘try_coalesce’: nir/nir_lower_vec_to_movs.c:124:66: warning: unused parameter ‘shader’ [-Wunused-parameter] try_coalesce(nir_alu_instr *vec, unsigned start_idx, nir_shader *shader)

Re: [Mesa-dev] [PATCH] mesa: remove validation of shaders that should be done elsewhere

On Wed, 2015-12-09 at 00:17 +1100, Timothy Arceri wrote: > In core profile even if re-linking fails rendering shouldn't fail as > the > previous succesfully linked program will still be available. It also > shouldn't be possible to have an unlinked program as part of the > current rendering state.

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #17 from Ronie Salgado --- > > In case this turns out to be necessary to make GROMACS OpenCL work, do you > mind > if I finish your patch and make it suitable for merging (with proper credit, > of > course)? > > I don't mind. Just g

[Mesa-dev] [Bug 93375] unsupported call to function erf when running GROMACS with OpenCL

https://bugs.freedesktop.org/show_bug.cgi?id=93375 --- Comment #2 from Vedran Miletić --- (In reply to Aaron Watry from comment #1) > Looks like libclc does not yet implement the erf function. Neat, the approach you suggest seems to be simpler than the one I had in mind, analogous to ldexp http:

Re: [Mesa-dev] [Bug 93352] GRID Autosport crashes on start of race

On Mon, 2015-12-14 at 09:46 -0500, Ilia Mirkin wrote: > Hi Edwin, > > Thanks for reaching out to the mesa community! See my comments > inline. > > On Mon, Dec 14, 2015 at 5:13 AM, > wrote: > > Comment # 20 on bug 93352 from Edwin Smith > > My name is Edwin Smith and I work for Feral Interactive

Re: [Mesa-dev] [PATCH] nir: Fix number of indices on shared variable store intrinsics.

Kenneth Graunke writes: > Shared variables and input reworks landed around the same time. > Presumably, this was some sort of mistake in rebase conflict resolution. > > Found by inspection. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/glsl/nir/nir_intrinsics.

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #16 from Vedran Miletić --- (In reply to Ronie Salgado from comment #15) > I did not fix my patch. Sorry, but I do not have time to work on this. In case this turns out to be necessary to make GROMACS OpenCL work, do you mind if I fi

Re: [Mesa-dev] [PATCH 2/2] i965: Allocate URB space for HS and DS stages when required.

Kenneth Graunke writes: > From: Chris Forbes > > v2: (by Ken, incorporating feedback from Matt Turner): > - Rewrite the push constant allocation code to be clearer. > - Only apply the minimum VS entries workaround on Gen 8. > > v3: (by Ken) > - Fix a bug in v2 where we failed to allocate the ful

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix crash when calling glViewport with no surface bound

On Thu, Dec 10, 2015 at 01:08:37PM -0800, Nanley Chery wrote: > On Tue, Dec 08, 2015 at 04:35:57PM +, Neil Roberts wrote: > > If EGL_KHR_surfaceless_context is used then glViewport can be called > > with NULL for the draw and read surfaces. This was previously causing > > a crash because the i9

[Mesa-dev] [Bug 93375] unsupported call to function erf when running GROMACS with OpenCL

https://bugs.freedesktop.org/show_bug.cgi?id=93375 --- Comment #1 from Aaron Watry --- Looks like libclc does not yet implement the erf function. erfc is implemented, but not plain erf. The amd-builtins branch in libclc looks like there's an erf implementation that can be ported over: https://l

Re: [Mesa-dev] [PATCH v2 06/13] i965: Add tessellation shader VUE map code.

On Saturday, December 12, 2015 12:16:33 PM Jordan Justen wrote: > On 2015-12-11 13:23:55, Kenneth Graunke wrote: > > Based on a patch by Chris Forbes, but largely rewritten by Ken. > > > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/brw_compiler.h | 20 ++- > > src/m

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #15 from Ronie Salgado --- > > Ronie, was this fixed? > > I did not fix my patch. Sorry, but I do not have time to work on this. Best regards, Ronie 2015-12-14 12:06 GMT-03:00 : > *Comment # 14

Re: [Mesa-dev] [PATCH] nir: Fix number of indices on shared variable store intrinsics.

Reviewed-by: Jason Ekstrand On Mon, Dec 14, 2015 at 3:32 AM, Kenneth Graunke wrote: > Shared variables and input reworks landed around the same time. > Presumably, this was some sort of mistake in rebase conflict resolution. > > Found by inspection. > > Signed-off-by: Kenneth Graunke > --- > s

Re: [Mesa-dev] Mesa 11.1.0 release candidate 3

On 12/11/2015 07:08 PM, Eric Anholt wrote: > Emil Velikov writes: > >> The third release candidate for Mesa 11.1.0 is now available. > > With the kernel stuff now looking ready to merge upstream, I'd like to > merge support for vc4 based on the headed-upstream kernel ABI to the > 11.1 branch. I

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta/generate_mipmap: Work-around GLES 1.x problem with GL_DRAW_FRAMEBUFFER

On 12/12/2015 10:50 AM, Emil Velikov wrote: > On 3 December 2015 at 23:52, Anuj Phogat wrote: >> On Thu, Dec 3, 2015 at 2:43 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> GL_DRAW_FRAMEBUFFER does not exist in OpenGL ES 1.x, and since >>> _mesa_meta_begin hasn't been called yet, we have

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

Kristian Høgsberg writes: > "Song, Ruiling" writes: > >>> -Original Message- >>> From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of >>> Kristian H?gsberg >>> Sent: Monday, December 14, 2015 1:34 PM >>> To: Song, Ruiling >>> Cc: Winiarski, Michal ; intel- >>> g...@lists.

Re: [Mesa-dev] [PATCH 1/2] i965: Use DIV_ROUND_UP() in gen7_urb.c code.

Kenneth Graunke writes: > This is a newer convention, which we prefer over ALIGN(x, n) / n. > > Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/gen7_urb.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git

[Mesa-dev] [Bug 93375] unsupported call to function erf when running GROMACS with OpenCL

https://bugs.freedesktop.org/show_bug.cgi?id=93375 Bug ID: 93375 Summary: unsupported call to function erf when running GROMACS with OpenCL Product: Mesa Version: git Hardware: All OS: All Status

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

On 14 December 2015 at 18:11, Brian Paul wrote: > On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: >> --- a/src/gallium/auxiliary/util/u_surface.c >> +++ b/src/gallium/auxiliary/util/u_surface.c >> @@ -600,7 +600,7 @@ is_box_inside_resource(const struct pipe_resource >> *res, >> depth =

Re: [Mesa-dev] [PATCH] docs: Replace sourceforge logo with a text link

Reviewed-by: Brian Paul On 12/14/2015 08:55 AM, Andreas Boll wrote: Fixes the following Lintian (Debian package checker) error: privacy-breach-logo usr/share/doc/mesa-common-dev/contents.html (http://sourceforge.net/sflogo.php?group_id=3&type=1) usr/share/doc/mesa-common-dev/than

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

"Song, Ruiling" writes: >> -Original Message- >> From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of >> Kristian H?gsberg >> Sent: Monday, December 14, 2015 1:34 PM >> To: Song, Ruiling >> Cc: Winiarski, Michal ; intel- >> g...@lists.freedesktop.org; mesa-dev@lists.freede

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

"Song, Ruiling" writes: >> -Original Message- >> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel >> Vetter >> Sent: Monday, December 14, 2015 4:28 PM >> To: Song, Ruiling >> Cc: k...@bitplanet.net; Winiarski, Michal ; >> mesa-dev@lists.freedesktop.org; intel-...@l

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c| 2 +- src/gallium/auxil

Re: [Mesa-dev] [PATCH 1/3] mesa/main: use BITSET_FOREACH_SET in perf_monitor_result_size

Reviewed-by: Samuel Pitoiset On 12/14/2015 06:06 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle This should make the code both faster and slightly clearer. --- src/mesa/main/performance_monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/perfo

Re: [Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

Instead of "unsigned int" you can just use "unsigned", but this is OK. With addressing the patch 1 issue, this series is: Reviewed-by: Brian Paul On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/svga/svga_tgsi_

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix perfcounter selection for SI_PC_MULTI_BLOCK layouts

On 2015-12-15 04:06, Nicolai Hähnle wrote: From: Nicolai Hähnle The incorrectly computed register count caused lockups. --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gall

Re: [Mesa-dev] gallium r300 driver for PowerPC

On 14.12.2015 04:10, Eero Tamminen wrote: On 12/14/2015 10:44 AM, Herminio Hernandez, Jr. wrote: I am new to this list. I have been trying to see if I can fix or at least pin point an issue with Radeon r300 driver failing on PowerPC systems. This has been a problem for a while and I would like t

Re: [Mesa-dev] [PATCH v3] nvc0: check return value of nvc0_program_validate()

Reviewed-by: Ilia Mirkin On Mon, Dec 14, 2015 at 12:07 PM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/gallium/driv

[Mesa-dev] [PATCH v3] nvc0: check return value of nvc0_program_validate()

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c index

[Mesa-dev] [PATCH 2/3] gallium/radeon: remove unnecessary test in r600_pc_query_add_result

From: Nicolai Hähnle This test is a left-over of the initial development. It is unneeded and misleading, so let's get rid of it. --- src/gallium/drivers/radeon/r600_perfcounter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_perfcounter.c b/src/gallium/dr

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

On 12/14/2015 05:56 PM, Ilia Mirkin wrote: No, gp->code_size is set by the validation. You need to put that last. Right, it's set by nvc0_program_translate(). On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/

[Mesa-dev] [PATCH 3/3] radeonsi: fix perfcounter selection for SI_PC_MULTI_BLOCK layouts

From: Nicolai Hähnle The incorrectly computed register count caused lockups. --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/radeonsi/si_perfcounter.c index

[Mesa-dev] [PATCH 1/3] mesa/main: use BITSET_FOREACH_SET in perf_monitor_result_size

From: Nicolai Hähnle This should make the code both faster and slightly clearer. --- src/mesa/main/performance_monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/performance_monitor.c b/src/mesa/main/performance_monitor.c index 98dfbea..43529b2 10

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

On Mon, Dec 14, 2015 at 11:59 AM, Pierre Moreau wrote: > On 11:56 AM - Dec 14 2015, Ilia Mirkin wrote: >> No, gp->code_size is set by the validation. You need to put that last. > > IIRC, you can't assume in which order the compiler will decide to evaluate the > different expressions being AND'ed.

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

On 11:56 AM - Dec 14 2015, Ilia Mirkin wrote: > No, gp->code_size is set by the validation. You need to put that last. IIRC, you can't assume in which order the compiler will decide to evaluate the different expressions being AND'ed. > > On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset > wrote

Re: [Mesa-dev] [PATCH v2 1/3] nv50, nvc0: make use of unreachable() when invalid texture target happens

Reviewed-by: Ilia Mirkin On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv50_tex.c | 3 +-- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 4 +--- > 2 files changed, 2 insertions(+), 5

Re: [Mesa-dev] [PATCH v2 3/3] nv50: check return value of nouveau_object_new()

Reviewed-by: Ilia Mirkin On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: > When ret == 0, obj is not NULL. Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

No, gp->code_size is set by the validation. You need to put that last. On Mon, Dec 14, 2015 at 11:51 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + > 1 file changed, 1 insertion(+), 4 d

[Mesa-dev] [PATCH v2 3/3] nv50: check return value of nouveau_object_new()

When ret == 0, obj is not NULL. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv84_video.c b/src/gallium/drivers/nouveau/nv50/nv84

[Mesa-dev] [PATCH v2 2/3] nvc0: check return value of nvc0_program_validate()

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c b/src/gallium/drivers/nouveau/nvc0/nvc0_shader_state.c index

[Mesa-dev] [PATCH v2 1/3] nv50, nvc0: make use of unreachable() when invalid texture target happens

Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_tex.c | 3 +-- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_tex.c b/src/gallium/drivers/nou

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

On 12/14/2015 05:07 PM, Ilia Mirkin wrote: On Mon, Dec 14, 2015 at 11:04 AM, Samuel Pitoiset wrote: On 12/14/2015 04:05 PM, Ilia Mirkin wrote: Bogus. obj will be null on failure. Well, checking the return value instead of obj seems better tbh, because we do that in the rest of the code

[Mesa-dev] Further Coccinelle inspired cleanups

The following patch series continues on what can be done with Coccinelle to clean up Mesa3D house keeping duties. On a good note we have a pretty clean tree for the fairly trivial runs so far. [PATCH 1/6] gallium: Remove unnecessary semicolons [PATCH 2/6] gallium/drivers: Remove unnecessary semi

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/svga/svga_tgsi_insn.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c index dbb90f7..1c7097f 10064

[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c index 09c1b37..f0

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_test_blend.c | 2 +- src/gallium/drivers/llvmpipe/lp_test_conv.c | 2 +- src/ga

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index db53eb4..e7932bf 100644 -

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c| 2 +- src/gallium/auxiliary/util/u_surface.c | 2 +- src/gallium/auxili

[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16 src/gallium/drivers/ilo/shader/ilo_shader_vs.c | 4 ++-- src/gallium/drivers/ilo/shader/toy_legaliz

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

On 12/14/2015 04:48 PM, Pierre Moreau wrote: On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote: frame cannot be NULL in that branch. Spotted by Coverity. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nouveau_video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

On Mon, Dec 14, 2015 at 11:04 AM, Samuel Pitoiset wrote: > > > On 12/14/2015 04:05 PM, Ilia Mirkin wrote: >> >> Bogus. obj will be null on failure. > > > Well, checking the return value instead of obj seems better tbh, because we > do that in the rest of the code. Can ret = 0 but obj still be nul

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

On Mon, Dec 14, 2015 at 11:02 AM, Samuel Pitoiset wrote: > > > On 12/14/2015 04:04 PM, Ilia Mirkin wrote: >> >> Instead take the return value and stick it into the if below. >> Returning early from these functions isn't something we generally want >> to do. > > > We already return at the same poin

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

On 12/14/2015 04:05 PM, Ilia Mirkin wrote: Bogus. obj will be null on failure. Well, checking the return value instead of obj seems better tbh, because we do that in the rest of the code. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: Spotted by Coverity. Signed-off-by: Samue

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

On 12/14/2015 04:04 PM, Ilia Mirkin wrote: Instead take the return value and stick it into the if below. Returning early from these functions isn't something we generally want to do. We already return at the same point for vertex programs, but I can definitely move this below. On Mon, De

Re: [Mesa-dev] [PATCH 2/5] nv50, nvc0: fix potential resource leak in nvXX_create_texture_view()

On 12/14/2015 04:01 PM, Ilia Mirkin wrote: Again, bogus. Can't get there. I'd take a patch that asserts though, or marks it unreachable, or just drops the default case entirely. Make it unreachable is fine by me. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: Spotted by Coverity

[Mesa-dev] [PATCH] docs: Replace sourceforge logo with a text link

Fixes the following Lintian (Debian package checker) error: privacy-breach-logo usr/share/doc/mesa-common-dev/contents.html (http://sourceforge.net/sflogo.php?group_id=3&type=1) usr/share/doc/mesa-common-dev/thanks.html (http://sourceforge.net/sflogo.php?group_id=3&type=1) The extend

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

On 11:14 AM - Dec 14 2015, Samuel Pitoiset wrote: > frame cannot be NULL in that branch. Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nouveau_video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/gallium/drivers/nouveau/nouveau_vide

Re: [Mesa-dev] [PATCH 5/5] draw: remove clip_vertex from vertex header

On 12/12/15 02:31, srol...@vmware.com wrote: From: Roland Scheidegger vertex header had both clip_pos and clip_vertex. We only really need one (clip_pos) because the draw llvm shader would overwrite the position output from the vs with the viewport transformed. However, we don't really need the

Re: [Mesa-dev] [PATCH 3/5] nvc0: make sure gmt programs are correctly validated

Instead take the return value and stick it into the if below. Returning early from these functions isn't something we generally want to do. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/

Re: [Mesa-dev] [PATCH 5/5] draw: remove clip_vertex from vertex header

The series looks good to me. Thanks for digging into this. Reviewed-by: Brian Paul On 12/11/2015 07:31 PM, srol...@vmware.com wrote: From: Roland Scheidegger vertex header had both clip_pos and clip_vertex. We only really need one (clip_pos) because the draw llvm shader would overwrite th

Re: [Mesa-dev] [PATCH 5/5] nouveau: remove logically dead code in nouveau_vpe_mb_mv_header()

This code is old, crusty and subtle. Clearly this can't happen, however I'd rather not remove it... if you really hate it how about a #if 0 /* XXX */ ... #endif I have no idea what DUAL_PRIME is, or whether it appears for frame or field stuff. Or what that PMPEG command does for that matter. On

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 --- Comment #14 from Vedran Miletić --- Ronie, was this fixed? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:/

Re: [Mesa-dev] [PATCH 4/5] nv50: check return value of nouveau_object_new()

Bogus. obj will be null on failure. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv84_video.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/galliu

Re: [Mesa-dev] [PATCH 2/5] nv50, nvc0: fix potential resource leak in nvXX_create_texture_view()

Again, bogus. Can't get there. I'd take a patch that asserts though, or marks it unreachable, or just drops the default case entirely. On Mon, Dec 14, 2015 at 5:14 AM, Samuel Pitoiset wrote: > Spotted by Coverity. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv50_

Re: [Mesa-dev] [PATCH 1/5] nv50, nvc0: fix using uninitialized value 'templ.texture' in nvXX_blit_set_src()

While true, this isn't a real issue. view->pipe = *templ; view->pipe.reference.count = 1; view->pipe.texture = NULL; texture can be uninitialized in the template. I know that your first impulse might be "just make Coverity happy", but I don't pander to broken tools. If the report is bogu

  1   2   >