[Mesa-dev] [Bug 91747] Ubuntu 15.04/Oibaf PPA - Unity bar not transparent

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91747 Benjamin Bellec changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this ma

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Samuel Iglesias Gonsálvez
On 28/08/15 08:48, Jordan Justen wrote: > On 2015-08-27 23:07:26, Samuel Iglesias Gonsálvez wrote: >> >> On 28/08/15 08:06, Samuel Iglesias Gonsálvez wrote: >>> >>> On 28/08/15 02:21, Jordan Justen wrote: On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH] Revert "i965: Stop aux data compare preventing program binary re-use"

2015-08-27 Thread Pohjolainen, Topi
On Thu, Aug 27, 2015 at 10:05:14AM -0700, Ben Widawsky wrote: > On Thu, Aug 27, 2015 at 10:51:59AM +0300, Pohjolainen, Topi wrote: > > On Wed, Aug 26, 2015 at 03:46:05PM -0700, Ben Widawsky wrote: > > > This reverts commit 1bba29ed403e735ba0bf04ed8aa2e571884fcaaf > > > Author: Topi Pohjolainen > >

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Jordan Justen
On 2015-08-27 23:07:26, Samuel Iglesias Gonsálvez wrote: > > On 28/08/15 08:06, Samuel Iglesias Gonsálvez wrote: > > > > On 28/08/15 02:21, Jordan Justen wrote: > >> On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: > >>> From: Samuel Iglesias Gonsalvez > >>> > >>> Notice that Skylake needs to i

Re: [Mesa-dev] [PATCH rework] mesa: rework Driver.CopyImageSubData() and related code

2015-08-27 Thread Jason Ekstrand
On Thu, Aug 27, 2015 at 11:42 PM, Jason Ekstrand wrote: > From: Brian Paul > > Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures > to wrap renderbuffer sources/destinations. This caused a bit of a mess in > the Mesa/gallium state tracker because we had to basically undo

[Mesa-dev] [PATCH rework] mesa: rework Driver.CopyImageSubData() and related code

2015-08-27 Thread Jason Ekstrand
From: Brian Paul Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker because we had to basically undo that wrapping. Instead, change ctx->Driver.CopyImageSubData() to

Re: [Mesa-dev] [PATCH v2] glsl: provide the option of using BFE for unpack builting lowering

2015-08-27 Thread Ilia Mirkin
On Fri, Aug 28, 2015 at 2:25 AM, Matt Turner wrote: > On Tue, Aug 25, 2015 at 9:39 AM, Ilia Mirkin wrote: >> This greatly improves generated code, especially for the snorm variants, >> since it is able to get rid of the lshift/rshift for sext, as well as >> replacing each shift + mask with a sing

Re: [Mesa-dev] [PATCH] glsl: use bitfield_insert instead of and + shift + or for packing

2015-08-27 Thread Ilia Mirkin
On Fri, Aug 28, 2015 at 2:20 AM, Matt Turner wrote: > On Thu, Aug 20, 2015 at 6:00 PM, Ilia Mirkin wrote: >> It is fairly tricky to detect the proper conditions for using bitfield >> insert, but easy to just use it up front. This removes a lot of >> instructions on nvc0 when invoking the packing

Re: [Mesa-dev] [PATCH v2] glsl: provide the option of using BFE for unpack builting lowering

2015-08-27 Thread Matt Turner
On Tue, Aug 25, 2015 at 9:39 AM, Ilia Mirkin wrote: > This greatly improves generated code, especially for the snorm variants, > since it is able to get rid of the lshift/rshift for sext, as well as > replacing each shift + mask with a single op. > > Signed-off-by: Ilia Mirkin > --- > > v1 -> v2:

[Mesa-dev] [Bug 91785] make check DispatchSanity_test.GLES31 regression

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91785 Vinson Lee changed: What|Removed |Added Keywords||bisected CC|

Re: [Mesa-dev] [PATCH 2/2] i965/gen: Don't conflate base miplevel in sampler state

2015-08-27 Thread Kenneth Graunke
On Thursday, August 27, 2015 11:50:52 AM Ben Widawsky wrote: > Gen9 changes the meaning of this to coarse LOD quality mode. Although that's a > desirable thing to be setting, it doesn't match the gen8 behavior and this was > unintentional. > > This doesn't fix, or regress anything on SKL (AFAICT).

Re: [Mesa-dev] [PATCH] glsl: use bitfield_insert instead of and + shift + or for packing

2015-08-27 Thread Matt Turner
On Thu, Aug 20, 2015 at 6:00 PM, Ilia Mirkin wrote: > It is fairly tricky to detect the proper conditions for using bitfield > insert, but easy to just use it up front. This removes a lot of > instructions on nvc0 when invoking the packing builtins. > > Signed-off-by: Ilia Mirkin > --- > > Not su

Re: [Mesa-dev] [PATCH 1/2] i965/gen9: Annotate input coverage mask change

2015-08-27 Thread Kenneth Graunke
On Thursday, August 27, 2015 11:50:51 AM Ben Widawsky wrote: > As far as I can tell, the behavior is preserved from the previous generations. > Before we set a single bit to tell the FS whether or not we'll be using an > input > coverage mask. Now we have some options which are implementing variou

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Samuel Iglesias Gonsálvez
On 28/08/15 08:06, Samuel Iglesias Gonsálvez wrote: > > > On 28/08/15 02:21, Jordan Justen wrote: >> On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: >>> From: Samuel Iglesias Gonsalvez >>> >>> Notice that Skylake needs to include a header in the sampler message >>> so it will need some tweak

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Samuel Iglesias Gonsálvez
On 28/08/15 02:21, Jordan Justen wrote: > On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> Notice that Skylake needs to include a header in the sampler message >> so it will need some tweaks to work there. >> >> Signed-off-by: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Samuel Iglesias Gonsálvez
On 28/08/15 02:04, Jordan Justen wrote: > On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> Notice that Skylake needs to include a header in the sampler message >> so it will need some tweaks to work there. >> >> Signed-off-by: Samuel Iglesias Gonsalvez

Re: [Mesa-dev] [PATCH v4 (part2) 13/59] glsl: Lower unsized array's length calculation expression

2015-08-27 Thread Samuel Iglesias Gonsálvez
On 27/08/15 21:24, Jordan Justen wrote: > On 2015-08-05 01:30:10, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> v2: >> - Reduce the number of lines over 80 character line width >> limit. (Thomas Hellan) >> >> Signed-off-by: Samuel Iglesias Gonsalvez >> --- >> src/glsl/lo

Re: [Mesa-dev] [PATCH v4 (part2) 13/59] glsl: Lower unsized array's length calculation expression

2015-08-27 Thread Samuel Iglesias Gonsálvez
On 27/08/15 21:26, Jordan Justen wrote: > On 2015-08-05 01:30:10, Iago Toral Quiroga wrote: >> From: Samuel Iglesias Gonsalvez >> >> v2: >> - Reduce the number of lines over 80 character line width >> limit. (Thomas Hellan) >> >> Signed-off-by: Samuel Iglesias Gonsalvez >> --- >> src/glsl/lo

Re: [Mesa-dev] [PATCH 07/10] glsl: add support for the imageSamples function

2015-08-27 Thread Ilia Mirkin
On Fri, Aug 28, 2015 at 1:46 AM, Kenneth Graunke wrote: > On Thursday, August 27, 2015 11:48:36 PM Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/glsl/builtin_functions.cpp | 48 >> +++--- >> 1 file changed, 45 insertions(+), 3 deletions(-) >>

[Mesa-dev] [Bug 91785] make check DispatchSanity_test.GLES31 regression

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91785 Bug ID: 91785 Summary: make check DispatchSanity_test.GLES31 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords:

Re: [Mesa-dev] [PATCH 06/10] i965: add support for textureSamples function

2015-08-27 Thread Kenneth Graunke
On Thursday, August 27, 2015 11:48:35 PM Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/drivers/dri/i965/brw_defines.h | 3 +++ > src/mesa/drivers/dri/i965/brw_disasm.c | 1 + > src/mesa/drivers/dri/i965/brw_fs.cpp | 7 +++ > src/mesa/driver

Re: [Mesa-dev] [PATCH 07/10] glsl: add support for the imageSamples function

2015-08-27 Thread Kenneth Graunke
On Thursday, August 27, 2015 11:48:36 PM Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/glsl/builtin_functions.cpp | 48 > +++--- > 1 file changed, 45 insertions(+), 3 deletions(-) > > diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builti

Re: [Mesa-dev] [PATCH 1/6] i965: Only consider fixed_hw_reg in equals() if file is HW_REG/IMM.

2015-08-27 Thread Jason Ekstrand
On Aug 27, 2015 10:33 PM, "Kenneth Graunke" wrote: > > On Thursday, August 27, 2015 10:17:24 PM Matt Turner wrote: > > Noticed when debugging things that lead to the next patch. > > > > On G45 (and presumably ILK) this helps register coalescing: > > > > total instructions in shared programs: 40773

Re: [Mesa-dev] [PATCH 1/6] i965: Only consider fixed_hw_reg in equals() if file is HW_REG/IMM.

2015-08-27 Thread Kenneth Graunke
On Thursday, August 27, 2015 10:17:24 PM Matt Turner wrote: > Noticed when debugging things that lead to the next patch. > > On G45 (and presumably ILK) this helps register coalescing: > > total instructions in shared programs: 4077373 -> 4077340 (-0.00%) > instructions in affected programs:

[Mesa-dev] [PATCH 4/6] i965/fs: Skip blocks in register coalescing interference check.

2015-08-27 Thread Matt Turner
No need to walk through instructions in blocks we know don't contain our registers' live ranges. --- View with git diff -w for easier review. .../drivers/dri/i965/brw_fs_register_coalesce.cpp | 34 +- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/src/mesa/dr

[Mesa-dev] [PATCH 5/6] i965/fs: Replace awful variable names.

2015-08-27 Thread Matt Turner
start_to -> dst_start end_to-> dst_end start_from-> src_start end_from -> src_end var_to-> dst_var var_from -> src_var reg_to-> dst_reg reg_to_offset -> dst_reg_offset reg_from -> src_reg Not sure how these made sense to me

[Mesa-dev] [PATCH 6/6] i965/fs: Remove fs_visitor::try_replace_with_sel().

2015-08-27 Thread Matt Turner
No shader-db changes on g4x, snb, hsw, or bdw. --- opt_peephole_sel() still offers some small benefits. src/mesa/drivers/dri/i965/brw_fs.h | 1 - src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 - src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 89 3 files

[Mesa-dev] [PATCH 1/6] i965: Only consider fixed_hw_reg in equals() if file is HW_REG/IMM.

2015-08-27 Thread Matt Turner
Noticed when debugging things that lead to the next patch. On G45 (and presumably ILK) this helps register coalescing: total instructions in shared programs: 4077373 -> 4077340 (-0.00%) instructions in affected programs: 43751 -> 43718 (-0.08%) helped:52 HURT:

[Mesa-dev] [PATCH 3/6] i965/fs: Improve register coalescing interference check.

2015-08-27 Thread Matt Turner
I always thought that the is_control_flow() -> return false check was a bad hack, and some previous attempts to remove it have failed and have been reverted. The previous two patches fix some problems that caused register coalescing to not notice some interference between registers, which the is_c

[Mesa-dev] [PATCH 2/6] i965/fs: Use overwrites_reg() instead of dst.equals().

2015-08-27 Thread Matt Turner
equals() returns false for registers with different types, using it isn't appropriate to determine whether an is overwriting a register. --- src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH] r600g: add proper support for VGT_FLUSH

2015-08-27 Thread Ilia Mirkin
Just an observation... this was previously only done for EG+, while now R600/R700 will get this too. On Fri, Aug 28, 2015 at 12:31 AM, Dave Airlie wrote: > From: Dave Airlie > > The geom shader rings require a VGT FLUSH, but up until now > it was just hacked into the function, add proper support

[Mesa-dev] [PATCH] r600g: add proper support for VGT_FLUSH

2015-08-27 Thread Dave Airlie
From: Dave Airlie The geom shader rings require a VGT FLUSH, but up until now it was just hacked into the function, add proper support for it. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 9 + src/gallium/drivers/r600/r600_hw_context.c | 5 + src/gall

[Mesa-dev] [PATCH 02/10] glsl: add ir_texture_samples texture opcode

2015-08-27 Thread Ilia Mirkin
Will be used for textureSamples() Signed-off-by: Ilia Mirkin --- src/glsl/ir.cpp| 5 +++-- src/glsl/ir.h | 3 ++- src/glsl/ir_clone.cpp | 1 + src/glsl/ir_equals.cpp | 1 + src/glsl/ir_hv_accept.cpp

[Mesa-dev] [PATCH 03/10] nir: add nir_texop_texture_samples and convert from glsl

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/nir/glsl_to_nir.cpp | 5 + src/glsl/nir/nir.h | 4 +++- src/glsl/nir/nir_print.c | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 5fb4ee2..ed1a91e 100

[Mesa-dev] [PATCH 07/10] glsl: add support for the imageSamples function

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_functions.cpp | 48 +++--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 3fdda32..b3982f4 100644 --- a/src/glsl/builtin_functi

[Mesa-dev] [PATCH 10/10] i965: enable ARB_shader_texture_image_samples

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index c9eb24f..997f359 100644 --- a/src/mesa/drivers/dri/i965/intel_extensio

[Mesa-dev] [PATCH 00/10] i965: add ARB_shader_texture_image_samples support

2015-08-27 Thread Ilia Mirkin
This should include everything. I sent a test for textureSamples to piglit a while ago, not sure how to test imageSamples -- apparently ms images aren't entirely supported on i965? But I'm not sure via what feat that happens. I'll send some tests for compiler tests though. Ilia Mirkin (10): mes

[Mesa-dev] [PATCH 05/10] glsl: add support for the textureSamples function

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_functions.cpp | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 5e05199..3fdda32 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/buil

[Mesa-dev] [PATCH 09/10] i965: add handling for imageSamples

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 172e29f..0b13e74 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/

[Mesa-dev] [PATCH 08/10] nir: convert glsl imageSamples into a new intrinsic

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/nir/glsl_to_nir.cpp | 6 +- src/glsl/nir/nir_intrinsics.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index ed1a91e..fb90ade 100644 --- a/src/glsl/nir/glsl_to_nir.cpp

[Mesa-dev] [PATCH 04/10] glsl: add ARB_shader_texture_image_samples infrastructure

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 2d631f0..118333d 100644 --- a/src

[Mesa-dev] [PATCH 01/10] mesa: add infra for ARB_shader_texture_image_samples

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index a57d5ba..1f7d542 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c

[Mesa-dev] [PATCH 06/10] i965: add support for textureSamples function

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/brw_defines.h | 3 +++ src/mesa/drivers/dri/i965/brw_disasm.c | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 7 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 4 src/mesa/drivers/dri/i965/b

Re: [Mesa-dev] [PATCH] glsl: clean up textureSize prototype

2015-08-27 Thread Timothy Arceri
On Thu, 2015-08-27 at 23:08 -0400, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin Reviewed-by: Timothy Arceri > --- > src/glsl/builtin_functions.cpp | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp >

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 11:14 PM, Timothy Arceri wrote: > On Thu, 2015-08-27 at 15:43 -0400, Ilia Mirkin wrote: >> Cube maps are special in that they have separate teximages for each >> face. We handled that by copying the data to them separately, but in >> case zoffset != 0 or depth != 6 we would

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Timothy Arceri
On Thu, 2015-08-27 at 15:43 -0400, Ilia Mirkin wrote: > Cube maps are special in that they have separate teximages for each > face. We handled that by copying the data to them separately, but in > case zoffset != 0 or depth != 6 we would read off the end of the client > array or modify the wrong im

[Mesa-dev] [PATCH] glsl: clean up textureSize prototype

2015-08-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/glsl/builtin_functions.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 4092d68..5e05199 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions

[Mesa-dev] [PATCH] r600: port si_conv_prim_to_gs_out from radeonsi

2015-08-27 Thread Dave Airlie
From: Dave Airlie This code we broken by the tess merge, and I totally missed it until now. I'm not sure this fixes anything but it stops the assert. Cc: "11.0" Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_pipe.h | 31 --- 1 file changed, 16 inserti

Re: [Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Matt Turner
On Thu, Aug 27, 2015 at 4:56 PM, Ilia Mirkin wrote: > The ffsll patch seems dodgy... among other things the same logic is in > imports.c and thus would probably best refactored to src/util, but > additionally it's only defined if !_GNU_SOURCE -- is that OK? Would > e.g. a 32-bit build have ffsll?

Re: [Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 8:19 PM, Brian Paul wrote: > On 08/27/2015 06:01 PM, Ilia Mirkin wrote: >> >> Are you sure you want to enable it in spite of the fact that it >> doesn't handle swizzling (which you've slightly papered over by >> switching some of the format orders around, but as I pointed o

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Notice that Skylake needs to include a header in the sampler message > so it will need some tweaks to work there. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
On 08/27/2015 06:01 PM, Ilia Mirkin wrote: Are you sure you want to enable it in spite of the fact that it doesn't handle swizzling (which you've slightly papered over by switching some of the format orders around, but as I pointed out not completely)? As I said before, I'd like to get as much

Re: [Mesa-dev] [PATCH 4/9] st/mesa: add st_CopyImageSubData() function

2015-08-27 Thread Brian Paul
On 08/27/2015 05:59 PM, Ilia Mirkin wrote: You need to rip out the st_CopyImageSubData I already added in st_cb_texture.c (I think). Yes, I created my feature branch before you added that code. I'll have to rebase onto master. A patch to remove your code will be trivial. -Brian On Thu,

Re: [Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Brian Paul
On 08/27/2015 05:56 PM, Ilia Mirkin wrote: The ffsll patch seems dodgy... among other things the same logic is in imports.c and thus would probably best refactored to src/util, I can do that in a follow-on someday. There was very little in src/util/ back when I added that code to u_math.h s

Re: [Mesa-dev] [PATCH v4 (part2) 15/59] i965/vec4: Implement unsized array's length calculation

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:12, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Notice that Skylake needs to include a header in the sampler message > so it will need some tweaks to work there. > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Ilia Mirkin
Are you sure you want to enable it in spite of the fact that it doesn't handle swizzling (which you've slightly papered over by switching some of the format orders around, but as I pointed out not completely)? On Thu, Aug 27, 2015 at 7:48 PM, Brian Paul wrote: > This enables GL_ARB_copy_image for

[Mesa-dev] [PATCH 2/2] r600g: use PRIu64 for some compute debug printfs

2015-08-27 Thread Dave Airlie
From: Dave Airlie Otherwise this will crash on 32-bit, and it gets rid of warnings building on 32-bit. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memo

[Mesa-dev] [PATCH 1/2] gallium/util: fix debug_get_flags_option on 32-bit

2015-08-27 Thread Dave Airlie
From: Dave Airlie On 32-bit we need to use PRIu64 flags for printfs, otherwise this segfaults in R600_DEBUG=help otherwise. Cc: "11.0" Signed-off-by: Dave Airlie --- src/gallium/auxiliary/util/u_debug.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/aux

Re: [Mesa-dev] [PATCH 4/9] st/mesa: add st_CopyImageSubData() function

2015-08-27 Thread Ilia Mirkin
You need to rip out the st_CopyImageSubData I already added in st_cb_texture.c (I think). On Thu, Aug 27, 2015 at 7:47 PM, Brian Paul wrote: > From: Neha Bhende > > Basically, get the src/dst pipe_resource surfaces and call the > pipe_context::resource_copy_region() function. > > Reviewed-by: Ma

Re: [Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Ilia Mirkin
The ffsll patch seems dodgy... among other things the same logic is in imports.c and thus would probably best refactored to src/util, but additionally it's only defined if !_GNU_SOURCE -- is that OK? Would e.g. a 32-bit build have ffsll? Perhaps it'd make sense to post the generic patches to the l

[Mesa-dev] [PATCH 5/9] gallium: add new PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
In principle, since all gallium drivers implement pipe_context:: resource_copy_region() they should all support GL_ARB_copy_image but until that's true and verified, drivers must opt-in to support this feature. Reviewed-by: Marek Olšák --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 +

[Mesa-dev] [PATCH 9/9] llvmpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
We have to disallow the 8 and 16-bit 3-component formats for non-display target surfaces as we do for softpipe (see earlier commit). v2: Simplify 3-component format check, per Marek. Also check that target != PIPE_BUFFER --- src/gallium/drivers/llvmpipe/lp_screen.c | 17 - 1 file

[Mesa-dev] [PATCH 6/9] st/mesa: enable GL_ARB_copy_image if driver supports PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 13d636f..dfa8936 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_

[Mesa-dev] [PATCH 3/9] st/mesa: tweak surface format mapping table

2015-08-27 Thread Brian Paul
1. Try to choose R8G8B8A8 unorm/srgb formats before other orders in an effort to try to match component ordering for UINT/SINT/etc. 2. If we can't get a format such as PIPE_FORMAT_A16_UNORM, try PIPE_FORMAT_R16G16B16A16_UNORM before shallower formats. Reviewed-by: Marek Olšák --- src/mesa/state

[Mesa-dev] [PATCH 1/9] mesa, i965: rework Driver.CopyImageSubData() and related code

2015-08-27 Thread Brian Paul
Previously, core Mesa's _mesa_CopyImageSubData() created temporary textures to wrap renderbuffer sources/destinations. This caused a bit of a mess in the Mesa/gallium state tracker because we had to basically undo that wrapping. Instead, change ctx->Driver.CopyImageSubData() to take both gl_rende

[Mesa-dev] [PATCH 4/9] st/mesa: add st_CopyImageSubData() function

2015-08-27 Thread Brian Paul
From: Neha Bhende Basically, get the src/dst pipe_resource surfaces and call the pipe_context::resource_copy_region() function. Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources| 2 + src/mesa/state_tracker/st_cb_copyimage.c | 94 src/mesa

[Mesa-dev] [PATCH 7/9] softpipe: don't use 3-component formats

2015-08-27 Thread Brian Paul
Mesa and gallium don't have a complete set of matching 3-component texture formats. For example, 8-bit sRGB unorm. To fully support the GL_ARB_copy_image extension we need to have support for all of these formats: RGB8_UNORM, RGB8_SNORM, RGB8_SRGB, RGB8_UINT, and RGB8_SINT using the same componen

[Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

2015-08-27 Thread Brian Paul
This enables GL_ARB_copy_image for softpipe. --- src/gallium/drivers/softpipe/sp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 817572c..4cd8581 100644 --- a/src/gallium/drive

[Mesa-dev] [PATCH 2/9] util: update util_resource_copy_region() for GL_ARB_copy_image

2015-08-27 Thread Brian Paul
This primarily means added support for copying between compressed and uncompressed formats. --- src/gallium/auxiliary/util/u_surface.c | 106 +++-- 1 file changed, 88 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxi

[Mesa-dev] VMware patches for OpenGL 3.3 support

2015-08-27 Thread Brian Paul
If you've seen the announcement of VMware Workstation 12 / Fusion 8, we now support OpenGL 3.3 in the guest. The Mesa/gallium patches for this can be seen in my git repo at cgit.freedesktop.org/~brianp/mesa/log/?h=vmware-gl3 The first 15 patches or so are general gallium util/tgsi/etc chang

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/6] mesa: fix SwapBytes handling in texstore.

2015-08-27 Thread Brian Paul
Some of the commit messages, like this one, seem to line-wrapped shorter than necessary. For patches 1-4, the changes look OK, AFAICT. Though, it seems there's some very similar byte-swap code duplicated in several places. Would it be possible to write a function which does byte swapping for

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 --- Comment #3 from Arsen Tufankjian --- Oops you're right I didn't RTFM. This can be closed for now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 --- Comment #2 from Brian Paul --- I don't recall seeing any patches from you on the mesa-dev list yet. Generally, we don't give git commit access until the developer has some track record of producing good patches. -- You are receiving this ma

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 --- Comment #1 from Arsen Tufankjian --- Created attachment 117956 --> https://bugs.freedesktop.org/attachment.cgi?id=117956&action=edit GPG Public Key -- You are receiving this mail because: You are the QA Contact for the bug. You are the as

[Mesa-dev] [Bug 91783] Requesting Account

2015-08-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91783 Bug ID: 91783 Summary: Requesting Account Product: Mesa Version: git Hardware: Other OS: Linux (All) Status: NEW Severity: normal Priority: medi

Re: [Mesa-dev] [PATCH 1/2] i965/gen9: Annotate input coverage mask change

2015-08-27 Thread Ben Widawsky
On Thu, Aug 27, 2015 at 11:50:51AM -0700, Ben Widawsky wrote: > As far as I can tell, the behavior is preserved from the previous generations. > Before we set a single bit to tell the FS whether or not we'll be using an > input > coverage mask. Now we have some options which are implementing vario

Re: [Mesa-dev] [PATCH v2] mesa/es3.1: Expose GL_ARB_framebuffer_no_attachments to GLES 3.1

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 3:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > V2: Conform to new standard for exposing enums for OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt Reviewed-by: Ilia Mirkin While this patch is fine, it appears that ES3.1 doesn't have GL_FRAMEBUFFER_DEFAULT_LA

Re: [Mesa-dev] [PATCH 1/3] r600g/sb: Handle undef in read port tracker

2015-08-27 Thread Dieter Nützel
Hello Glenn, with your series I got some steps forward on this one: [r600g] regression: SB-related NI/Turks crash on 'gsraytrace' https://bugs.freedesktop.org/show_bug.cgi?id=91503 Crash is GONE. GPU hang is BACK _without_ R600_DEBUG=nosb. With R600_DEBUG=nosb vsraytrace, fsraytrace and gsrayt

Re: [Mesa-dev] [PATCH 0/8] nouveau: add support for vaapi

2015-08-27 Thread Emil Velikov
On 27 August 2015 at 18:35, Ilia Mirkin wrote: > On Thu, Aug 27, 2015 at 1:11 PM, Emil Velikov > wrote: >> HI Julien, >> >> On 27 August 2015 at 15:15, Julien Isorce wrote: >>> Currently nouveau does not support chunk decoding >>> which is required to support st/va >>> >>> The following patches

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Brian Paul
On 08/27/2015 03:15 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 5:15 PM, Brian Paul wrote: On 08/27/2015 03:05 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: On 08/27/2015 01:43 PM, Ilia Mirkin wrote: C

Re: [Mesa-dev] [PATCH] mesa: rename rowStride to imageStride in texturesubimage()

2015-08-27 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Aug 27, 2015 at 5:16 PM, Brian Paul wrote: > --- > src/mesa/main/teximage.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index 8d94903..3647854 100644 > --- a/src/mesa/main

[Mesa-dev] [PATCH] mesa: rename rowStride to imageStride in texturesubimage()

2015-08-27 Thread Brian Paul
--- src/mesa/main/teximage.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 8d94903..3647854 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3764,7 +3764,7 @@ texturesubimage(struct gl_c

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 5:15 PM, Brian Paul wrote: > On 08/27/2015 03:05 PM, Ilia Mirkin wrote: >> >> On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: >>> >>> On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: On 08/27/2015 01:43 PM, Ilia Mirkin wrote: > > > Cube maps ar

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Brian Paul
On 08/27/2015 03:05 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: On 08/27/2015 01:43 PM, Ilia Mirkin wrote: Cube maps are special in that they have separate teximages for each face. We handled that by copying t

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 4:43 PM, Ilia Mirkin wrote: > On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: >> On 08/27/2015 01:43 PM, Ilia Mirkin wrote: >>> >>> Cube maps are special in that they have separate teximages for each >>> face. We handled that by copying the data to them separately, but

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 4:32 PM, Brian Paul wrote: > On 08/27/2015 01:43 PM, Ilia Mirkin wrote: >> >> Cube maps are special in that they have separate teximages for each >> face. We handled that by copying the data to them separately, but in >> case zoffset != 0 or depth != 6 we would read off the

Re: [Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Brian Paul
On 08/27/2015 01:43 PM, Ilia Mirkin wrote: Cube maps are special in that they have separate teximages for each face. We handled that by copying the data to them separately, but in case zoffset != 0 or depth != 6 we would read off the end of the client array or modify the wrong images. zoffset/de

Re: [Mesa-dev] [PATCH 1/2] st/mesa: reduce time spent in calculating temp read/writes

2015-08-27 Thread Marek Olšák
Yes, I think it's useful too. I'm not familiar with this code, so you can add Acked-by: Marek Olšák and commit if there is no reviewer. Marek On Thu, Aug 27, 2015 at 9:48 PM, Dave Airlie wrote: > On 27 August 2015 at 21:57, Marek Olšák wrote: >> We could just skip this for radeonsi or any dr

Re: [Mesa-dev] [PATCH 1/2] st/mesa: reduce time spent in calculating temp read/writes

2015-08-27 Thread Dave Airlie
On 27 August 2015 at 21:57, Marek Olšák wrote: > We could just skip this for radeonsi or any driver that does regalloc, > because it's useless there. I did expect this comment from Ilia, though adding a CAP and piping it through is an option I'd look into later. (or someone who cares can do it so

[Mesa-dev] [PATCH] mesa: only copy the requested teximage faces

2015-08-27 Thread Ilia Mirkin
Cube maps are special in that they have separate teximages for each face. We handled that by copying the data to them separately, but in case zoffset != 0 or depth != 6 we would read off the end of the client array or modify the wrong images. zoffset/depth have already been verified by the time th

Re: [Mesa-dev] [PATCH v4 (part2) 13/59] glsl: Lower unsized array's length calculation expression

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:10, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > v2: > - Reduce the number of lines over 80 character line width > limit. (Thomas Hellan) > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 190 >

Re: [Mesa-dev] [PATCH v4 (part2) 13/59] glsl: Lower unsized array's length calculation expression

2015-08-27 Thread Jordan Justen
On 2015-08-05 01:30:10, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > v2: > - Reduce the number of lines over 80 character line width > limit. (Thomas Hellan) > > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/glsl/lower_ubo_reference.cpp | 190 >

Re: [Mesa-dev] [PATCH 2/2] i965/gen: Don't conflate base miplevel in sampler state

2015-08-27 Thread Ben Widawsky
On Thu, Aug 27, 2015 at 11:50:52AM -0700, Ben Widawsky wrote: Subject should read gen9. Fixed locally > Gen9 changes the meaning of this to coarse LOD quality mode. Although that's a > desirable thing to be setting, it doesn't match the gen8 behavior and this was > unintentional. > > This doesn'

Re: [Mesa-dev] [PATCH 0/2] i965: Two more UNIFORM cleanups

2015-08-27 Thread Kenneth Graunke
On Wednesday, August 26, 2015 10:24:04 AM Jason Ekstrand wrote: > These two patches are largely a re-send of other patches in my bigger > series to push small uniform arrays. The first patch is a really nice > cleanup that I think we want regardless of pushing uniform arrays. > Unfortunately, it w

Re: [Mesa-dev] [PATCH 1/5] nir: Make nir_block_{first, last}_instr return NULL for empty blocks.

2015-08-27 Thread Jason Ekstrand
On Thu, Aug 27, 2015 at 11:45 AM, Jason Ekstrand wrote: > On Tue, Aug 25, 2015 at 1:24 PM, Kenneth Graunke > wrote: >> This is a lot more reasonable than returning an offset from NULL. >> >> Signed-off-by: Kenneth Graunke >> --- >> src/glsl/nir/nir.h | 4 ++-- >> 1 file changed, 2 insertions(+

[Mesa-dev] [PATCH 1/2] i965/gen9: Annotate input coverage mask change

2015-08-27 Thread Ben Widawsky
As far as I can tell, the behavior is preserved from the previous generations. Before we set a single bit to tell the FS whether or not we'll be using an input coverage mask. Now we have some options which are implementing various extensions. These bits are used for the various conservative rasteri

[Mesa-dev] [PATCH 2/2] i965/gen: Don't conflate base miplevel in sampler state

2015-08-27 Thread Ben Widawsky
Gen9 changes the meaning of this to coarse LOD quality mode. Although that's a desirable thing to be setting, it doesn't match the gen8 behavior and this was unintentional. This doesn't fix, or regress anything on SKL (AFAICT). Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_sampl

Re: [Mesa-dev] [PATCH 1/5] nir: Make nir_block_{first, last}_instr return NULL for empty blocks.

2015-08-27 Thread Jason Ekstrand
On Tue, Aug 25, 2015 at 1:24 PM, Kenneth Graunke wrote: > This is a lot more reasonable than returning an offset from NULL. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/nir.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir

Re: [Mesa-dev] [Nouveau] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Ilia Mirkin
On Thu, Aug 27, 2015 at 1:59 PM, Alex Deucher wrote: > On Thu, Aug 27, 2015 at 1:55 PM, Hans de Goede wrote: >> Hi, >> >> On 27-08-15 15:46, Marek Olšák wrote: >>> >>> On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede >>> wrote: Hi All, While debugging: https://bugzilla.redhat.c

  1   2   >