On Mon, May 25, 2015 at 08:57:36AM -0600, Brian Paul wrote:
> ---
> src/mesa/main/glformats.c | 2 +-
> src/mesa/main/glformats.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Very nice, series is:
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/mesa/main/glformats.c b/src/mes
The problem is that the EDGEFLAG has to be toggled at vertex submission
time. This can be done from either the draw or the regular paths. Avoid
falling back to draw just because there's an edgeflag.
Signed-off-by: Ilia Mirkin
Cc: "10.5 10.6"
---
src/gallium/drivers/nouveau/nv30/nvfx_vertprog.c
These are only used once per draw, so it makes sense to keep them in
GART. Also take this opportunity to modernize the buffer mapping API
usage.
Signed-off-by: Ilia Mirkin
Cc: "10.5 10.6"
---
src/gallium/drivers/nouveau/nv30/nv30_draw.c | 16 ++--
1 file changed, 10 insertions(+), 6
Commit 8acaf862dfe switched things over to use TEXCOORD instead of
GENERIC, but did not update the nv30 swtnl draw paths. This teaches the
draw logic about TEXCOORD.
Among other things, this fixes a crash in demos/arbocclude when using
swtnl. Curiously enough, the point-sprite piglit works without
Instead of always having it in the data, let the bo placement decide it.
This fixes glxgears with swtnl forced on.
Signed-off-by: Ilia Mirkin
Cc: "10.5 10.6"
---
src/gallium/drivers/nouveau/nv30/nv30_draw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/dr
This prevents leaks and makes sure all data are available.
In case there is only one section it works as before.
Signed-off-by: Jan Vesely
---
This might break stuff if something relied on previous rodata locations.
src/gallium/drivers/radeon/radeon_elf_util.c | 9 ++---
1 file changed, 6
Signed-off-by: Jan Vesely
---
src/gallium/drivers/r600/evergreen_compute.c | 24 +---
src/gallium/drivers/r600/r600_llvm.c | 14 +-
src/gallium/drivers/r600/r600_llvm.h | 2 ++
src/gallium/drivers/radeon/r600_pipe_common.h | 17 +
Signed-off-by: Jan Vesely
---
src/gallium/drivers/r600/evergreen_compute.c | 6 +++---
src/gallium/drivers/r600/evergreen_state.c | 4 ++--
src/gallium/drivers/r600/r600_asm.h | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/r600/evergreen_co
reserve buffer id 2 for rodata
Signed-off-by: Jan Vesely
---
This needs coresponding LLVM changes (see [0], also posted) to work,
but it does not break anything (except waste a buffer) without.
Both series fix table based builtins (acosh, atanh, cosh, log1p),
as well as gegl's format conversion
Hi Rob,
I've sent a patch that adds the CAP.
Marek
On Mon, May 25, 2015 at 3:17 PM, Rob Clark wrote:
> Ignoring the compiler for a moment, I think this would probably break
> my varying linking (where I match up VS out and FS in).. (and I
> wouldn't be surprised if somewhere between tgsi_to_ni
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Flagged by Oracle's parfait static analyzer:
Error: Format string argument mismatch (CWE 628)
In call to printf with format string "usage: %s [options] \n\nPossible options are:\n"
Too many arguments for format string (got more than 1 arguments)
at line 285 of src/glsl/main.cpp in
pong
the unhappyness case will hopefully soon be extended with cull_distance
+ clipvertex, so good to see this fixed!
Reviewed-by: Tobias Klausmann
On 25.05.2015 21:42, Ilia Mirkin wrote:
ping
On Sun, May 17, 2015 at 5:56 PM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
Just happe
Overall, this looks like a good idea to me. Probably needs some changes
in our internal code but the idea is quite sane.
Roland
Am 24.05.2015 um 13:19 schrieb Marek Olšák:
> Hi,
>
> The reason I add this is that TGSI doesn't allow indirect indexing of inputs
> and outputs. Consider this:
>
> M
2015-05-25 18:20 GMT+02:00 Brian Paul :
> This hasn't been updated in a long time and from recent discussion on
> the mailing list, it's not always clear what's expected. Hopefully,
> this will help a bit.
> ---
> docs/devinfo.html | 155
> ++
>
I guess one day we might actually make use of specifying the size in
bytes despite currently requiring that size to be a multiple of vec4
size. It should not really be difficult to allow 4-byte offsets / sizes
since the constants are only fetched one element at a time anyway.
Essentially just the v
ping
On Sun, May 17, 2015 at 5:56 PM, Ilia Mirkin wrote:
> Signed-off-by: Ilia Mirkin
> ---
>
> Just happened to notice it... still not the leak I'm chasing :( The
> only time this can happen is basically when it's unhappy about the
> clip distance usage (i.e. clipvertex + clipdistance at the sa
https://bugs.freedesktop.org/show_bug.cgi?id=90600
--- Comment #11 from Dylan ---
I tested with auto tools and python 2.6, so I'm so I'm rather suprised that
isn't working. I'm out of town today, but I'm pretty sure I know how to fix it,
I'll take care of it first thing in the morning, and send o
This case wasn't dealing with floats, though.
That said I guess it's a pointless discussion. If the compiler doesn't
think it's a good idea I'll just add the parentheses just to shut it up...
Roland
Am 25.05.2015 um 21:19 schrieb Axel Davy:
> If one side is NaN, then
> !(x == y) is true, whereas
This makes the vertex buffer go to GART, not VRAM, and redoes the
mapping to not use the UNSYNCHRONIZED access (which is meaningless on a
VRAM buffer anyways). While we're at it, add some flushes for VBO data.
Moving the vertex buffer from VRAM to GART makes glxgears work fully
with NV30_SWTNL=1.
Commit 8acaf862dfe switched things over to use TEXCOORD instead of
GENERIC, but did not update the nv30 swtnl draw paths. This teaches the
draw logic about TEXCOORD.
Among other things, this fixes a crash in demos/arbocclude when using
swtnl. Curiously enough, the point-sprite piglit works without
https://bugs.freedesktop.org/show_bug.cgi?id=90600
--- Comment #10 from Vinson Lee ---
Reverting commit cf718cc964f86dc49c1fc9ed5e39aa5bd87ad931 triggers a similar
build error in another file.
Traceback (most recent call last):
File "src/mapi/glapi/gen/remap_helper.py", line 199, in
main(
If one side is NaN, then
!(x == y) is true, whereas x != y is false
On 25/05/2015 21:01, Ilia Mirkin wrote :
On Mon, May 25, 2015 at 2:53 PM, Matt Turner wrote:
It's that the compiler thinks that (!x == y) is a typo for !(x == y).
I have to say, I think the first does look strange.
I dunno..
On Mon, May 25, 2015 at 12:01 PM, Ilia Mirkin wrote:
> On Mon, May 25, 2015 at 2:53 PM, Matt Turner wrote:
>> On Mon, May 25, 2015 at 11:50 AM, Roland Scheidegger
>> wrote:
>>> I can't see what's wrong with the code.
>>> I thought not using parantheses there is quite common, is that some new
>>
Am 24.05.2015 um 13:19 schrieb Marek Olšák:
> From: Marek Olšák
>
> ---
> src/gallium/auxiliary/tgsi/tgsi_scan.c | 11 +--
> src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 ++
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c
> b/s
It makes it easier for the statically-sized arrays. Not that there is
anything good about statically-sized arrays.
The hard limit is 1022 arrays per file, because ArrayID has 10 bits.
Marek
On Mon, May 25, 2015 at 8:42 PM, Roland Scheidegger wrote:
> Do we really need this?
> I think ideally we
On Mon, May 25, 2015 at 2:53 PM, Matt Turner wrote:
> On Mon, May 25, 2015 at 11:50 AM, Roland Scheidegger
> wrote:
>> I can't see what's wrong with the code.
>> I thought not using parantheses there is quite common, is that some new
>> warning from some super duper new compiler version?
>
> It'
On Mon, May 25, 2015 at 11:53 AM, Matt Turner wrote:
> On Mon, May 25, 2015 at 11:50 AM, Roland Scheidegger
> wrote:
>> I can't see what's wrong with the code.
>> I thought not using parantheses there is quite common, is that some new
>> warning from some super duper new compiler version?
>
> It
On 25.05.2015 20:36, Roland Scheidegger wrote:
This doesn't really do what the commit message claims - it just adds a
cap bit, not actual support for arb_cull_distance (which was already
there), so the log should be changed accordingly.
Yep, you are completely right here, will change it to be
On Mon, May 25, 2015 at 11:50 AM, Roland Scheidegger wrote:
> I can't see what's wrong with the code.
> I thought not using parantheses there is quite common, is that some new
> warning from some super duper new compiler version?
It's that the compiler thinks that (!x == y) is a typo for !(x == y
I can't see what's wrong with the code.
I thought not using parantheses there is quite common, is that some new
warning from some super duper new compiler version?
Roland
Am 25.05.2015 um 02:46 schrieb Roger Brown:
>
>
> From mesa-10.5.6 compilation.
>
> Is this an oversight ?
>
> lp_qu
From: Marek Olšák
Softpipe, llvmpipe, and radeonsi pass tests. Other drivers need testing.
The piglit filter should be "variable-indexing".
Freedreno and nv30 are definitely broken. Other drivers seem to be alright.
---
src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 +
src/gallium/auxil
Do we really need this?
I think ideally we wouldn't really need any limit on this, as it is
already limited by the max number of the temps (though obviously that
number is higher). d3d10 doesn't seem to have any such limit neither.
If some driver can't do it, I think it's not unreasonable to expect
This doesn't really do what the commit message claims - it just adds a
cap bit, not actual support for arb_cull_distance (which was already
there), so the log should be changed accordingly.
Apart from what was already mentioned (that is, the cap bit isn't used
by st/mesa which instead mistakenly us
This is the code for setting the vs constbuf (in nv30_draw.c):
void *map = nv04_resource(nv30->vertprog.constbuf)->data;
debug_printf("map: %p, nr: %d\n", map, nv30->vertprog.constbuf_nr);
draw_set_mapped_constant_buffer(draw, PIPE_SHADER_VERTEX, 0,
The only thing I can think of is an illegal setup of the constant
buffer, because the index was not verified before for direct accesses,
which made this work before even for "illegal" sizes.
This is still not verified but buffers which get rounded down to size
zero are now definitely no longer work
On 05/25/2015 10:33 AM, Ilia Mirkin wrote:
On Mon, May 25, 2015 at 12:20 PM, Brian Paul wrote:
---
docs/devinfo.html | 104 --
1 file changed, 102 insertions(+), 2 deletions(-)
diff --git a/docs/devinfo.html b/docs/devinfo.html
index c7e41
Cc: "10.6"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90629
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index ead7
On Mon, May 25, 2015 at 7:01 AM, Brian Paul wrote:
> On 05/23/2015 01:48 PM, Jason Ekstrand wrote:
>>
>> Module: Mesa
>> Branch: master
>> Commit: 58aed1031d40e62c9f41f7c512b3165dd5913d1e
>> URL:
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D5
On Mon, May 25, 2015 at 12:20 PM, Brian Paul wrote:
> ---
> docs/devinfo.html | 104
> --
> 1 file changed, 102 insertions(+), 2 deletions(-)
>
> diff --git a/docs/devinfo.html b/docs/devinfo.html
> index c7e4171..a6fb76b 100644
> --- a/docs/de
This hasn't been updated in a long time and from recent discussion on
the mailing list, it's not always clear what's expected. Hopefully,
this will help a bit.
---
docs/devinfo.html | 155 ++
1 file changed, 86 insertions(+), 69 deletions(-)
di
Move "Adding Extensions" to the end. Add a simple table of contents
at the top.
---
docs/devinfo.html | 110 ++
1 file changed, 61 insertions(+), 49 deletions(-)
diff --git a/docs/devinfo.html b/docs/devinfo.html
index 8d20eea..c7e4171 100644
-
---
docs/devinfo.html | 104 --
1 file changed, 102 insertions(+), 2 deletions(-)
diff --git a/docs/devinfo.html b/docs/devinfo.html
index c7e4171..a6fb76b 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -124,13 +124,113 @@ src/mesa/st
On Tue, Mar 24, 2015 at 1:41 AM, Tapani Pälli wrote:
>
>
> On 03/23/2015 02:41 PM, Ilia Mirkin wrote:
>>
>> On Mon, Mar 23, 2015 at 8:06 AM, Tapani Pälli
>> wrote:
>>>
>>>
>>>
>>> On 03/23/2015 01:43 PM, Ilia Mirkin wrote:
On Mon, Mar 23, 2015 at 3:20 AM, Tapani Pälli
wrote:
Sure.
On 05/25/2015 05:14 PM, Tobias Klausmann wrote:
Can you push this with your newly won commit access? Makes up a nice
trial ;-)
Am 25.05.2015 um 16:49 schrieb Samuel Pitoiset:
yeah, very important thing to do *before* starting to write a new
extension. ;)
Reviewed-by: Samuel Pitoiset
Can you push this with your newly won commit access? Makes up a nice
trial ;-)
Am 25.05.2015 um 16:49 schrieb Samuel Pitoiset:
yeah, very important thing to do *before* starting to write a new
extension. ;)
Reviewed-by: Samuel Pitoiset
On 05/25/2015 03:57 PM, Tobias Klausmann wrote:
Signed
---
src/mesa/main/textureview.c | 83 -
src/mesa/main/textureview.h | 5 +--
2 files changed, 55 insertions(+), 33 deletions(-)
diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c
index a1cbec5..6b0aed4 100644
--- a/src/mesa/main/tex
---
src/mesa/main/copyimage.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c
index 789f9a6..e8732c6 100644
--- a/src/mesa/main/copyimage.c
+++ b/src/mesa/main/copyimage.c
@@ -40,6 +40,19 @@ enum mesa_block_class {
---
src/mesa/main/textureview.c | 12 ++--
src/mesa/main/textureview.h | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/textureview.c b/src/mesa/main/textureview.c
index cd87a27..a1cbec5 100644
--- a/src/mesa/main/textureview.c
+++ b/src/mesa/main/tex
In case the glproto.h file isn't up to date, we provide the #define
for X_GLXCreateContextAttribsARB.
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/glx/xlib/glx_api.c
b/src/gallium/state_trac
---
src/mesa/main/glformats.c | 2 +-
src/mesa/main/glformats.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 8ced579..6a77c91 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glformats.c
@@ -1200,7 +120
---
src/mesa/main/copyimage.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c
index fd22f28..789f9a6 100644
--- a/src/mesa/main/copyimage.c
+++ b/src/mesa/main/copyimage.c
@@ -46,8 +46,6 @@ prepare_target(s
yeah, very important thing to do *before* starting to write a new
extension. ;)
Reviewed-by: Samuel Pitoiset
On 05/25/2015 03:57 PM, Tobias Klausmann wrote:
Signed-off-by: Tobias Klausmann
---
I'm already getting emails wanting me to do this, so just mark it,
wont change anything really
Spotted by inspection. Untested (no piglit test).
---
src/mesa/main/attrib.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c
index 365a79d..53626e3 100644
--- a/src/mesa/main/attrib.c
+++ b/src/mesa/main/attrib.c
@@ -1091,6 +1091,11 @@ _mes
If the glPushAttrib() mask value was zero we didn't actually push
anything onto the attribute stack. A subsequent glPopAttrib() call
would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute
in that case to prevent the error.
Mesa now matches nvidia's behavior.
---
src/mesa/main/att
If the incoming func matches the current state it must be a legal
value so we can do this before the switch statement.
---
src/mesa/main/depth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/depth.c b/src/mesa/main/depth.c
index 29851ec..bb4591c 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=90612
--- Comment #6 from Samuel Pitoiset ---
That's a bit strange...
Anyways, thank you guys!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=90612
--- Comment #5 from Daniel Stone ---
That's correct, yeah.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://l
https://bugs.freedesktop.org/show_bug.cgi?id=90600
--- Comment #9 from Brian Paul ---
(In reply to Vinson Lee from comment #6)
> cf718cc964f86dc49c1fc9ed5e39aa5bd87ad931 is the first bad commit
> commit cf718cc964f86dc49c1fc9ed5e39aa5bd87ad931
> Author: Dylan Baker
> Date: Wed Nov 19 13:36:35
https://bugs.freedesktop.org/show_bug.cgi?id=90612
--- Comment #4 from Samuel Pitoiset ---
Mmmh.. This means I already have commit access to mesa repository?
Btw, I never tried to push...
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugs.freedesktop.org/show_bug.cgi?id=90147
--- Comment #13 from Brian Paul ---
Looks like the patch was commited as 31cd2d75dc3844e40143f649fe383de17c152a13
Bug is resolved as closed so I presume that's it. Re-open if not.
--
You are receiving this mail because:
You are the QA Contact
https://bugs.freedesktop.org/show_bug.cgi?id=90612
Daniel Stone changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=90612
--- Comment #2 from Brian Paul ---
Sounds good to me.
Bug is already assigned to fd.o admins.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
mesa-dev mailing list
mes
On 05/23/2015 01:48 PM, Jason Ekstrand wrote:
Module: Mesa
Branch: master
Commit: 58aed1031d40e62c9f41f7c512b3165dd5913d1e
URL:
https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D58aed1031d40e62c9f41f7c512b3165dd5913d1e&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM
Signed-off-by: Tobias Klausmann
---
I'm already getting emails wanting me to do this, so just mark it,
wont change anything really
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 44a824b..8e1c8cd 100644
--- a/docs/GL3.txt
+++ b/
Ignoring the compiler for a moment, I think this would probably break
my varying linking (where I match up VS out and FS in).. (and I
wouldn't be surprised if somewhere between tgsi_to_nir and my
compiler, it also caused breakage)
Unless you have a setup where you can test/fix all the drivers, I
Oh, I meant I would have just pushed something like this :)
- Chris
On Mon, May 25, 2015 at 8:26 PM, Iago Toral wrote:
> On Mon, 2015-05-25 at 20:15 +1200, Chris Forbes wrote:
>> Hardly needed, but:
>
> I know, I should've sent this patch when we started working on this... I
> got some comments
On Thu, May 21, 2015 at 12:41:03PM -0400, Connor Abbott wrote:
> I'm not so sure about where to put the helper currently in nir.c... on
> the one hand, it's pretty specific to this pass, but on the other hand
> it needs to do some very fiddly low-level things to the control flow
> which is why it n
No, the function is only used for linking ES->GS and it will be used
for linking tessellation shaders. The OpenGL core profile is the only
user of those shaders.
Marek
On Mon, May 25, 2015 at 5:35 AM, Michel Dänzer wrote:
> On 24.05.2015 18:52, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> Thes
On Mon, 2015-05-25 at 20:15 +1200, Chris Forbes wrote:
> Hardly needed, but:
I know, I should've sent this patch when we started working on this... I
got some comments asking why this is marked as not started if there are
patches in the mailing list, so I guess this will help make the current
stat
Hardly needed, but:
Reviewed-by: Chris Forbes
On Mon, May 25, 2015 at 7:41 PM, Iago Toral Quiroga wrote:
> ---
> docs/GL3.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/GL3.txt b/docs/GL3.txt
> index 9d56ee5..44a824b 100644
> --- a/docs/GL3.txt
> +++ b/do
Reviewed-by: Chris Forbes
On Mon, May 25, 2015 at 7:38 PM, Kenneth Graunke wrote:
> BRW_NEW_NUM_SAMPLES is sufficient.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/driv
---
docs/GL3.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 9d56ee5..44a824b 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -164,7 +164,7 @@ GL 4.3, GLSL 4.30:
GL_ARB_program_interface_query DONE (all drivers)
BRW_NEW_NUM_SAMPLES is sufficient.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/gen8_ps_state.c
b/src/mesa/drivers/dri/i965/gen8_ps_state.c
index 85ad3b6..6b9489b 10
74 matches
Mail list logo
