Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

2015-04-26 Thread Pekka Paalanen
On Thu, 16 Apr 2015 21:06:27 +0100 Daniel Stone wrote: > Hi, > > On 9 April 2015 at 17:20, Kristian Høgsberg wrote: > > On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov > > wrote: > >> Hi all, > >> > >> Can we get a pair of eyes on this patch please ? > > > > Reviewed-by: Kristian Høgsberg > >

Re: [Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

2015-04-26 Thread Pali Rohár
On Thursday 23 April 2015 23:04:22 Jose Fonseca wrote: > On 23/04/15 18:46, Pali Rohár wrote: > > On Monday 13 April 2015 22:35:03 Pali Rohár wrote: > >> On Monday 13 April 2015 22:32:10 Brian Paul wrote: > >>> On 04/13/2015 01:49 PM, Pali Rohár wrote: > On Monday 13 April 2015 21:26:32 Pali R

[Mesa-dev] GLSL versions that don't match GL versions

2015-04-26 Thread Ilia Mirkin
Hello, Right now a driver has to be very careful about the GLSL version it exposes, since it's computed separately from the GL version. The main/version.c:compute_version code uses the consts->GLSLVersion as an input, would there be any downside to having it also fix up the GLSL version as well? F

[Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-26 Thread Marek Olšák
From: Marek Olšák v2: - move interop.cpp to clover/api - change intptr_t to void* in the interface - add a virtual function fence() to simplify some code --- src/gallium/include/state_tracker/opencl_interop.h | 42 +++ src/gallium/state_trackers/clover/Makefile.sources | 1 +

Re: [Mesa-dev] [PATCH 09/10] gallium, clover: add OpenCL interoperability support for CL events

2015-04-26 Thread Marek Olšák
On Tue, Apr 21, 2015 at 3:50 PM, Francisco Jerez wrote: > Marek Olšák writes: > >> From: Marek Olšák >> > Hi Marek, looks mostly OK to me, a few nits inline, > >> --- >> src/gallium/include/state_tracker/opencl_interop.h | 42 ++ >> src/gallium/state_trackers/clover/Makefile.sources

Re: [Mesa-dev] [PATCH v3 07/10] nvc0: define driver-specific query groups

2015-04-26 Thread Martin Peres
On 27/04/2015 01:18, Martin Peres wrote: On 02/04/2015 21:41, Samuel Pitoiset wrote: This patch defines "Driver statistics" and "MP counters" groups, but only the latter will be exposed through GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/n

Re: [Mesa-dev] [PATCH v3 07/10] nvc0: define driver-specific query groups

2015-04-26 Thread Martin Peres
On 02/04/2015 21:41, Samuel Pitoiset wrote: This patch defines "Driver statistics" and "MP counters" groups, but only the latter will be exposed through GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 67 +

Re: [Mesa-dev] [PATCH v3 06/10] st/mesa: implement GL_AMD_performance_monitor

2015-04-26 Thread Martin Peres
On 02/04/2015 21:41, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. v3: - only enable this extension when the underlying driver expose GPU counters - get rid of the ring buffer of queries v2 (Samuel Pitoiset): - improve Gallium

Re: [Mesa-dev] [PATCH v3 05/10] gallium: make pipe_context::begin_query return a boolean

2015-04-26 Thread Martin Peres
On 02/04/2015 21:41, Samuel Pitoiset wrote: GL_AMD_performance_monitor must return an error when a monitoring session cannot be started. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Martin Peres --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/g

Re: [Mesa-dev] [PATCH 1/2] util/macros: Move DIV_ROUND_UP to util/macros.h

2015-04-26 Thread Axel Davy
On 26/04/2015 23:23, Axel Davy wrote : Move DIV_ROUND_UP to a shared location accessible everywhere Signed-off-by: Axel Davy --- I want to use DIV_ROUND_UP in a galliumm nine patch src/gallium/auxiliary/util/u_math.h | 1 - src/gallium/drivers/svga/include/svga3d_surfacedef

[Mesa-dev] [PATCH 1/2] util/macros: Move DIV_ROUND_UP to util/macros.h

2015-04-26 Thread Axel Davy
Move DIV_ROUND_UP to a shared location accessible everywhere Signed-off-by: Axel Davy --- I want to use DIV_ROUND_UP in a galliumm nine patch src/gallium/auxiliary/util/u_math.h | 1 - src/gallium/drivers/svga/include/svga3d_surfacedefs.h | 3 +-- src/mesa/main/macros.h

[Mesa-dev] [PATCH 2/2] gallium/svga: Remove useless ARRAY_SIZE declaration

2015-04-26 Thread Axel Davy
This is already declared in util/macros.h Signed-off-by: Axel Davy --- src/gallium/drivers/svga/include/svga3d_surfacedefs.h | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/svga/include/svga3d_surfacedefs.h b/src/gallium/drivers/svga/include/svga3d_surfacedefs.h index

Re: [Mesa-dev] [PATCH v3 04/10] gallium: replace pipe_driver_query_info::max_value by a union

2015-04-26 Thread Martin Peres
On 02/04/2015 21:41, Samuel Pitoiset wrote: This allows queries to return different numeric types. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Martin Peres --- src/gallium/auxiliary/hud/hud_driver_query.c| 3 ++- src/gallium/drivers/freedreno/freedreno_query.c

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-04-26 Thread Marek Olšák
I thought Heaven only used 3.2 Core. Weird. Marek On Sun, Apr 26, 2015 at 10:57 PM, Ilia Mirkin wrote: > With force_glsl_version=150, I get: > > heaven_x64: main/ff_fragment_shader.cpp:532: ir_rvalue* > get_gl_Color(texenv_fragment_program*): Assertion `var' failed. > > Might be because it'll en

Re: [Mesa-dev] [PATCH v3 02/10] gallium: add new fields to pipe_driver_query_info

2015-04-26 Thread Martin Peres
On 02/04/2015 21:41, Samuel Pitoiset wrote: According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. v3: fix incorrect query

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-04-26 Thread Ilia Mirkin
With force_glsl_version=150, I get: heaven_x64: main/ff_fragment_shader.cpp:532: ir_rvalue* get_gl_Color(texenv_fragment_program*): Assertion `var' failed. Might be because it'll end up affecting compat context as well? On Sun, Apr 26, 2015 at 4:48 PM, Marek Olšák wrote: > There are comments at

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-04-26 Thread Marek Olšák
There are comments at the beginning of the file explaining some of the workarounds. I think some of them predate Heaven 4.0 and might not be needed for 4.0. How about setting version 150? Marek On Sun, Apr 26, 2015 at 9:38 PM, Ilia Mirkin wrote: > Brian, Marek, > > We now have a new fun situa

[Mesa-dev] [PATCH 11/16 v2] st/nine: Fix behaviour of D3DUSAGE_QUERY_POSTPIXELSHADER_BLENDING

2015-04-26 Thread Axel Davy
From: Xavier Bouchoux Ignore D3DUSAGE_QUERY_POSTPIXELSHADER_BLENDING when D3DUSAGE_RENDERTARGET is not specified. This behaviour matches windows drivers. Reviewed-by: Axel Davy Signed-off-by: Xavier Bouchoux --- v2: fix commit message src/gallium/state_trackers/nine/adapter9.c | 3 ++- 1 fil

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-04-26 Thread Ilia Mirkin
Brian, Marek, We now have a new fun situation relating to this, perhaps you have thoughts on how to resolve this. Unigine Heaven 4.0 has, in the drirc, has However some shaders in Heaven have #version 150 (the ones that do tess, at least), which in turn causes issues with the new se

Re: [Mesa-dev] [PATCH] st/mesa: update stencil surface if it comes from texture

2015-04-26 Thread Ilia Mirkin
On Sat, Apr 25, 2015 at 6:23 AM, Dave Airlie wrote: > On 25 April 2015 at 09:18, Ilia Mirkin wrote: >> Now that ARB_texture_stencil8 is supported, this might happen. > > Seems logical, would be nice to have a piglit for it, > > Reviewed-by: Dave Airlie TBH, I'm not 100% sure how this condition

Re: [Mesa-dev] [PATCH 08/16 v2] st/nine: Change x86 FPU Control word on device creation

2015-04-26 Thread Roland Scheidegger
Am 26.04.2015 um 18:36 schrieb Ilia Mirkin: > On Sun, Apr 26, 2015 at 12:27 PM, Axel Davy wrote: >> From: Tiziano Bacocco >> >> As on wined3d and windows, when D3DCREATE_FPU_PRESERVE is not >> specified, change the fpu control word to all exceptions masked, >> single precision, round to nearest.

Re: [Mesa-dev] [PATCH 08/16 v2] st/nine: Change x86 FPU Control word on device creation

2015-04-26 Thread Ilia Mirkin
On Sun, Apr 26, 2015 at 12:27 PM, Axel Davy wrote: > From: Tiziano Bacocco > > As on wined3d and windows, when D3DCREATE_FPU_PRESERVE is not > specified, change the fpu control word to all exceptions masked, > single precision, round to nearest. > > Signed-off-by: Axel Davy > Signed-off-by: Tizi

[Mesa-dev] [PATCH 08/16 v2] st/nine: Change x86 FPU Control word on device creation

2015-04-26 Thread Axel Davy
From: Tiziano Bacocco As on wined3d and windows, when D3DCREATE_FPU_PRESERVE is not specified, change the fpu control word to all exceptions masked, single precision, round to nearest. Signed-off-by: Axel Davy Signed-off-by: Tiziano Bacocco --- src/gallium/state_trackers/nine/device9.c | 31 +

Re: [Mesa-dev] [PATCH 12/16] st/nine: Fix computation of const_used_size

2015-04-26 Thread Ilia Mirkin
On Sun, Apr 26, 2015 at 5:14 AM, Axel Davy wrote: > On 24/04/2015 23:40, Ilia Mirkin wrote : >> >> On Fri, Apr 24, 2015 at 4:09 PM, Axel Davy wrote: >>> >>> From: Xavier Bouchoux >>> >>> Was sometimes too large for PS. >>> >>> Reviewed-by: Axel Davy >>> Signed-off-by: Xavier Bouchoux >>> --- >

[Mesa-dev] [Bug 85203] [DRI2][RadeonSI] Pageflip completion event has impossible msc.

2015-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85203 --- Comment #10 from Clément Guérin --- Same problem here. It happens as far as I remember using my HD 7950 since last summer. I ran GNOME 3.12 to 3.16 on Arch Linux the whole time. The screen glitches for a frame and I can find the error in the

[Mesa-dev] [Bug 85203] [DRI2][RadeonSI] Pageflip completion event has impossible msc.

2015-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85203 Clément Guérin changed: What|Removed |Added CC||geecko@free.fr -- You are receivin

Re: [Mesa-dev] [PATCH 16/16] st/nine: Rework texture data allocation

2015-04-26 Thread Ilia Mirkin
On Sun, Apr 26, 2015 at 4:26 AM, Axel Davy wrote: > Le 25/04/2015 00:21, Ilia Mirkin a écrit : >> >> On Fri, Apr 24, 2015 at 6:13 PM, Axel Davy wrote: >>> >>> Le 25/04/2015 00:02, Ilia Mirkin a écrit : I'm having trouble understanding what you're changing here... perhaps a bet

Re: [Mesa-dev] [PATCH] glsl: properly setting var->data.binding if explicit_binding is true

2015-04-26 Thread Alejandro Piñeiro
On 26/04/15 00:08, Timothy Arceri wrote: > On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: >> There was a typo on commit c0cd5b, doing it when explicit_binding >> was false. This prevented to use any binding point different to 0. >> --- >> >> Taking into account the explanation on the h

Re: [Mesa-dev] [PATCH 05/16] st/nine: Workaround barycentrics issue on some cards

2015-04-26 Thread Axel Davy
Le 24/04/2015 23:19, Ilia Mirkin a écrit : On Fri, Apr 24, 2015 at 4:09 PM, Axel Davy wrote: Might I suggest either describing the bug or the solution to the bug? e.g. boolean shift_viewport; Perhaps there's another different buggy barycentric problem which is solved in an entirely different w

Re: [Mesa-dev] [PATCH 12/16] st/nine: Fix computation of const_used_size

2015-04-26 Thread Axel Davy
On 24/04/2015 23:40, Ilia Mirkin wrote : On Fri, Apr 24, 2015 at 4:09 PM, Axel Davy wrote: From: Xavier Bouchoux Was sometimes too large for PS. Reviewed-by: Axel Davy Signed-off-by: Xavier Bouchoux --- src/gallium/state_trackers/nine/nine_shader.c | 8 +--- 1 file changed, 5 insert

Re: [Mesa-dev] [PATCH 09/16] st/nine: Fix D3DQUERYTYPE_TIMESTAMPFREQ query

2015-04-26 Thread Axel Davy
On 24/04/2015 23:26, Ilia Mirkin wrote : >From https://msdn.microsoft.com/en-us/library/windows/desktop/bb172594%28v=vs.85%29.aspx D3DQUERYTYPE_TIMESTAMPFREQ This query result is TRUE if the values from D3DQUERYTYPE_TIMESTAMP queries cannot be guaranteed to be continuous throughout the duration

Re: [Mesa-dev] [PATCH 16/16] st/nine: Rework texture data allocation

2015-04-26 Thread Axel Davy
Le 25/04/2015 00:21, Ilia Mirkin a écrit : On Fri, Apr 24, 2015 at 6:13 PM, Axel Davy wrote: Le 25/04/2015 00:02, Ilia Mirkin a écrit : I'm having trouble understanding what you're changing here... perhaps a better commit description could go a ways to clearing things up? Were you allocating

Re: [Mesa-dev] [PATCH 03/11] st/nine: Simplify Surface9 Managed resources implementation

2015-04-26 Thread Axel Davy
On 25/04/2015 22:53, Ilia Mirkin wrote : On Fri, Apr 24, 2015 at 4:11 PM, Axel Davy wrote: +if (damaged) { +box = *damaged; +box.z = This->layer; +box.depth = 1; +} else { +box.x = 0; +box.y = 0; +box.z = This->layer; +box.width =

Re: [Mesa-dev] [PATCH 1/4] freedreno/a3xx: add support for disabling depth clipping

2015-04-26 Thread Bruno Jimenez
On Sat, 2015-04-25 at 18:59 -0400, Ilia Mirkin wrote: > On Sat, Apr 25, 2015 at 6:57 PM, Bruno Jimenez > wrote: > > On Sat, 2015-04-25 at 15:00 -0400, Ilia Mirkin wrote: > > > Signed-off-by: Ilia Mirkin > > > --- > > > docs/relnotes/10.6.0.html | 7 --- > > > src/ga