On Thursday, February 26, 2015 06:14:17 PM Ben Widawsky wrote:
> Recomendation [sic] is to set this field to 1 always. Programming it to
> default
> value of 0, may have -ve impact on performance for MSAA WLs.
>
> Another don't suck bit which needs to get set.
>
> Totally untested.
>
> v2: v1 w
On Thursday, February 12, 2015 05:38:09 PM Carl Worth wrote:
> Across the board of the various generations, the intial few atoms in
> all of the atom lists are basically the same, (performing uploads for
> the various programs). The only difference is that prior to gen6
> there's an ff_gs upload in
Reviewed-by: Chris Forbes
On Fri, Feb 27, 2015 at 5:52 PM, Jason Ekstrand wrote:
> I'll admit that I don't know that portion of the code all that well, but it
> looks sensible to me.
>
> Reviewed-by: Jason Ekstrand
>
> On Thu, Feb 26, 2015 at 3:55 PM, Kenneth Graunke
> wrote:
>>
>> _mesa_choos
I'll admit that I don't know that portion of the code all that well, but it
looks sensible to me.
Reviewed-by: Jason Ekstrand
On Thu, Feb 26, 2015 at 3:55 PM, Kenneth Graunke
wrote:
> _mesa_choose_tex_format (texformat.c) tries I8_SNORM, L8_SNORM, and
> either L8A8_SNORM or A8L8_SNORM, none of
This adds SGPR count, VGPR count, shader size, LDS size, and scratch
usage to shader dumps.
---
src/gallium/drivers/radeonsi/si_shader.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/
> On Feb 26, 2015, at 5:06 PM, Tom Stellard wrote:
>
> v2:
> - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and
>CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE.
> - Only define cl_khr_fp64 if the extension is supported.
> - Remove trailing space from extension string.
> - Rena
On 27.02.2015 10:06, Tom Stellard wrote:
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
> b/src/gallium/drivers/radeonsi/si_pipe.c
> index 26182c2..c7a7622 100644
> --- a/src/ga
Recomendation [sic] is to set this field to 1 always. Programming it to default
value of 0, may have -ve impact on performance for MSAA WLs.
Another don't suck bit which needs to get set.
Totally untested.
v2: v1 was a mix of two patches. Since 0x7004 is masked, we only need to set it
once at in
---
src/gallium/drivers/radeonsi/si_pipe.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index 26182c2..c7a7622 100644
--- a/src/gallium/drivers/radeonsi/si_pipe.c
+++ b/src/gallium/driver
v2:
- Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and
CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE.
- Only define cl_khr_fp64 if the extension is supported.
- Remove trailing space from extension string.
- Rename device query function from cl_khr_fp64() to has_doubles().
-
This should be done by the frontend for devices that support this
extension.
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
i
Recomendation [sic] is to set this field to 1 always. Programming it to default
value of 0, may have -ve impact on performance for MSAA WLs.
Another don't suck bit which needs to get set.
Totally untested.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_misc_state.c | 9 ++
https://bugs.freedesktop.org/show_bug.cgi?id=89343
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 +++
> src/mesa/main/fbobject.c | 147
> ++---
> src/mesa/main/fbobject.h | 9 ++
> s
On Thu, Feb 26, 2015 at 10:09 AM, Marc Dietrich wrote:
> Am Mittwoch, 25. Februar 2015, 17:49:28 schrieb Sedat Dilek:
>> On Fri, Feb 20, 2015 at 1:45 PM, Sedat Dilek wrote:
>> > On Tue, Feb 17, 2015 at 1:55 PM, Sedat Dilek
> wrote:
>> >> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich wrote:
>>
On Thu, Feb 26, 2015 at 4:56 PM, Emil Velikov wrote:
> On 26/02/15 15:26, Marc Dietrich wrote:
>> Am Donnerstag, 26. Februar 2015, 14:44:25 schrieb Emil Velikov:
>>> Hi Marc
>>>
>>> On 17/02/15 09:40, Marc Dietrich wrote:
This adds clang/gcc visibility macro detection to configure and
ut
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++
> src/mesa/main/fbobject.c | 53
> +++---
> src/mesa/main/fbobject.h | 4 ++
> src
Reviewed-by: Laura Ekstrand
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +
> src/mesa/main/fbobject.c | 37
> +-
> src/mesa/main/fbobject.h
_mesa_choose_tex_format (texformat.c) tries I8_SNORM, L8_SNORM, and
either L8A8_SNORM or A8L8_SNORM, none of which are supported by our
driver. Failing that, it falls back to RGBX for luminance, and RGBA
intensity and luminance alpha. So, we need to use swizzle overrrides
to obtain the correct va
LGTM.
Reviewed-by: Laura Ekstrand
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++
> src/mesa/main/samplerobj.c | 26
> --
> src/mesa/main/sample
On Thu, Feb 26, 2015 at 03:42:53PM -0800, Ben Widawsky wrote:
> Keep this as a separate patch for review, but I will squash it with the
> previous
> patch before pushing.
>
> We don't support 16x MSAA yet, but I entered it in here while I was at the
> table.
>
> I'm having trouble getting throug
Keep this as a separate patch for review, but I will squash it with the previous
patch before pushing.
We don't support 16x MSAA yet, but I entered it in here while I was at the
table.
I'm having trouble getting through a piglit run on SKL at the moment, so I just
few a threw small tests at it:
From: Kristian Høgsberg
v2 by Ben:
Rebase with conflict resolution
Add the SKL scaling factors
Squashed in i965/skl: Dont zero surf[12]. The patch can't work properly without
that, so there's no point in a separate patch.
Signed-off-by: Kristian Høgsberg
Reviewed-by: Ben Widawsky
Signed-off-by
LGTM.
Reviewed-by: Laura Ekstrand
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> These entry points will be fleshed out when the GL_ARB_query_buffer_object
> extension gets implemented. In the meantime, return GL_INVALID_OPERATION as
> suggested by Ian.
>
> Signed-off-by: Martin Peres
On Feb 26, 2015 4:32 PM, "Emil Velikov" wrote:
>
> On 26/02/15 01:30, Brian Paul wrote:
> > Another clean-up series. Mostly trimming down on unneeded #includes.
> >
> > I tested DRI, non-DRI and MSVC builds of this series but it's possible
> > I've missed some configuration and broke something.
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++
> src/mesa/main/queryobj.c | 76
> +++---
> src/mesa/main/queryobj.h | 2 +
> src/
On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - use the transform feedback object lookup wrapper
>
> v3:
> - use the new name of _mesa_lookup_transform_feedback_object_err
>
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_acces
On 02/26/2015 08:25 AM, Neil Roberts wrote:
> Hi,
>
> While trying to make _mesa_meta_pbo_TexSubImage understand the image
> height packing property I got stuck trying to work out whether it should
> have any affect for 1D array textures. Intuitively to me it seems like
> it shouldn't have any eff
Looks good to me.
Reviewed-by: Laura Ekstrand
On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres
wrote:
> v2: Review from Laura Ekstrand
> - use the transform feedback object lookup wrapper
>
> Signed-off-by: Martin Peres
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++
> src/m
Both are
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_eu.c | 22 ++
src/mesa/drivers/dri/i965/brw_eu.h | 1 +
2 files changed, 23 insertions(+)
This one comes first. Whoops...
diff --git a/src/mesa/drivers/dri/i965/brw_eu.c
b/src/mesa/drivers/dri/i965/brw_eu.c
CMP.Z doesn't work on Gen4-5 because the boolean isn't guaranteed to be
0 or 0x - only the low bit is defined.
We can call emit_bool_to_cond_code to generate the condition in f0.0;
the last instruction will generate the flag value. We can patch it to
use f0.1, and negate the condition.
F
https://bugs.freedesktop.org/show_bug.cgi?id=89345
---
src/mesa/main/imports.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h
index c863154..7921000 100644
--- a/src/mesa/main/imports.h
+++ b/src/mesa/main/imports.h
@@ -37,6 +37,7 @@
#inc
https://bugs.freedesktop.org/show_bug.cgi?id=89345
--- Comment #1 from Brian Paul ---
I'll have to restore the #include Patch coming.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
m
https://bugs.freedesktop.org/show_bug.cgi?id=89345
Bug ID: 89345
Summary: imports.h:452:58: error: expected declaration
specifiers or '...' before 'va_list'
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
On Wed, Feb 25, 2015 at 3:58 PM, Laura Ekstrand wrote:
> This fixes a dEQP test failure. In the test,
> glCompressedTexSubImage2D was called with target = 0 and failed to throw
> INVALID ENUM. This failure was caused by _mesa_get_current_tex_object(ctx,
> target) being called before the target ch
On Thu, Feb 26, 2015 at 12:34:56PM -0700, Brian Paul wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89343
Reviewed-by: Tom Stellard
> ---
> src/gallium/drivers/r300/compiler/tests/radeon_compiler_optimize_tests.c | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/sr
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89342
---
include/c99_math.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/c99_math.h b/include/c99_math.h
index 0a359eb..35173c6 100644
--- a/include/c99_math.h
+++ b/include/c99_math.h
@@ -144,4 +144,17 @@ llrint
https://bugs.freedesktop.org/show_bug.cgi?id=89342
--- Comment #1 from Brian Paul ---
Hmm, I don't see that here. The patch is simple though. Will post for review.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89343
---
src/gallium/drivers/r300/compiler/tests/radeon_compiler_optimize_tests.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/src/gallium/drivers/r300/compiler/tests/radeon_compiler_optimize_tests.c
b/src/gallium/drivers/r300/compil
On 02/10/2015 06:34 PM, Ian Romanick wrote:
> This patch is
>
> Reviewed-by: Ian Romanick
>
> We'll have to see if this breaks any applications...
>
I have not merged this patch yet because a piglit test need to be
updated to avoid a regression. The piglit patch is here:
http://lists.freedesk
https://bugs.freedesktop.org/show_bug.cgi?id=89342
Bug ID: 89342
Summary: main/light.c:159:62: error: 'M_PI' undeclared (first
use in this function)
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Li
https://bugs.freedesktop.org/show_bug.cgi?id=89343
Bug ID: 89343
Summary: compiler/tests/radeon_compiler_optimize_tests.c:43:3:
error: implicit declaration of function ‘fprintf’
[-Werror=implicit-function-declaration]
Produc
On Wed, Feb 25, 2015 at 6:04 PM, Laura Ekstrand wrote:
>
> This fixes a dEQP test failure. In the test,
> glCopyTexSubImage2D was called with target = 0 and failed to throw
> INVALID ENUM. This failure was caused by _mesa_get_current_tex_object(ctx,
> target) being called before the target checki
On 26/02/15 17:48, Brian Paul wrote:
---
include/c99_math.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/c99_math.h b/include/c99_math.h
index 5d4f535..bec80e1 100644
--- a/include/c99_math.h
+++ b/include/c99_math.h
@@ -38,6 +38,12 @@
#include "c99_compat.h"
+/* This
On Mon, Feb 23, 2015 at 09:38:42AM -0800, Matt Turner wrote:
> On Sun, Feb 22, 2015 at 2:23 PM, Ben Widawsky wrote:
> > On Wed, Feb 11, 2015 at 02:54:51PM -0800, Matt Turner wrote:
> >> total instructions in shared programs: 5932832 -> 5932736 (-0.00%)
> >> instructions in affected programs: 8
On Thu, Feb 26, 2015 at 10:01 AM, Brian Paul wrote:
>> I guess my question is whether we need imports.h or whether we can
>> simply include stdlib.h, string.h, and friends directly?
>
>
> I guess I don't feel too strongly about it.
>
> Getting them from imports.h goes back to when we had MALLOC/FR
Reviewed-by: Brian Paul
On 02/26/2015 09:51 AM, Jose Fonseca wrote:
The main objective of this change is to enable Linux developers to use
more of C99 throughout Mesa, with confidence that the portions that need
to be built with MSVC -- and only those portions --, stay portable.
This is achiev
On 02/26/2015 09:51 AM, Jose Fonseca wrote:
This is to enable the code to build with -Werror=vla in the short term,
and enable the code to build with MSVC2013 soon after.
---
include/c99_alloca.h | 45
src/glsl/nir/nir_from_ssa.c |
On 02/26/2015 10:32 AM, Matt Turner wrote:
On Thu, Feb 26, 2015 at 7:34 AM, Brian Paul wrote:
On 02/25/2015 08:36 PM, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:30 PM, Brian Paul wrote:
Don't include stuff we don't need. Fix a few #includes elsewhere to
keep thing building.
---
src/m
On Thu, Feb 26, 2015 at 12:47 PM, Brian Paul wrote:
> We now use 'inline' everywhere in Mesa.
For the series:
Reviewed-by: Alex Deucher
> ---
> src/mesa/main/compiler.h | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
> index cf
---
src/mesa/drivers/dri/radeon/radeon_cmdbuf.h | 2 +-
src/mesa/drivers/dri/radeon/radeon_common.c | 4 ++--
src/mesa/drivers/dri/radeon/radeon_common_context.h | 6 +++---
src/mesa/drivers/dri/radeon/radeon_ioctl.h | 2 +-
src/mesa/drivers/dri/radeon/radeon_swtcl.c
---
src/mesa/drivers/dri/i915/i830_context.h | 2 +-
src/mesa/drivers/dri/i915/i830_texblend.c | 2 +-
src/mesa/drivers/dri/i915/i915_context.h | 2 +-
src/mesa/drivers/dri/i915/i915_program.h | 4 ++--
src/mesa/drivers/dri/i915/intel_batchbuffer.h | 14 +++---
---
src/mesa/drivers/dri/r200/r200_ioctl.h| 2 +-
src/mesa/drivers/dri/r200/r200_swtcl.c| 2 +-
src/mesa/drivers/dri/r200/r200_vertprog.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/r200/r200_ioctl.h
b/src/mesa/drivers/dri/r200/r200_ioctl.
---
src/mesa/state_tracker/st_cb_bufferobjects.h | 2 +-
src/mesa/state_tracker/st_cb_clear.c | 14 +++---
src/mesa/state_tracker/st_cb_fbo.h | 2 +-
src/mesa/state_tracker/st_cb_feedback.c | 2 +-
src/mesa/state_tracker/st_cb_flush.c | 2 +-
src/mesa/sta
---
src/mesa/drivers/dri/swrast/swrast.c | 2 +-
src/mesa/drivers/dri/swrast/swrast_priv.h | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/swrast/swrast.c
b/src/mesa/drivers/dri/swrast/swrast.c
index a2a6c84..b801476 100644
--- a/src/mesa
---
include/c99_math.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/c99_math.h b/include/c99_math.h
index 5d4f535..bec80e1 100644
--- a/include/c99_math.h
+++ b/include/c99_math.h
@@ -38,6 +38,12 @@
#include "c99_compat.h"
+/* This is to ensure that we get M_PI, etc. defi
We now use 'inline' everywhere in Mesa.
---
src/mesa/main/compiler.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index cf9a686..dd65d07 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -91,13 +91,6 @@ extern "
On Thu, Feb 26, 2015 at 7:34 AM, Brian Paul wrote:
> On 02/25/2015 08:36 PM, Matt Turner wrote:
>>
>> On Wed, Feb 25, 2015 at 5:30 PM, Brian Paul wrote:
>>>
>>> Don't include stuff we don't need. Fix a few #includes elsewhere to
>>> keep thing building.
>>> ---
>>> src/mesa/main/compiler.h
On 26/02/15 15:27, Emil Velikov wrote:
On 26/02/15 12:09, Jose Fonseca wrote:
MSVC 2008 (shipped with Windows SDK 7.0.7600) is the oldest we
need to support. At least on llvmpipe, gallium/auxiliary, and util
modules. For the remaining modules (particular all OpenGL specific
code) can be built
The main objective of this change is to enable Linux developers to use
more of C99 throughout Mesa, with confidence that the portions that need
to be built with MSVC -- and only those portions --, stay portable.
This is achieved by using the appropriate -Werror= options only on the
places they nee
This is to enable the code to build with -Werror=vla in the short term,
and enable the code to build with MSVC2013 soon after.
---
include/c99_alloca.h | 45
src/glsl/nir/nir_from_ssa.c | 19 +++
src/glsl/nir/nir_live_variab
Hi,
While trying to make _mesa_meta_pbo_TexSubImage understand the image
height packing property I got stuck trying to work out whether it should
have any affect for 1D array textures. Intuitively to me it seems like
it shouldn't have any effect because you have to use glTexImage2D to
specify the
On 26/02/15 15:26, Marc Dietrich wrote:
> Am Donnerstag, 26. Februar 2015, 14:44:25 schrieb Emil Velikov:
>> Hi Marc
>>
>> On 17/02/15 09:40, Marc Dietrich wrote:
>>> This adds clang/gcc visibility macro detection to configure and
>>> util/macros.h. This is can be used to conveniently add e.g. a "H
On 02/26/2015 08:32 AM, Emil Velikov wrote:
On 26/02/15 01:30, Brian Paul wrote:
Another clean-up series. Mostly trimming down on unneeded #includes.
I tested DRI, non-DRI and MSVC builds of this series but it's possible
I've missed some configuration and broke something. Fix-ups should be
si
On 26/02/15 15:39, Brian Paul wrote:
On 02/26/2015 05:07 AM, Jose Fonseca wrote:
On 26/02/15 09:19, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund
wrote:
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner
wrote:
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
Should b
On 02/26/2015 08:31 AM, Emil Velikov wrote:
On 26/02/15 15:26, Brian Paul wrote:
...
I just like consistency.
You're not the only one here :-)
As for the grep, can't you use '$' to match EOL: git grep "^enum foo$" ?
It's actually one less keystroke! :)
Last time I've tried it there were so
On 02/26/2015 05:07 AM, Jose Fonseca wrote:
On 26/02/15 09:19, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund
wrote:
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
Should be defined in math.h. If not, we can a
On 26/02/15 01:30, Brian Paul wrote:
> Another clean-up series. Mostly trimming down on unneeded #includes.
>
> I tested DRI, non-DRI and MSVC builds of this series but it's possible
> I've missed some configuration and broke something. Fix-ups should be
> simple though.
>
Hi Brian,
Did you go
On 02/25/2015 08:36 PM, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:30 PM, Brian Paul wrote:
Don't include stuff we don't need. Fix a few #includes elsewhere to
keep thing building.
---
src/mesa/main/compiler.h | 3 ---
src/mesa/main/cpuinfo.c | 2 +-
src/
On 26/02/15 12:09, Jose Fonseca wrote:
> MSVC 2008 (shipped with Windows SDK 7.0.7600) is the oldest we
> need to support. At least on llvmpipe, gallium/auxiliary, and util
> modules. For the remaining modules (particular all OpenGL specific
> code) can be built with MSVC 2013.
Does that mean tha
Am Donnerstag, 26. Februar 2015, 14:44:25 schrieb Emil Velikov:
> Hi Marc
>
> On 17/02/15 09:40, Marc Dietrich wrote:
> > This adds clang/gcc visibility macro detection to configure and
> > util/macros.h. This is can be used to conveniently add e.g. a "HIDDEN"
> > attribute to a function.
> I beli
On 02/26/2015 07:59 AM, Emil Velikov wrote:
On 26/02/15 00:06, Brian Paul wrote:
Just to keep things consistent.
---
src/gallium/include/pipe/p_defines.h | 66
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/src/gallium/include/pipe/p_defin
On 26/02/15 15:26, Brian Paul wrote:
...
> I just like consistency.
>
You're not the only one here :-)
> As for the grep, can't you use '$' to match EOL: git grep "^enum foo$" ?
> It's actually one less keystroke! :)
>
Last time I've tried it there were some declarations which had trailing
white
LGTM. Reviewed-by: Brian Paul
On 02/26/2015 05:09 AM, Jose Fonseca wrote:
MSVC 2008 (shipped with Windows SDK 7.0.7600) is the oldest we
need to support. At least on llvmpipe, gallium/auxiliary, and util
modules. For the remaining modules (particular all OpenGL specific
code) can be built wi
On 26/02/15 00:06, Brian Paul wrote:
> Just to keep things consistent.
> ---
> src/gallium/include/pipe/p_defines.h | 66
>
> 1 file changed, 36 insertions(+), 30 deletions(-)
>
> diff --git a/src/gallium/include/pipe/p_defines.h
> b/src/gallium/include/pipe
Hi Marc
On 17/02/15 09:40, Marc Dietrich wrote:
> This adds clang/gcc visibility macro detection to configure and util/macros.h.
> This is can be used to conveniently add e.g. a "HIDDEN" attribute to a
> function.
>
I believe this should be OK to go in regardless of the status of patch
2. There
On 03/02/15 17:51, Felix Janda wrote:
> Emil Velikov wrote:
>> On 3 February 2015 at 02:53, Emil Velikov wrote:
>>> Hi Felix,
>>>
>
> Thanks for the review.
>
>>> On 2 February 2015 at 19:04, Felix Janda wrote:
Previously PTHREAD_MUTEX_RECURSIVE_NP had been used on linux for
compatibi
On 26/02/15 13:42, Jose Fonseca wrote:
On 26/02/15 03:55, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:37 PM, Jona
On 26/02/15 03:55, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray wrote:
If it isn't going to
On 26/02/15 01:55, Jonathan Gray wrote:
> On Wed, Feb 25, 2015 at 10:43:39PM +, Emil Velikov wrote:
>> On 25 February 2015 at 22:19, Jonathan Gray wrote:
>>> On Wed, Feb 25, 2015 at 08:49:52PM +, Emil Velikov wrote:
On 24/02/15 22:48, Jonathan Gray wrote:
> On Tue, Feb 24, 2015 at
When rendering to an fbo, even though it may be acting as a winsys
frontbuffer or just generally, we never throttle. However, when rendering
to an fbo, there is no natural frame boundary. Conventionally we use
SwapBuffers and glFinish, but potential callers avoid often glFinish for
being too heavy
On 26/02/15 00:06, Brian Paul wrote:
Just to keep things consistent.
---
src/gallium/include/pipe/p_defines.h | 66
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
https://bugs.freedesktop.org/show_bug.cgi?id=89328
--- Comment #2 from Emil Velikov ---
(In reply to Samuel Iglesias from comment #1)
> Since commit 2b37bea010a9c, the format-handling code is auto-generated via
> python scripts and mako templates, so python is required.
> Also, Python is
> listed
On 26/02/2015 03:55, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote:
On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray wrote:
If it isn't going t
MSVC 2008 (shipped with Windows SDK 7.0.7600) is the oldest we
need to support. At least on llvmpipe, gallium/auxiliary, and util
modules. For the remaining modules (particular all OpenGL specific
code) can be built with MSVC 2013.
---
include/c99_compat.h| 11 +++---
include/c99
On 26/02/15 01:29, Brian Paul wrote:
We only need the M_LOG2E definition.
---
src/glsl/lower_instructions.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp
index 4779de0..845cfff 100644
--- a/src/glsl/lower
On 26/02/15 09:19, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund wrote:
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote:
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
Should be defined in math.h. If not, we can add them to c99_math.h
And FWIW, the MSDN pa
Right now the GLSL compiler eats precision qualifiers and detects basic
parsing errors but it does not anything with them beyond that. This
series adds:
1. Default precision values for the types specified in the spec
(patches 1-2)
2. Proper tracking of precision statements for each scope (patch
As the comment in precision_qualifier_allowed() says, they are only allowed
for float, integer and sampler types.
---
src/glsl/ast_to_hir.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index df129df..3941554 100644
--- a/src/glsl/ast_to_hir
We will need this later on when we implement proper support for precision
qualifiers in the drivers and also to do link time checks for uniforms as
indicated by the spec.
This patch also adds compile-time checks for variables without precision
information (currently, Mesa only checks that a defaul
Notice that the spec requires that a default precision has been set for every
type used by a shader that can use a precision qualifier and does not have a
predefined precision, however, at the moment, Mesa only checks this for floats
in the fragment shader. This is probably because the GLSL ES 1.0
The GLSL ES spec specifies default precision qualifiers for certain types,
so populate the symbol table with these.
Notice that the desktop GLSL spec also indicates defaults for some types
but this is not really useful since precision qualifiers are completely
ignored in desktop GLSL.
---
src/gls
These have scoping rules that match the ones defined for other things such
as variables, so we want them in the symbol table.
---
src/glsl/glsl_symbol_table.cpp | 24
src/glsl/glsl_symbol_table.h | 2 ++
2 files changed, 26 insertions(+)
diff --git a/src/glsl/glsl_symb
Currently, we only consider precision qualifiers at compile-time. This patch
adds precision information to ir_variable so we can also do link time checks.
Specifically, from the GLSL ES3 spec, 4.5.3 Precision Qualifiers:
"The same uniform declared in different shaders that are linked together
mus
Reviewed-by: Marek Olšák
Marek
On Thu, Feb 26, 2015 at 2:29 AM, Brian Paul wrote:
> It only needs typical stdio.h and stdlib.h functions.
> ---
> src/gallium/drivers/r300/compiler/radeon_compiler.h | 2 --
> src/gallium/drivers/r300/compiler/radeon_emulate_loops.c| 3 ++-
> src/gal
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund wrote:
> On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote:
>> On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
>>> Should be defined in math.h. If not, we can add them to c99_math.h
>>
>> And FWIW, the MSDN page [0] says that if you define _U
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote:
> On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
>> Should be defined in math.h. If not, we can add them to c99_math.h
>
> And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES
> before including math.h, these will be define
Am Mittwoch, 25. Februar 2015, 17:49:28 schrieb Sedat Dilek:
> On Fri, Feb 20, 2015 at 1:45 PM, Sedat Dilek wrote:
> > On Tue, Feb 17, 2015 at 1:55 PM, Sedat Dilek
wrote:
> >> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich wrote:
> >>> Patch 1 adds a check for the compilers visibility macro to
https://bugs.freedesktop.org/show_bug.cgi?id=89328
--- Comment #1 from Samuel Iglesias ---
Since commit 2b37bea010a9c, the format-handling code is auto-generated via
python scripts and mako templates, so python is required. Also, Python is
listed in the prerequisites for building Mesa in the docs
100 matches
Mail list logo
