https://bugs.freedesktop.org/show_bug.cgi?id=89328
Samuel Iglesias changed:
What|Removed |Added
CC||emil.l.veli...@gmail.com,
On Thu, 2015-02-26 at 18:45 +1100, Timothy Arceri wrote:
> Currently intrastage arrays are validated twice for interface blocks.
> ---
> src/glsl/linker.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
> index dafcbe0..956818
On Thu, 2015-02-26 at 18:45 +1100, Timothy Arceri wrote:
> V2: return true when var->type is unsized by max access is within valid range
That should be:
V2: return true when var->type is unsized but max access is within valid
range
Fixed in my local branch
>
__
Currently intrastage arrays are validated twice for interface blocks.
---
src/glsl/linker.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index dafcbe0..9568185 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -761,7
V2: return true when var->type is unsized by max access is within valid range
---
src/glsl/linker.cpp | 89 ++---
src/glsl/linker.h | 5 +++
2 files changed, 55 insertions(+), 39 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cp
Use common intrastage array validation for interface blocks.
This change also allows us to support interface blocks
that are arrays of arrays.
V2: Reinsert unsized array asserts in interstage_match()
---
src/glsl/link_interface_blocks.cpp | 74 +++---
1 file chang
On Thu, 2015-02-26 at 12:06 +1100, Timothy Arceri wrote:
> Mark Janes wrote
>
> > Timothy Arceri writes:
> >
> > > Use common intrastage array validation for interface blocks. This
> change also allows us to support interface blocks that are arrays of
> arrays.
> >
> > Please wrap thi
https://bugs.freedesktop.org/show_bug.cgi?id=89330
--- Comment #1 from Samuel Iglesias ---
We submitted a spec bug because it's not completely clear whether or not
invariant should be allowed in an 'in' or 'out' block in GLSL or
OES_shader_io_blocks extension specs. Once we have the answer, we w
On Wed, Feb 25, 2015 at 07:09:26PM -0800, Matt Turner wrote:
> On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote:
> > On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
> >> On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray wrote:
> >> > If it isn't going to be configure checks could so
On Wed, Feb 25, 2015 at 5:30 PM, Brian Paul wrote:
> Another clean-up series. Mostly trimming down on unneeded #includes.
>
> I tested DRI, non-DRI and MSVC builds of this series but it's possible I've
> missed some configuration and broke something. Fix-ups should be simple
> though.
Thanks Br
On Wed, Feb 25, 2015 at 5:30 PM, Brian Paul wrote:
> Don't include stuff we don't need. Fix a few #includes elsewhere to
> keep thing building.
> ---
> src/mesa/main/compiler.h | 3 ---
> src/mesa/main/cpuinfo.c | 2 +-
> src/mesa/main/imports.h
On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote:
> Should be defined in math.h. If not, we can add them to c99_math.h
And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES
before including math.h, these will be defined for you. Not sure what
versions of MSVC that applies to.
[
On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray wrote:
> On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
>> On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray wrote:
>> > If it isn't going to be configure checks could someone merge the
>> > original patch in this thread?
>>
>> I committed
On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
> On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray wrote:
> > If it isn't going to be configure checks could someone merge the
> > original patch in this thread?
>
> I committed
>
> commit 3492e88090d2d0c0bfbc934963b8772b45fc8880
> Autho
On Fri, Feb 20, 2015 at 1:45 PM, Sedat Dilek wrote:
> On Tue, Feb 17, 2015 at 1:55 PM, Sedat Dilek wrote:
>> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich wrote:
>>> Patch 1 adds a check for the compilers visibility macro to configure.ac.
>>> Patch 2 avoids redefined symbol errors in clang of
On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray wrote:
> If it isn't going to be configure checks could someone merge the
> original patch in this thread?
I committed
commit 3492e88090d2d0c0bfbc934963b8772b45fc8880
Author: Matt Turner
Date: Fri Feb 20 18:46:43 2015 -0800
gallium/util: Use
https://bugs.freedesktop.org/show_bug.cgi?id=89330
Bug ID: 89330
Summary: piglit glsl-1.50 invariant-qualifier-in-out-block-01
regression
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
This fixes a dEQP test failure. In the test,
glCopyTexSubImage2D was called with target = 0 and failed to throw
INVALID ENUM. This failure was caused by _mesa_get_current_tex_object(ctx,
target) being called before the target checking. To remedy this, target
checking was separated from the main e
It is really difficult to robustly create a 2D ARRAY texture
for a buffer object because this poses some miptree problems (as I discovered
while trying to fix Meta PBO uploads and downloads).
Therefore, we should stop advertising 2D ARRAY as an acceptable target for
this function.
---
src/mesa/mai
On Wed, Feb 25, 2015 at 10:43:39PM +, Emil Velikov wrote:
> On 25 February 2015 at 22:19, Jonathan Gray wrote:
> > On Wed, Feb 25, 2015 at 08:49:52PM +, Emil Velikov wrote:
> >> On 24/02/15 22:48, Jonathan Gray wrote:
> >> > On Tue, Feb 24, 2015 at 04:53:03PM +, Emil Velikov wrote:
> >
Ah, now that I looked at your other patch I see why you have image_height.
On Wed, Feb 25, 2015 at 5:33 PM, Laura Ekstrand
wrote:
> This was an unfortunate artifact of rebasing; I fixed the 1D array bug
> before figuring out a robust fix for the 2D array bug (7a49f2e). I think
> that you are ri
On Mon, Feb 09, 2015 at 07:22:35PM +, Jose Fonseca wrote:
> On 09/02/15 16:59, Jon TURNEY wrote:
> >On 06/02/2015 19:58, Matt Turner wrote:
> >>On Fri, Feb 6, 2015 at 3:38 AM, Jonathan Gray wrote:
> >>>OpenBSD has ffs in libc but does not have ffsll so use the compiler
> >>>builtin. PIPE_OS_B
This was an unfortunate artifact of rebasing; I fixed the 1D array bug
before figuring out a robust fix for the 2D array bug (7a49f2e). I think
that you are right, although I'm confused what you are doing with the
variable image_height that you added. It seems like you should be able to
get rid o
Not needed.
---
src/mesa/main/compiler.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index e644e23..cf9a686 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -47,12 +47,6 @@ extern "C" {
/**
- * Get standar
It only needs typical stdio.h and stdlib.h functions.
---
src/gallium/drivers/r300/compiler/radeon_compiler.h | 2 --
src/gallium/drivers/r300/compiler/radeon_emulate_loops.c| 3 ++-
src/gallium/drivers/r300/compiler/radeon_remove_constants.c | 1 +
src/gallium/drivers/r300/compiler/ra
Not needed.
---
src/mesa/main/compiler.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 9eecf5b..12c02b2 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -36,7 +36,6 @@
#include
#include
-#include
#include
---
src/glsl/linker.cpp | 1 +
src/mesa/main/compiler.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 3f5eac1..e11b6fa 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -64,6 +64,7 @@
* \author Ian Romanick
---
src/mesa/drivers/dri/common/xmlconfig.c | 1 +
src/mesa/main/compiler.h| 1 -
src/mesa/main/errors.c | 1 +
src/mesa/main/imports.c | 3 +--
src/mesa/program/program_parse.y| 2 ++
5 files changed, 5 insertions(+), 3 deletions(-)
diff -
Not needed.
---
src/mesa/main/compiler.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 694e0af..9eecf5b 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -40,7 +40,6 @@
#include
#include
#include
-#include
Not needed by anything in that header. Include math.h or c99_math.h
where needed instead.
---
src/mesa/drivers/dri/common/xmlconfig.c | 1 +
src/mesa/drivers/x11/xm_tri.c | 1 +
src/mesa/main/compiler.h| 1 -
src/mesa/main/imports.c | 1 +
4 files changed
Don't include stuff we don't need. Fix a few #includes elsewhere to
keep thing building.
---
src/mesa/main/compiler.h | 3 ---
src/mesa/main/cpuinfo.c | 2 +-
src/mesa/main/imports.h | 2 ++
src/mesa/program/prog_parameter_layout.c | 2 +-
4 files
We only need the M_LOG2E definition.
---
src/glsl/lower_instructions.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp
index 4779de0..845cfff 100644
--- a/src/glsl/lower_instructions.cpp
+++ b/src/glsl/lower_in
Another clean-up series. Mostly trimming down on unneeded #includes.
I tested DRI, non-DRI and MSVC builds of this series but it's possible
I've missed some configuration and broke something. Fix-ups should be
simple though.
-Brian
___
mesa-dev ma
Should be defined in math.h. If not, we can add them to c99_math.h
---
src/mesa/main/compiler.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 0884742..cf31ad1 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/co
https://bugs.freedesktop.org/show_bug.cgi?id=89328
Bug ID: 89328
Summary: python required to build Mesa release tarballs
Product: Mesa
Version: 10.5
Hardware: All
OS: OpenBSD
Status: NEW
Severity: normal
Mark Janes wrote
> Timothy Arceri writes:
>
> > Use common intrastage array validation for interface blocks. This change
> > also allows us to support interface blocks that are arrays of arrays.
>
> Please wrap this message to fit within 80 columns.
>
> > ---
> > src/glsl/link_inte
https://bugs.freedesktop.org/show_bug.cgi?id=89312
--- Comment #5 from Laura Ekstrand ---
Like 89311, the root cause was that target checking must take place prior to
calling _mesa_get_current_texture_object, and this necessitated splitting
target checking out of the main error-checking function
https://bugs.freedesktop.org/show_bug.cgi?id=89311
--- Comment #4 from Laura Ekstrand ---
I've sent out a patch to fix this just now. The root cause was that target
checking must take place prior to calling _mesa_get_current_texture_object, and
this necessitated splitting target checking out of
Just to keep things consistent.
---
src/gallium/include/pipe/p_defines.h | 66
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines.h
index 1a9d80e..a8ffe9c 100644
--- a/src/g
Note that PIPE_BIND_COMMAND_ARGS_BUFFER and PIPE_BIND_LINEAR were both
bit 21 before.
---
src/gallium/include/pipe/p_defines.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/gallium/include/pipe/p_defines.h
b/src/gallium/include/pipe/p_defines
---
src/gallium/auxiliary/util/u_debug.c | 33 +
src/gallium/auxiliary/util/u_debug.h | 3 +++
2 files changed, 36 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_debug.c
b/src/gallium/auxiliary/util/u_debug.c
index 731cdec..f54fc3a 100644
--- a/src/galli
This fixes a dEQP test failure. In the test,
glCompressedTexSubImage2D was called with target = 0 and failed to throw
INVALID ENUM. This failure was caused by _mesa_get_current_tex_object(ctx,
target) being called before the target checking. To remedy this, target
checking was made into its own f
https://bugs.freedesktop.org/show_bug.cgi?id=89311
Ian Romanick changed:
What|Removed |Added
CC||i...@freedesktop.org
Summary|[
https://bugs.freedesktop.org/show_bug.cgi?id=89312
Ian Romanick changed:
What|Removed |Added
CC||i...@freedesktop.org
--- Comment #4 from
2015-02-23 15:23 GMT-07:00 Bruno Jimenez :
> From my part, I'd prefer the word 'buffer', rather than 'búfer', but
> mostly as I tend to keep the technical words in English.
> Spanish Wikipedia has both words depending on where you look:
> 'Búfer de datos': https://es.wikipedia.org/wiki/B%C3%BAfer_d
On 01/08/2015 10:59 PM, Matt Turner wrote:
> + if ((then_rhs->is_one() || then_rhs->is_negative_one()) &&
> + (else_rhs->is_one() || else_rhs->is_negative_one())) {
> + assert(then_rhs->is_one() == else_rhs->is_negative_one());
> + assert(else_rhs->is_one() == then_rhs->is_negativ
On 25 February 2015 at 22:19, Jonathan Gray wrote:
> On Wed, Feb 25, 2015 at 08:49:52PM +, Emil Velikov wrote:
>> On 24/02/15 22:48, Jonathan Gray wrote:
>> > On Tue, Feb 24, 2015 at 04:53:03PM +, Emil Velikov wrote:
>> >> On 22 February 2015 at 08:19, Jonathan Gray wrote:
>> >>> The leng
Timothy Arceri writes:
> Use common intrastage array validation for interface blocks. This change also
> allows us to support interface blocks that are arrays of arrays.
Please wrap this message to fit within 80 columns.
> ---
> src/glsl/link_interface_blocks.cpp | 76
> ++---
On Wed, Feb 25, 2015 at 08:49:52PM +, Emil Velikov wrote:
> On 24/02/15 22:48, Jonathan Gray wrote:
> > On Tue, Feb 24, 2015 at 04:53:03PM +, Emil Velikov wrote:
> >> On 22 February 2015 at 08:19, Jonathan Gray wrote:
> >>> The length argument passed to sysctl was the size of the pointer
>
On 25 February 2015 at 00:43, Tom Stellard wrote:
> Configure arguments:
>
> ./configure --disable-dri3 --disable-xvmc --enable-opencl
> --with-gallium-drivers=r300,r600,radeonsi
> --with-egl-platforms=drm
>
> Build error:
>
I was thinking about it yesterday but could not r
On 24/02/15 22:48, Jonathan Gray wrote:
> On Tue, Feb 24, 2015 at 04:53:03PM +, Emil Velikov wrote:
>> On 22 February 2015 at 08:19, Jonathan Gray wrote:
>>> The length argument passed to sysctl was the size of the pointer
>>> not the type. The result of this is sysctl calls would fail on
>>>
On 02/25/2015 12:21 PM, Jose Fonseca wrote:
On 24/02/15 23:30, Brian Paul wrote:
---
src/mesa/main/imports.h | 8
src/mesa/main/light.c| 2 +-
src/mesa/math/m_matrix.c | 4 ++--
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/mesa/main/imports.h b/src/mesa/
https://bugs.freedesktop.org/show_bug.cgi?id=89311
Jason Ekstrand changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |la...@jlekstrand.net
https://bugs.freedesktop.org/show_bug.cgi?id=89312
Jason Ekstrand changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |la...@jlekstrand.net
Nobody is working on ARB_gpu_shader5 for radeonsi.
Marek
On Wed, Feb 25, 2015 at 6:41 PM, Ilia Mirkin wrote:
> On Wed, Feb 25, 2015 at 11:24 AM, Alexandre Demers
> wrote:
>> Hi everyone,
>>
>> I'd like to know if someone is working on Geometry shader instancing
>> for radeonsi or if there is
On 24/02/15 23:30, Brian Paul wrote:
---
src/mesa/main/imports.h | 8
src/mesa/main/light.c| 2 +-
src/mesa/math/m_matrix.c | 4 ++--
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h
index 356f0e1..d886427 100644
Reviewed-by: Jason Ekstrand
On Wed, Feb 25, 2015 at 8:02 AM, Neil Roberts wrote:
> A layered PBO image is now interpreted as a single tall 2D image so
> the z argument in _mesa_meta_bind_fbo_image is ignored. Therefore this
> was just redundantly rebinding the same image repeatedly.
> ---
> sr
On Wed, Feb 25, 2015 at 11:24 AM, Alexandre Demers
wrote:
> Hi everyone,
>
> I'd like to know if someone is working on Geometry shader instancing
> for radeonsi or if there is already a work in progress somewhere I
> would have missed. I might be interested in giving it a try and then
> on GL_ARB_
On 02/24/2015 04:32 AM, marius.pre...@intel.com wrote:
From: Marius Predut
For 32-bit builds, floating point operations use x86 FPU registers,
not SSE registers. If we're actually storing an integer in a float
variable, the value might get modified when written to memory. This
patch changes
Hi everyone,
I'd like to know if someone is working on Geometry shader instancing
for radeonsi or if there is already a work in progress somewhere I
would have missed. I might be interested in giving it a try and then
on GL_ARB_viewport_array.
Cheers.
Alexandre Demers
Now that a layered source PBO is interpreted as a single tall 2D image
it's quite easy to accept the image height packing option by just
creating an image that is tall enough to include the image padding.
This is tested by the texsubimage Piglit test with the array and pbo
arguments. Previously th
Sorry for the late review.
Can you explain what this patch does? The previous code was doing a blit
like this:
_mesa_meta_BlitFramebuffer(ctx, ctx->ReadBuffer, ctx->DrawBuffer,
0, z * height, width, (z + 1) * height,
xoffset,
A layered PBO image is now interpreted as a single tall 2D image so
the z argument in _mesa_meta_bind_fbo_image is ignored. Therefore this
was just redundantly rebinding the same image repeatedly.
---
src/mesa/drivers/common/meta_tex_subimage.c | 4
1 file changed, 4 deletions(-)
diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=89312
--- Comment #2 from Samuel Iglesias ---
After looking into it, I found that the test is expecting to receive a
GL_INVALID_ENUM error when calling glCopyTexSubImage2D() with target different
than GL_TEXTURE_2D and GL_TEXTURE_CUBE_MAP_*.
By lookin
https://bugs.freedesktop.org/show_bug.cgi?id=89311
--- Comment #2 from Samuel Iglesias ---
After looking into it, I found that the test is expecting to receive a
GL_INVALID_ENUM error when calling glCompressedTexSubImage2D() with target
different than GL_TEXTURE_2D and GL_TEXTURE_CUBE_MAP_*. The
https://bugs.freedesktop.org/show_bug.cgi?id=89322
--- Comment #1 from Martin Peres ---
Created attachment 113818
--> https://bugs.freedesktop.org/attachment.cgi?id=113818&action=edit
A simple way to reproduce the problem
--
You are receiving this mail because:
You are the QA Contact for the
https://bugs.freedesktop.org/show_bug.cgi?id=89322
Bug ID: 89322
Summary: ../../libtool: line 7916: func_munge_path_list:
command not found
Product: Mesa
Version: git
Hardware: Other
OS: All
Stat
On Wed, 2015-02-25 at 10:01 +0100, Iago Toral wrote:
> On Fri, 2015-02-06 at 15:03 +0100, Iago Toral Quiroga wrote:
> > Currently, we only consider precision qualifiers at compile-time. This patch
> > adds precision information to ir_variable so we can also do link time
> > checks.
> > Specificall
Ben Widawsky writes:
>> + if (layout_1d) {
>> + physical_qpitch = mt->align_h;
>> + /* When using the horizontal layout the qpitch is measured in pixels
>> */
>
> I think the docs words are a bit clearer:
> "Surface QPitch specifies the distance in pixels between array
> slices."
Ok
Ben Widawsky writes:
> Okay, I'm guilty of a bikeshed here, but doesn't this look cleaner if you just
> do two for loops? One for depth, and one for levels.
>
> something like...
> const unsigned depth = mt->physical_depth0;
> for (i = 0; i < depth; i++) {
> width = mt->physical_width0;
>
Ben Widawsky writes:
>> + if (mt->target == GL_TEXTURE_3D)
>> + depth = minify(depth, 1);
>> }
>> }
>
> assert(brw->gen >= 9)? (up to you, I'm very assert happy)
Yes, that seems like a good idea.
>>
>> @@ -263,7 +266,7 @@ brw_miptree_layout_texture_array(struct brw_context *
On Fri, 2015-02-06 at 15:03 +0100, Iago Toral Quiroga wrote:
> Currently, we only consider precision qualifiers at compile-time. This patch
> adds precision information to ir_variable so we can also do link time checks.
> Specifically, from the GLSL ES3 spec, 4.5.3 Precision Qualifiers:
>
> "The s
On Wednesday, February 18, 2015 10:55:32 AM Pohjolainen, Topi wrote:
> On Tue, Feb 17, 2015 at 05:39:33PM -0800, Kenneth Graunke wrote:
> > There's some debate about whether we should use Meta or BLORP,
> > but either should run circles around the BLT engine.
> >
> > In particular, this means that
On 02/24/2015 09:22 PM, Matt Turner wrote:
There were some bugs, and the code was really difficult to follow. We
would optimize
min(max(x, b), 1.0) into max(sat(x), b)
but not pay attention to the order of min/max and also do
max(min(x, b), 1.0) into max(sat(x), b)
Corrects four sha
On Tuesday 24 February 2015 12:22:18 Ian Romanick wrote:
> This patch is
>
> Reviewed-by: Ian Romanick
>
> Please also add the following to the commit message:
>
> Cc: "10.4 10.5"
>
> If you guys have the time, I'd also really appreciate a piglit test or
> two for this case.
>
OK, we are go
75 matches
Mail list logo
