Ben Widawsky <b...@bwidawsk.net> writes: >> + if (layout_1d) { >> + physical_qpitch = mt->align_h; >> + /* When using the horizontal layout the qpitch is measured in pixels >> */ > > I think the docs words are a bit clearer: > "Surface QPitch specifies the distance in pixels between array > slices."
Ok, yeah, I'll change it to that. >> + mt->qpitch = physical_qpitch * mt->total_width; > > talking to myself - this seems more complicated than it ought to be. Maybe it would be less confusing if I changed it to mt->align_h * mt->total_width? > This patch is a bit trickier than the previous, and I got lazy with fact > checking in bspec, but it lgtm: > Reviewed-by: Ben Widawsky <b...@bwidawsk.net> Thanks again for the reviews. Regards, - Neil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev