On 23/02/15 17:35, Jason Ekstrand wrote:
People do tend to use page numbers from what I've seen. Yes, it has
the potential to get out-of-sync but probably never by more than a
page or two. I don't thnk spec updates are all that substantial,
especially in older versions. You could also give a
Use common intrastage array validation for interface blocks. This change also
allows us to support interface blocks that are arrays of arrays.
---
src/glsl/link_interface_blocks.cpp | 76 ++
1 file changed, 35 insertions(+), 41 deletions(-)
diff --git a/src/gl
---
src/glsl/linker.cpp | 87 +
src/glsl/linker.h | 5 +++
2 files changed, 53 insertions(+), 39 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 3f5eac1..ff62e32 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker
Can somebody push this please?!
Thanks,
Tobias
On 12.02.2015 23:04, Jose Fonseca wrote:
LGTM.
On 12/02/15 17:31, Tobias Klausmann wrote:
The most common macros are defined there, no use to duplicate these
Clean up the already redefinded macros
Signed-off-by: Tobias Klausmann
---
src/galli
This patch avoids the unnecessary texture upload when glTexImage{1,2,3}D()
calls allocate a texture with pixels = null and we use
_mesa_meta_pbo_TexSubImage() path.
Texture upload is also avoided when glTexSubImage{1,2,3}D() calls
have pixels = null and use mesa_meta_pbo_TexSubImage() path.
We sh
This will be used by next patch in the series.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index
before calling _mesa_meta_pbo_TexSubImage(). This will be used in
later patches and will be required in Skylake to get the tile
resource mode of miptree before calling _mesa_meta_pbo_TexSubImage().
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_tex_image.c | 13 +++--
1 f
No functional changes in the patch. Just makes the code look cleaner.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 +++
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/sr
create_texture_for_pbo() is used by both _mesa_meta_pbo_GetTexSubImage()
and _mesa_meta_pbo_TexSubImage() functions with different PBO targets.
Use GL_STREAM_READ with GL_PIXEL_PACK_BUFFER and GL_STREAM_DRAW with
GL_PIXEL_UNPACK_BUFFER.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta
otherwise samples=0 passes the check, which is invalid.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_blit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/common/meta_blit.c
b/src/mesa/drivers/common/meta_blit.c
index bf893be..9498817 100
Jose Fonseca writes:
> On 23/02/15 16:12, Emil Velikov wrote:
>> On 23/02/15 07:05, Eric Anholt wrote:
>>> Matt Turner writes:
>>>
---
This series is attempting to make some progress towards moving u_math.h
to src/util.
>>>
>>> Hmm, looks like for other headers we've got include/c
On Mon, Feb 23, 2015 at 4:27 PM, Ian Romanick wrote:
> On 02/20/2015 10:56 AM, Ilia Mirkin wrote:
>> Doubles are always packed, but a single double will never cross a slot
>> boundary -- single slots can still be wasted in some situations.
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>>
>> Packing *al
Signed-off-by: Alex Henrie
---
Version 3 leaves "Gallium Nine" as "Gallium Nine", because it is a
proper name.
src/mesa/drivers/dri/common/xmlpool/ca.po | 52 ---
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/src/mesa/drivers/dri/common/xmlpool/ca.po
Looks like two things are needed.
1. replace INLINE with inline
2. #include math.h at the top of c99_copmat.h so that we get prototypes
for floorf(), etc. to prevent a bunch of warnings where floorf() is
called. This kind of feels wrong. Maybe there should be a c99_math.h
wrapper for math.h
From: Marek Olšák
- remove the last parameter of si_emit_rasterizer_prim_state
- remove the last unused parameter of si_emit_draw_registers
- use current_rast_prim in si_emit_draw_registers
---
src/gallium/drivers/radeonsi/si_state_draw.c | 15 ++-
1 file changed, 6 insertions(+), 9
From: Marek Olšák
---
src/mesa/state_tracker/st_program.c | 45 -
src/mesa/state_tracker/st_program.h | 4
2 files changed, 49 deletions(-)
diff --git a/src/mesa/state_tracker/st_program.c
b/src/mesa/state_tracker/st_program.c
index ec123fb..744543f 10
From: Marek Olšák
Mostly dead code or code that didn't do anything.
Computing gs_num_outputs at the end was also useless. It's already set
correctly.
---
src/mesa/state_tracker/st_program.c | 132
1 file changed, 30 insertions(+), 102 deletions(-)
diff --gi
From: Marek Olšák
---
src/mesa/main/uniforms.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c
index e471b87..4bb3dfb 100644
--- a/src/mesa/main/uniforms.c
+++ b/src/mesa/main/uniforms.c
@@ -1142,6 +1142,8 @@ _mesa_GetActiveUniformBlockiv
This broke the MSVC build for me. I'll try to sort it out...
-Brian
On 02/23/2015 11:50 AM, Matt Turner wrote:
Module: Mesa
Branch: master
Commit: 5a191f49ad084e728122fed83bd7511817e66831
URL:
https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3
On 02/22/2015 08:40 PM, Matt Turner wrote:
> ---
> I can't believe this is beneficial, especially since it came from the
> i915tex import.
My recollection is that memcpy does some weird optimizations (copying
from the end first) assuming the memory is mapped in a certain way. We
don't necessarily
On Sun, Feb 22, 2015 at 2:23 PM, Ben Widawsky wrote:
> On Wed, Feb 11, 2015 at 02:54:51PM -0800, Matt Turner wrote:
>> total instructions in shared programs: 5932832 -> 5932736 (-0.00%)
>> instructions in affected programs: 8184 -> 8088 (-1.17%)
>> helped:52
>>
On Skylake the qpitch value is uploaded as part of the surface state
so we don't need to add the extra rows that are done for other
generations. However for 3D textures it needs to be aligned to the
tile height and for depth/stencil textures it needs to be a multiple
of 8. Unlike previous generatio
On Sun, Feb 22, 2015 at 11:05 PM, Eric Anholt wrote:
> Matt Turner writes:
>
>> ---
>> This series is attempting to make some progress towards moving u_math.h
>> to src/util.
>
> Hmm, looks like for other headers we've got include/c99/whatever.h that
> includes the system version and fixes it up.
For series
Reviewed-by: Jose Fonseca
23/02/15 15:59, Brian Paul wrote:
Also, wrapping the array in #ifdef DEBUG / #endif doesn't seem necessary.
---
src/gallium/auxiliary/util/u_debug.c | 45 +---
1 file changed, 21 insertions(+), 24 deletions(-)
diff --gi
Reviewed-by: Jose Fonseca
On 23/02/15 15:39, Brian Paul wrote:
Bugzilla:
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D89260&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=L3FUFZqbsV2eYNm6
Thanks Brian, this fixes the build for me. You can have my
Tested-by: Kai Wasserbäch
for this patch.
Brian Paul wrote on 23.02.2015 16:39:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89260
> ---
> src/mesa/drivers/osmesa/Makefile.am | 2 ++
> 1 file changed, 2 insertions(+)
>
> d
On 23/02/15 07:05, Eric Anholt wrote:
> Matt Turner writes:
>
>> ---
>> This series is attempting to make some progress towards moving u_math.h
>> to src/util.
>
> Hmm, looks like for other headers we've got include/c99/whatever.h that
> includes the system version and fixes it up. I think it s
https://bugs.freedesktop.org/show_bug.cgi?id=89260
--- Comment #5 from Kai ---
(In reply to Brian Paul from comment #4)
> patch posted to mesa-dev for review.
I replied there, but for the record of this bug: the posted patch works for me.
--
You are receiving this mail because:
You are the QA
Also, wrapping the array in #ifdef DEBUG / #endif doesn't seem necessary.
---
src/gallium/auxiliary/util/u_debug.c | 45 +---
1 file changed, 21 insertions(+), 24 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_debug.c
b/src/gallium/auxiliary/util/u_debug.c
Add add missing PIPE_TRANSFER_PERSISTENT, PIPE_TRANSFER_COHERENT flags.
---
src/gallium/auxiliary/util/u_debug.c | 41
1 file changed, 13 insertions(+), 28 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_debug.c
b/src/gallium/auxiliary/util/u_debug.c
i
On 02/23/2015 01:31 AM, Martin Peres wrote:
Signed-off-by: Martin Peres
---
src/mesa/drivers/osmesa/Makefile.am | 2 ++
src/mesa/drivers/osmesa/SConscript | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/mesa/drivers/osmesa/Makefile.am
b/src/mesa/drivers/osmesa/Makefile.am
index
Oh right. I think the NVIDIA blob executes those steps conditionally
based on the upper bits not being 0x7ff (== infinity/nan). I should do
the same thing here. [FWIW I was able to test the nv50 code last night
and that one's a total fail for rcp/rsq... will need to port that over
to my nvc0 and de
https://bugs.freedesktop.org/show_bug.cgi?id=89260
--- Comment #4 from Brian Paul ---
patch posted to mesa-dev for review.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
mesa-dev maili
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89260
---
src/mesa/drivers/osmesa/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/osmesa/Makefile.am
b/src/mesa/drivers/osmesa/Makefile.am
index 589b5ee..60048cc 100644
--- a/src/mesa/drivers/osmesa/Makefile
On Mon, Feb 23, 2015 at 12:51 AM, Martin Peres wrote:
> On 20/02/15 20:38, Laura Ekstrand wrote:
>
>> Please provide a page number and a section title in your spec comment.
>>
>
> I'm not very fond of giving the page number as Khronos updates the pdf
> quite often
> and the page number may change
Hi Lucas,
On 23 February 2015 at 14:08, Lucas Stach wrote:
> As this is a really trivial one I'm going to push this by Wednesday this
> week if nobody voices any objections.
>
> Regards,
> Lucas
>
> Am Mittwoch, den 18.02.2015, 12:01 +0100 schrieb Lucas Stach:
>> From: Philipp Zabel
>>
>> Since
v2: review from Laura Ekstrand
- use the refactored code to lookup the objects
- improve some error messages
- factor out the gl method name computation
- better handle the spec differences between the DSA and non-DSA cases
- quote the spec a little more
v3: review from Laura Ekstrand
- use the ne
v2: Review from Laura Ekstrand
- give more helpful error messages
- factor the lookup code for the xfb and objBuf
- replace some already-existing tabs with spaces
- add comments to explain the cases where xfb == 0 or buffer == 0
- fix the condition for binding the transform buffer or not
v3: Revie
https://bugs.freedesktop.org/show_bug.cgi?id=89260
Kai changed:
What|Removed |Added
Keywords||regression
CC|
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67676
Reviewed-by: Chad Versace
---
docs/specs/EGL_MESA_transparent_alpha.txt | 120 ++
1 file changed, 120 insertions(+)
create mode 100644 docs/specs/EGL_MESA_transparent_alpha.txt
diff --git a/docs/specs/EGL_M
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67676
---
include/EGL/eglmesaext.h| 5 +
src/egl/drivers/dri2/platform_wayland.c | 9 +++--
src/egl/drivers/dri2/platform_x11.c | 22 +-
src/egl/main/eglapi.c | 13 +++
On 02/23/2015 02:37 PM, Martin Peres wrote:
> Looks better :) Indeed, this is only for OpenGLES 3.
>
> Reviewed-by: Martin Peres
>
Thanks Martin! The patch was already pushed by Samuel Iglesias.
cheers,
Eduardo
___
mesa-dev mailing list
mesa-dev@list
As this is a really trivial one I'm going to push this by Wednesday this
week if nobody voices any objections.
Regards,
Lucas
Am Mittwoch, den 18.02.2015, 12:01 +0100 schrieb Lucas Stach:
> From: Philipp Zabel
>
> Since imx-drm has graduated from staging it seems to be a good idea to
> recogniz
Looks better :) Indeed, this is only for OpenGLES 3.
Reviewed-by: Martin Peres
On 23/02/15 14:03, Eduardo Lima Mitev wrote:
This corrects a trivial error introduced in commit
19252fee46b835cb4f6b1cce18d7737d62b64a2e. That patch was merged recently
and omits one condition (that 'samples' is gre
Does this give correct results for special floats (0, infs)?
We tried to improve (for single floats) x86 rcp in llvmpipe with
newton-raphson, but unfortunately not being able to give correct results
for these two cases (without even more additional code) meant it got all
disabled in the end (you ca
Series looks good to me. It's a nice cleanup on its own right.
Reviewed-by: Jose Fonseca
Jose
On 23/02/15 04:31, Matt Turner wrote:
---
This series is attempting to make some progress towards moving u_math.h
to src/util.
include/c99_compat.h| 143 ++
Like the previous patch, I wonder what I was thinking.
Anyway, should be good now. I'll send the new versions as a response. No
need to re-send the whole series for now.
On 21/02/15 03:02, Laura Ekstrand wrote:
On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres
mailto:martin.pe...@linux.intel.c
On 21/02/15 02:25, Laura Ekstrand wrote:
You still seem to be confused about the names of internal functions.
If a function exists outside of its "class," (ie. is extern-ed from a
*.h file), it should have the "_mesa" in front. If a function exists
purely inside of a *.c file, it should be st
Hi,
On 02/11/2015 08:45 PM, Kenneth Graunke wrote:
On Wednesday, February 11, 2015 04:56:56 PM Juha-Pekka Heikkila wrote:
There is no error path available thus instead of giving
realloc possibility to fail use new which will never
return null pointer and throws bad_alloc on failure.
...
Okay,
This corrects a trivial error introduced in commit
19252fee46b835cb4f6b1cce18d7737d62b64a2e. That patch was merged recently
and omits one condition (that 'samples' is greater than zero) in one of
the error checks. That error will definitely cause regressions.
Also corrects the reference to the spe
On 02/23/2015 12:41 PM, Martin Peres wrote:
>>
>> Section 4.4 (Framebuffer objects), page 198 of the OpenGL 3.0.0
>> specification says:
>>
>> "If internalformat is a signed or unsigned integer format and
>> samples is greater than zero, then the error INVALID_OPERATION
>> is gener
On 23/02/15 11:24, Eduardo Lima Mitev wrote:
On 02/23/2015 09:48 AM, Martin Peres wrote:
On 23/02/15 10:33, Eduardo Lima Mitev wrote:
Hi, can someone take a look? It should be very straight forward.
Eduardo
You are not supposed to return INVALID_OPERATION if samples < 0.
Also, samples == 0
Martin Peres writes:
> Signed-off-by: Martin Peres
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 02/23/2015 09:48 AM, Martin Peres wrote:
>
> On 23/02/15 10:33, Eduardo Lima Mitev wrote:
>> Hi, can someone take a look? It should be very straight forward.
>>
>> Eduardo
> You are not supposed to return INVALID_OPERATION if samples < 0.
>
> Also, samples == 0 is valid [0], so this is a NAK f
On 20/02/15 20:57, Ilia Mirkin wrote:
On Mon, Feb 16, 2015 at 9:13 AM, Martin Peres
wrote:
Maybe this should be the job of the dispatch layer.
Signed-off-by: Martin Peres
---
src/mesa/main/multisample.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/mesa/main/multisample.
On 20/02/15 20:38, Laura Ekstrand wrote:
Please provide a page number and a section title in your spec comment.
I'm not very fond of giving the page number as Khronos updates the pdf
quite often
and the page number may change. Since I see so little people write the
pdf page
number, is there
On 23/02/15 10:33, Eduardo Lima Mitev wrote:
Hi, can someone take a look? It should be very straight forward.
Eduardo
You are not supposed to return INVALID_OPERATION if samples < 0.
Also, samples == 0 is valid [0], so this is a NAK for me! The correct patch
has already been posted to the ML:
On Tuesday, February 10, 2015 11:09:57 AM Matt Turner wrote:
> We were special casing OPCODE_END but no other instructions that have no
> destination, like OPCODE_KIL, leading us to emitting MOVs with null
> destinations.
>
> total instructions in shared programs: 5950886 -> 5947182 (-0.06%)
> ins
On Tuesday, February 10, 2015 11:09:59 AM Matt Turner wrote:
> Each emit_cond_mov() emits a CMP of its first to arguments using the
> specified conditional mod, followed by a predicated MOV of the fifth
> argument into the fourth. In all four cases here, it was just
> implementing MIN/MAX which we
Hi, can someone take a look? It should be very straight forward.
Eduardo
On 02/20/2015 02:09 PM, Eduardo Lima Mitev wrote:
> This corrects a trivial error introduced in commit
> 19252fee46b835cb4f6b1cce18d7737d62b64a2e. That patch was merged recently
> and omits one condition (that 'samples' is g
Signed-off-by: Martin Peres
---
src/mesa/drivers/osmesa/Makefile.am | 2 ++
src/mesa/drivers/osmesa/SConscript | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/mesa/drivers/osmesa/Makefile.am
b/src/mesa/drivers/osmesa/Makefile.am
index 589b5ee..590dd66 100644
--- a/src/mesa/drivers/os
On Friday, February 20, 2015 01:30:56 PM Laura Ekstrand wrote:
> Textures made expressly for internal buffer objects shouldn't have extra
> padding around them, but should be densely packed.
I might explain this as:
PBOs do not support miplevels - array slices are densely packed, with no
extra pa
On Friday, February 20, 2015 01:30:53 PM Laura Ekstrand wrote:
> Solves bugs related to the driver not setting up the texture miptree
> correctly, leading to faulty PBO uploads and downloads.
> ---
> src/mesa/drivers/common/meta_tex_subimage.c | 13 +
> src/mesa/drivers/dri/i965/intel_
On Sunday, February 22, 2015 08:40:17 PM Matt Turner wrote:
> ---
> I can't believe this is beneficial, especially since it came from the
> i915tex import.
>
> src/mesa/drivers/dri/i965/brw_context.h | 27
> ---
> src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +
64 matches
Mail list logo
