Re: [Mesa-dev] [PATCH 16/20] mesa/formats: add new mesa formats and their pack/unpack functions.

2014-11-23 Thread Samuel Iglesias Gonsálvez
On Thu, 2014-11-20 at 13:19 +0100, Samuel Iglesias Gonsálvez wrote: [...] > > + /* Other formats */ > > + MESA_FORMAT_R3G3B2_UNORM, > >/* BBGG GRRR */ > > + MESA_FORMAT_A4B4G4R4_UNORM, /* > > */ > >

Re: [Mesa-dev] [PATCH 11/11] st/nine: return S_FALSE instead of INVALIDCALL when in building query state

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > It is the same behaviour as wine has. > > Cc: "10.4" > Reviewed-by: David Heidelberg > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/nine/query9.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [Mesa-dev] [PATCH 10/11] st/nine: Handle queries not supported by the driver

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > Cc: "10.4" > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/nine/device9.c | 2 +- > src/gallium/state_trackers/nine/query9.c | 52 > --- > src/gallium/state_trackers/nine

[Mesa-dev] [Bug 83445] eglSwapBuffers() crash on dri

2014-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83445 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 09/11] st/nine: Rework queries

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > From this moment we should handle errors same way as Wine does. > > Original patch from John Ettedgui > > Cc: "10.4" > Tested-by: David Heidelberg > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/nine

Re: [Mesa-dev] [PATCH 05/11] st/nine: return GetAvailableTextureMem in bytes as expected (v2)

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > PIPE_CAP_VIDEO_MEMORY returns the amount of video memory in megabytes, > so need to converted it to bytes. > > Fixed Warframe memory detection. > > v2: also prepare for cards with more than 4GB memory > > Cc: "10.4" > Tested-by: Yaroslav

Re: [Mesa-dev] [PATCH 03/11] st/nine: propertly declare constants

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > Fixes "Error : CONST[20]: Undeclared source register" when running > dx9_alpha_blending_material. Also artifacts on ilo. > > Cc: "10.4" > Tested-by: David Heidelberg > Signed-off-by: Axel Davy > --- > src/gallium/s

Re: [Mesa-dev] [PATCH 02/11] st/nine: call DBG() at more external entry points

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Stanislaw Halik > > Cc: "10.4" > Reviewed-by: David Heidelberg > Reviewed-by: Axel Davy > Signed-off-by: Stanislaw Halik Reviewed-by: Ilia Mirkin I wouldn't really bother with backporting this to 10.4, but similar comment as

[Mesa-dev] [PATCH 09/11] st/nine: Rework queries

2014-11-23 Thread David Heidelberg
From: Axel Davy From this moment we should handle errors same way as Wine does. Original patch from John Ettedgui Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 66 +--- 1 file changed, 44 insertion

[Mesa-dev] [PATCH 10/11] st/nine: Handle queries not supported by the driver

2014-11-23 Thread David Heidelberg
From: Axel Davy Cc: "10.4" Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 2 +- src/gallium/state_trackers/nine/query9.c | 52 --- src/gallium/state_trackers/nine/query9.h | 2 +- 3 files changed, 42 insertions(+), 14 deletions(-) diff

[Mesa-dev] [PATCH 11/11] st/nine: return S_FALSE instead of INVALIDCALL when in building query state

2014-11-23 Thread David Heidelberg
From: Axel Davy It is the same behaviour as wine has. Cc: "10.4" Reviewed-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/query9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/query9.c b/src/gallium/sta

Re: [Mesa-dev] [PATCH 01/11] st/nine: Refactor Resource9 BaseTexture9 Surface9 and Texture9 initialization

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > First change is to pass initResource argument to initialise the resource > field in Resource9 instead of in the parents. > > Second change is to pass Usage argument, instead of letting the parent > classes set the usag

Re: [Mesa-dev] [PATCH 08/11] st/nine: Fix setting of the shift modifier in nine_shader

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > It is an sint_4, but it was stored in a uint_8... > The code using it was acting as if it was signed. > > Problem found thanks to Coverity > > Cc: "10.4" > Tested-by: David Heidelberg > Signed-off-by: Axel Davy Rev

Re: [Mesa-dev] [PATCH 07/11] st/nine: remove unused pipe_viewport_state::translate[3] and scale[3]

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > 2efabd9f5a711a7f6cd1846630244b7814bf25b3 removed them as unused. > > This caused random memory overwrites (reported by Coverity). > > Cc: "10.4" > Reviewed-by: Marek Olšák > Reviewed-by: Axel Davy > Signed-off-by: David Heidelberg Rev

Re: [Mesa-dev] [PATCH 06/11] st/nine: fix wrong variable reset

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 5:40 PM, David Heidelberg wrote: > From: Axel Davy > > Error detected by Coverity (COPY_PAST_ERROR) Probably COPY_PASTE_ERROR? Didn't check... > > Cc: "10.4" > Signed-off-by: Axel Davy > Signed-off-by: David Heidelberg Reviewed-by: Ilia Mirkin > --- > src/gallium/

[Mesa-dev] [PATCH 07/11] st/nine: remove unused pipe_viewport_state::translate[3] and scale[3]

2014-11-23 Thread David Heidelberg
2efabd9f5a711a7f6cd1846630244b7814bf25b3 removed them as unused. This caused random memory overwrites (reported by Coverity). Cc: "10.4" Reviewed-by: Marek Olšák Reviewed-by: Axel Davy Signed-off-by: David Heidelberg --- src/gallium/state_trackers/nine/nine_state.c | 2 -- 1 file changed, 2

[Mesa-dev] [PATCH 06/11] st/nine: fix wrong variable reset

2014-11-23 Thread David Heidelberg
From: Axel Davy Error detected by Coverity (COPY_PAST_ERROR) Cc: "10.4" Signed-off-by: Axel Davy Signed-off-by: David Heidelberg --- src/gallium/state_trackers/nine/nine_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_state.c

[Mesa-dev] [PATCH 08/11] st/nine: Fix setting of the shift modifier in nine_shader

2014-11-23 Thread David Heidelberg
From: Axel Davy It is an sint_4, but it was stored in a uint_8... The code using it was acting as if it was signed. Problem found thanks to Coverity Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 6 -- 1 file changed,

[Mesa-dev] [PATCH 01/11] st/nine: Refactor Resource9 BaseTexture9 Surface9 and Texture9 initialization

2014-11-23 Thread David Heidelberg
From: Axel Davy First change is to pass initResource argument to initialise the resource field in Resource9 instead of in the parents. Second change is to pass Usage argument, instead of letting the parent classes set the usage field of the Resource9 structure. Third change fixes a bug, prevent

[Mesa-dev] [PATCH 02/11] st/nine: call DBG() at more external entry points

2014-11-23 Thread David Heidelberg
From: Stanislaw Halik Cc: "10.4" Reviewed-by: David Heidelberg Reviewed-by: Axel Davy Signed-off-by: Stanislaw Halik --- src/gallium/state_trackers/nine/basetexture9.c | 17 src/gallium/state_trackers/nine/cubetexture9.c | 17 src/gallium/state_trackers/nine/device9

Re: [Mesa-dev] [PATCH 2/2] i965/draw state: Allow state upload to proceed when inputs are not set

2014-11-23 Thread Jordan Justen
On 2014-11-22 23:50:29, Kenneth Graunke wrote: > On Saturday, November 22, 2014 11:26:39 PM Jordan Justen wrote: > > On 2014-11-22 17:33:54, Kenneth Graunke wrote: > > > On Saturday, November 22, 2014 12:02:31 PM Jordan Justen wrote: > > > > For drawing the OpenGL API should validate this before we

[Mesa-dev] [PATCH] r600g: merge the TXQ and BUFFER constant buffers

2014-11-23 Thread Dave Airlie
From: Dave Airlie We are using 1 more buffer than we have, although in the future the driver should just end up using one buffer in total probably, this is a good first step, it merges the txq cube array and buffer info constants on r600 and evergreen. this also most likely breaks llvm backend,

Re: [Mesa-dev] [PATCH] r600g: do all CUBE ALU operations before gradient texture operations (v2)

2014-11-23 Thread Glenn Kennard
On Mon, 24 Nov 2014 01:32:36 +0100, Dave Airlie wrote: From: Dave Airlie This moves all the CUBE section above the gradients section, it also fixes a bug with gradient handling in the bytecode handling where the gradient dst register should be ignored but isn't causing the subsequent sample_g

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] glsl: Generate unique names for each const array lowered to uniforms

2014-11-23 Thread Chris Forbes
Just fallen through the cracks. I'll land them after work (a few hours). On Mon, Nov 24, 2014 at 2:01 PM, Emil Velikov wrote: > Hi Chris, > > These two patches haven't landed in master. Did they fall through the > cracks or you're planning to do more work on them ? Afaics Ken is happy > with thei

[Mesa-dev] [PATCH] docs: add template mesa 10.5.0 relnotes page

2014-11-23 Thread Emil Velikov
Signed-off-by: Emil Velikov --- Perhaps I'll add this to the list of things for the branchpoint :) Note that the version includes the forever missing trailing 0. -Emil docs/relnotes/10.5.0.html | 61 +++ 1 file changed, 61 insertions(+) create mode

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] glsl: Generate unique names for each const array lowered to uniforms

2014-11-23 Thread Emil Velikov
Hi Chris, These two patches haven't landed in master. Did they fall through the cracks or you're planning to do more work on them ? Afaics Ken is happy with their current state. Thanks Emil On 18/11/14 08:15, Chris Forbes wrote: > Uniform names (even for hidden uniforms) are required to be uniqu

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2014-11-23 Thread Roland Scheidegger
Am 23.11.2014 um 22:34 schrieb Marek Olšák: > Hi Roland, > > What's the reason for not using an ordered comparison for SNE? Well, I guess for consistency with the new Fxxx versions (essentially dx10). All ordered except not equal which is unordered (I have no idea if that's what the r600 does with

Re: [Mesa-dev] [PATCH] r600: fix texture gradients instruction emission (v2)

2014-11-23 Thread Glenn Kennard
On Tue, 18 Nov 2014 23:53:23 +0100, Dave Airlie wrote: From: Dave Airlie The piglit tests were failing, and it appeared to be SB optimising out things, but Glenn pointed out the gradients are meant to be clause local, so we should emit the texture instructions in the same clause. This moves t

[Mesa-dev] [PATCH] r600g: do all CUBE ALU operations before gradient texture operations (v2)

2014-11-23 Thread Dave Airlie
From: Dave Airlie This moves all the CUBE section above the gradients section, it also fixes a bug with gradient handling in the bytecode handling where the gradient dst register should be ignored but isn't causing the subsequent sample_g to fail into a second tex clause. v2: avoid changes to by

Re: [Mesa-dev] [PATCH] nine: the .pc file should not follow mesa version

2014-11-23 Thread David Heidelberg
Reviewed-by: David Heidelberg On 11/22/2014 05:23 AM, Emil Velikov wrote: The version provided by it should be the same as the one provided/handled by the module. Add the missing tiny version. Cc: Signed-off-by: Emil Velikov --- configure.ac| 2 ++ src/gall

[Mesa-dev] [PATCH 04/11] st/nine: Add pool check to SetTexture (v2)

2014-11-23 Thread David Heidelberg
From: Axel Davy D3DPOOL_SCRATCH is disallowed according to spec. D3DPOOL_SYSTEMMEM should be allowed but we don't handle it right for now. v2: Fixes segfault in SetTexture when unsetting the texture Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_tracke

[Mesa-dev] [PATCH 05/11] st/nine: return GetAvailableTextureMem in bytes as expected (v2)

2014-11-23 Thread David Heidelberg
PIPE_CAP_VIDEO_MEMORY returns the amount of video memory in megabytes, so need to converted it to bytes. Fixed Warframe memory detection. v2: also prepare for cards with more than 4GB memory Cc: "10.4" Tested-by: Yaroslav Andrusyak Reviewed-by: Axel Davy Signed-off-by: David Heidelberg ---

[Mesa-dev] [PATCH 03/11] st/nine: propertly declare constants

2014-11-23 Thread David Heidelberg
From: Axel Davy Fixes "Error : CONST[20]: Undeclared source register" when running dx9_alpha_blending_material. Also artifacts on ilo. Cc: "10.4" Tested-by: David Heidelberg Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2014-11-23 Thread Marek Olšák
Hi Roland, What's the reason for not using an ordered comparison for SNE? Marek On Tue, Aug 13, 2013 at 7:04 PM, wrote: > From: Roland Scheidegger > > Also use ordered comparisons for old cmp instructions. Untested. > --- > src/gallium/drivers/r600/r600_shader.c | 18 --- >

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 1:55 PM, Ben Widawsky wrote: > On Sun, Nov 23, 2014 at 01:50:08PM -0500, Ilia Mirkin wrote: >> On Sun, Nov 23, 2014 at 1:31 PM, Ben Widawsky wrote: >> > On Sun, Nov 23, 2014 at 02:12:10AM -0500, Ilia Mirkin wrote: >> >> On Sat, Nov 22, 2014 at 6:52 PM, Ben Widawsky >> >>

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-23 Thread Ben Widawsky
On Sun, Nov 23, 2014 at 01:50:08PM -0500, Ilia Mirkin wrote: > On Sun, Nov 23, 2014 at 1:31 PM, Ben Widawsky wrote: > > On Sun, Nov 23, 2014 at 02:12:10AM -0500, Ilia Mirkin wrote: > >> On Sat, Nov 22, 2014 at 6:52 PM, Ben Widawsky > >> wrote: > >> > This patch implements ARB_pipeline_statistics_

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-23 Thread Ilia Mirkin
On Sun, Nov 23, 2014 at 1:31 PM, Ben Widawsky wrote: > On Sun, Nov 23, 2014 at 02:12:10AM -0500, Ilia Mirkin wrote: >> On Sat, Nov 22, 2014 at 6:52 PM, Ben Widawsky >> wrote: >> > This patch implements ARB_pipeline_statistics_query. This addition to GL >> > does >> > not add a new API. Instead,

Re: [Mesa-dev] [PATCH 2/2] i965/draw state: Allow state upload to proceed when inputs are not set

2014-11-23 Thread Ben Widawsky
On Sat, Nov 22, 2014 at 11:50:29PM -0800, Kenneth Graunke wrote: > On Saturday, November 22, 2014 11:26:39 PM Jordan Justen wrote: > > On 2014-11-22 17:33:54, Kenneth Graunke wrote: > > > On Saturday, November 22, 2014 12:02:31 PM Jordan Justen wrote: > > > > For drawing the OpenGL API should valid

Re: [Mesa-dev] [PATCH] i965: implement ARB_pipeline_statistics_query

2014-11-23 Thread Ben Widawsky
On Sun, Nov 23, 2014 at 02:12:10AM -0500, Ilia Mirkin wrote: > On Sat, Nov 22, 2014 at 6:52 PM, Ben Widawsky > wrote: > > This patch implements ARB_pipeline_statistics_query. This addition to GL > > does > > not add a new API. Instead, it adds new tokens to the existing query APIs. > > The > > w

[Mesa-dev] [PATCH] nv50/ir: set neg modifiers on min/max args

2014-11-23 Thread Ilia Mirkin
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=86618 Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp b/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [Bug 85203] [DRI2][RadeonSI] Pageflip completion event has impossible msc.

2014-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85203 --- Comment #3 from alex_y...@yahoo.ca --- Created attachment 109903 --> https://bugs.freedesktop.org/attachment.cgi?id=109903&action=edit sanitized dmesg -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [Bug 85203] [DRI2][RadeonSI] Pageflip completion event has impossible msc.

2014-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85203 alex_y...@yahoo.ca changed: What|Removed |Added CC||alex_y...@yahoo.ca --- Comment #2 fr

Re: [Mesa-dev] [PATCH 3/4] nine: handle D3DISSUE_END without previous D3DISSUE_BEGIN

2014-11-23 Thread Marek Olšák
A few Gallium queries don't need and it's invalid to call begin_query. Those are PIPE_QUERY_GPU_FINISHED (D3DQUERYTYPE_EVENT) and PIPE_QUERY_TIMESTAMP (D3DQUERYTYPE_TIMESTAMP). The attached patch should fix this. Marek On Sat, Nov 22, 2014 at 9:48 AM, John Ettedgui wrote: > So I tried both code