[Mesa-dev] [Bug 83631] /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83631 ruhly changed: What|Removed |Added CC||truhl...@gmail.com -- You are receiving this ma

[Mesa-dev] [Bug 83631] /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83631 --- Comment #7 from ruhly --- I too ran into this bug when trying to install opencascade for freecad on Arch linux. I added the following typedefs to a section of code that had been added in 10.3: # diff glxext.h.saved glxext.h 479a480,481 > typ

[Mesa-dev] [Bug 84242] FTBFS: libOpenCL.so.1.0.0: ld: .eh_frame_hdr table[5707] FDE at 0000000000c45b8c overlaps table[5708] FDE at 0000000000c45a88

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84242 --- Comment #15 from Alan Modra --- Build libOpenCL.so.1 with -Wl,-noinhibit-exec,-Map,libOpenCl.map and look at the mapfile entries for .eh_frame. Try to match up with addresses given for the overlapping FDE. This should give you the object fi

[Mesa-dev] [Bug 84242] FTBFS: libOpenCL.so.1.0.0: ld: .eh_frame_hdr table[5707] FDE at 0000000000c45b8c overlaps table[5708] FDE at 0000000000c45a88

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84242 Michel Dänzer changed: What|Removed |Added CC||amo...@gmail.com --- Comment #14 from Mi

Re: [Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-10-02 Thread Michel Dänzer
On 03.10.2014 02:26, Marek Olšák wrote: From: Marek Olšák I'll need this in radeonsi. v2: use __builtin_popcountll if available --- src/gallium/auxiliary/util/u_math.h | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxili

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-10-02 Thread Jason Ekstrand
On Tue, Sep 30, 2014 at 5:00 PM, Matt Turner wrote: > On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner wrote: > > The compiler isn't privy to the knowledge that we're doing at least one > > framebuffer write. > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + > > 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Maarten Lankhorst
Hey, Op 02-10-14 om 04:22 schreef Roland Scheidegger: > Am 01.10.2014 16:56, schrieb Maarten Lankhorst: >> This fixes a crash when llvmpipe tries to use sse instructions, >> but llvm detects a cpu that doesn't support them. >> >> Fixes for example piglit/bin/amd_seamless_cubemap_per_texture -fbo -

[Mesa-dev] FOSDEM15: Graphics DevRoom: call for speakers.

2014-10-02 Thread Luc Verhaegen
Hi, At FOSDEM on the 31st of january and the 1st of February 2015, there will be another graphics DevRoom. URL: https://fosdem.org/2015/ The focus of this DevRoom is of course the same as last year, namely: * Graphics drivers: from display to media to 3d drivers, both in kernel or userspace.

[Mesa-dev] New stable-branch 10.2 candidate pushed

2014-10-02 Thread Emil Velikov
Hello list, It is time for the final 10.2 stable candidate. Currently we have - 10 queued - 2 nominated (old and outstanding) - and 0 rejected patches Take a look at section "Mesa stable queue" for more information. Regressions/Fixes - No regressions or fixes were spotted in sw

Re: [Mesa-dev] [PATCH] Revert "configure: ask vdpau.pc for the default location of the vdpau drivers"

2014-10-02 Thread Ilia Mirkin
On Thu, Oct 2, 2014 at 7:59 PM, Emil Velikov wrote: > On 02/10/14 06:41, Ilia Mirkin wrote: >> On Mon, Sep 29, 2014 at 8:33 PM, Emil Velikov >> wrote: >>> On 29/09/14 17:24, Matt Turner wrote: On Mon, Sep 29, 2014 at 9:16 AM, Emil Velikov wrote: > So all in all we have the follow

[Mesa-dev] [Bug 84242] FTBFS: libOpenCL.so.1.0.0: ld: .eh_frame_hdr table[5707] FDE at 0000000000c45b8c overlaps table[5708] FDE at 0000000000c45a88

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84242 --- Comment #13 from Alan Modra --- I don't believe trunk binutils is the source of the problem. Trunk binutils (commit ae6c7e33 and aa8f4d1e) is merely letting you know about a case where previous versions of ld silently created binaries with p

[Mesa-dev] [Bug 75165] compute.c:464:49: error: function definition is not allowed here

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75165 Vinson Lee changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Vinson Lee --- (In

[Mesa-dev] [Bug 83381] dri_screen.c:72:10: error: expected '}'

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83381 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] Revert "configure: ask vdpau.pc for the default location of the vdpau drivers"

2014-10-02 Thread Emil Velikov
On 02/10/14 06:41, Ilia Mirkin wrote: > On Mon, Sep 29, 2014 at 8:33 PM, Emil Velikov > wrote: >> On 29/09/14 17:24, Matt Turner wrote: >>> On Mon, Sep 29, 2014 at 9:16 AM, Emil Velikov >>> wrote: So all in all we have the following: Some distributions/people choose odd location

Re: [Mesa-dev] [PATCH] i965/fs: Use the correct base_mrf for spilling pairs in SIMD8

2014-10-02 Thread Matt Turner
On Thu, Oct 2, 2014 at 4:16 PM, Jason Ekstrand wrote: > Before, we were hard-coding the base_mrf based on dispatch width not number > of registers spilled at a time. This caused us to emit instructions with a > base_mrf or 14 and a mlen of 3 so we used the magical non-existant m16 > register. Th

[Mesa-dev] [PATCH] i965/fs: Use the correct base_mrf for spilling pairs in SIMD8

2014-10-02 Thread Jason Ekstrand
Before, we were hard-coding the base_mrf based on dispatch width not number of registers spilled at a time. This caused us to emit instructions with a base_mrf or 14 and a mlen of 3 so we used the magical non-existant m16 register. This fixes the problem. --- src/mesa/drivers/dri/i965/brw_fs_reg

Re: [Mesa-dev] [PATCH] tgsi: change tgsi_shader_info::properties to a one-dimensional array

2014-10-02 Thread Roland Scheidegger
Am 02.10.2014 um 19:36 schrieb Marek Olšák: > From: Marek Olšák > > --- > This should be applied on top of my previous big patch series. > > src/gallium/auxiliary/draw/draw_gs.c | 6 +++--- > src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 +- > src/gallium/auxiliary/tgsi/tgsi_

Re: [Mesa-dev] [PATCH 1/2] util: Add assume() macro.

2014-10-02 Thread Matt Turner
On Thu, Oct 2, 2014 at 1:58 PM, Kenneth Graunke wrote: > On Tuesday, September 30, 2014 04:24:39 PM Matt Turner wrote: >> --- >> src/util/macros.h | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/src/util/macros.h b/src/util/macros.h >> index 40ebf02..77055e8 100644 >> -

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Add a MAX_GRF_SIZE define and use it various places

2014-10-02 Thread Kenneth Graunke
On Thursday, October 02, 2014 11:53:27 AM Matt Turner wrote: > On Wed, Oct 1, 2014 at 12:18 PM, Jason Ekstrand wrote: > > Previously, we had a MAX_SAMPLER_MESSAGE_SIZE which we used instead. > > However, some FB write messages can validly be longer than this so we need > > something different. Si

Re: [Mesa-dev] [PATCH 1/2] util: Add assume() macro.

2014-10-02 Thread Kenneth Graunke
On Tuesday, September 30, 2014 04:24:39 PM Matt Turner wrote: > --- > src/util/macros.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/util/macros.h b/src/util/macros.h > index 40ebf02..77055e8 100644 > --- a/src/util/macros.h > +++ b/src/util/macros.h > @@ -75,6 +75,

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-02 Thread Alex Deucher
On Thu, Oct 2, 2014 at 1:51 PM, Christian König wrote: > Am 02.10.2014 um 19:34 schrieb Marek Olšák: >> >> From: Marek Olšák >> >> This fixes a crash when exiting Firefox. I have really no idea how Firefox >> does it. It seems to involve multiple contexts and multithreading. > > > That looks to m

Re: [Mesa-dev] [PATCH 1/7] mesa: Add usage history bitfield to buffer objects

2014-10-02 Thread Marek Olšák
On Thu, Oct 2, 2014 at 8:21 PM, Ian Romanick wrote: > On 10/01/2014 09:06 AM, Marek Olšák wrote: >> On Wed, Oct 1, 2014 at 11:02 AM, Chris Forbes wrote: >>> In the drivers, we occasionally want to reallocate the backing >>> store for a buffer object; often to avoid waiting for the GPU >>> to be f

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Add a MAX_GRF_SIZE define and use it various places

2014-10-02 Thread Matt Turner
On Wed, Oct 1, 2014 at 12:18 PM, Jason Ekstrand wrote: > Previously, we had a MAX_SAMPLER_MESSAGE_SIZE which we used instead. > However, some FB write messages can validly be longer than this so we need > something different. Since MAX_SAMPLER_MESSAGE_SIZE is validly useful on > its own, we leave

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Use the actual regsister width in brw_reg_from_fs_reg

2014-10-02 Thread Matt Turner
On Wed, Oct 1, 2014 at 12:18 PM, Jason Ekstrand wrote: > This fixes a bug where 1-wide operations don't properly translate down to > 1-wide instructions. ... specifically for MRF writes? Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] [PATCH 1/3] i965/fs_fp: Use null_reg from fs_visitor instead of rolling our own

2014-10-02 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH 31/56] glsl: Add builtin uniforms for default inner/outer tess levels

2014-10-02 Thread Chris Forbes
On Fri, Oct 3, 2014 at 3:24 AM, Marek Olšák wrote: > This won't catch state changes made by glPatchParameterfv. > glPatchParameterfv should add a flag and also call FLUSH_VERTICES and > the same flag should be used for these 2 state variables. Otherwise, > the constant buffer won't be updated afte

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in builtin_builder::_image_prototype.

2014-10-02 Thread Ian Romanick
Since this is Curro's code, I'm CC'ing me. On 10/01/2014 03:12 AM, Iago Toral Quiroga wrote: > in_var calls the ir_variable constructor, which dups the variable name. > --- > src/glsl/builtin_functions.cpp | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/glsl/

Re: [Mesa-dev] [PATCH 1/7] mesa: Add usage history bitfield to buffer objects

2014-10-02 Thread Ian Romanick
On 10/01/2014 09:06 AM, Marek Olšák wrote: > On Wed, Oct 1, 2014 at 11:02 AM, Chris Forbes wrote: >> In the drivers, we occasionally want to reallocate the backing >> store for a buffer object; often to avoid waiting for the GPU >> to be finished with the previous contents. >> >> At the point that

Re: [Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-02 Thread Christian König
Am 02.10.2014 um 19:34 schrieb Marek Olšák: From: Marek Olšák This fixes a crash when exiting Firefox. I have really no idea how Firefox does it. It seems to involve multiple contexts and multithreading. That looks to me like we now release all sampler views with the current context and not

Re: [Mesa-dev] [PATCH] i965/fs_fp: Use a null register of the appropreate width.

2014-10-02 Thread Ian Romanick
This fixes the bug on my IVB system. Tested-by: Ian Romanick On 09/30/2014 05:49 PM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84529 > --- > src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 2 +- > 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH] tgsi: change tgsi_shader_info::properties to a one-dimensional array

2014-10-02 Thread Marek Olšák
From: Marek Olšák --- This should be applied on top of my previous big patch series. src/gallium/auxiliary/draw/draw_gs.c | 6 +++--- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_scan.c | 5 ++--- src/gallium/auxiliary/tgsi/tgsi_

[Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release for releasing sampler views

2014-10-02 Thread Marek Olšák
From: Marek Olšák This fixes a crash when exiting Firefox. I have really no idea how Firefox does it. It seems to involve multiple contexts and multithreading. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81680 Cc: 10.2 10.3 Tested-by: Benjamin Bellec --- src/mesa/state_tracker/st_

[Mesa-dev] [PATCH] gallium/util: add util_bitcount64

2014-10-02 Thread Marek Olšák
From: Marek Olšák I'll need this in radeonsi. v2: use __builtin_popcountll if available --- src/gallium/auxiliary/util/u_math.h | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index 39bd40f..f95c111 100

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Roland Scheidegger
Am 02.10.2014 um 18:11 schrieb Ilia Mirkin: > On Thu, Oct 2, 2014 at 11:34 AM, Jose Fonseca wrote: >> On 02/10/14 03:09, Ilia Mirkin wrote: >>> >>> On Wed, Oct 1, 2014 at 10:56 AM, Maarten Lankhorst >>> wrote: This fixes a crash when llvmpipe tries to use sse instructions, but llvm

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 Matt Turner changed: What|Removed |Added QA Contact||mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Roland Scheidegger
Am 02.10.2014 um 17:36 schrieb Jose Fonseca: > On 02/10/14 15:04, Roland Scheidegger wrote: >> Am 02.10.2014 um 09:31 schrieb Maarten Lankhorst: >>> Op 02-10-14 om 09:10 schreef Maarten Lankhorst: Hey, Op 02-10-14 om 04:22 schreef Roland Scheidegger: > Am 01.10.2014 16:56, schrie

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Ilia Mirkin
On Thu, Oct 2, 2014 at 11:34 AM, Jose Fonseca wrote: > On 02/10/14 03:09, Ilia Mirkin wrote: >> >> On Wed, Oct 1, 2014 at 10:56 AM, Maarten Lankhorst >> wrote: >>> >>> This fixes a crash when llvmpipe tries to use sse instructions, >>> but llvm detects a cpu that doesn't support them. >>> >>> Fix

[Mesa-dev] [PATCH] mesa: fix spurious wglGetProcAddress / GL_INVALID_OPERATION error

2014-10-02 Thread Brian Paul
On Windows, the Piglit primitive-restart test was failing a glGetError()==0 assertion when it was run w/out any command line arguments. Piglit's all.py script only runs primitive-restart with arguments so this case isn't normally hit during a full piglit run. The basic problem is Microsoft's open

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Jose Fonseca
On 02/10/14 15:04, Roland Scheidegger wrote: Am 02.10.2014 um 09:31 schrieb Maarten Lankhorst: Op 02-10-14 om 09:10 schreef Maarten Lankhorst: Hey, Op 02-10-14 om 04:22 schreef Roland Scheidegger: Am 01.10.2014 16:56, schrieb Maarten Lankhorst: This fixes a crash when llvmpipe tries to use s

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Jose Fonseca
On 02/10/14 03:09, Ilia Mirkin wrote: On Wed, Oct 1, 2014 at 10:56 AM, Maarten Lankhorst wrote: This fixes a crash when llvmpipe tries to use sse instructions, but llvm detects a cpu that doesn't support them. Fixes for example piglit/bin/amd_seamless_cubemap_per_texture -fbo -auto on i386 whe

[Mesa-dev] [Bug 54080] glXQueryDrawable fails with GLXBadDrawable for a Window in direct context

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54080 --- Comment #6 from Adrian Negreanu --- Created attachment 107229 --> https://bugs.freedesktop.org/attachment.cgi?id=107229&action=edit call SendMakeCurrent. With the 0001-SendMakeCurrent, the error goes away, but causes an Xorg segfault when

Re: [Mesa-dev] [RFC PATCH 31/56] glsl: Add builtin uniforms for default inner/outer tess levels

2014-10-02 Thread Marek Olšák
On Sun, Sep 21, 2014 at 3:41 AM, Chris Forbes wrote: > If the hardware needs to always have a control shader present if > and evaluation shader is present, then the control shader will need > these values. > --- > src/glsl/builtin_variables.cpp| 14 ++ > src/mesa/program/prog_stat

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Roland Scheidegger
Am 02.10.2014 um 09:31 schrieb Maarten Lankhorst: > Op 02-10-14 om 09:10 schreef Maarten Lankhorst: >> Hey, >> >> Op 02-10-14 om 04:22 schreef Roland Scheidegger: >>> Am 01.10.2014 16:56, schrieb Maarten Lankhorst: This fixes a crash when llvmpipe tries to use sse instructions, but llvm d

Re: [Mesa-dev] [PATCH 1/7] mesa: Add usage history bitfield to buffer objects

2014-10-02 Thread Marek Olšák
On Thu, Oct 2, 2014 at 11:57 AM, Chris Forbes wrote: > That fixes the bug and is nice and minimal, but it doesn't meet my > overhead-reduction goal. > > _NEW_TEXTURE triggers piles of work, mostly irrelevant if we've only > changed buffer textures. I agree. I was only showing that the bug is in m

Re: [Mesa-dev] [PATCH v2] radeonsi: Add CIK SDMA support

2014-10-02 Thread Marek Olšák
1) We should have our own copyright in the new file. Other than that: Reviewed-by: Marek Olšák The following things can be done in a separate patch. 2) I recommend removing the CMASK and FMASK checking and replacing it with nr_samples > 1 (for SI too). For nr_samples <= 1, CMASK checking is alr

Re: [Mesa-dev] [PATCH 1/7] mesa: Add usage history bitfield to buffer objects

2014-10-02 Thread Chris Forbes
That fixes the bug and is nice and minimal, but it doesn't meet my overhead-reduction goal. _NEW_TEXTURE triggers piles of work, mostly irrelevant if we've only changed buffer textures. On Thu, Oct 2, 2014 at 10:28 PM, Marek Olšák wrote: > On Thu, Oct 2, 2014 at 6:05 AM, Ilia Mirkin wrote: >> O

Re: [Mesa-dev] [PATCH] radeonsi: Clear sampler view flags when binding a buffer

2014-10-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 2, 2014 at 9:03 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes assertion failure while running the Unreal Engine 4 Elemental demo: > > .../si_blit.c:322:si_decompress_color_textures: Assertion `tex->cmask.size || > tex->fmask.size' failed.

Re: [Mesa-dev] [PATCH] gallium/hud: use u_sampler_view_default_template helper

2014-10-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Oct 2, 2014 at 1:45 AM, Ilia Mirkin wrote: > The existing code was not setting several fields, most importantly the > target, which is required on nv50/nvc0. > > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/hud/hud_context.c | 9 +++-- >

Re: [Mesa-dev] [PATCH 1/7] mesa: Add usage history bitfield to buffer objects

2014-10-02 Thread Marek Olšák
On Thu, Oct 2, 2014 at 6:05 AM, Ilia Mirkin wrote: > On Wed, Oct 1, 2014 at 12:06 PM, Marek Olšák wrote: >> On Wed, Oct 1, 2014 at 11:02 AM, Chris Forbes wrote: >>> In the drivers, we occasionally want to reallocate the backing >>> store for a buffer object; often to avoid waiting for the GPU >>

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 Iago Toral changed: What|Removed |Added CC||sigles...@igalia.com Assignee|mes

[Mesa-dev] [Bug 84566] Unify the format conversion code

2014-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84566 --- Comment #2 from Iago Toral --- Hi Jason: Samuel and I will continue your work. We will ask here if we need input from your side. -- You are receiving this mail because: You are the assignee for the bug. _

Re: [Mesa-dev] [PATCH] gallivm: force sse instructions for llvm 3.5+

2014-10-02 Thread Maarten Lankhorst
Op 02-10-14 om 09:10 schreef Maarten Lankhorst: > Hey, > > Op 02-10-14 om 04:22 schreef Roland Scheidegger: >> Am 01.10.2014 16:56, schrieb Maarten Lankhorst: >>> This fixes a crash when llvmpipe tries to use sse instructions, >>> but llvm detects a cpu that doesn't support them. >>> >>> Fixes for

[Mesa-dev] [PATCH] radeonsi: Clear sampler view flags when binding a buffer

2014-10-02 Thread Michel Dänzer
From: Michel Dänzer Fixes assertion failure while running the Unreal Engine 4 Elemental demo: .../si_blit.c:322:si_decompress_color_textures: Assertion `tex->cmask.size || tex->fmask.size' failed. Cc: "10.2 10.3" Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_descriptors.c