Re: [Mesa-dev] [PATCH] gallium/targets: #include radeon_winsys.h in a couple of more places

2014-04-11 Thread Michel Dänzer
> On 2014/04/11, at 19:43, Marek Olšák wrote: > > Thanks. > > Reviewed-by: Marek Olšák Thank you. Can you or someone push this please? I probably won't get to it before Monday. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.fr

[Mesa-dev] [PATCH 1/5] dri: Expand driParseDebugString return value to uint64_t.

2014-04-11 Thread Matt Turner
Users will downcast if they don't have >32 debug flags. --- src/mesa/drivers/dri/common/utils.c | 7 +++ src/mesa/drivers/dri/common/utils.h | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index

[Mesa-dev] [PATCH 2/5] i965: Expand INTEL_DEBUG to uint64_t.

2014-04-11 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_debug.c | 2 +- src/mesa/drivers/dri/i965/intel_debug.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_debug.c b/src/mesa/drivers/dri/i965/intel_debug.c index 77f410a..dc74202 100644 --- a/src/mesa/drivers

[Mesa-dev] [PATCH 3/5] i965: Add envvar to debug the optimization passes.

2014-04-11 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_debug.c | 1 + src/mesa/drivers/dri/i965/intel_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_debug.c b/src/mesa/drivers/dri/i965/intel_debug.c index dc74202..44a38b4 100644 --- a/src/mesa/drivers/dri/i965/intel_de

[Mesa-dev] [PATCH 5/5] i965/fs: Debug the optimization passes by dumping instr to file.

2014-04-11 Thread Matt Turner
With INTEL_DEBUG=optimizer, write the output of dump_instructions() to a file each time an optimization pass makes progress. This lets you easily diff successive files to see what an optimization pass did. Example filenames written when running glxgears: fs8-00-00-start fs8-00-01-04-opt_copy

[Mesa-dev] [PATCH 4/5] i965: Let dump_instructions write to a file.

2014-04-11 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 129 +- src/mesa/drivers/dri/i965/brw_fs.h| 2 + src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 20 +++- src/mesa/drivers/dri/i965/brw_sha

Re: [Mesa-dev] [PATCH 01/20] i965/blorp: Single sample stencil msaa

2014-04-11 Thread Pohjolainen, Topi
On Fri, Apr 11, 2014 at 12:45:21PM -0700, Ian Romanick wrote: > On 04/11/2014 12:28 AM, Topi Pohjolainen wrote: > > Instead of relying on the sampler engine, use the existing sample > > coordinate encoding scheme and fetch samples as if the surface is > > single sampled. > > One unit test gets drop

Re: [Mesa-dev] [PATCH V2] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-04-11 Thread Chris Forbes
> This does a little more than the error message says - won't it prevent using > sample/centroid on, say, vertex shader inputs/fragment shader outputs? > > If so, then it seems like you could drop a pile of other code: > > /* From section 4.3.4 of the GLSL 1.30 spec: >*"It is an e

Re: [Mesa-dev] [PATCH] i965/gen8: add debug code to show FS disasm with jump locations

2014-04-11 Thread Kenneth Graunke
On 04/11/2014 07:33 PM, Jordan Justen wrote: > Copied from similar code in gen8_vec4_generator.cpp. > > Signed-off-by: Jordan Justen > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/drivers/

[Mesa-dev] [PATCH] i965/gen8: add debug code to show FS disasm with jump locations

2014-04-11 Thread Jordan Justen
Copied from similar code in gen8_vec4_generator.cpp. Signed-off-by: Jordan Justen Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965/gen

Re: [Mesa-dev] [PATCH V2] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-04-11 Thread Kenneth Graunke
On 04/11/2014 06:21 PM, Chris Forbes wrote: > We've been allowing `centroid` and `sample` in all kinds of weird places > where they're not valid. > > Insist that `sample` is combined with `in` or `out`; > and that `centroid` is combined with `in`, `out`, or the deprecated > `varying`. > > V2: Val

[Mesa-dev] [PATCH] egl-static: Reduce code duplication for radeons

2014-04-11 Thread Tobias Droste
Consolidate pipe_r300_create_screen, pipe_r600_create_screen and pipe_radeonsi_create_screen to one function. They do exactly the same and only pass a different parameter to radeon_drm_winsys_create. Signed-off-by: Tobias Droste --- This may or may not be an improvement. Pro: Less duplicate code

Re: [Mesa-dev] Mesa git (r600g): OpenGL Error(GL_INVALID_OPERATION): initTexture2D

2014-04-11 Thread Dieter Nützel
Am 17.03.2014 19:07, schrieb Marek Olšák: It would be good to know what's causing the error, so that we can rule out the possibility that the test is wrong and Mesa is right. Marek Hello Marek, Tim and Ian helped me a lot to find a solution. Look here: http://lists.freedesktop.org/archives/me

[Mesa-dev] [PATCH] egl-static: Fix build with only r600 or radeonsi

2014-04-11 Thread Tobias Droste
radeon/drm/radeon_winsys.h and radeon/drm/radeon_drm_public.h are needed for r300, r600 and radeonsi so include them as soon as one of them is selected. Also fix the comment which was probably the cause of the problem in the first place. Signed-off-by: Tobias Droste --- src/gallium/targets/egl-s

[Mesa-dev] [PATCH V2] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-04-11 Thread Chris Forbes
We've been allowing `centroid` and `sample` in all kinds of weird places where they're not valid. Insist that `sample` is combined with `in` or `out`; and that `centroid` is combined with `in`, `out`, or the deprecated `varying`. V2: Validate this in a more sensible place. This does require an ex

Re: [Mesa-dev] [PATCH] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-04-11 Thread Chris Forbes
This is a lame place to put this validation. Will respin something more sensible. On Sat, Apr 12, 2014 at 12:35 PM, Chris Forbes wrote: > We've been allowing `centroid` and `sample` in all kinds of weird places > where they're not valid. > > Insist that `sample` is combined with `in` or `out`; >

Re: [Mesa-dev] [PATCH 00/19] Last of the GL_ARB_separate_shader_objects patches!

2014-04-11 Thread Kenneth Graunke
On 03/27/2014 02:40 PM, Ian Romanick wrote: > This final series finishes up GL_ARB_separate_shader_objects for desktop > OpenGL, and it implements GL_EXT_separate_shader_objects for OpenGL ES. > It also removes GL_EXT_separate_shader_objects from desktop OpenGL. > Note that the two EXT extensions a

[Mesa-dev] [Bug 75797] EGL application crashes with BadDrawable at SwapBuffers

2014-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75797 Kristian Høgsberg changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds - SOLVED

2014-04-11 Thread Dieter Nützel
Am 05.04.2014 08:04, schrieb Timothy Arceri: On Fri, 2014-04-04 at 17:40 -0700, Ian Romanick wrote: On 04/03/2014 05:31 PM, Dieter Nützel wrote: > Am 03.04.2014 22:53, schrieb Ian Romanick: >> On 04/03/2014 07:35 AM, Dieter Nützel wrote: >>> Am 03.04.2014 04:16, schrieb Ian Romanick: On 04/

[Mesa-dev] [Bug 75797] EGL application crashes with BadDrawable at SwapBuffers

2014-04-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75797 Giovanni Campagna changed: What|Removed |Added CC||scampa.giova...@gmail.com --- Commen

[Mesa-dev] [PATCH] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-04-11 Thread Chris Forbes
We've been allowing `centroid` and `sample` in all kinds of weird places where they're not valid. Insist that `sample` is combined with `in` or `out`; and that `centroid` is combined with `in`, `out`, or the deprecated `varying`. Signed-off-by: Chris Forbes --- src/glsl/ast_to_hir.cpp | 18

Re: [Mesa-dev] [PATCH 00/19] Last of the GL_ARB_separate_shader_objects patches!

2014-04-11 Thread Eric Anholt
Ian Romanick writes: > This final series finishes up GL_ARB_separate_shader_objects for desktop > OpenGL, and it implements GL_EXT_separate_shader_objects for OpenGL ES. > It also removes GL_EXT_separate_shader_objects from desktop OpenGL. > Note that the two EXT extensions are completely differe

Re: [Mesa-dev] [PATCH 11/19] glsl: Track explicitly set location independent from the actual location

2014-04-11 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Almost all of the time the location set by layout(location=...) is the > location that will be used for the variable. Vertex shader inputs and > fragment shader outputs, for example, are visible to the API. We just > use those actual settings. > >

Re: [Mesa-dev] [PATCH 10/19] linker: Allow geometry shader without vertex shader for separable programs

2014-04-11 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/linker.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp > index ee07e89..e02ce87 100644 > --- a/src/glsl/linker.cpp > +++ b/src/gls

Re: [Mesa-dev] [PATCH v2 6/6] glsl: Ignore loop-too-large heuristic if there's bad variable indexing.

2014-04-11 Thread Eric Anholt
Kenneth Graunke writes: > Many shaders use a pattern such as: > > for (int i = 0; i < NUM_LIGHTS; i++) { >...access a uniform array, or shader input/output array... > } > > where NUM_LIGHTS is a small constant (such as 2, 4, or 8). > > The expectation is that the compiler will unroll those lo

Re: [Mesa-dev] Preparing for 10.1.1

2014-04-11 Thread Brian Paul
I just tested the 10.1 branch here and it looks good. -Brian On Fri, Apr 11, 2014 at 1:56 PM, Ian Romanick wrote: > Vinson, > > Can you check that the 10.1 branch builds on the configurations that are > important to VMware? There are enough patches brought over that it's > better to err on t

Re: [Mesa-dev] [PATCH] i965/fs: Reset reg_from when we can't coalesce.

2014-04-11 Thread Eric Anholt
Matt Turner writes: > Not setting this would prevented coalescing after a failed attempt if > the sources for both MOVs were the same. > > total instructions in shared programs: 1654531 -> 1650224 (-0.26%) > instructions in affected programs: 423167 -> 418860 (-1.02%) > GAINED:

Re: [Mesa-dev] [PATCH] docs: Expand ARB_gpu_shader5 to describe status of individual features

2014-04-11 Thread Chris Forbes
OK, that simplifies things. Will fix. On Sat, Apr 12, 2014 at 4:04 AM, Ian Romanick wrote: > On 04/09/2014 01:11 AM, Chris Forbes wrote: >> On Wed, Apr 9, 2014 at 7:23 AM, Ian Romanick wrote: >> >>> I believe UBO array indices are also dynamically uniform. >> >> I was surprised to find this when

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move translate_colorswap to common code

2014-04-11 Thread Marek Olšák
The patch is probably not necessary. The same applies to patch 2. Marek On Fri, Apr 11, 2014 at 9:51 PM, Carl Worth wrote: > Marek Olšák writes: >> On Mon, Mar 3, 2014 at 4:19 PM, Alex Deucher wrote: >>> On Sun, Mar 2, 2014 at 8:25 PM, Marek Olšák wrote: From: Marek Olšák Also

Re: [Mesa-dev] Preparing for 10.1.1

2014-04-11 Thread Dylan Baker
On Friday, April 11, 2014 09:33:44 AM Carl Worth wrote: > I'm (finally) getting around to putting together a new stable release. I > apologize it's so late. > > I've just pushed about 66 patches to the 10.1 branch. This includes > almost everything currently on master that was nominated for the st

Re: [Mesa-dev] Preparing for 10.1.1

2014-04-11 Thread Ian Romanick
Vinson, Can you check that the 10.1 branch builds on the configurations that are important to VMware? There are enough patches brought over that it's better to err on the side of caution. It would be a shame to have to ship 10.1.2 two days later with just build fixes. :( On 04/11/2014 09:33 AM,

Re: [Mesa-dev] [PATCH] draw: remove unused 'start' variable in draw_stats_clipper_primitives()

2014-04-11 Thread Ian Romanick
Looking at the whole function, this seems obviously correct. Reviewed-by: Ian Romanick On 04/11/2014 10:47 AM, Brian Paul wrote: > It was computed, but never actually used. > --- > src/gallium/auxiliary/draw/draw_context.c |7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > d

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move translate_colorswap to common code

2014-04-11 Thread Carl Worth
Marek Olšák writes: > On Mon, Mar 3, 2014 at 4:19 PM, Alex Deucher wrote: >> On Sun, Mar 2, 2014 at 8:25 PM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Also translate the Y__X swizzle. >> >> For the series: >> >> Reviewed-by: Alex Deucher >> >> Candidate for the stable trees as part of t

Re: [Mesa-dev] [PATCH 01/20] i965/blorp: Single sample stencil msaa

2014-04-11 Thread Ian Romanick
On 04/11/2014 12:28 AM, Topi Pohjolainen wrote: > Instead of relying on the sampler engine, use the existing sample > coordinate encoding scheme and fetch samples as if the surface is > single sampled. > One unit test gets dropped as it is not compatible anymore. > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] Mesa build instructions

2014-04-11 Thread Eric Anholt
Matt Turner writes: > Someone asked about my Mesa build set up. Rather than sending it > privately I figured I'd post it for posterity on mesa-dev. > > I build with > > CFLAGS="-O2 -march=native -pipe" CXXFLAGS="$CFLAGS" ./autogen.sh > --with-dri-drivers=i965 --with-gallium-drivers= > --with-egl-

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-11 Thread Ian Romanick
On 04/11/2014 10:07 AM, Eric Anholt wrote: > Ian Romanick writes: > >> On 04/07/2014 03:27 PM, Eric Anholt wrote: >>> Ian Romanick writes: >>> On 04/07/2014 09:14 AM, Eric Anholt wrote: > Ian Romanick writes: > >> On 04/04/2014 05:52 PM, Matt Turner wrote: >>> On Fri, Apr 4

Re: [Mesa-dev] [PATCH] add a bugfix in 10.2 release notes

2014-04-11 Thread Benjamin Bellec
Oh OK, I wasn't aware of this process and script. That said, the commit that fixed the bug was not intended to. And it will not be caught by the script. Noted for git send-email. Benjamin Le 11/04/2014 20:24, Emil Velikov a écrit : > On 11/04/14 19:07, Benjamin Bellec wrote: >> Signed-off-by: Be

Re: [Mesa-dev] [PATCH] add a bugfix in 10.2 release notes

2014-04-11 Thread Emil Velikov
On 11/04/14 19:07, Benjamin Bellec wrote: > Signed-off-by: Benjamin Bellec > Hi Benjamin, The bugfixes section is generated as part of the release process, and is automated via the bin/bugzilla_mesa.sh script, so I do not think that "we're ready" for this patch yet :) For a future reference can

Re: [Mesa-dev] EXTERNAL: Re: R600/OpenCL - kernel_param resource

2014-04-11 Thread Dorrington, Albert
I think that is the case. I added the following to evergreen_delete_compute_state() to clean it up, and it seems to have helped. if (shader->kernel_param) { pipe_resource_reference((struct pipe_resource**)&shader->kernel_param, NULL); } I discovered the functionality of the GALLIUM_REFC

[Mesa-dev] [PATCH] add a bugfix in 10.2 release notes

2014-04-11 Thread Benjamin Bellec
Signed-off-by: Benjamin Bellec diff --git a/docs/relnotes/10.2.html b/docs/relnotes/10.2.html index da79e7d..05fd502 100644 --- a/docs/relnotes/10.2.html +++ b/docs/relnotes/10.2.html @@ -51,7 +51,11 @@ Note: some of the new features are only available with certain drivers. Bug fixes -TBD. +

[Mesa-dev] [PATCH] draw: remove unused 'start' variable in draw_stats_clipper_primitives()

2014-04-11 Thread Brian Paul
It was computed, but never actually used. --- src/gallium/auxiliary/draw/draw_context.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_context.c b/src/gallium/auxiliary/draw/draw_context.c index da1e958..0a67879 100644 --- a/src/galli

[Mesa-dev] Mesa build instructions

2014-04-11 Thread Matt Turner
Someone asked about my Mesa build set up. Rather than sending it privately I figured I'd post it for posterity on mesa-dev. I build with CFLAGS="-O2 -march=native -pipe" CXXFLAGS="$CFLAGS" ./autogen.sh --with-dri-drivers=i965 --with-gallium-drivers= --with-egl-platforms=x11,drm --enable-glx-tls -

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-11 Thread Eric Anholt
Ian Romanick writes: > On 04/07/2014 03:27 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> On 04/07/2014 09:14 AM, Eric Anholt wrote: Ian Romanick writes: > On 04/04/2014 05:52 PM, Matt Turner wrote: >> On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick >> wrote: >>

[Mesa-dev] [PATCH] winsys/radeon: consolidate hash table lookup

2014-04-11 Thread Marek Olšák
From: Marek Olšák I should have done this long ago. --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 110 +++--- src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 7 +- 2 files changed, 49 insertions(+), 68 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_dr

[Mesa-dev] Preparing for 10.1.1

2014-04-11 Thread Carl Worth
I'm (finally) getting around to putting together a new stable release. I apologize it's so late. I've just pushed about 66 patches to the 10.1 branch. This includes almost everything currently on master that was nominated for the stable branch. There are a handful of patches which I didn't cherry-

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-11 Thread Ian Romanick
On 04/07/2014 03:27 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 04/07/2014 09:14 AM, Eric Anholt wrote: >>> Ian Romanick writes: >>> On 04/04/2014 05:52 PM, Matt Turner wrote: > On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick wrote: >> Fast forwarding 3 months from the 10.1

Re: [Mesa-dev] [PATCH] docs: Expand ARB_gpu_shader5 to describe status of individual features

2014-04-11 Thread Ian Romanick
On 04/09/2014 01:11 AM, Chris Forbes wrote: > On Wed, Apr 9, 2014 at 7:23 AM, Ian Romanick wrote: > >> I believe UBO array indices are also dynamically uniform. > > I was surprised to find this when building the list too, but I believe > it's unrestricted. > > The GLSL 4.0 spec, 4.3.7 p43 (bott

Re: [Mesa-dev] [PATCH 1/4] swrast: fix more fetch_texel function names

2014-04-11 Thread Ian Romanick
Patches 1 through 3 are Reviewed-by: Ian Romanick On 04/10/2014 06:04 PM, Brian Paul wrote: > These were missed/typo'd in the previous patch series: > s/R8G8B8A/R8G8B8A8/ > s/rgba_16/RGBA_UNORM16/ > s/rgba_uint/RGBA_UINT/ > s/rgba_int/RGBA_SINT/ > --- > src/mesa/swrast/s_texfetch.c | 48

Re: [Mesa-dev] [PATCH] softpipe: fix shadow sampling and remove nonsensical approximation of linear interpolation behavior for shadow samplers.

2014-04-11 Thread Ian Romanick
On 04/11/2014 12:14 AM, Janzing, Heinrich wrote: > Shadow sampling appeared to be fundamentally broken; fix in attachment. In the future, please only send patches using git-send-email. With most e-mail programs, it is impossible to give in-line comments with attachments. > __

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix incorrect indentation.

2014-04-11 Thread Ian Romanick
Oof... that's a giant wall of text. :( I skimmed this patch, and it mostly looks right. I made a couple comments below. I've pruned out hunks that did not have comments. On 04/11/2014 03:52 AM, Iago Toral Quiroga wrote: > --- > src/glsl/ast_to_hir.cpp | 1344 > +++-

Re: [Mesa-dev] R600/OpenCL - kernel_param resource

2014-04-11 Thread Tom Stellard
On Thu, Apr 10, 2014 at 03:24:32PM +, Dorrington, Albert wrote: > I am having an issue with a memory leak in an OpenCL program I am testing. > In the program I call the same kernel repeatedly, for every pixel in an > image. (Probably not the most efficient code, but it is a learning/testing >

Re: [Mesa-dev] [RFC] r600g/radeonsi: Use caching buffer manager for textures as well

2014-04-11 Thread Marek Olšák
After some discussion, this seems to be a good idea. BTW I'd like to keep the use_reusable_pool parameter in case we change our opinion. Reviewed-by: Marek Olšák Marek On Thu, Apr 10, 2014 at 11:23 AM, Michel Dänzer wrote: > From: Michel Dänzer > > --- > > This is just an RFC; if other develo

Re: [Mesa-dev] [PATCH 1/5] i965: Add writes_accumulator flag

2014-04-11 Thread Juha-Pekka Heikkilä
I did today run these patches against piglit glsl tests and there was no regressions. I did go testing write the attached patch on top of this set, it change MULs with explicit accumulator write into implicit accumulator write. I guess what Eric said mean something like the attached patch is needed

Re: [Mesa-dev] [PATCH] softpipe: fix shadow sampling and remove nonsensical approximation of linear interpolation behavior for shadow samplers.

2014-04-11 Thread Brian Paul
On 04/11/2014 01:14 AM, Janzing, Heinrich wrote: Shadow sampling appeared to be fundamentally broken; fix in attachment. Reviewed-by: Brian Paul Piglit tests seem OK too. Do you need me to commit this for you? -Brian ___ mesa-dev mailing list me

[Mesa-dev] [PATCH 0/2] glsl: Emit warning if a var declaration shadows one at a higher scope

2014-04-11 Thread Iago Toral Quiroga
Implements a FIXME in ast_to_hir.cpp. The second patch fixes indentation in ast_to_hir.cpp. It was mixing blanks and tabs all over the place making some parts of the code really difficult to read. Iago Toral Quiroga (2): glsl: Emit warning if a var declaration shadows one at a higher scope. g

[Mesa-dev] [PATCH 1/2] glsl: Emit warning if a var declaration shadows one at a higher scope.

2014-04-11 Thread Iago Toral Quiroga
--- src/glsl/ast_to_hir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 8d55ee3..b70b628 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -3180,10 +3180,6 @@ ast_declarator_list::hir(exe

Re: [Mesa-dev] [PATCH] gallium/targets: #include radeon_winsys.h in a couple of more places

2014-04-11 Thread Marek Olšák
Thanks. Reviewed-by: Marek Olšák Marek On Fri, Apr 11, 2014 at 5:21 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes the build since Marek's recent radeon winsys reorganization. > > Signed-off-by: Michel Dänzer > --- > src/gallium/targets/egl-static/egl_pipe.c | 1 + > src/gal

Re: [Mesa-dev] [PATCH] i965: fix MakeCurrent when switching a context between multiple drawables.

2014-04-11 Thread Iago Toral
On Thu, 2014-04-10 at 12:22 -0700, Ian Romanick wrote: > On 04/10/2014 03:39 AM, Iago Toral wrote: > > On Thu, 2014-04-10 at 10:31 +0200, Iago Toral wrote: > >> Hi Kristian, > >> > >> On Tue, 2014-04-08 at 10:14 -0700, Kristian Høgsberg wrote: > >>> On Mon, Apr 7, 2014 at 9:24 AM, Eric Anholt wrot

[Mesa-dev] [PATCH 07/20] i965/vec4: Use unsigned instead of signed for visitor uniform count

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 12 ++-- src/mesa/drivers/dri/i965/brw_vec4.h | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 2 +- 4 files changed, 11 ins

[Mesa-dev] [PATCH 11/20] i965/fs: Move emission of ALUs into fs_emitter

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 89 src/mesa/drivers/dri/i965/brw_fs.h | 63 ++-- src/mesa/drivers/dri/i965/brw_fs_emitter.cpp | 88 +++ 3 files changed, 120 insertion

[Mesa-dev] [PATCH 15/20] i965/fs: Add support for linear to W-tiled coordinate translation

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 8 +++ src/mesa/drivers/dri/i965/brw_fs_emitter.cpp | 86 2 files changed, 94 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index

[Mesa-dev] [PATCH 13/20] i965/fs: Add generator support for simd16 math as 2x simd8

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index e590bdf..27f49d2 100644 --- a/s

[Mesa-dev] [PATCH 04/20] i965: Split emitter out of backend_visitor

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_cfg.cpp| 8 src/mesa/drivers/dri/i965/brw_cfg.h | 4 ++-- src/mesa/drivers/dri/i965/brw_dead_control_flow.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_dead_control_flow.h| 2 +- s

[Mesa-dev] [PATCH 19/20] i965: Expose the linear offset calculation of W-tiled stencil

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tr

[Mesa-dev] [PATCH 06/20] i965: Merge max_grf between stage compilers

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h| 2 -- src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 - src/mesa/drivers/dri/i965/brw_shader.cpp | 3 ++- src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 12/20] i965/blorp: Use fs_emitter

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 340 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 28 +- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 110 +--- 3 files changed, 189 insertions(+), 289 deletions(-) diff

[Mesa-dev] [PATCH 17/20] i965/blorp: Increase the scope for the coordinate accessors

2014-04-11 Thread Topi Pohjolainen
These will be used in the main dispatcher of the compiler. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 34 ++-- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/

[Mesa-dev] [PATCH 02/20] i965/blorp: Use program to offset W-tiled into correct level/layer

2014-04-11 Thread Topi Pohjolainen
Once the logic is changed to treat the surface as linear one cannot use the hardware for the layer/level shift anymore. Sampler engine would try to base the calculation on linear layout which wouldn't match the W-tiled. Similarly shifting the start address of the surface wouldn't suffice as it coul

[Mesa-dev] [PATCH 05/20] i965: Merge memory context allocation for shader visitors

2014-04-11 Thread Topi Pohjolainen
Such like fs_visitor the dynamic data generated by vec4_visitor does not have lifecycle longer than the visitor itself. Hence it can be taken cared of by the common base. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 -- src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 08/20] i965: Merge common members of visitors

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 19 --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 19 --- src/mesa/drivers/dri/i965/brw_shader.cpp | 18 +- src/mesa/drivers/dri/i965/brw_shader.h

[Mesa-dev] [PATCH 01/20] i965/blorp: Single sample stencil msaa

2014-04-11 Thread Topi Pohjolainen
Instead of relying on the sampler engine, use the existing sample coordinate encoding scheme and fetch samples as if the surface is single sampled. One unit test gets dropped as it is not compatible anymore. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 12 +- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 20/20] i965/blorp: Translate w-tiling into linear instead of into Y-tiling

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 10 ++-- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 90 +++- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 10 +--- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 10 +--- 4 files chang

[Mesa-dev] [PATCH 18/20] i965/blorp: Add source and destination strides into push constants

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h| 4 +++- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 8 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h index

[Mesa-dev] [PATCH 10/20] i965/fs: Split LIR emission ouf of ir-visitor

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 44 --- src/mesa/drivers/dri/i965/brw_fs.h | 53 - src/mesa/drivers/dri/i965/brw_fs_emitter.cpp | 110 ++

[Mesa-dev] [PATCH 09/20] i965: Merge fail() for ir visitors

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 30 src/mesa/drivers/dri/i965/brw_fs.h | 2 -- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_shader.cpp | 38 +++

[Mesa-dev] [PATCH 14/20] i965/fs: Add support for W-tiled coordinate swizzling

2014-04-11 Thread Topi Pohjolainen
--- src/mesa/drivers/dri/i965/brw_fs.h | 4 src/mesa/drivers/dri/i965/brw_fs_emitter.cpp | 23 +++ 2 files changed, 27 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 26e5545..a30351d 100644 --- a/src/me

[Mesa-dev] [PATCH 16/20] i965/fs: Add support for W-tiled to linear coordinate translation

2014-04-11 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 8 +++ src/mesa/drivers/dri/i965/brw_fs_emitter.cpp | 93 2 files changed, 101 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h inde

[Mesa-dev] [PATCH 03/20] i965/blorp: Drop unnecessary tile offset calculator

2014-04-11 Thread Topi Pohjolainen
Now that blorp program offsets w-tiled internally, the surface setup support is not needed anymore. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 26 -- src/mesa/drivers/dri/i965/brw_blorp.h| 2 -- src/mesa/drivers/dri/i965/br

[Mesa-dev] Map W-tiled as linear instead of as Y-tiled for i965-blorp

2014-04-11 Thread Topi Pohjolainen
Patches one and two prepare for the mapping change. Once the surface is configured as linear one cannot use hardware msaa support anymore, and the offsets to the miplevels/layers wouldn't match between linear and W-tiled within the 64x64 tiles. Fortunately the blorp blit program can be adjusted wit

[Mesa-dev] [PATCH] softpipe: fix shadow sampling and remove nonsensical approximation of linear interpolation behavior for shadow samplers.

2014-04-11 Thread Janzing, Heinrich
Shadow sampling appeared to be fundamentally broken; fix in attachment. 0001-softpipe-fix-shadow-sampling-and-remove-nonsensical-.patch Description: 0001-softpipe-fix-shadow-sampling-and-remove-nonsensical-.patch ___ mesa-dev mailing list mesa-dev@lists