Re: [Mesa-dev] [PATCH 1/2] glsl: remove {add, get}_type_ast from glsl_symbol_table

2014-03-25 Thread Matt Turner
On Tue, Mar 25, 2014 at 9:52 PM, Chia-I Wu wrote: > They are not needed since 0da1a2cc369052643ccaea75a1722cc37652d82a. > --- Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinf

[Mesa-dev] [PATCH 2/2] glsl: remove UBO fields from _mesa_glsl_parse_state

2014-03-25 Thread Chia-I Wu
They are not needed since 514f8c7ec7cc1ab18be93cebb5b9bf970b1955a9. --- src/glsl/glsl_parser_extras.cpp | 10 -- src/glsl/glsl_parser_extras.h | 4 src/mesa/main/mtypes.h | 3 +-- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/src/glsl/glsl_parser_extras.c

[Mesa-dev] [PATCH 1/2] glsl: remove {add, get}_type_ast from glsl_symbol_table

2014-03-25 Thread Chia-I Wu
They are not needed since 0da1a2cc369052643ccaea75a1722cc37652d82a. --- src/glsl/glsl_parser.yy| 1 - src/glsl/glsl_symbol_table.cpp | 25 - src/glsl/glsl_symbol_table.h | 2 -- 3 files changed, 28 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/gl

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Roland Scheidegger
Am 26.03.2014 03:29, schrieb Marek Olšák: > My reasoning was that it would be better to specify a raw clear value > and clear value size for buffers, which are always untyped, and > pipe_color_union for textures, which are always typed, so that drivers > can easily implement the texture clearing on

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Marek Olšák
The first 2 patches are: Reviewed-by: Marek Olšák Marek On Wed, Mar 26, 2014 at 12:23 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > v1 -> v2: add docs section to context.rst > > src/gallium/docs/source/context.rst | 5 + > src/gallium/include/pipe/p_context.h | 11 +

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Marek Olšák
My reasoning was that it would be better to specify a raw clear value and clear value size for buffers, which are always untyped, and pipe_color_union for textures, which are always typed, so that drivers can easily implement the texture clearing on top of pipe_context::clear. I also suggested tha

[Mesa-dev] [PATCH 3/3] i965: Support rendering to RGBX formats in general.

2014-03-25 Thread Kenneth Graunke
Previously, we supported rendering to B8G8R8X8_UNORM by overriding the rendering format to B8G8R8A8_UNORM. However, we didn't support any other formats, such as R8G8B8X8_UNORM. This patch adds format overrides for all other RGBX formats, making them renderable (assuming the equivalent RGBA format

[Mesa-dev] [PATCH 2/3] i965: Use _mesa_format_x_to_a to support more X -> A blits.

2014-03-25 Thread Kenneth Graunke
There's really no reason to limit ourselves to a single format; the technique works just as well for any format in this family. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 ++ src/mesa/drivers/dri/i965/intel_blit.c | 16 +++- 2 f

[Mesa-dev] [PATCH 1/3] mesa: Add a new _mesa_format_x_to_a() function.

2014-03-25 Thread Kenneth Graunke
This translates RGBX formats to the equivalent RGBA format. Signed-off-by: Kenneth Graunke --- src/mesa/main/formats.c | 57 + src/mesa/main/formats.h | 3 +++ 2 files changed, 60 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/main

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Ilia Mirkin
On Tue, Mar 25, 2014 at 7:57 PM, Brian Paul wrote: > On 03/25/2014 05:23 PM, Ilia Mirkin wrote: >> >> Signed-off-by: Ilia Mirkin >> --- >> >> v1 -> v2: add docs section to context.rst >> >> src/gallium/docs/source/context.rst | 5 + >> src/gallium/include/pipe/p_context.h | 11 ++

[Mesa-dev] [PATCH V3 09/10] mesa: Add support to unpack depth-stencil texture in to FLOAT_32_UNSIGNED_INT_24_8_REV

2014-03-25 Thread Anuj Phogat
V2: Follow the new naming convention for unpack functions. Use double precision for converting Z24 to a float. V3: Unpack stencil value to most significant byte. Use 'struct z32f_x24s8' type. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/format_unpack.c | 80

Re: [Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Brian Paul
On 03/25/2014 05:23 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- v1 -> v2: add docs section to context.rst src/gallium/docs/source/context.rst | 5 + src/gallium/include/pipe/p_context.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/src/gallium/docs/sourc

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 --- Comment #8 from Dâniel Fraga --- (In reply to comment #7) > A crucial piece of information you could have mentioned earlier :) I completely forgot it ;) Sorry. > As Matt hinted, mesa is not to blame about "I'm using this hack as some > oth

Re: [Mesa-dev] [PATCH 1/2] mesa: Move TextureView layer error checks before dimension checking.

2014-03-25 Thread Ian Romanick
On 03/20/2014 02:18 AM, Kenneth Graunke wrote: > If the number of layers is invalid, we're supposed to return > INVALID_VALUE. _mesa_legal_texture_dimensions detects some of these > cases (i.e. number of layers not being divisible by 6 for cubes), but > results in an INVALID_OPERATION error (which

Re: [Mesa-dev] [PATCH] mapi/glapi: Use ElementTree instead of libxml2.

2014-03-25 Thread Ian Romanick
On 03/25/2014 09:34 AM, jfons...@vmware.com wrote: > From: José Fonseca > > It is quite hard to meet the dependency of the libxml2 python bindings > out side Linux, and in particularly on MacOSX; whereas ElementTree is > part of Python's standard library. ElementTree is more limited than > libxm

[Mesa-dev] [PATCHv2 3/3] nv50: implement clear_buffer to accelerate ARB_clear_buffer_object

2014-03-25 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: no change src/gallium/drivers/nouveau/nv50/nv50_surface.c | 111 1 file changed, 111 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_surface.c b/src/gallium/drivers/nouveau/nv50/nv50_surface.c index 612649b..52

[Mesa-dev] [PATCHv2 2/3] mesa/st: Accelerate ARB_clear_buffer_object with clear_buffer

2014-03-25 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: mark zeros as static const data, change line wrapping src/mesa/main/bufferobj.c| 6 +++--- src/mesa/main/bufferobj.h| 7 +++ src/mesa/state_tracker/st_cb_bufferobjects.c | 28 3 f

[Mesa-dev] [PATCHv2 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: add docs section to context.rst src/gallium/docs/source/context.rst | 5 + src/gallium/include/pipe/p_context.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/src/gallium/docs/source/context.rst b/src/gallium/docs/source/context

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 Emil Velikov changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Roland Scheidegger
Am 25.03.2014 23:48, schrieb Ilia Mirkin: > On Tue, Mar 25, 2014 at 6:32 PM, Roland Scheidegger > wrote: >> Am 25.03.2014 22:36, schrieb Ilia Mirkin: >>> Signed-off-by: Ilia Mirkin >>> --- >>> src/gallium/include/pipe/p_context.h | 11 +++ >>> 1 file changed, 11 insertions(+) >>> >>> di

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 --- Comment #6 from Matt Turner --- (In reply to comment #5) > Or Mesa should put CPPFLAGS *after* their own include paths? Maybe this > would avoid this problem when user sets CPPFLAGS? If the user sets his own CPPFLAGS, he gets whatever is the

Re: [Mesa-dev] [PATCH] Channels alive in fast clear

2014-03-25 Thread Kenneth Graunke
On 03/24/2014 11:37 PM, Kevin Rogovin wrote: > When deciding if a clear color is suitable for fast clear, > take into account if a color channel is active in the > buffer format. > > --- > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[Mesa-dev] [PATCH V3 03/10] mesa: Add error condition for integer formats in glGetTexImage()

2014-03-25 Thread Anuj Phogat
OpenGL 4.0 spec, page 306 suggests an INVALID_OPERATION in glGetTexImage if : "format is one of the integer formats in table 3.3 and the internal format of the texture image is not integer, or format is not one of the integer formats in table 3.3 and the internal format is integer." V2:

Re: [Mesa-dev] [PATCH 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Ilia Mirkin
On Tue, Mar 25, 2014 at 6:32 PM, Roland Scheidegger wrote: > Am 25.03.2014 22:36, schrieb Ilia Mirkin: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/include/pipe/p_context.h | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/src/gallium/include/pipe/p_context.h >> b/

Re: [Mesa-dev] [PATCH 2/3] mesa/st: Accelerate ARB_clear_buffer_object with clear_buffer

2014-03-25 Thread Brian Paul
On 03/25/2014 03:36 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- Note that this also ensures that the clear size is passed through even when the data is null. This preserves the validation done to make sure that size % clear size == 0. src/mesa/main/bufferobj.c|

Re: [Mesa-dev] [Mesa-stable] [PATCH 2.5/10] mesa: Add helper function _mesa_is_format_integer()

2014-03-25 Thread Brian Paul
On 03/25/2014 03:59 PM, Anuj Phogat wrote: This function will be used in the following patch. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/formats.c | 9 + src/mesa/main/formats.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/main/f

Re: [Mesa-dev] [PATCH 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Roland Scheidegger
Am 25.03.2014 22:36, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > src/gallium/include/pipe/p_context.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/gallium/include/pipe/p_context.h > b/src/gallium/include/pipe/p_context.h > index fe3045a..bf27285 100644

Re: [Mesa-dev] [PATCH] mesa: Move declaration before code

2014-03-25 Thread Brian Paul
Thanks, but I already pushed a fix for this earlier. -Brian On 03/25/2014 04:23 PM, Ian Romanick wrote: From: Ian Romanick Should fix MSVC build: src\mesa\main\pipelineobj.c(250) : error C2275: 'GLbitfield' : illegal use of this type as an expression C:\hudson\workspace\mesa-msvc\i

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 --- Comment #5 from Dâniel Fraga --- (In reply to comment #4) > Dâniel I'm kind of struggling to see(tested as well) how on earth did the > system header got included in your case, pending any funny options during > the compilation of gcc (other

[Mesa-dev] [PATCH] mesa: Move declaration before code

2014-03-25 Thread Ian Romanick
From: Ian Romanick Should fix MSVC build: src\mesa\main\pipelineobj.c(250) : error C2275: 'GLbitfield' : illegal use of this type as an expression C:\hudson\workspace\mesa-msvc\include\GL/gl.h(127) : see declaration of 'GLbitfield' src\mesa\main\pipelineobj.c(250) : error C2146: syntax

Re: [Mesa-dev] [PATCHv3] configure: enable dri3 only for linux

2014-03-25 Thread Ian Romanick
On 03/25/2014 02:47 PM, Emil Velikov wrote: > On 21/03/14 18:09, Emil Velikov wrote: >> Currently only linux can make use of dri3, so it would make sense to >> enable it explicitly for the platform. >> Drop a duplicated libudev check while we're at it. >> >> v3: Properly handle dri3 and reword comm

[Mesa-dev] [PATCH V2 09/10] mesa: Add support to unpack depth-stencil texture in to FLOAT_32_UNSIGNED_INT_24_8_REV

2014-03-25 Thread Anuj Phogat
V2: Follow the new naming convention for unpack functions. Use double precision for converting Z24 to a float. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/format_unpack.c | 86 ++- src/mesa/main/format_unpack.h | 5 +++ 2 files changed, 90 inser

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 --- Comment #4 from Emil Velikov --- Seems like gcc does not handle include directives as I though it would. The only difference quoted vs angle brackets make is an extra searches for the header in the folder containing the source file. One can

[Mesa-dev] [PATCH V2 03/10] mesa: Add error condition for integer formats in glGetTexImage()

2014-03-25 Thread Anuj Phogat
OpenGL 4.0 spec, page 306 suggests an INVALID_OPERATION in glGetTexImage if : "format is one of the integer formats in table 3.3 and the internal format of the texture image is not integer, or format is not one of the integer formats in table 3.3 and the internal format is integer." V2:

[Mesa-dev] [PATCH 2.5/10] mesa: Add helper function _mesa_is_format_integer()

2014-03-25 Thread Anuj Phogat
This function will be used in the following patch. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/formats.c | 9 + src/mesa/main/formats.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index fb2501c..5c67011 100644 --- a/src

Re: [Mesa-dev] [PATCHv3] configure: enable dri3 only for linux

2014-03-25 Thread Emil Velikov
On 21/03/14 18:09, Emil Velikov wrote: > Currently only linux can make use of dri3, so it would make sense to > enable it explicitly for the platform. > Drop a duplicated libudev check while we're at it. > > v3: Properly handle dri3 and reword commit message. > Would there be any objections if I

Re: [Mesa-dev] [PATCH 00/16] DRI*extension cleanups v3

2014-03-25 Thread Emil Velikov
Hello gents, Can anyone take a look at this series. It's kind of blocking the query-renderer support + a cleanup series that I have locally. Thanks Emil On 16/03/14 13:48, Emil Velikov wrote: > Hi all, > > Here is the third iteration of some DRI*extension cleanup patches. > > This revision add

[Mesa-dev] [PATCH 3/3] nv50: implement clear_buffer to accelerate ARB_clear_buffer_object

2014-03-25 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- This passed all the arb_clear_buffer_object tests. (And it failed a bunch of them until I realized I had to pass the pitch in and not the width for RT_HORIZ.) Presumably one could be clever and try to factor the number of elements instead of just rounding, but this

[Mesa-dev] [PATCH 1/3] gallium: add interface to clear buffers

2014-03-25 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/include/pipe/p_context.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index fe3045a..bf27285 100644 --- a/src/gallium/include/pipe/p_context.h +++ b/src/gall

[Mesa-dev] [PATCH 2/3] mesa/st: Accelerate ARB_clear_buffer_object with clear_buffer

2014-03-25 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- Note that this also ensures that the clear size is passed through even when the data is null. This preserves the validation done to make sure that size % clear size == 0. src/mesa/main/bufferobj.c| 6 +++--- src/mesa/main/bufferobj.h

Re: [Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-25 Thread Kenneth Graunke
On 03/25/2014 11:27 AM, Eric Anholt wrote: > The implementation kept a page-sized area for uploading data, and > uploaded chunks from that to a 64kb-sized streamed buffer. This wasted > cache footprint (and extra state tracking to do so) when we want to just > write our data into the buffer immedi

[Mesa-dev] [Bug 76602] [llvmpipe] [softpipe] piglit draw-pixels regression

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76602 --- Comment #3 from Brian Paul --- OK, thanks Chris. I hate it when a test passes with one driver but not another like this. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 2/2] i965: Use intel_upload_map/unmap for pull constant uploads.

2014-03-25 Thread Kenneth Graunke
On 03/25/2014 11:27 AM, Eric Anholt wrote: > This also happens to fix a leak of the current GS pull constant BO on > context destroy, by just not holding on to the pull const bos after the > surface state is generated. We should fix that separately so we have a patch which can be cherry-picked to

[Mesa-dev] [Bug 76602] [llvmpipe] [softpipe] piglit draw-pixels regression

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76602 --- Comment #2 from Chris Forbes --- This works on i965 and swrast. I don't usually build softpipe or llvmpipe, so I didn't see this problem. Let's revert it for now, though. I'll continue unraveling the breakage this is exposing and propose a n

[Mesa-dev] [Bug 76602] [llvmpipe] [softpipe] piglit draw-pixels regression

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76602 --- Comment #1 from Brian Paul --- Chris, how about reverting your patch? I assumed you tested your change with piglit. Let's be more careful about that in the future. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 2/2] st/mesa: improve sampler view handling

2014-03-25 Thread Brian Paul
Minor nits below. On 03/25/2014 11:28 AM, Christian König wrote: From: Christian König Keep a dynamically increasing array of all the views created for a texture instead of just the last one. Signed-off-by: Christian König --- src/mesa/state_tracker/st_atom_sampler.c | 21 --- src

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix sampler view handling with shared textures v4

2014-03-25 Thread Brian Paul
On 03/25/2014 11:28 AM, Christian König wrote: From: Christian König Release the references to the sampler views before destroying the pipe context. v2: remove TODO and unrelated change v3: move to st_texture.[ch], rename callback, add comment v4: fix rebase mess up and add further cleanups S

Re: [Mesa-dev] [PATCH 01/10] mesa: Add entry for extension ARB_texture_stencil8

2014-03-25 Thread Anuj Phogat
On Tue, Mar 25, 2014 at 11:41 AM, Ian Romanick wrote: > On 03/21/2014 03:01 PM, Anuj Phogat wrote: >> Cc: > > Why is this tagged for stable? [Patch 2 / 10] is a bug fix tagged for stable and it requires this change. > >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/main/mtypes.h | 1 + >> 1 f

[Mesa-dev] [Bug 75797] EGL application crashes with BadDrawable at SwapBuffers

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75797 --- Comment #2 from Armin K --- Is this patch submitted to mesa-dev list? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH 00/14] Klocwork patches

2014-03-25 Thread Juha-Pekka Heikkilä
On Tue, Mar 25, 2014 at 7:46 PM, Matt Turner wrote: > On Tue, Mar 25, 2014 at 5:40 AM, Juha-Pekka Heikkila > wrote: >> Again fixed my Klocwork set. I reworked Ian's patch because my set depend on >> it and Ian's patch seem to have vanished in the void. It needed a small >> update >> because it w

[Mesa-dev] [PATCH 1/2] i965: Massively simplify the intel_upload implementation.

2014-03-25 Thread Eric Anholt
The implementation kept a page-sized area for uploading data, and uploaded chunks from that to a 64kb-sized streamed buffer. This wasted cache footprint (and extra state tracking to do so) when we want to just write our data into the buffer immediately. Instead, build it around an interface like

Re: [Mesa-dev] [PATCH 01/10] mesa: Add entry for extension ARB_texture_stencil8

2014-03-25 Thread Ian Romanick
On 03/21/2014 03:01 PM, Anuj Phogat wrote: > Cc: Why is this tagged for stable? > Signed-off-by: Anuj Phogat > --- > src/mesa/main/mtypes.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index a0d893c..0b754b1 100644 > --- a/src/mesa

[Mesa-dev] [PATCH 2/2] i965: Use intel_upload_map/unmap for pull constant uploads.

2014-03-25 Thread Eric Anholt
This also happens to fix a leak of the current GS pull constant BO on context destroy, by just not holding on to the pull const bos after the surface state is generated. No statistically significant performance difference on GLB2.7 on HSW at 1024x768 (n=40) or 320x240 (n=44), or on BYT at 320x240

Re: [Mesa-dev] [PATCH v2] i965: fix dma_buf import with non-zero offset.

2014-03-25 Thread Gwenole Beauchesne
Pushed to git master after r-b on IRC (#intel-gfx) a few days ago. Thanks. 2014-03-14 18:46 GMT+01:00 Gwenole Beauchesne : > Fix eglCreateImage() from a packed dma_buf surface with a non-zero offset > to pixels data. In particular, this fixes support for planar YUV surfaces > when they are individ

Re: [Mesa-dev] [PATCH 00/14] Klocwork patches

2014-03-25 Thread Matt Turner
On Tue, Mar 25, 2014 at 5:40 AM, Juha-Pekka Heikkila wrote: > Again fixed my Klocwork set. I reworked Ian's patch because my set depend on > it and Ian's patch seem to have vanished in the void. It needed a small update > because it was breaking "make check". I already reviewed a hand-full of the

Re: [Mesa-dev] [PATCH] mapi/glapi: Use ElementTree instead of libxml2.

2014-03-25 Thread Matt Turner
On Tue, Mar 25, 2014 at 9:34 AM, wrote: > diff --git a/configure.ac b/configure.ac > index c5042f9..04bf711 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -54,7 +54,6 @@ AM_PROG_CC_C_O > AM_PROG_AS > AC_CHECK_PROGS([MAKE], [gmake make]) > AC_CHECK_PROGS([PYTHON2], [python2 python]) > -A

Re: [Mesa-dev] RFC: Fixing XBMC crash with NV_vdpau_interop

2014-03-25 Thread Christian König
Am 24.03.2014 18:54, schrieb Roland Scheidegger: Am 23.03.2014 12:36, schrieb Christian König: Am 22.03.2014 23:33, schrieb Brian Paul: On Sat, Mar 22, 2014 at 2:49 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: Hi guys, recently some XBMC users complained about crashes

Re: [Mesa-dev] [PATCH 1/3] st/mesa: recreate sampler view on context change v2

2014-03-25 Thread Christian König
Will you try to implement the linked list? Sure, shouldn't be to much of a problem. It actually turned out to be easier as a small dynamically resized array. Patches are on the list CCing you, please review. Thanks, Christian. Am 24.03.2014 17:56, schrieb Christian König: Am 24.03.2014

[Mesa-dev] [PATCH 1/2] st/mesa: fix sampler view handling with shared textures v4

2014-03-25 Thread Christian König
From: Christian König Release the references to the sampler views before destroying the pipe context. v2: remove TODO and unrelated change v3: move to st_texture.[ch], rename callback, add comment v4: fix rebase mess up and add further cleanups Signed-off-by: Christian König Cc: "10.0 10.1" -

[Mesa-dev] [PATCH 2/2] st/mesa: improve sampler view handling

2014-03-25 Thread Christian König
From: Christian König Keep a dynamically increasing array of all the views created for a texture instead of just the last one. Signed-off-by: Christian König --- src/mesa/state_tracker/st_atom_sampler.c | 21 --- src/mesa/state_tracker/st_atom_texture.c | 53 +--

[Mesa-dev] [Bug 76601] New: [llvmpipe] [softpipe] piglit glean pixelFormats regression

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76601 Priority: medium Bug ID: 76601 Keywords: regression CC: bri...@vmware.com, chr...@ijw.co.nz Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] [softpipe] piglit glean p

[Mesa-dev] [PATCH] mapi/glapi: Use ElementTree instead of libxml2.

2014-03-25 Thread jfonseca
From: José Fonseca It is quite hard to meet the dependency of the libxml2 python bindings out side Linux, and in particularly on MacOSX; whereas ElementTree is part of Python's standard library. ElementTree is more limited than libxml2: no DTD verification, defaults from DTD, or XInclude support

Re: [Mesa-dev] [PIGLIT,radeonsi] crash in spec/glsl-1.50/execution/geometry/max-input-components – who's bug is it?

2014-03-25 Thread Kai Wasserbäch
Brian Paul schrieb am 24.03.2014 15:45: > On 03/22/2014 01:53 PM, Kai Wasserbäch wrote: >> Dear Mesa devs, >> I'm not sure whether this is a bug in Mesa, LLVM or in eglibc. The crash >> happens >> in _int_malloc, but since that is certainly one of the more often used >> functions, I'm not yet conv

[Mesa-dev] [Bug 76489] Mesa git (011569b5b7) compilation issue: render2.c:49:4: error: implicit declaration of function '__glMap1d_size' [-Werror=implicit-function-declaration]

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76489 Emil Velikov changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] gallivm: fix no-op n:n lp_build_resize()

2014-03-25 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > This can get called in some circumstances if both src type and dst type > have same width (seen with float32->unorm32). While this particular case > was bogus anyway let's just fix that as it can work trivially (due to the > way it was

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 --- Comment #3 from Dâniel Fraga --- (In reply to comment #2) > Created attachment 96363 [details] [review] > egl: do not use system egl headers, make use of the one we provide > > Well this is kind of our fault as well. We should not be includi

[Mesa-dev] [Bug 76489] Mesa git (011569b5b7) compilation issue: render2.c:49:4: error: implicit declaration of function '__glMap1d_size' [-Werror=implicit-function-declaration]

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76489 --- Comment #10 from Dâniel Fraga --- (In reply to comment #9) > Do you recall which version of indent was causing the problem, which one > works correctly ? We can check in configure.ac and fall-back to using cat > rather than causing such nuisa

[Mesa-dev] [PATCH 10/14] mesa: Add missing null checks into prog_hash_table.c

2014-03-25 Thread Juha-Pekka Heikkila
Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/prog_hash_table.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/program/prog_hash_table.c b/src/mesa/program/prog_hash_table.c index f45e

[Mesa-dev] [PATCH 05/14] mesa: Add missing null check in _mesa_parse_arb_program()

2014-03-25 Thread Juha-Pekka Heikkila
Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y index 6dde69d..1664740 100644

[Mesa-dev] [PATCH 03/14] glx: add extra null check in getFBConfigs

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxext.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..0838cd1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -677,6 +677,10 @@ static GLboolean psc->serverGLXexts = __g

[Mesa-dev] [PATCH 13/14] i965: check malloc return value in intel_resolve_map_set()

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index 04b5c94..a338c5e 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 04/14] mesa: Prevent negative indexing on noise2, noise3 and noise4

2014-03-25 Thread Juha-Pekka Heikkila
% operator could return negative value which would cause indexing before perm table. Change %256 to &0xff Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/prog_noise.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/mesa/progr

[Mesa-dev] [PATCH 09/14] mesa: In emit_texenv() type mismatch was forced with typecast

2014-03-25 Thread Juha-Pekka Heikkila
Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_s

[Mesa-dev] [PATCH 07/14] mesa: add missing null checks in _tnl_register_fastpath()

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/tnl/t_vertex.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..5cdf743 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src/mesa/tnl/t_vertex.c @@ -83,12

[Mesa-dev] [PATCH 14/14] mesa: add null checks in symbol_table.c

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..9c3556a 100644 --- a/src/mesa/program/symb

[Mesa-dev] [PATCH 00/14] Klocwork patches

2014-03-25 Thread Juha-Pekka Heikkila
Again fixed my Klocwork set. I reworked Ian's patch because my set depend on it and Ian's patch seem to have vanished in the void. It needed a small update because it was breaking "make check". Matt, about "glsl: add missing null check in tfeedback_decl::init()", ralloc_strndup failure would be co

[Mesa-dev] [PATCH 06/14] mesa: remove redundant running of check_symbol_table()

2014-03-25 Thread Juha-Pekka Heikkila
Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/

[Mesa-dev] [PATCH 08/14] mesa: add extra null checks in vbo_rebase_prims()

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/vbo/vbo_rebase.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index f3fe5f7..7aa8d08 100644 --- a/src/mesa/vbo/vbo_rebase.c +++ b/src/mesa/vbo/vb

[Mesa-dev] [PATCH 01/14] mesa: Add _mesa_error_no_memory for logging out-of-memory messages

2014-03-25 Thread Juha-Pekka Heikkila
From: Ian Romanick This can be called from locations that don't have a context pointer handy. This patch also adds enough infrastructure so that the unit tests for the GLSL compiler and the stand-alone compiler will build and function. This patch was originally signed off by Ian Romanick, now v

[Mesa-dev] [PATCH 11/14] glsl: add missing null check in tfeedback_decl::init()

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_varyings.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..d0a9d75 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -278,6 +278,12 @@

[Mesa-dev] [PATCH 12/14] mesa: add missing null check in _mesa_NewHashTable()

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/hash.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 4c92005..21da652 100644 --- a/src/mesa/main/hash.c +++ b/src/mesa/main/hash.c @@ -115,10 +115,20 @@ _mesa_NewHashTable(void

[Mesa-dev] [PATCH 02/14] glx: remove unused __glXClientInfo()

2014-03-25 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxcmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 4b17d7c..7984715 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1378,19 +1378,6 @@ glXQueryServerString(Display * dpy,

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 Emil Velikov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

[Mesa-dev] [Bug 76489] Mesa git (011569b5b7) compilation issue: render2.c:49:4: error: implicit declaration of function '__glMap1d_size' [-Werror=implicit-function-declaration]

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76489 Emil Velikov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

[Mesa-dev] [Bug 76577] egl_dri2.c:507:27: error: 'EGL_OPENGL_ES3_BIT_KHR' undeclared (first use in this function)

2014-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76577 --- Comment #2 from Emil Velikov --- Created attachment 96363 --> https://bugs.freedesktop.org/attachment.cgi?id=96363&action=edit egl: do not use system egl headers, make use of the one we provide Well this is kind of our fault as well. We sh

[Mesa-dev] [PATCH] gbm: Set errno on errors

2014-03-25 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This should give the caller some information of what called the error. For the gbm_bo_import() case, for instance, it is possible to know if the import is not supported or the error was caused by an invalid parameter. --- src/gbm/backends/dri/gbm_dri.c | 38

Re: [Mesa-dev] EXTERNAL: Re: OpenCL/clover buffers vs images

2014-03-25 Thread Dorrington, Albert
I realized as I was lying in bed last night trying to sleep that the Dissassembly I posted below was a version in which I replaced a lot of the PV and PS references with names to help me decode. Here is the original ISA: ; Disassembly 00 ALU: ADDR(32) CNT(18) KCACH