Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't renumber UNIFORM registers.

On 03/12/2014 03:14 AM, Pohjolainen, Topi wrote: > On Tue, Mar 11, 2014 at 11:48:54PM -0700, Kenneth Graunke wrote: >> Previously, remove_dead_constants() would renumber the UNIFORM registers >> to be sequential starting from zero, and the resulting register number >> would be used directly as an i

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't renumber UNIFORM registers.

On 03/12/2014 05:30 AM, Pohjolainen, Topi wrote: > On Tue, Mar 11, 2014 at 11:48:54PM -0700, Kenneth Graunke wrote: [snip] >> + stage_prog_data->nr_params = num_push_constants; >> + >> + /* Up until now, the param[] array has been indexed by reg + reg_offset >> +* of UNIFORM registers. Con

[Mesa-dev] removal of _glthread_GetID() breaks libglapi.so's ABI

Hi Brian, _glthread_GetID() was removed by this commit commit 02cb04c68ffbdaffaf7513ddc951584cac29f209 Author: Brian Paul Date: Tue Mar 4 15:24:16 2014 -0700 mesa: remove remaining uses of _glthread_GetID() It turns out the function, declared in glapi.h, is a part of libglapi.so ABI. I

Re: [Mesa-dev] [RFC PATCH 3/4] mesa: Prefer non-swizzled formats when prefer_no_swizzle set

Actually, after poking around a bit more, I think this is correct... As of Brian's commit 657436da7ee, the packed formats are described as being laid out from the LSB. This is consistent with this patch, with the pack/unpack code, and the hardware documentation: mesa: update packed format lay

Re: [Mesa-dev] PATCH: R600/SI: Instruction verifier improvements

On Mit, 2014-03-12 at 09:49 -0700, Tom Stellard wrote: > > The attached patches add some more checks to the instruction verifier on SI > and also fix some false positives. This should fix all the verifier errors > generated by the piglit tests. I can confirm your patches fix the false positive e

Re: [Mesa-dev] Wrong colors in 3D apps on big-endian systems

On Mit, 2014-03-12 at 11:26 +, Richard Sandiford wrote: > Michel Dänzer writes: > > On Die, 2014-03-11 at 11:08 +, Richard Sandiford wrote: > >> Michel Dänzer writes: > >> > On Mon, 2014-03-10 at 10:11 +0100, Christian Zigotzky wrote: > >> >> > >> >> The Fedora guys have solved the probl

[Mesa-dev] [PATCH V2] mesa: Fix glGetVertexAttribi(GL_VERTEX_ATTRIB_ARRAY_SIZE)

mesa currently returns 4 when GL_VERTEX_ATTRIB_ARRAY_SIZE is queried for a vertex array initially set up with size=GL_BGRA. This patch makes changes to return size=GL_BGRA as required by the spec. Fixes Khronos OpenGL CTS test: vertex_array_bgra_basic.test V2: Use array->Format instead of adding

[Mesa-dev] [PATCH V2] mesa: Fix error code generation in glReadPixels()

Section 4.3.1, page 220, of OpenGL 3.3 specification explains the error conditions for glreadPixels(): "If the format is DEPTH_STENCIL, then values are taken from both the depth buffer and the stencil buffer. If there is no depth buffer or if there is no stencil buffer, then the err

Re: [Mesa-dev] Gallium u_gen_mipmap problem with queries

I don't think there is a disable bit for all queries in our hardware. We disable queries by "ending" them and resuming is like starting a new one. We have to do that for context switches and blitting and resource_copy_region anyway. Conditional rendering can be predicated by an array of query resu

[Mesa-dev] Z24S8 textures on nv04/nv10

Hi Francisco, I'm looking at some piglit failures on nv10... full run at http://people.freedesktop.org/~imirkin/nv10-comparison/problems.html The specific one is: http://people.freedesktop.org/~imirkin/nv10-comparison/nv18-imirkin/spec/!OpenGL%201.1/copyteximage%201D.html Which fails in nouvea

[Mesa-dev] [PATCH] mesa: Fix glGetVertexAttribi(GL_VERTEX_ATTRIB_ARRAY_SIZE)

mesa currently returns 4 when GL_VERTEX_ATTRIB_ARRAY_SIZE is queried for a vertex array initially set up with size=GL_BGRA. This patch makes changes to return size=GL_BGRA as required by the spec. Fixes Khronos OpenGL CTS test: vertex_array_bgra_basic.test Signed-off-by: Anuj Phogat Cc: --- sr

Re: [Mesa-dev] [PATCH 2/8] glsl: Add wrapper function that calls ir_dereference::constant_referenced

On Wed, Mar 12, 2014 at 6:49 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/ir_constant_expression.cpp | 52 > + > 1 file changed, 36 insertions(+), 16 deletions(-) > > diff --git a/src/glsl/ir_constant_expressi

Re: [Mesa-dev] [PATCH 1/8] glsl: Group all of the constant_referenced functions together

On 03/12/2014 04:11 PM, Connor Abbott wrote: > On Wed, Mar 12, 2014 at 6:49 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/glsl/ir_clone.cpp | 10 +- >> src/glsl/ir_constant_expression.cpp | 195 >> +++---

[Mesa-dev] [PATCH 5.5/8] glsl: Just ignore non-dereference IR in constant_referenced

From: Ian Romanick This simplifies some of the call sites. Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp

Re: [Mesa-dev] [PATCH 1/8] glsl: Group all of the constant_referenced functions together

On Wed, Mar 12, 2014 at 6:49 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/glsl/ir_clone.cpp | 10 +- > src/glsl/ir_constant_expression.cpp | 195 > +++- > 2 files changed, 109 insertions(+), 96 deletions

[Mesa-dev] [PATCH v2] glsl: Fold implementation of ir_dereference_array::constant_referenced into wrapper

From: Ian Romanick v2: Don't shadow the variable 'deref' from a higher scope. Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 90 ++--- 1 file changed, 44 insertions(+), 46 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/s

[Mesa-dev] [PATCH] glsl: Fold implementation of ir_dereference_record::constant_referenced into wrapper

From: Ian Romanick v2: Don't shadow the variable 'deref' from a higher scope. Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 39 + 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/s

[Mesa-dev] [PATCH 8/8] glsl: Clean up "unused parameter" warnings

From: Ian Romanick ../../src/glsl/ir_constant_expression.cpp:486:1: warning: unused parameter 'variable_context' [-Wunused-parameter] ../../src/glsl/ir_constant_expression.cpp:1633:1: warning: unused parameter 'variable_context' [-Wunused-parameter] ../../src/glsl/ir_constant_expression.cpp:175

[Mesa-dev] [PATCH 1/8] glsl: Group all of the constant_referenced functions together

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ir_clone.cpp | 10 +- src/glsl/ir_constant_expression.cpp | 195 +++- 2 files changed, 109 insertions(+), 96 deletions(-) diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp index

[Mesa-dev] [PATCH 5/8] glsl: Fold implementation of ir_dereference_array::constant_referenced into wrapper

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 89 ++--- 1 file changed, 43 insertions(+), 46 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 336ce17..53db618 10

[Mesa-dev] [PATCH 4/8] glsl: Fold implementation of ir_dereference_record::constant_referenced into wrapper

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 38 - 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index c013dfd..336ce17 10

[Mesa-dev] [PATCH 2/8] glsl: Add wrapper function that calls ir_dereference::constant_referenced

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 52 + 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index a31e579..4149a0e 10

[Mesa-dev] [PATCH 7/8] glsl: Minor clean ups in constant_referenced

From: Ian Romanick These could probably be squashed into one of the previous commits. Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_co

[Mesa-dev] [PATCH 6/8] glsl: Remove ir_dereference::constant_referenced

From: Ian Romanick All of the functionality is implemented in a private function in the one file where it is used. Signed-off-by: Ian Romanick --- src/glsl/ir.h | 36 src/glsl/ir_constant_expression.cpp | 25 -

[Mesa-dev] [PATCH 0/8]

The goal of this series is to get constant_referenced out of the public interface of the ir_dereference class hierarchy. It has always seemed odd to me that an interface that's specific to ir_constant_expression is generally exposed. In addition, having it live in that class hierarchy makes some

[Mesa-dev] [PATCH 3/8] glsl: Fold implementation of ir_dereference_variable::constant_referenced into wrapper

From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ir_constant_expression.cpp | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 4149a0e..c013dfd 100644 --- a/s

Re: [Mesa-dev] static version of osmesa is missing llvm symbols, bug?

Guys, Thanks for the feedback and for continued support of static linking. I will file the bug reports. Burlen On 03/12/2014 06:30 AM, Brian Paul wrote: On 03/11/2014 06:48 PM, Emil Velikov wrote: On 12/03/14 00:08, Burlen Loring wrote: yep, I'm using 10.1.0 and also noticed the same in 9.2.

Re: [Mesa-dev] [PATCH 00/13] Klocwork patches

1, 3-7, and 9 are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/13] glsl: add missing null check in tfeedback_decl::init()

On Wed, Mar 12, 2014 at 2:11 PM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/link_varyings.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp > index c925c00..226f012 100644 >

[Mesa-dev] [Bug 74563] Surfaceless contexts are not properly released by DRI drivers

https://bugs.freedesktop.org/show_bug.cgi?id=74563 Chad Versace changed: What|Removed |Added CC||chad.vers...@linux.intel.co

Re: [Mesa-dev] [PATCH 09/13] mesa: Add missing null checks into prog_hash_table.c

On Wed, Mar 12, 2014 at 2:11 PM, Juha-Pekka Heikkila wrote: > Check calloc return values in hash_table_insert() and > hash_table_replace() > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/program/prog_hash_table.c | 23 +-- > 1 file changed, 17 insertions(+), 6 deletio

[Mesa-dev] [Bug 75797] EGL application crashes with BadDrawable at SwapBuffers

https://bugs.freedesktop.org/show_bug.cgi?id=75797 Chad Versace changed: What|Removed |Added CC||chad.vers...@linux.intel.co

Re: [Mesa-dev] [PATCH 08/13] mesa: In emit_texenv() type mismatch was forced with typecast

On Wed, Mar 12, 2014 at 2:11 PM, Juha-Pekka Heikkila wrote: > Type mismatch caused random memory to be copied when casted > memory area was smaller than expected type. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/main/ff_fragment_shader.cpp | 17 + > 1 file changed, 9

Re: [Mesa-dev] [PATCH 07/13] mesa: add extra null checks in vbo_rebase_prims()

On Wed, Mar 12, 2014 at 2:11 PM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/vbo/vbo_rebase.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c > index f3f

Re: [Mesa-dev] [PATCH 0/7] EGL_MESA_configless_context

On Fri, Mar 7, 2014 at 10:05 AM, Neil Roberts wrote: > Here is a series of patches to add an extension which makes it > possible to create an EGL context without specifying a config. A > context created in this way can be bound with any surface using the > same EGLDisplay rather than being restric

Re: [Mesa-dev] [PATCH 05/13] mesa: remove redundant running of check_symbol_table()

On Wed, Mar 12, 2014 at 2:11 PM, Juha-Pekka Heikkila wrote: > Nested for loops running through tables against which they > finally do an assert were ran also with optimized builds. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/program/symbol_table.c | 6 -- > 1 file changed, 4 inse

[Mesa-dev] [PATCH 06/13] mesa: add missing null checks in _tnl_register_fastpath()

Signed-off-by: Juha-Pekka Heikkila --- src/mesa/tnl/t_vertex.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..5cdf743 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src/mesa/tnl/t_vertex.c @@ -83,12

[Mesa-dev] [PATCH 02/13] glx: add extra null check in getFBConfigs

Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxext.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4a195bd..0838cd1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -677,6 +677,10 @@ static GLboolean psc->serverGLXexts = __g

[Mesa-dev] [PATCH 11/13] mesa: add missing null check in _mesa_NewHashTable()

Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/hash.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 4c92005..592ef4d 100644 --- a/src/mesa/main/hash.c +++ b/src/mesa/main/hash.c @@ -115,6 +115,11 @@ _mesa_NewHashTable(void)

[Mesa-dev] [PATCH 05/13] mesa: remove redundant running of check_symbol_table()

Nested for loops running through tables against which they finally do an assert were ran also with optimized builds. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/

[Mesa-dev] [PATCH 09/13] mesa: Add missing null checks into prog_hash_table.c

Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/prog_hash_table.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/mesa/program/prog_hash_table.c b/src/mesa/program

[Mesa-dev] [PATCH 12/13] i965: check malloc return value in intel_resolve_map_set()

Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index 04b5c94..a338c5e 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 00/13] Klocwork patches

Most of these were on mesa-dev before, thank you again Brian and Ian for commenting these earlier. I hope I did not miss any comment. These depend on Ian's patch "mesa: Add _mesa_error_no_memory for logging out-of-memory messages" http://patchwork.freedesktop.org/patch/21355/ /Juha-Pekka Juha-P

[Mesa-dev] [PATCH 07/13] mesa: add extra null checks in vbo_rebase_prims()

Signed-off-by: Juha-Pekka Heikkila --- src/mesa/vbo/vbo_rebase.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index f3fe5f7..7aa8d08 100644 --- a/src/mesa/vbo/vbo_rebase.c +++ b/src/mesa/vbo/vb

[Mesa-dev] [PATCH 10/13] glsl: add missing null check in tfeedback_decl::init()

Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_varyings.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..226f012 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -290,7

[Mesa-dev] [PATCH 08/13] mesa: In emit_texenv() type mismatch was forced with typecast

Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shad

[Mesa-dev] [PATCH 13/13] mesa: add null checks in symbol_table.c

Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..9c3556a 100644 --- a/src/mesa/program/symb

[Mesa-dev] [PATCH 04/13] mesa: Add missing null check in _mesa_parse_arb_program()

Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mesa/program/program_parse.y index 6dde69d..1664740 100644

[Mesa-dev] [PATCH 01/13] glx: remove unused __glXClientInfo()

Signed-off-by: Juha-Pekka Heikkila --- src/glx/glxcmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 4b17d7c..7984715 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -1378,19 +1378,6 @@ glXQueryServerString(Display * dpy,

[Mesa-dev] [PATCH 03/13] mesa: Prevent negative indexing on noise2, noise3 and noise4

% operator could return negative value which would cause indexing before perm table. Change %256 to &0xff Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/prog_noise.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/mesa/progr

Re: [Mesa-dev] [PATCH 1/6] glsl: Optimize pow(x, 2) into x * x.

On 03/12/2014 01:29 AM, Erik Faye-Lund wrote: > On Wed, Mar 12, 2014 at 1:32 AM, Eric Anholt wrote: >> Erik Faye-Lund writes: >> >>> On Wed, Mar 12, 2014 at 12:00 AM, Eric Anholt wrote: Erik Faye-Lund writes: > On Tue, Mar 11, 2014 at 7:27 PM, Eric Anholt wrote: >> Erik Faye-

Re: [Mesa-dev] [PATCH 5/6] mesa: Implement INTEL_performance_query.

On 03/12/2014 05:54 AM, Petri Latvala wrote: > Using the existing driver hooks made for AMD_performance_monitor, implement > INTEL_performance_query functions. > > Signed-off-by: Petri Latvala > --- > src/mesa/main/performance_monitor.c | 476 > +--- > 1 file cha

Re: [Mesa-dev] [PATCH 07/12] mesa/sso: Implement _mesa_UseProgramStages

On 03/05/2014 12:35 PM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Gregory Hainaut >> >> Now arb_separate_shader_object-GetProgramPipelineiv should pass. >> >> V3 (idr): >> * Change spec references to core OpenGL versions instead of issues in >> the extension spec. >> * Split out fro

Re: [Mesa-dev] [PATCH 03/12] mesa/sso: replace Shader binding point with _Shader

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/2014 12:23 PM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Gregory Hainaut >> >> To avoid NULL pointer check a default pipeline object is >> installed in _Shader when no program is current >> >> The spec say that UseProgram/UseSh

Re: [Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

On 03/12/2014 11:30 AM, Kenneth Graunke wrote: > On 03/12/2014 02:51 AM, Ilia Mirkin wrote: >> On Wed, Mar 12, 2014 at 4:28 AM, Kenneth Graunke >> wrote: >>> Ideally, we'd like to never even attempt the SIMD16 compile if we could >>> know ahead of time that it won't succeed---it's purely a waste

Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/2014 01:00 PM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Gregory Hainaut >> >> Implementation note: I don't use context for ralloc (don't know >> how). >> >> The check on PROGRAM_SEPARABLE flags is also done when the >> pipelin

[Mesa-dev] [PATCH] radeonsi/compute: Fix memory leak

Free shader buffer object for all kernels when deleting compute state. Signed-off-by: Aaron Watry --- src/gallium/drivers/radeonsi/si_compute.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index e

Re: [Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

On 03/12/2014 02:51 AM, Ilia Mirkin wrote: > On Wed, Mar 12, 2014 at 4:28 AM, Kenneth Graunke > wrote: >> Ideally, we'd like to never even attempt the SIMD16 compile if we could >> know ahead of time that it won't succeed---it's purely a waste of time. >> This is especially important for state-ba

Re: [Mesa-dev] [PATCH 4/4] nvc0: minor cleanups in stream output handling

On Wed, Mar 12, 2014 at 1:24 PM, Emil Velikov wrote: > Constify the offsets parameter to silence gcc warning 'assignment > from incompatible pointer type' due to function prototype miss-match. > > Use a boolean changed as a shorthand for target != current_target. > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] Gallium u_gen_mipmap problem with queries

Am 12.03.2014 15:00, schrieb Marek Olšák: > Hi everybody, > > u_gen_mipmap doesn't disable queries, so all active queries are > incremented, even though mipmap generation shouldn't have any effect > on queries. Hardware drivers can disable queries, but this feature is > not exposed via the gallium

Re: [Mesa-dev] [PATCH 1/4] nv50: add missing brackets when handling the samplers array

On Wed, Mar 12, 2014 at 1:24 PM, Emil Velikov wrote: > Commit 3805a864b1d(nv50: assert before trying to out-of-bounds access > samplers) introduced a series of asserts as a precausion of a previous > illegal memory access. > > Although it failed to encapsulate loop within nv50_sampler_state_delete

Re: [Mesa-dev] [PATCH] i965: Don't enable reset notification support on Gen4-5.

On 03/12/2014 01:43 AM, Kenneth Graunke wrote: > arekm reported that using Chrome with GPU acceleration enabled on GM45 > triggered the hw_ctx != NULL assertion in brw_get_graphics_reset_status. > > We definitely do not want to advertise reset notification support on > Gen4-5 systems, since it nee

Re: [Mesa-dev] [PATCH 3/4] nouveau: honor fread return value in the nouveau_compiler

On Wed, Mar 12, 2014 at 1:24 PM, Emil Velikov wrote: > There is little point of continuing if fread returns zero, as it > indicates that either the file is empty or cannot be read from. > Bail out if fread returns zero after closing the file. > > Cc: Ilia Mirkin > Signed-off-by: Emil Velikov Re

Re: [Mesa-dev] i965: Pull parameters in SIMD16 mode.

Patches 1 through 4 and 8 are Reviewed-by: Ian Romanick I don't know the code well enough to give any evaluation of patch 5, and all the others really depend on 5. On 03/11/2014 11:48 PM, Kenneth Graunke wrote: > Hello, > > This series adds support for pull constants in SIMD16 mode. By the en

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't renumber UNIFORM registers.

On 03/11/2014 11:48 PM, Kenneth Graunke wrote: > Previously, remove_dead_constants() would renumber the UNIFORM registers > to be sequential starting from zero, and the resulting register number > would be used directly as an index into the params[] array. > > This renumbering made it difficult to

Re: [Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

On Wed, Mar 12, 2014 at 10:36 AM, Ian Romanick wrote: > On 03/12/2014 02:51 AM, Ilia Mirkin wrote: >> On Wed, Mar 12, 2014 at 4:28 AM, Kenneth Graunke >> wrote: >>> Ideally, we'd like to never even attempt the SIMD16 compile if we could >>> know ahead of time that it won't succeed---it's purely

Re: [Mesa-dev] [PATCH 1/6] mesa: Add GL_INTEL_performance_query definitions

On 03/12/2014 05:54 AM, Petri Latvala wrote: > Until Khronos adds the definitions to glext.h, add definitions for this > extension to gl.h. I don't know how we missed it, but the glext.h at http://www.opengl.org/registry/api/GL/glext.h does have the definitions. We should just import that instead

Re: [Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

On 03/12/2014 02:51 AM, Ilia Mirkin wrote: > On Wed, Mar 12, 2014 at 4:28 AM, Kenneth Graunke > wrote: >> Ideally, we'd like to never even attempt the SIMD16 compile if we could >> know ahead of time that it won't succeed---it's purely a waste of time. >> This is especially important for state-ba

[Mesa-dev] [PATCH 4/4] nvc0: minor cleanups in stream output handling

Constify the offsets parameter to silence gcc warning 'assignment from incompatible pointer type' due to function prototype miss-match. Use a boolean changed as a shorthand for target != current_target. Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 9 +

[Mesa-dev] [PATCH 1/4] nv50: add missing brackets when handling the samplers array

Commit 3805a864b1d(nv50: assert before trying to out-of-bounds access samplers) introduced a series of asserts as a precausion of a previous illegal memory access. Although it failed to encapsulate loop within nv50_sampler_state_delete effectively failing to clear the sampler state, apart from exa

[Mesa-dev] [PATCH 3/4] nouveau: honor fread return value in the nouveau_compiler

There is little point of continuing if fread returns zero, as it indicates that either the file is empty or cannot be read from. Bail out if fread returns zero after closing the file. Cc: Ilia Mirkin Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nouveau_compiler.c | 4 ++-- 1 file

[Mesa-dev] [PATCH 2/4] nouveau: typecast the prime_fd handle when calling nouveau_bo_set_prime

Core drm defines that the handle is of type int, while all drivers treat it as uint internally. Typecast the value to silence gcc warning messages and be consistent amongst all drivers. Signed-off-by: Emil Velikov --- src/gallium/drivers/nouveau/nouveau_screen.c | 2 +- 1 file changed, 1 inserti

[Mesa-dev] PATCH: R600/SI: Instruction verifier improvements

Hi, The attached patches add some more checks to the instruction verifier on SI and also fix some false positives. This should fix all the verifier errors generated by the piglit tests. As far as I can tell, there are no regressions with this series. I had some trouble making it through a full

[Mesa-dev] Mesa 10.0.4

Mesa 10.0.4 has been released. Mesa 10.0.4 is a bug fix release which fixes bugs fixed since the 10.0.3 release, (see below for a list of changes). The tag in the git repository for Mesa 10.0.4 is 'mesa-10.0.4'. Mesa 10.0.4 is available for download at ftp://freedesktop.org/pub/mesa/10.0.4/ md5s

[Mesa-dev] [mesa-9.2][llvm-3.4] Requires some fixes from GIT master to build properly

Hi, I tried to build mesa-9.2 GIT branch with llvm-3.4 on Ubuntu/precise AMD64 and needed the 2 following patches: [PATCH 1/2] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4. [PATCH 2/2] gallivm: Remove NoFramePointerElimNonLeaf for LLVM >= 3.4. Not sure if mesa-9.2.x is still mai

Re: [Mesa-dev] [PATCH] Release gl_debug_state when destroying context.

Brian, Please push that. I haven't gotten commit access for myself yet. On Tue, Mar 11, 2014 at 5:42 PM, Brian Paul wrote: > On 03/11/2014 05:07 PM, Mike Stroyan wrote: > >> Commit 6e8d04a caused a leak by allocating ctx->Debug but never freeing >> it. >> Release the memory in _mesa_free_er

Re: [Mesa-dev] [PATCH 0/6] Implement INTEL_performance_query

One concern I forgot to mention: Interoperability with AMD_performance_monitor. With this patch series as is, after glBeginPerfQueryINTEL, there will be a value you can pass to glEndPerfMonitorAMD that won't produce GL_INVALID_VALUE as it should. Making sure context's monitor objects are acce

[Mesa-dev] Gallium u_gen_mipmap problem with queries

Hi everybody, u_gen_mipmap doesn't disable queries, so all active queries are incremented, even though mipmap generation shouldn't have any effect on queries. Hardware drivers can disable queries, but this feature is not exposed via the gallium interface. Generally, we want to disable all queries

Re: [Mesa-dev] static version of osmesa is missing llvm symbols, bug?

On 03/11/2014 06:48 PM, Emil Velikov wrote: On 12/03/14 00:08, Burlen Loring wrote: yep, I'm using 10.1.0 and also noticed the same in 9.2.2. In that case "it wasn't me" ;-) in short static linking is essential for reasonable performance of parallel applications on Cray systems. In this scen

Re: [Mesa-dev] [PATCH 6/6] i965: Enable INTEL_performance_query for Gen5+.

On 03/12/2014 03:17 PM, Dragomir Ivanov wrote: What about other drivers supporting `AMD_performance_monitor`? Are there any? Other drivers don't support it. -- Petri Latvala ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.free

Re: [Mesa-dev] [PATCH 6/6] i965: Enable INTEL_performance_query for Gen5+.

What about other drivers supporting `AMD_performance_monitor`? Are there any? On Wed, Mar 12, 2014 at 2:54 PM, Petri Latvala wrote: > Signed-off-by: Petri Latvala > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src

[Mesa-dev] [PATCH 3/6] mesa: Add INTEL_performance_query enums to tests/enum_strings.cpp

Signed-off-by: Petri Latvala --- src/mesa/main/tests/enum_strings.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/main/tests/enum_strings.cpp b/src/mesa/main/tests/enum_strings.cpp index 3795700..d16eb36 100644 --- a/src/mesa/main/tests/enum_strings.cpp +++ b

[Mesa-dev] [PATCH 5/6] mesa: Implement INTEL_performance_query.

Using the existing driver hooks made for AMD_performance_monitor, implement INTEL_performance_query functions. Signed-off-by: Petri Latvala --- src/mesa/main/performance_monitor.c | 476 +--- 1 file changed, 439 insertions(+), 37 deletions(-) diff --git a/src/mes

[Mesa-dev] [PATCH 6/6] i965: Enable INTEL_performance_query for Gen5+.

Signed-off-by: Petri Latvala --- src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 5094c2b..78bf5b4 100644 --- a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 0/6] Implement INTEL_performance_query

This patch series implements the INTEL_performance_query extension. With driver code for AMD_performance_monitor already in place, implementing this extension was fairly straightforward. Planned future improvements: Proper semantic types for counters and data normalization (currently all counters

[Mesa-dev] [PATCH 1/6] mesa: Add GL_INTEL_performance_query definitions

Until Khronos adds the definitions to glext.h, add definitions for this extension to gl.h. Signed-off-by: Petri Latvala --- include/GL/gl.h | 45 + 1 file changed, 45 insertions(+) diff --git a/include/GL/gl.h b/include/GL/gl.h index 4e2932d..e2caf73

[Mesa-dev] [PATCH 4/6] mesa: Add core support for the GL_INTEL_performance_query extension.

Like AMD_performance_monitor, this extension provides an interface for applications (and OpenGL-based tools) to access GPU performance counters. Since the exact performance counters available vary between vendors and hardware generations, the extension provides an API the application can use to get

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't renumber UNIFORM registers.

On Tue, Mar 11, 2014 at 11:48:54PM -0700, Kenneth Graunke wrote: > Previously, remove_dead_constants() would renumber the UNIFORM registers > to be sequential starting from zero, and the resulting register number > would be used directly as an index into the params[] array. > > This renumbering ma

Re: [Mesa-dev] Wrong colors in 3D apps on big-endian systems

Michel Dänzer writes: > On Die, 2014-03-11 at 11:08 +, Richard Sandiford wrote: >> Michel Dänzer writes: >> > On Mon, 2014-03-10 at 10:11 +0100, Christian Zigotzky wrote: >> >> >> >> The Fedora guys have solved the problem with the patch >> >> "mesa-9.2-llvmpipe-on-big-endian.patch". What d

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Don't renumber UNIFORM registers.

On Tue, Mar 11, 2014 at 11:48:54PM -0700, Kenneth Graunke wrote: > Previously, remove_dead_constants() would renumber the UNIFORM registers > to be sequential starting from zero, and the resulting register number > would be used directly as an index into the params[] array. > > This renumbering ma

Re: [Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

On Wed, Mar 12, 2014 at 4:28 AM, Kenneth Graunke wrote: > Ideally, we'd like to never even attempt the SIMD16 compile if we could > know ahead of time that it won't succeed---it's purely a waste of time. > This is especially important for state-based recompiles, which happen at > draw time. > > Th

Re: [Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

This patch is: Reviewed-by: Chris Forbes On Wed, Mar 12, 2014 at 9:28 PM, Kenneth Graunke wrote: > Ideally, we'd like to never even attempt the SIMD16 compile if we could > know ahead of time that it won't succeed---it's purely a waste of time. > This is especially important for state-based rec

[Mesa-dev] [PATCH] i965: Don't enable reset notification support on Gen4-5.

arekm reported that using Chrome with GPU acceleration enabled on GM45 triggered the hw_ctx != NULL assertion in brw_get_graphics_reset_status. We definitely do not want to advertise reset notification support on Gen4-5 systems, since it needs hardware contexts, and we never even request a hardwar

Re: [Mesa-dev] [PATCH 1/6] glsl: Optimize pow(x, 2) into x * x.

On Wed, Mar 12, 2014 at 1:32 AM, Eric Anholt wrote: > Erik Faye-Lund writes: > >> On Wed, Mar 12, 2014 at 12:00 AM, Eric Anholt wrote: >>> Erik Faye-Lund writes: >>> On Tue, Mar 11, 2014 at 7:27 PM, Eric Anholt wrote: > Erik Faye-Lund writes: > >> On Tue, Mar 11, 2014 at 2:50

[Mesa-dev] [PATCH 8/7] i965: Accurately bail on SIMD16 compiles.

Ideally, we'd like to never even attempt the SIMD16 compile if we could know ahead of time that it won't succeed---it's purely a waste of time. This is especially important for state-based recompiles, which happen at draw time. The fragment shader compiler has a number of checks like: if (disp