[Mesa-dev] [PATCH 4/4] i965: Refactor Gen4-6 SURFACE_STATE setup for buffer surfaces.

This was an embarassingly large amount of copy and pasted code, and it wasn't particularly simple code either. By factoring it out into a helper function, we consolidate the complexity. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 98 +---

[Mesa-dev] [PATCH 3/4] i965: Remove MIPLAYOUT_BELOW from Gen4-6 constant buffer surface state.

Specifying a miptree layout makes no sense for constant buffers. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_sta

[Mesa-dev] [PATCH 2/4] i965: Share Gen7+ SURFACE_STATE setup for textures and renderbuffers.

The SURFACE_STATE entries for textures and renderbuffers share almost all of the same fields. Only a couple are specific to one or the other. Thus, it makes sense to have a single shared function that takes care of all the bit-shifting required to assemble the SURFACE_STATE structure. This remov

[Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

This was an embarassingly large amount of copy and pasted code, and it wasn't particularly simple code either. By factoring it out into a helper function, we consolidate the complexity. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 144 +-

[Mesa-dev] i965 surface state tidying, part 1

Here's a bit of tidying I did to the i965 SURFACE_STATE code: - It unifies the code for constant buffers/UBOs, texture buffers, and shader time buffers. - It also unifies the texture/renderbuffer code on Gen7+. Both of these delete a /lot/ of complicated cut and pasted code. No performance regre

[Mesa-dev] [PATCH] st/mesa: don't dereference stObj->pt if NULL

It seems a user app can get us into this state, I trigger the fail running fbo-maxsize inside virgl, it fails to create the backing storage for the texture object, but then segfaults here when it should fail the completeness test. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_cb_fbo.c

Re: [Mesa-dev] regression on nvc0 since floating point compare instructions

On Fri, Sep 13, 2013 at 12:24 AM, Christoph Bumiller wrote: > On 12.09.2013 16:14, Roland Scheidegger wrote: >> Am 12.09.2013 03:40, schrieb Dave Airlie: Maybe the type isn't set correctly? Looks to me like these instructions end up in mkCmp, which will set both src and dst type but igno

[Mesa-dev] [PATCH] mesa: Check for valid debug label before memcpy.

Fixes "Dereference after null check" reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/main/objectlabel.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/objectlabel.c b/src/mesa/main/objectlabel.c index 90d9e09..79fd8c7 100644 ---

[Mesa-dev] [PATCH 3/3] i965: Use gen7_upload_constant_state for 3DSTATE_CONSTANT_PS as well.

Now we use gen7_upload_constant_state() for all three shader stages. Signed-off-by: Kenneth Graunke Cc: Paul Berry --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_wm_sta

[Mesa-dev] [PATCH 2/3] i965: Set brw_stage_state::push_const_size for PS constants.

This paves the way for using gen7_upload_constant_state for PS data. The formula is copied from gen7_wm_state.c. Signed-off-by: Kenneth Graunke Cc: Paul Berry --- src/mesa/drivers/dri/i965/gen6_wm_state.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH 1/3] i965: Introduce a prog_data temporary in gen6_upload_wm_push_constants.

This saves a bit of typing and shortens a few lines. Signed-off-by: Kenneth Graunke Cc: Paul Berry --- src/mesa/drivers/dri/i965/gen6_wm_state.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_wm_state.c b/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

On 12 September 2013 22:06, Chia-I Wu wrote: > From: Chia-I Wu > > Consider only the top-left and top-right pixels to approximate DDX in a 2x2 > subspan, unless the application or the user requests a more accurate > approximation. This results in a less accurate approximation. However, it > im

Re: [Mesa-dev] [PATCH 11/17] mesa: Get GL_MAX_VARYING_FLOATS_ARB from VertexProgram.MaxOutputComponents

On 11 September 2013 16:28, Ian Romanick wrote: > On 09/11/2013 04:05 PM, Paul Berry wrote: > > On 10 September 2013 12:10, Ian Romanick > > wrote: > > > > From: Ian Romanick > > > > > > Signed-off-by: Ian Romanick >

[Mesa-dev] [PATCH 3/3] glsl: Drop shader_bit_encoding version checks.

We now set the ARB_shader_bit_encoding flag for versions that support this functionality, so we don't need to double check it here. Signed-off-by: Kenneth Graunke Cc: Ian Romanick --- src/glsl/builtin_functions.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/glsl/b

Re: [Mesa-dev] [PATCH] glsl: Enable extensions implied by GLSL 3.30

On 09/13/2013 09:13 AM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Reported-by: Dan Ginsburg > --- > src/glsl/glsl_parser_extras.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCH 2/3] glsl: Set ARB_shader_bit_encoding_enable = true for GLSL 3.30 / ES 3.00.

This should have no effect, since the only user of this flag is builtin_functions.cpp, which already explicitly checks for the core versions. Still, it's probably not a bad idea. Signed-off-by: Kenneth Graunke Cc: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 1 + 1 file changed, 1 insert

[Mesa-dev] [PATCH 1/3] glsl: Enable ARB_explicit_attrib_location in GLSL 3.30.

GLSL 3.30 wholly includes the ARB_explicit_attrib_location functionality. Failing to set this flag meant we wouldn't handle the layout qualifiers appropriately. Signed-off-by: Kenneth Graunke Reported-by: Dan Ginsburg Cc: Ian Romanick --- src/glsl/glsl_parser_extras.cpp | 2 +- 1 file changed

Re: [Mesa-dev] [PATCH] mesa: Remove all traces of GL_OES_matrix_get

On 09/13/2013 09:37 AM, Ian Romanick wrote: > From: Ian Romanick > > I believe this extension was enabled by accident. As far as I can tell, > there has never been any code in Mesa to actually support it. Not only > that, this extension is only useful in the common-lite profile, and Mesa > does

[Mesa-dev] [PATCH] gallivm: some bits of seamless cube filtering implementation

From: Roland Scheidegger Simply adjust wrap mode to clamp_to_edge. This is all that's needed for a correct implementation for nearest filtering, and it's way better than using repeat wrap for instance for linear filtering (though obviously this doesn't actually do seamless filtering). v2: fix s/

[Mesa-dev] [PATCH] gallivm: some bits of seamless cube filtering implementation

From: Roland Scheidegger Simply adjust wrap mode to clamp_to_edge. This is all that's needed for a correct implementation for nearest filtering, and it's way better than using repeat wrap for instance for linear filtering (though obviously this doesn't actually do seamless filtering). --- src/ga

[Mesa-dev] [PATCH v3] wayland: Add support for eglSwapInterval

Here is another version of the patch which brings back the blocking when there are no buffers available to cope with the situation where the compositor isn't immediately releasing buffers. Maybe we could leave the decision about whether to increase the buffer count to 4 as a separate patch. Sorry

[Mesa-dev] [PATCH] mesa: Remove all traces of GL_OES_matrix_get

From: Ian Romanick I believe this extension was enabled by accident. As far as I can tell, there has never been any code in Mesa to actually support it. Not only that, this extension is only useful in the common-lite profile, and Mesa does the common profile. Signed-off-by: Ian Romanick --- I

[Mesa-dev] [PATCH] glsl: Enable extensions implied by GLSL 3.30

From: Ian Romanick Signed-off-by: Ian Romanick Reported-by: Dan Ginsburg --- src/glsl/glsl_parser_extras.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 3f65ca5..e92f36e 100644 --- a/src/glsl/glsl_parser_extra

Re: [Mesa-dev] [PATCH v3] wayland: Add support for eglSwapInterval

Oh no, I meant to send this to the wayland-devel list. git send-email is hard. Sorry about that! - Neil - Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2

Re: [Mesa-dev] gallium-bind-sampler-states branch

Am 13.09.2013 02:46, schrieb Brian Paul: > > I just pushed a gallium-bind-sampler-states branch to my git repo at > git://people.freedesktop.org/~brianp/mesa > > It replaces the four > pipe_context::bind_fragment/vertex/geometry/compute_sampler_states() > functions with a single bind_sampler_stat

[Mesa-dev] [Bug 69321] starting openCL crashes/boots system

https://bugs.freedesktop.org/show_bug.cgi?id=69321 Alex Deucher changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Mesa-dev] [Bug 69321] starting openCL crashes/boots system

https://bugs.freedesktop.org/show_bug.cgi?id=69321 --- Comment #1 from udo --- Got no logging yet (dmesg, messages, xorg.0.log) -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesk

[Mesa-dev] [Bug 69321] New: starting openCL crashes/boots system

https://bugs.freedesktop.org/show_bug.cgi?id=69321 Priority: medium Bug ID: 69321 Assignee: mesa-dev@lists.freedesktop.org Summary: starting openCL crashes/boots system Severity: normal Classification: Unclassified OS: All

Re: [Mesa-dev] [PATCH] android: Remove builtin_compiler

On Fri, Sep 13, 2013 at 5:01 PM, Ian Romanick wrote: > Getting rid of the builtin_compiler from the Android build is a good > idea... but I'll let Chad or someone who knows /anything/ about the > Android build system actually review the patch. > > Acked-by: Ian Romanick > > I don't think I want t

Re: [Mesa-dev] [PATCH] android: Remove builtin_compiler

Getting rid of the builtin_compiler from the Android build is a good idea... but I'll let Chad or someone who knows /anything/ about the Android build system actually review the patch. Acked-by: Ian Romanick I don't think I want to remove any of the other bits of the builtin compiler or standalo

[Mesa-dev] [PATCH] android: Remove builtin_compiler

From: Adrian Negreanu the first part was done in: commit c845140a20efa6a30a5465301d1f9b4acea79155 Author: Kenneth Graunke Date: Tue Sep 3 21:22:17 2013 -0700 Signed-off-by: Adrian Negreanu --- src/glsl/Android.gen.mk | 19 --- 1 file changed, 19 deletions(-) diff