[Mesa-dev] [PATCH] i965: Compute dFdy() correctly for FBOs.

2012-06-20 Thread Paul Berry
On i965, dFdx() and dFdy() are computed by taking advantage of the fact that each consecutive set of 4 pixels dispatched to the fragment shader always constitutes a contiguous 2x2 block of pixels in a fixed arrangement known as a "sub-span". So we calculate dFdx() by taking the difference between

Re: [Mesa-dev] [PATCH] i965: Fix brw_swap_cmod() for LE/GE comparisons.

2012-06-20 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/16/2012 02:20 AM, Kenneth Graunke wrote: > The idea here is to rewrite comparisons like 2 >= x with x <= 2; we want to > simply exchange arguments, not negate > the condition. If equality was part of the original comparison, it should > remain

Re: [Mesa-dev] [PATCH] softpipe: Take all lods into account when texture sampling.

2012-06-20 Thread Jose Fonseca
- Original Message - > On 06/20/2012 06:39 AM, Roland Scheidegger wrote: > > On 06/20/2012 05:43 AM, Olivier Galibert wrote: > >> On Tue, Jun 19, 2012 at 02:46:35PM -0700, Jose Fonseca wrote: > >>> Could you give more background on why is this necessary? > >>> > >>> This will make softwar

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-20 Thread Kristian Høgsberg
On Wed, Jun 20, 2012 at 10:11 AM, Brian Paul wrote: > On 06/20/2012 08:00 AM, Kristian Høgsberg wrote: >> >> On Tue, Jun 19, 2012 at 3:26 PM, Eric Anholt  wrote: >>> >>> On Tue, 19 Jun 2012 08:10:25 -0600, Brian Paul  wrote: On 06/18/2012 07:35 PM, Eric Anholt wrote: > > Fixes pi

Re: [Mesa-dev] [PATCH] scons: Add glsl/glcpp to the include path.

2012-06-20 Thread Brian Paul
On 06/20/2012 12:15 AM, Vinson Lee wrote: Fixes this build failure on Solaris. Compiling build/sunos-debug/glsl/glcpp/glcpp-lex.c ... "src/glsl/glcpp/glcpp-lex.l", line 30: cannot find include file: "glcpp-parse.h" Signed-off-by: Vinson Lee --- src/glsl/SConscript |4 ++-- 1 files cha

Re: [Mesa-dev] [PATCH] softpipe: Take all lods into account when texture sampling.

2012-06-20 Thread Brian Paul
On 06/20/2012 06:39 AM, Roland Scheidegger wrote: On 06/20/2012 05:43 AM, Olivier Galibert wrote: On Tue, Jun 19, 2012 at 02:46:35PM -0700, Jose Fonseca wrote: Could you give more background on why is this necessary? This will make software renderering slower, so I'd really like to avoid it on

Re: [Mesa-dev] [PATCH] scons: Do not build glx on Solaris.

2012-06-20 Thread Alan Coopersmith
On 06/19/12 11:34 PM, Vinson Lee wrote: > The GLX headers on Solaris are not recent enough. Huh? Which Solaris? Solaris 11 ships with X.Org's glproto 1.4.10 - how new do you need? Or what headers do you need if not glproto? (Not that I know anyone who uses scons, so maybe this doesn't matte

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-20 Thread Brian Paul
On 06/20/2012 08:00 AM, Kristian Høgsberg wrote: On Tue, Jun 19, 2012 at 3:26 PM, Eric Anholt wrote: On Tue, 19 Jun 2012 08:10:25 -0600, Brian Paul wrote: On 06/18/2012 07:35 PM, Eric Anholt wrote: Fixes piglit ARB_uniform_buffer_object/getintegeri_v. --- src/mesa/main/get.c | 24 ++

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-20 Thread Kristian Høgsberg
On Tue, Jun 19, 2012 at 3:26 PM, Eric Anholt wrote: > On Tue, 19 Jun 2012 08:10:25 -0600, Brian Paul wrote: >> On 06/18/2012 07:35 PM, Eric Anholt wrote: >> > Fixes piglit ARB_uniform_buffer_object/getintegeri_v. >> > --- >> >   src/mesa/main/get.c |   24 >> >   1 file ch

Re: [Mesa-dev] [PATCH] scons: Do not build glx on Solaris.

2012-06-20 Thread Brian Paul
On 06/20/2012 04:18 AM, Jose Fonseca wrote: - Original Message - On 06/19/2012 11:34 PM, Vinson Lee wrote: The GLX headers on Solaris are not recent enough. Signed-off-by: Vinson Lee --- src/SConscript |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/SCo

Re: [Mesa-dev] Building under Windows

2012-06-20 Thread Jose Fonseca
I use MinGW cross compilation exclusively, so never run into this issue. However, I use scons w/ MSVC and this nevers happens, because scons passes options to MS lib/link via a option file. GNU ar too, supports this, so it is probably just a matter of teaching scons to use option files to GNU a

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-20 Thread Brian Paul
On 06/19/2012 01:26 PM, Eric Anholt wrote: On Tue, 19 Jun 2012 08:10:25 -0600, Brian Paul wrote: On 06/18/2012 07:35 PM, Eric Anholt wrote: Fixes piglit ARB_uniform_buffer_object/getintegeri_v. --- src/mesa/main/get.c | 24 1 file changed, 24 insertions(+) diff

Re: [Mesa-dev] [PATCH] softpipe: Take all lods into account when texture sampling.

2012-06-20 Thread Roland Scheidegger
On 06/20/2012 05:43 AM, Olivier Galibert wrote: On Tue, Jun 19, 2012 at 02:46:35PM -0700, Jose Fonseca wrote: Could you give more background on why is this necessary? This will make software renderering slower, so I'd really like to avoid it on llvmpipe if at all possible. Well, given the ex

Re: [Mesa-dev] [PATCH] softpipe: Take all lods into account when texture sampling.

2012-06-20 Thread Roland Scheidegger
On 06/19/2012 08:01 PM, Olivier Galibert wrote: This patch churns a lot because it needs to change 4-wide filters into single pixel filters, since each fragment may use a different filter. The only case not entirely supported is the anisotropic filtering. Not sure what we want to do there, since

Re: [Mesa-dev] [PATCH v2 03/21] mesa: Remove unnecessary parameters from TexImage

2012-06-20 Thread Kenneth Graunke
On 06/12/2012 11:38 AM, Pauli Nieminen wrote: > gl_texture_image structure always holds size and internal format before > TexImage driver hook is called. Those passing same information in > function parameters only duplicates information making the interface > harder to understand. > > Signed-off-

Re: [Mesa-dev] [PATCH v2 07/21] mesa/samplerobj: Support EXT_texture_sRGB_decode

2012-06-20 Thread Kenneth Graunke
On 06/12/2012 11:38 AM, Pauli Nieminen wrote: > sRGBDecode state is part of sampler object state but mesa was missing > handlers to access the state. This patch adds the support for required > state changes and queries. > > GL_EXT_texture_sRGB_decode issue 4: > "4) Should we add forward-looking su

Re: [Mesa-dev] [PATCH] scons: Do not build glx on Solaris.

2012-06-20 Thread Jose Fonseca
- Original Message - > On 06/19/2012 11:34 PM, Vinson Lee wrote: > > The GLX headers on Solaris are not recent enough. > > > > Signed-off-by: Vinson Lee > > --- > > src/SConscript |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/SConscript b/src/S

Re: [Mesa-dev] [PATCH 1/9] glapi: Add uniform buffer object API

2012-06-20 Thread Kenneth Graunke
On 06/18/2012 06:35 PM, Eric Anholt wrote: > From: Vincent Lejeune > > v2: Fix a typo spotted by Eric Anholt. > v3: Fix missing "GL" on types, fix style, fix Studly_Caps extension name, > drop commented code duplicated with GL3x.xml [anholt] Aside from the pithy comments and one tiny fix, th

Re: [Mesa-dev] [PATCH 8/9] mesa: Add support for glGetIntegeri_v from GL_ARB_uniform_buffer_object.

2012-06-20 Thread Kenneth Graunke
On 06/18/2012 06:35 PM, Eric Anholt wrote: > Fixes piglit ARB_uniform_buffer_object/getintegeri_v. > --- > src/mesa/main/get.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c > index 933bfe7..4798c02 100644 > --- a/src

Re: [Mesa-dev] [PATCH 7/9] mesa: Add support for glBindBufferBase/Range on GL_UNIFORM_BUFFER.

2012-06-20 Thread Kenneth Graunke
On 06/18/2012 06:35 PM, Eric Anholt wrote: > Fixes piglits: > GL_ARB_uniform_buffer_object/bindbuffer-general-point. > GL_ARB_uniform_buffer_object/negative-bindbuffer-buffer > GL_ARB_uniform_buffer_object/negative-bindbuffer-index > GL_ARB_uniform_buffer_object/negative-bindbuffer-target > GL_ARB_

Re: [Mesa-dev] [PATCH 2/9] mesa: Add state and getters for the GL_ARB_uniform_buffer_object maximums.

2012-06-20 Thread Kenneth Graunke
On 06/18/2012 06:35 PM, Eric Anholt wrote: > Fixes piglit GL_ARB_uniform_buffer_object/minmax. > --- > src/mesa/main/context.c |9 + > src/mesa/main/get.c | 30 ++ > src/mesa/main/mtypes.h | 12 > 3 files changed, 51 insertions(+) > >

Re: [Mesa-dev] [PATCH 2/3] glsl: glcpp: Move handling of #line directives from lexer to parser.

2012-06-20 Thread Kenneth Graunke
On 06/09/2012 04:41 PM, Carl Worth wrote: > The GLSL specification requires that #line directives be interpreted > after macro expansion. Our existing implementation of #line macros in > the lexer prevents conformance on this point. > > Moving the handling of #line from the lexer to the parser giv

Re: [Mesa-dev] [PATCH] mesa: remove obsolete confdiff.sh

2012-06-20 Thread Kenneth Graunke
On 06/19/2012 10:49 AM, Andreas Boll wrote: > this script is obsolete since > 0cc216676c96efacb0e1eb82457e6a83920ae704 > --- > bin/confdiff.sh | 48 > 1 files changed, 0 insertions(+), 48 deletions(-) > delete mode 100755 bin/confdiff.sh Heh! :D

Re: [Mesa-dev] [PATCH] scons: Do not build glx on Solaris.

2012-06-20 Thread Kenneth Graunke
On 06/19/2012 11:34 PM, Vinson Lee wrote: > The GLX headers on Solaris are not recent enough. > > Signed-off-by: Vinson Lee > --- > src/SConscript |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/SConscript b/src/SConscript > index 75c4446..f55a20e 100644 > ---

[Mesa-dev] [PATCH] scons: Do not build glx on Solaris.

2012-06-20 Thread Vinson Lee
The GLX headers on Solaris are not recent enough. Signed-off-by: Vinson Lee --- src/SConscript |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/SConscript b/src/SConscript index 75c4446..f55a20e 100644 --- a/src/SConscript +++ b/src/SConscript @@ -23,7 +23,7 @@ SCons

[Mesa-dev] [PATCH] scons: Add glsl/glcpp to the include path.

2012-06-20 Thread Vinson Lee
Fixes this build failure on Solaris. Compiling build/sunos-debug/glsl/glcpp/glcpp-lex.c ... "src/glsl/glcpp/glcpp-lex.l", line 30: cannot find include file: "glcpp-parse.h" Signed-off-by: Vinson Lee --- src/glsl/SConscript |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --