-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/16/2012 02:20 AM, Kenneth Graunke wrote:
> The idea here is to rewrite comparisons like 2 >= x with x <= 2; we want to
> simply exchange arguments, not negate
> the condition. If equality was part of the original comparison, it should
> remain part of the swapped version.
>
> This is the true cause of bug #50298. It didn't manifest itself on
> Sandybridge because we embed the conditional
> modifier in the IF instruction rather than emitting a CMP. All other
> platforms use CMP.
>
> It also didn't manifest itself on the master branch because commit be5f27a84d
> ("glsl: Refine the loop instruction
> counting.") papered over the problem.
>
> NOTE: This is a candidate for stable release branches.
>
> Cc: Eric Anholt <e...@anholt.net> Cc: Chad Versace
> <chad.vers...@linux.intel.com> Bugzilla:
> https://bugs.freedesktop.org/show_bug.cgi?id=50298 Signed-off-by: Kenneth
> Graunke <kenn...@whitecape.org> ---
> src/mesa/drivers/dri/i965/brw_eu.c | 8 ++++---- 1 file changed, 4
> insertions(+), 4 deletions(-)
Oh, wow...
Reviewed-by: Chad Versace <chad.vers...@linux.intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJP4ghCAAoJEAIvNt057x8iGrsP/j6iqPbU6wctahvRXuf4JOe8
YW/3jSKSS33JBIjqoWgJG4QdF3kQ+Pvd4KkvKqNIb4exErUVRQLeNodJPakyrkIC
dSyPUPepzfCK2H+iECcBd+Xtok1C71IrP1YCJxc0yH/hZSGYwxtMJzUdMX80e6oQ
mkyz3VvBu7dwpiZdGdaPK3nSEnCV9EYLdEKRfPuHj2mKd3KLuEYei5EAJST6rvlB
cDRLQ5nFe1JdruhXOJADL9Wc4rwSnHg2AFT/jhoi5q4mEGq6eU6yPL0G6n+bnc/c
0HS4TcOuQK3jMyZ997+8VhwmniqIqrZQYil+IvLDpJmZs76OZ0KiTHpsjY8L57bE
6jpUcF9r9EPslBE6ikNo2IXV+cFx+FbiGX3Hmzt7jsKw/iRnfY6LkG3rgrxsANqm
9DbMg3wi8o8ZbM0bD6Tn0ZVNcRNKy0O2jpbFASbUDawuvQ1suxoMg5/EAEOZ2xj7
FVwj44nQGWFaWmc9AsmMJJ8lbF/uH2WeToyRiyorjnaZhb2hIZhND4dzPF3hRmDm
k0egahLF+vAHo7dwr0ZnIRp+uD0bjtwYPZigQrwIQmYKvl2QNtu8oiCq3bLe55g3
qhm7fvlZMuu6O/uLScheiwjprhygwI8Qfy0VV54ym28cpOQluSmVhBFP0eGRdTe1
qE/R/GdSK1Wqmb7gPqAl
=UfrR
-----END PGP SIGNATURE-----
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
