[Mesa-dev] [PATCH] i915g: Check for geometry shader earlier in i915_set_constant_buffer.

2012-05-23 Thread Vinson Lee
Fix resource leak defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/i915/i915_state.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/i915/i915_state.c b/src/gallium/drivers/i915/i915_state.c index bd9e8ba..1ff5388

[Mesa-dev] [PATCH] scons: Fix SCons build infrastructure for FreeBSD.

2012-05-23 Thread Vinson Lee
This patch gets the FreeBSD SCons build working again. The build still fails though. Signed-off-by: Vinson Lee --- common.py |2 +- src/SConscript|2 +- src/gallium/SConscript|2 +- src/gallium/winsys/sw/xlib/SConscr

Re: [Mesa-dev] [PATCH] mesa: Remove the generated glapi from source control, and just build it.

2012-05-23 Thread Paul Berry
On 23 May 2012 13:33, Ian Romanick wrote: > On 05/23/2012 12:45 PM, Eric Anholt wrote: > >> Mesa already always depends on python to build. The checked in >> changes are not reviewed (because any trivial change rewrites the >> world). We also have been pushing commits between xml change and >>

Re: [Mesa-dev] [PATCH] mesa: Remove the generated glapi from source control, and just build it.

2012-05-23 Thread Kenneth Graunke
On 05/23/2012 01:33 PM, Ian Romanick wrote: > On 05/23/2012 12:45 PM, Eric Anholt wrote: >> Mesa already always depends on python to build. The checked in >> changes are not reviewed (because any trivial change rewrites the >> world). We also have been pushing commits between xml change and >> re

Re: [Mesa-dev] [PATCH] mesa: Remove the generated glapi from source control, and just build it.

2012-05-23 Thread Ian Romanick
On 05/23/2012 12:45 PM, Eric Anholt wrote: Mesa already always depends on python to build. The checked in changes are not reviewed (because any trivial change rewrites the world). We also have been pushing commits between xml change and regen where at-build-time xml-generated code disagrees wit

Re: [Mesa-dev] [PATCH] glsl/tests: Add .gitignore for uniform initialization unit test.

2012-05-23 Thread Ian Romanick
On 05/23/2012 01:00 PM, Paul Berry wrote: --- src/glsl/tests/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/glsl/tests/.gitignore b/src/glsl/tests/.gitignore index f3c7a7c..4f984b0 100644 --- a/src/glsl/tests/.gitignore +++ b/src/glsl/tests/.gitignore @

[Mesa-dev] [PATCH] glsl/tests: Add .gitignore for uniform initialization unit test.

2012-05-23 Thread Paul Berry
--- src/glsl/tests/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/glsl/tests/.gitignore b/src/glsl/tests/.gitignore index f3c7a7c..4f984b0 100644 --- a/src/glsl/tests/.gitignore +++ b/src/glsl/tests/.gitignore @@ -1 +1,2 @@ Makefile +uniform-initializer-te

[Mesa-dev] [PATCH] mesa: Remove the generated glapi from source control, and just build it.

2012-05-23 Thread Eric Anholt
Mesa already always depends on python to build. The checked in changes are not reviewed (because any trivial change rewrites the world). We also have been pushing commits between xml change and regen where at-build-time xml-generated code disagrees with committed xml-generated code. And worst of

[Mesa-dev] [PATCH v2] i965/blorp: Use 16 pixel dispatch on Gen7.

2012-05-23 Thread Paul Berry
Gen7 hardware requires us to enable at least one WM dispatch mode, even if there is no program being dispatched to. When this code was only used for HiZ operations (which don't use a WM program), we used 32-pixel dispatch, because it didn't matter. But blit programs are compiled for 16-pixel disp

Re: [Mesa-dev] [PATCH 07/15] i965/blorp: Use 16 pixel dispatch on Gen7 when there is a WM program.

2012-05-23 Thread Paul Berry
On 23 May 2012 11:15, Chad Versace wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/23/2012 10:22 AM, Kenneth Graunke wrote: > > On 05/23/2012 07:45 AM, Paul Berry wrote: > >> On 22 May 2012 13:02, Eric Anholt >> > wrote: > >> > >> On Fri, 11 May 201

Re: [Mesa-dev] [PATCH] i965/blorp: Implement destination clipping and scissoring

2012-05-23 Thread Paul Berry
On 22 May 2012 17:19, Eric Anholt wrote: > On Mon, 14 May 2012 15:47:35 -0700, Paul Berry > wrote: > > This patch implements clipping and scissoring of the destination rect > > for blits that use the blorp engine (e.g. MSAA blits). > > There's _mesa_clip_blit() used in swrast and state_tracker,

Re: [Mesa-dev] [PATCH] i965/blorp: Implement destination clipping and scissoring

2012-05-23 Thread Paul Berry
On 22 May 2012 11:08, Ian Romanick wrote: > On 05/14/2012 03:47 PM, Paul Berry wrote: > >> This patch implements clipping and scissoring of the destination rect >> for blits that use the blorp engine (e.g. MSAA blits). >> --- >> src/mesa/drivers/dri/i965/brw_**blorp_blit.cpp | 72 >> ++

Re: [Mesa-dev] [PATCH 07/15] i965/blorp: Use 16 pixel dispatch on Gen7 when there is a WM program.

2012-05-23 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/23/2012 10:22 AM, Kenneth Graunke wrote: > On 05/23/2012 07:45 AM, Paul Berry wrote: >> On 22 May 2012 13:02, Eric Anholt > > wrote: >> >> On Fri, 11 May 2012 11:03:50 -0700, Paul Berry >> mailto:stereotype...@gmai

Re: [Mesa-dev] [PATCH 1/7] glsl: Set initial values for uniforms in the linker

2012-05-23 Thread Kenneth Graunke
On 05/17/2012 09:41 AM, Ian Romanick wrote: From: Ian Romanick v2: Fix handling of arrays-of-structure. Thanks to Eric Anholt for pointing this out. Fixes piglit glsl-1.20/execution/uniform-initializer/fs-structure-array and glsl-1.20/execution/uniform-initializer/vs-structure-array. Signed-o

Re: [Mesa-dev] [PATCH 1/7] glsl: Set initial values for uniforms in the linker

2012-05-23 Thread Kenneth Graunke
On 05/17/2012 09:41 AM, Ian Romanick wrote: From: Ian Romanick v2: Fix handling of arrays-of-structure. Thanks to Eric Anholt for pointing this out. Fixes piglit glsl-1.20/execution/uniform-initializer/fs-structure-array and glsl-1.20/execution/uniform-initializer/vs-structure-array. Signed-o

Re: [Mesa-dev] [PATCH 07/15] i965/blorp: Use 16 pixel dispatch on Gen7 when there is a WM program.

2012-05-23 Thread Kenneth Graunke
On 05/23/2012 07:45 AM, Paul Berry wrote: On 22 May 2012 13:02, Eric Anholt mailto:e...@anholt.net>> wrote: On Fri, 11 May 2012 11:03:50 -0700, Paul Berry mailto:stereotype...@gmail.com>> wrote: > When executing a blorp operation on Gen7 that does not need a WM > program (i.e.

Re: [Mesa-dev] [PATCH 1/2] mesa: Keep a computed value for dual source blend func with each buffer.

2012-05-23 Thread Dave Airlie
On Sat, May 19, 2012 at 4:00 AM, Eric Anholt wrote: > The i965 driver needed this as well for hardware setup, so instead of > duplicating the logic, just save it off. > --- >  src/mesa/main/blend.c   |   20 >  src/mesa/main/context.c |   24 +++- >  src/mesa

Re: [Mesa-dev] [PATCH 11/15] i965/msaa: Properly handle sliced layout for Gen7.

2012-05-23 Thread Paul Berry
On 23 May 2012 09:47, Kenneth Graunke wrote: > On 05/23/2012 08:01 AM, Paul Berry wrote: > >> I also seem to recall that you found a subtlety about ARYSPC_LOD0 in the >> bspec yesterday that we'll need to keep in mind when we do revisit this >> topic. Do you remember what that was? I've forgott

Re: [Mesa-dev] [PATCH 11/15] i965/msaa: Properly handle sliced layout for Gen7.

2012-05-23 Thread Kenneth Graunke
On 05/23/2012 08:01 AM, Paul Berry wrote: On 22 May 2012 09:21, Paul Berry mailto:stereotype...@gmail.com>> wrote: On 22 May 2012 08:19, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote: On 05/11/2012 11:03 AM, Paul Berry wrote: Starting in Gen7, there are two possi

Re: [Mesa-dev] [PATCH 11/15] i965/msaa: Properly handle sliced layout for Gen7.

2012-05-23 Thread Paul Berry
On 22 May 2012 10:38, Ian Romanick wrote: > On 05/11/2012 11:03 AM, Paul Berry wrote: > >> Starting in Gen7, there are two possible layouts for MSAA surfaces: >> >> - Interleaved, in which additional samples are accommodated by scaling >> up the width and height of the surface. This is the onl

Re: [Mesa-dev] [PATCH] mesa: update color material in GetMaterialfv

2012-05-23 Thread Tapani Pälli
Hello; On 05/23/2012 05:53 PM, Brian Paul wrote: > On 05/23/2012 12:33 AM, Tapani Pälli wrote: >> color material state gets reseted when vertices are flushed, >> update state after flush. this change is written against piglit >> test 'colormaterial-query'. >> >> Signed-off-by: Tapani Pälli >> ---

Re: [Mesa-dev] Release of GLw?

2012-05-23 Thread Brian Paul
On 05/23/2012 09:27 AM, Sven Joachim wrote: On 2012-05-22 23:42 +0200, Brian Paul wrote: OK, the 8.0.0 version is at ftp://ftp.freedesktop.org/pub/mesa/glw/ Thanks! It seems what's left to make it "official" would be a tag in git and an announcement on the mesa-announce list, right? OK, I'

Re: [Mesa-dev] Release of GLw?

2012-05-23 Thread Sven Joachim
On 2012-05-22 23:42 +0200, Brian Paul wrote: > OK, the 8.0.0 version is at ftp://ftp.freedesktop.org/pub/mesa/glw/ Thanks! It seems what's left to make it "official" would be a tag in git and an announcement on the mesa-announce list, right? Cheers, Sven _

Re: [Mesa-dev] [PATCH 11/15] i965/msaa: Properly handle sliced layout for Gen7.

2012-05-23 Thread Paul Berry
On 22 May 2012 09:21, Paul Berry wrote: > On 22 May 2012 08:19, Kenneth Graunke wrote: > >> On 05/11/2012 11:03 AM, Paul Berry wrote: >> >>> Starting in Gen7, there are two possible layouts for MSAA surfaces: >>> >>> - Interleaved, in which additional samples are accommodated by scaling >>> up

Re: [Mesa-dev] [PATCH] mesa: update color material in GetMaterialfv

2012-05-23 Thread Brian Paul
On 05/23/2012 12:33 AM, Tapani Pälli wrote: color material state gets reseted when vertices are flushed, update state after flush. this change is written against piglit test 'colormaterial-query'. Signed-off-by: Tapani Pälli --- src/mesa/main/light.c |4 1 files changed, 4 insertions

Re: [Mesa-dev] [PATCH 07/15] i965/blorp: Use 16 pixel dispatch on Gen7 when there is a WM program.

2012-05-23 Thread Paul Berry
On 22 May 2012 13:02, Eric Anholt wrote: > On Fri, 11 May 2012 11:03:50 -0700, Paul Berry > wrote: > > When executing a blorp operation on Gen7 that does not need a WM > > program (i.e. a HiZ operation), we use 32-pixel dispatch mode because > > it's faster. However, when executing a blorp oper

Re: [Mesa-dev] [PATCH 10/11] clover: Add function for building a clover::module for non-TGSI targets v2

2012-05-23 Thread Francisco Jerez
Tom Stellard writes: > On Wed, May 23, 2012 at 02:04:20PM +0200, Francisco Jerez wrote: >>[...] >> Do we need this compatibility code? Don't you have to build a patched >> version of LLVM from sources for this to work anyway? >> > > You only need a patch if you want to use the r600 target. Thi

Re: [Mesa-dev] [PATCH v2] tgsi: Initialize Padding struct fields.

2012-05-23 Thread Brian Paul
On 05/23/2012 01:04 AM, Vinson Lee wrote: Fix uninitialized scalar variable defects report by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/tgsi/tgsi_build.c |4 1 file changed, 4 insertions(+) Reviewed-by: Brian Paul __

Re: [Mesa-dev] [PATCH 10/11] clover: Add function for building a clover::module for non-TGSI targets v2

2012-05-23 Thread Tom Stellard
On Wed, May 23, 2012 at 02:04:20PM +0200, Francisco Jerez wrote: > Tom Stellard writes: > > > v2: > > -Separate IR type and LLVM triple > > -Do the OpenCL C->LLVM IR and linking steps for all PIPE_SHADER_IR > >types. > > --- > > > > There really isn't much functional change in this patch

Re: [Mesa-dev] [PATCH 10/11] clover: Add function for building a clover::module for non-TGSI targets v2

2012-05-23 Thread Francisco Jerez
Tom Stellard writes: > v2: > -Separate IR type and LLVM triple > -Do the OpenCL C->LLVM IR and linking steps for all PIPE_SHADER_IR >types. > --- > > There really isn't much functional change in this patch from v1, the only > really difference is that the decision to emit LLVM or native m

Re: [Mesa-dev] [PATCH 01/11] configure.ac: Add HAVE_OPENCL AM_CONDITIONAL v2

2012-05-23 Thread Francisco Jerez
Tom Stellard writes: > v2: > - Drop HAVE_OPENCL variable for non-automake builds > - s/HAVE_OPENCL/HAVE_GALLIUM_COMPUTE > --- > configure.ac |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 3bb51a2..2805e7c 100644 > --- a/confi

Re: [Mesa-dev] [PATCH 09/11] clover: Add constructors to some of the module classes v2

2012-05-23 Thread Francisco Jerez
Tom Stellard writes: > This is for the llvm code that can't use extended initializers. > > v2: > - Use const references for vector arguments > - Move constructor defs before data members > - Initialize all values in the default constructors > --- > src/gallium/state_trackers/clover/core/mo

[Mesa-dev] [PATCH v2] tgsi: Initialize Padding struct fields.

2012-05-23 Thread Vinson Lee
Fix uninitialized scalar variable defects report by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/tgsi/tgsi_build.c |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c b/src/gallium/auxiliary/tgsi/tgsi_build.c index 1c24b9b..cb7b9b2