[Mesa-dev] [PATCH 2/2] i965/gen6+: Add support for GL_ARB_blend_func_extended.

v2: Add support for gen6, and don't turn it on if blending is disabled. (fixes GPU hang), and note it in docs/GL3.txt Reviewed-by: Kenneth Graunke --- docs/GL3.txt |2 +- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp |1 + src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 1/2] mesa: Keep a computed value for dual source blend func with each buffer.

The i965 driver needed this as well for hardware setup, so instead of duplicating the logic, just save it off. --- src/mesa/main/blend.c | 20 src/mesa/main/context.c | 24 +++- src/mesa/main/mtypes.h |5 + 3 files changed, 32 insertions(+),

Re: [Mesa-dev] IROUND() issue

Am 19.05.2012 02:43, schrieb Kurt Roeckx: > On Sat, May 19, 2012 at 02:19:36AM +0200, Roland Scheidegger wrote: >> Am 18.05.2012 23:55, schrieb Kurt Roeckx: >>> On Fri, May 18, 2012 at 09:11:38AM -0700, Jose Fonseca wrote: It sounds a sensible plan, but I wonder if the multiple iround >>>

Re: [Mesa-dev] IROUND() issue

On Sat, May 19, 2012 at 02:19:36AM +0200, Roland Scheidegger wrote: > Am 18.05.2012 23:55, schrieb Kurt Roeckx: > > On Fri, May 18, 2012 at 09:11:38AM -0700, Jose Fonseca wrote: > >> > >> It sounds a sensible plan, but I wonder if the multiple iround > >> versions are really worth it: SSE2 is guar

Re: [Mesa-dev] IROUND() issue

Am 18.05.2012 23:55, schrieb Kurt Roeckx: > On Fri, May 18, 2012 at 09:11:38AM -0700, Jose Fonseca wrote: >> >> It sounds a sensible plan, but I wonder if the multiple iround >> versions are really worth it: SSE2 is guaranteed in x64, so we >> could just start requiring SSE2 on x86, and only use t

Re: [Mesa-dev] [PATCH 1/2] mesa: reimplement IROUND(), add F_TO_I()

Am 19.05.2012 00:35, schrieb Brian Paul: > On 05/18/2012 03:54 PM, Roland Scheidegger wrote: >> Looks ok though I wonder if we really need our own assembly here? >> In particular if the compiler decides to use sse we really shouldn't use >> the fp stack for converting floats to ints. fistp is just

[Mesa-dev] Mesa 8.0.3 release

Mesa 8.0.3 has been released. Mesa 8.0.3 is a bug fix release which fixes bugs found since the 8.0.2 release. The tag in the GIT repository for Mesa 8.0.3 is 'mesa-8.0.3'. Mesa 8.0.3 is available for download at ftp://freedesktop.org/pub/mesa/8.0.3/ md5sums: b7210a6d6e4584bd852ab29294ce717e

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

On 05/17/2012 07:20 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 6:59 PM, Brian Paul wrote: On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paulwrote: On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not

Re: [Mesa-dev] [PATCH 1/2] mesa: reimplement IROUND(), add F_TO_I()

On 05/18/2012 02:10 PM, Brian Paul wrote: The different implementations of IROUND() behaved differently and in the case of fistp, depended on the current x86 FPU rounding mode. This caused some tests like piglit roundmode-pixelstore and roundmode-getintegerv to fail on 32-bit x86 but pass on 64-b

Re: [Mesa-dev] IROUND() issue

On 05/18/2012 03:55 PM, Kurt Roeckx wrote: On Fri, May 18, 2012 at 09:11:38AM -0700, Jose Fonseca wrote: It sounds a sensible plan, but I wonder if the multiple iround versions are really worth it: SSE2 is guaranteed in x64, so we could just start requiring SSE2 on x86, and only use the C for

Re: [Mesa-dev] [PATCH 1/2] mesa: reimplement IROUND(), add F_TO_I()

On 05/18/2012 03:54 PM, Roland Scheidegger wrote: Looks ok though I wonder if we really need our own assembly here? In particular if the compiler decides to use sse we really shouldn't use the fp stack for converting floats to ints. fistp is just twice as slow as sse conversion on newer cpus, and

Re: [Mesa-dev] IROUND() issue

On Fri, May 18, 2012 at 09:11:38AM -0700, Jose Fonseca wrote: > > It sounds a sensible plan, but I wonder if the multiple iround versions are > really worth it: SSE2 is guaranteed in x64, so we could just start requiring > SSE2 on x86, and only use the C for other platforms. Is the "start requi

Re: [Mesa-dev] [PATCH 1/2] mesa: reimplement IROUND(), add F_TO_I()

Looks ok though I wonder if we really need our own assembly here? In particular if the compiler decides to use sse we really shouldn't use the fp stack for converting floats to ints. fistp is just twice as slow as sse conversion on newer cpus, and additionally it might potentially involve moving va

[Mesa-dev] [PATCH] st/mesa: use pipe_sampler_view_release() in st_destroy_context_priv()

Fixes another case of sampler views being created by one context, shared by another, then deleted by the first, leaving a dangling pipe context pointer. --- src/mesa/state_tracker/st_context.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_conte

[Mesa-dev] [PATCH 1/2] mesa: reimplement IROUND(), add F_TO_I()

The different implementations of IROUND() behaved differently and in the case of fistp, depended on the current x86 FPU rounding mode. This caused some tests like piglit roundmode-pixelstore and roundmode-getintegerv to fail on 32-bit x86 but pass on 64-bit x86. Now IROUND() always rounds to the n

[Mesa-dev] [PATCH 2/2] mesa: use F_TO_I() instead of IROUND()

Use it where performance matters more and the exact method of float->int conversion/rounding isn't terribly important. There should no net change here since F_TO_I() is the new name of the old IROUND() function. --- src/mesa/main/macros.h | 10 +- src/mesa/main/pack.c| 220

Re: [Mesa-dev] [PATCH 1/1] mesa: stub the _mesa_StencilOp function.

On Fri, May 18, 2012 at 11:27:24AM -0600, Brian Paul wrote: > On 05/18/2012 05:24 AM, Oliver McFadden wrote: > > The device driver function table only implements StencilOpSeparate(), > > let's remove the obsolete 'todo' comment and code duplication. > > > > Signed-off-by: Oliver McFadden > > --- >

[Mesa-dev] [PATCH] mesa: fix Z32_FLOAT -> uint conversion functions

The IROUND converted all arguments to 0 or 1. That's not what we wanted. NOTE: This is a candidate for the 8.0 branch. --- src/mesa/main/format_unpack.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c index

[Mesa-dev] [Bug 50102] Test failure for fresh install

https://bugs.freedesktop.org/show_bug.cgi?id=50102 --- Comment #1 from Paul Seidler 2012-05-18 11:27:37 PDT --- Created attachment 61813 --> https://bugs.freedesktop.org/attachment.cgi?id=61813 Patch against 8.0 branch to use include/ -- Configure bugmail: https://bugs.freedesktop.org/userpr

[Mesa-dev] [Bug 50102] New: Test failure for fresh install

https://bugs.freedesktop.org/show_bug.cgi?id=50102 Bug #: 50102 Summary: Test failure for fresh install Classification: Unclassified Product: Mesa Version: unspecified Platform: All OS/Version: Linux (All) Status: NEW

Re: [Mesa-dev] IROUND() issue

- Original Message - > On Fri, May 18, 2012 at 11:28 AM, Brian Paul < bri...@vmware.com > > wrote: > > On 05/18/2012 10:11 AM, Jose Fonseca wrote: > > > > - Original Message - > > > > > > > A while back I noticed that the piglit roundmode-pixelstore and > > > > > > > > >

Re: [Mesa-dev] IROUND() issue

Am 18.05.2012 18:41, schrieb Patrick Baggett: > > > On Fri, May 18, 2012 at 11:28 AM, Brian Paul > wrote: > > On 05/18/2012 10:11 AM, Jose Fonseca wrote: > > > > - Original Message - > > > A while back I noticed that the piglit roun

Re: [Mesa-dev] [PATCH 1/1] mesa: stub the _mesa_StencilOp function.

On 05/18/2012 05:24 AM, Oliver McFadden wrote: The device driver function table only implements StencilOpSeparate(), let's remove the obsolete 'todo' comment and code duplication. Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |4 +- src/mesa/main/stencil.c| 7

Re: [Mesa-dev] Upcoming Mesa releases

On 05/18/2012 08:06 AM, Brian Paul wrote: On 05/18/2012 12:51 AM, Ian Romanick wrote: On 05/06/2012 01:12 PM, Kurt Roeckx wrote: On Sat, May 05, 2012 at 09:18:24PM -0700, Ian Romanick wrote: On 05/04/2012 03:57 PM, Kurt Roeckx wrote: On Fri, May 04, 2012 at 08:32:11AM -0700, Ian Romanick wrot

Re: [Mesa-dev] Upcoming Mesa releases

On 05/18/2012 03:30 AM, Kurt Roeckx wrote: On Thu, May 17, 2012 at 11:51:45PM -0700, Ian Romanick wrote: I've picked a bunch of these over. I didn't take ae92180 because it enables an extension (GL_ARB_draw_instanced) that wasn't previously enabled on 8.0.x. I'd do some more tomorrow. The c

Re: [Mesa-dev] IROUND() issue

On Fri, May 18, 2012 at 11:28 AM, Brian Paul wrote: > On 05/18/2012 10:11 AM, Jose Fonseca wrote: > >> >> >> - Original Message - >> >>> >>> A while back I noticed that the piglit roundmode-pixelstore and >>> roundmode-getinteger tests pass on my 64-bit Fedora system but fail >>> on >>> a

Re: [Mesa-dev] [PATCH] softpipe: Do round-to-even, not round-up.

On Fri, May 18, 2012 at 08:55:39AM -0600, Brian Paul wrote: > Doesn't the rint() function do the same thing as round-to-even? > Though, I'm not sure if rint() is available on Windows so we might > need your ieee754_fp32_round_half_to_even() function anyway. I'll try > to look into that. I kinda

Re: [Mesa-dev] IROUND() issue

On 05/18/2012 10:11 AM, Jose Fonseca wrote: - Original Message - A while back I noticed that the piglit roundmode-pixelstore and roundmode-getinteger tests pass on my 64-bit Fedora system but fail on a 32-bit Ubuntu system. Both glGetIntegerv() and glPixelStoref() use the IROUND()

Re: [Mesa-dev] IROUND() issue

- Original Message - > > A while back I noticed that the piglit roundmode-pixelstore and > roundmode-getinteger tests pass on my 64-bit Fedora system but fail > on > a 32-bit Ubuntu system. Both glGetIntegerv() and glPixelStoref() > use > the IROUND() function to convert floats to ints

[Mesa-dev] IROUND() issue

A while back I noticed that the piglit roundmode-pixelstore and roundmode-getinteger tests pass on my 64-bit Fedora system but fail on a 32-bit Ubuntu system. Both glGetIntegerv() and glPixelStoref() use the IROUND() function to convert floats to ints. The implementation if IROUND() that u

[Mesa-dev] Compile errors in mesa

Can someone have a look at the following compiler errors in current mesa git? They are blocking Debian / Ubuntu builds: [compile error] Makefile:29: *** target file `default' has both : and :: entries. Stop https://bugs.freedesktop.org/show_bug.cgi?id=49830 [Bisected] Mesa master compilation br

Re: [Mesa-dev] Upcoming Mesa releases

On 05/18/2012 12:51 AM, Ian Romanick wrote: On 05/06/2012 01:12 PM, Kurt Roeckx wrote: On Sat, May 05, 2012 at 09:18:24PM -0700, Ian Romanick wrote: On 05/04/2012 03:57 PM, Kurt Roeckx wrote: On Fri, May 04, 2012 at 08:32:11AM -0700, Ian Romanick wrote: Part of the reason there are so few ch

Re: [Mesa-dev] [PATCH v2] mesa: Remove undefinition of _P symbol.

On 05/18/2012 12:18 AM, Vinson Lee wrote: IRIX isn't used anymore. Signed-off-by: Vinson Lee --- src/mesa/main/compiler.h |6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 25d9810..bfa06f3 100644 --- a/src/mesa/main/compiler.

Re: [Mesa-dev] [PATCH] softpipe: Do round-to-even, not round-up.

On 05/18/2012 03:43 AM, Olivier Galibert wrote: Fixes the piglit roundEven tests. Signed-off-by: Olivier Galibert --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 76 ++-- 1 file changed, 72 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_

Re: [Mesa-dev] [PATCH 01/11] configure.ac: Add HAVE_OPENCL AM_CONDITIONAL

On Fri, May 18, 2012 at 12:36:56PM +0200, Francisco Jerez wrote: > Tom Stellard writes: > > > --- > > configs/autoconf.in |1 + > > configure.ac|3 +++ > > 2 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/configs/autoconf.in b/configs/autoconf.in > > index 3c

[Mesa-dev] [PATCH 1/1] mesa: stub the _mesa_StencilOp function.

The device driver function table only implements StencilOpSeparate(), let's remove the obsolete 'todo' comment and code duplication. Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |4 +- src/mesa/main/stencil.c| 75 ++- 2 files

[Mesa-dev] [Bug 45292] Compilation failure on d3d1x state tracker: ‘ID3D10Include’ has not been declared

https://bugs.freedesktop.org/show_bug.cgi?id=45292 epicmonkey changed: What|Removed |Added CC||m...@epicmonkey.org -- Configure bugmail:

Re: [Mesa-dev] [PATCH 01/11] configure.ac: Add HAVE_OPENCL AM_CONDITIONAL

Tom Stellard writes: > --- > configs/autoconf.in |1 + > configure.ac|3 +++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/configs/autoconf.in b/configs/autoconf.in > index 3c8f4c1..28f3cb4 100644 > --- a/configs/autoconf.in > +++ b/configs/autoconf.in > @@

Re: [Mesa-dev] [PATCH 09/11] clover: Add constructors to some of the module classes

Hi Tom, thanks for the patches, just a few suggestions inline. Tom Stellard writes: > This is for the llvm code that can't use extended initializers. > --- > src/gallium/state_trackers/clover/core/module.hpp | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --gi

Re: [Mesa-dev] Upcoming Mesa releases

On Thu, May 17, 2012 at 11:51:45PM -0700, Ian Romanick wrote: > > I've picked a bunch of these over. I didn't take ae92180 because it > enables an extension (GL_ARB_draw_instanced) that wasn't previously > enabled on 8.0.x. I'd do some more tomorrow. The commit message says it disables it for p

[Mesa-dev] [PATCH] softpipe: Do round-to-even, not round-up.

Fixes the piglit roundEven tests. Signed-off-by: Olivier Galibert --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 76 ++-- 1 file changed, 72 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c in