Re: [Mesa-dev] Upcoming Mesa releases

2012-05-17 Thread Ian Romanick
On 05/06/2012 01:12 PM, Kurt Roeckx wrote: On Sat, May 05, 2012 at 09:18:24PM -0700, Ian Romanick wrote: On 05/04/2012 03:57 PM, Kurt Roeckx wrote: On Fri, May 04, 2012 at 08:32:11AM -0700, Ian Romanick wrote: Part of the reason there are so few changes is that people get lazy about cherry pi

[Mesa-dev] [PATCH v2] mesa: Remove undefinition of _P symbol.

2012-05-17 Thread Vinson Lee
IRIX isn't used anymore. Signed-off-by: Vinson Lee --- src/mesa/main/compiler.h |6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 25d9810..bfa06f3 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -285,12 +

[Mesa-dev] [Bug 46376] display window will be black when run mesa demo gloss

2012-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46376 --- Comment #2 from libo 2012-05-17 19:03:57 UTC --- The issue still exists with the follow commits: Libdrm: (master)2.4.33-20-gd72a44c7c4f5eea9c1e5bb0c36cb9e0224b9ca22 Mesa: (8.0)fa68a8bae3961808288cfd84d5a7843f6fc0f317 Xserver

Re: [Mesa-dev] Upcoming Mesa releases

2012-05-17 Thread Ian Romanick
On 05/17/2012 04:54 PM, Kurt Roeckx wrote: On Sun, May 06, 2012 at 10:12:36PM +0200, Kurt Roeckx wrote: On Sat, May 05, 2012 at 09:18:24PM -0700, Ian Romanick wrote: On 05/04/2012 03:57 PM, Kurt Roeckx wrote: On Fri, May 04, 2012 at 08:32:11AM -0700, Ian Romanick wrote: Part of the reason th

Re: [Mesa-dev] Upcoming Mesa releases

2012-05-17 Thread Kurt Roeckx
On Sun, May 06, 2012 at 10:12:36PM +0200, Kurt Roeckx wrote: > On Sat, May 05, 2012 at 09:18:24PM -0700, Ian Romanick wrote: > > On 05/04/2012 03:57 PM, Kurt Roeckx wrote: > > >On Fri, May 04, 2012 at 08:32:11AM -0700, Ian Romanick wrote: > > >> > > >>Part of the reason there are so few changes is

Re: [Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Jose Fonseca
I commited after doing the last tweaks that Roland mentioned. Thanks Jose - Original Message - > Still have a comment, but it's really trivial and either way it's > fine so: > Reviewed-by: Roland Scheidegger > > Am 17.05.2012 16:48, schrieb Olivier Galibert: > > Piglits test for fragmen

Re: [Mesa-dev] [PATCH] llvmpipe: Don't mess with the provoking vertex when inverting a triangle.

2012-05-17 Thread Jose Fonseca
Pushed. Thanks. Jose - Original Message - > Fixes a bunch of piglit tests related to flat interpolation of > floats. > > Signed-off-by: Olivier Galibert > --- > src/gallium/drivers/llvmpipe/lp_setup_tri.c | 45 > --- > 1 file changed, 40 insertions(+), 5 dele

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-17 Thread Ian Romanick
On 05/17/2012 03:43 PM, Paul Berry wrote: On 17 May 2012 11:21, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 05/14/2012 06:24 PM, Paul Berry wrote: On 14 May 2012 16:50, Ian Romanick mailto:i...@freedesktop.org>

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-17 Thread Paul Berry
On 17 May 2012 11:21, Ian Romanick wrote: > On 05/14/2012 06:24 PM, Paul Berry wrote: > >> On 14 May 2012 16:50, Ian Romanick > > wrote: >> >>On 05/14/2012 02:13 PM, Paul Berry wrote: >> >>Just to update the list: I had an in-person meeting with Eric, >>

Re: [Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Roland Scheidegger
Still have a comment, but it's really trivial and either way it's fine so: Reviewed-by: Roland Scheidegger Am 17.05.2012 16:48, schrieb Olivier Galibert: > Piglits test for fragment shaders pass, vertex shaders fail. The > actual failure seems to be in the interpolators, and not the > textureSiz

Re: [Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Roland Scheidegger
Am 17.05.2012 16:41, schrieb Olivier Galibert: > On Thu, May 17, 2012 at 04:34:31PM +0200, Roland Scheidegger wrote: >>> + bld_int_vec.zero = lp_build_zero(gallivm, bld_int_vec.type); >>> + bld_int_vec.one = lp_build_one (gallivm, bld_int_vec.type); >> This is unnecessary. build_context_init()

Re: [Mesa-dev] [PATCH 5/6] Bitwise conversion operator support in the software renderers.

2012-05-17 Thread Ian Romanick
On 05/08/2012 11:40 AM, Olivier Galibert wrote: TGSI doesn't need an opcode, since registers are untyped (but beware once doubles come into the scene). Mesa IR doesn't handle native integers, so trying to handle them there is worthless, the case entries are only added for warning reasons. It wa

Re: [Mesa-dev] [PATCH 0/6] ARB_shader_bit_encoding support

2012-05-17 Thread Ian Romanick
On 05/08/2012 11:40 AM, Olivier Galibert wrote: Hi, Here is the second and hopefully last version of the bit encoding support. I think I took all reviews into account (dropping mesa ir, activating at the end, and style). piglit says nothing changed, which is expected given that the associat

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen6: Initial implementation of MSAA.

2012-05-17 Thread Ian Romanick
On 05/14/2012 06:24 PM, Paul Berry wrote: On 14 May 2012 16:50, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 05/14/2012 02:13 PM, Paul Berry wrote: Just to update the list: I had an in-person meeting with Eric, Ian, and Ken today to discuss the design of the

[Mesa-dev] [PATCH v2 3/3] i965: use cut index to handle primitive restart when possible

2012-05-17 Thread Jordan Justen
If the primitive restart index and the primitive type can be handled by the cut index feature, then use the hardware to handle the primitive restart feature. The VBO module's software handling of primitive restart is used as a fall back. Signed-off-by: Jordan Justen Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH v2 2/3] i965: add flag to enable cut_index

2012-05-17 Thread Jordan Justen
When brw->prim_restart.enable_cut_index is set, the cut index will be enabled when uploading index_buffer commands. Signed-off-by: Jordan Justen Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.c |1 + src/mesa/drivers/dri/i965/brw_context.h |1 + src/mesa/

[Mesa-dev] [PATCH v2 1/3] i965: create code path to handle primitive restart in hardware

2012-05-17 Thread Jordan Justen
For newer hardware we disable the VBO module's software handling of primitive restart. We now handle primitive restarts in brw_handle_primitive_restart. The initial version of brw_handle_primitive_restart simply calls vbo_sw_primitive_restart, and therefore still uses the VBO module software primi

[Mesa-dev] [PATCH v2 0/3] add i965 primitive restart hardware support where possible

2012-05-17 Thread Jordan Justen
v2: * Only enable NV_primitive_restart for gen >= 4 * Move function names to the beginning of lines * Don't include brw_context.h from brw_draw.h * brw_handle_primitive_restart returns GLboolean instead of bool * Only call vbo_sw_primitive_restart once in brw_handle_primitive_restart *

Re: [Mesa-dev] [PATCH 0/6] ARB_shader_bit_encoding support

2012-05-17 Thread Eric Anholt
On Tue, 8 May 2012 20:40:31 +0200, Olivier Galibert wrote: > Hi, > > Here is the second and hopefully last version of the bit encoding > support. I think I took all reviews into account (dropping mesa ir, > activating at the end, and style). piglit says nothing changed, which > is expected g

Re: [Mesa-dev] [PATCH] mesa: add GLSL_REPORT_ERRORS debug flag

2012-05-17 Thread Kenneth Graunke
On 05/17/2012 06:46 AM, Brian Paul wrote: If the MESA_GLSL env var contains "errors", GLSL compilation and link errors will be reported to stderr. --- src/mesa/main/mtypes.h|1 + src/mesa/main/shaderapi.c | 14 ++ 2 files changed, 15 insertions(+), 0 deletions(-) Usefu

Re: [Mesa-dev] [PATCH 1/7] glsl: Set initial values for uniforms in the linker

2012-05-17 Thread Eric Anholt
On Thu, 17 May 2012 09:41:16 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > v2: Fix handling of arrays-of-structure. Thanks to Eric Anholt for > pointing this out. > > Fixes piglit glsl-1.20/execution/uniform-initializer/fs-structure-array > and glsl-1.20/execution/uniform-initializer/v

Re: [Mesa-dev] [PATCH] mesa: add GLSL_REPORT_ERRORS debug flag

2012-05-17 Thread Ian Romanick
On 05/17/2012 06:46 AM, Brian Paul wrote: If the MESA_GLSL env var contains "errors", GLSL compilation and link errors will be reported to stderr. Reviewed-by: Ian Romanick --- src/mesa/main/mtypes.h|1 + src/mesa/main/shaderapi.c | 14 ++ 2 files changed, 15 insert

Re: [Mesa-dev] [PATCH] i965: Gut the separate OpenGL ES extension enabling.

2012-05-17 Thread Ian Romanick
On 05/15/2012 03:49 PM, Kenneth Graunke wrote: We should just set the bits of functionality that we support; the GL/ES1/ES2 flags in extensions.c will take care of advertising the appropriate extensions for the current API. This enables the GL_EXT_texture_compression_dxt1 extension on ES1/ES2 wh

Re: [Mesa-dev] [PATCH] mesa: Remove the OES_draw_texture extension from ES2.

2012-05-17 Thread Ian Romanick
On 05/15/2012 03:50 PM, Kenneth Graunke wrote: This extension appears to be written against ES 1.0. In ES 2.0, you really want to be using FBOs instead. I did a little archaeology. It looks like the patch that originally added this functionality (34064756a5e2c8952c9de26eaebafddabd562540) only

[Mesa-dev] [Bug 49539] [softpipe] piglit vs-attrib-ivec4-implied regression

2012-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49539 --- Comment #2 from Ian Romanick 2012-05-17 09:50:32 PDT --- (In reply to comment #0) > Run piglit vs-attrib-ivec4-implied on softpipe. > > $ ./bin/shader_runner > tests/spec/glsl-1.30/execution/vs-attrib-ivec4-implied.shader_test -auto > Mesa

[Mesa-dev] [PATCH 7/7] glsl/tests: Add test for uniform initialization by the linker

2012-05-17 Thread Ian Romanick
From: Ian Romanick v2: Put unit tests in src/glsl/tests rather than tests/glsl. Signed-off-by: Ian Romanick --- src/glsl/tests/Makefile.am| 26 +- src/glsl/tests/copy_constant_to_storage_tests.cpp | 294 +++ src/glsl/tests/set_uniform_initializer_tests.cpp |

[Mesa-dev] [PATCH 2/7] glsl: Initialize samplers to 0, propagate sampler values to the gl_program

2012-05-17 Thread Ian Romanick
From: Ian Romanick The spec requires that samplers be initialized to 0. Since this differs from the 1-to-1 mapping of samplers to texture units assumed by ARB assembly shaders (and the gl_program structure), be sure to propagate this date from the gl_shader_program to the gl_program. Signed-off

[Mesa-dev] [PATCH 4/7] ir_to_mesa: Propagate initial values in _mesa_associate_uniform_storage

2012-05-17 Thread Ian Romanick
From: Ian Romanick The linker may have set initial values for uniforms. Propagate these values to the driver's backing storage when it is first associated. Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/mesa/program/ir_to_mesa.cpp |9 + 1 files changed, 9 insertions

[Mesa-dev] [PATCH 6/7] mesa: Use initializers to configure samplers

2012-05-17 Thread Ian Romanick
From: Ian Romanick Now that the linker handles initializers of samplers just like any other uniform, a bunch of this annoying code is unnecessary. Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/mesa/main/ff_fragment_shader.cpp | 41 +++-- 1 files ch

[Mesa-dev] [PATCH 3/7] glsl: Propagate sampler uniform initializers to gl_shader_program::SamplerUnits

2012-05-17 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/glsl/link_uniform_initializers.cpp |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp index d363463..32

[Mesa-dev] [PATCH 5/7] ir_to_mesa: Don't set initial uniform values again

2012-05-17 Thread Ian Romanick
From: Ian Romanick This work is now done by the linker, so we don't need to keep doing it here. Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/mesa/program/ir_to_mesa.cpp | 104 --- 1 files changed, 0 insertions(+), 104 deletions(-) diff --g

[Mesa-dev] [PATCH 1/7] glsl: Set initial values for uniforms in the linker

2012-05-17 Thread Ian Romanick
From: Ian Romanick v2: Fix handling of arrays-of-structure. Thanks to Eric Anholt for pointing this out. Fixes piglit glsl-1.20/execution/uniform-initializer/fs-structure-array and glsl-1.20/execution/uniform-initializer/vs-structure-array. Signed-off-by: Ian Romanick --- src/glsl/Makefile.s

[Mesa-dev] [PATCH 0/7 v2] Refactor uniform initializer handling

2012-05-17 Thread Ian Romanick
This was a bit of follow-on work that I had wanted to do back when I did all the other uniform rework. Setting the initial values for uniforms (that have initializers in the GLSL code) is moved from ir_to_mesa to the linker. In addition, support for initializers on samplers is added. This gives

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-17 Thread Marek Olšák
On Thu, May 17, 2012 at 3:34 PM, Brian Paul wrote: > On 05/17/2012 07:20 AM, Marek Olšák wrote: >> >> On Mon, May 14, 2012 at 6:59 PM, Brian Paul  wrote: >>> >>> On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paul    wrote: > > > On 05/

Re: [Mesa-dev] Release of GLw?

2012-05-17 Thread Sven Joachim
On 2012-05-17 15:58 +0200, Brian Paul wrote: > On 05/17/2012 04:42 AM, Sven Joachim wrote: >> Hi, >> >> Commit 63720114b42 in mesa removed the GLw source which is now provided >> in a separate source tree. However, no release has been made from that >> tree yet, so users of Mesa 8.0+ have to reso

[Mesa-dev] [Bug 49996] DH61AG - HD Graphics 3000 - OpenGL sampler objects on Ubuntu Linux 12.04 do not work

2012-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49996 Kenneth Graunke changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |kenn...@whitecape.org

[Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Olivier Galibert
Piglits test for fragment shaders pass, vertex shaders fail. The actual failure seems to be in the interpolators, and not the textureSize query. Signed-off-by: Olivier Galibert --- src/gallium/auxiliary/draw/draw_llvm_sample.c | 23 ++ src/gallium/auxiliary/gallivm/lp_bld_sample.c

Re: [Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Olivier Galibert
On Thu, May 17, 2012 at 04:34:31PM +0200, Roland Scheidegger wrote: > > + bld_int_vec.zero = lp_build_zero(gallivm, bld_int_vec.type); > > + bld_int_vec.one = lp_build_one (gallivm, bld_int_vec.type); > This is unnecessary. build_context_init() will take care of initializing > the zero/one val

Re: [Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Roland Scheidegger
This looks good to me. Minor nitpicks below. Am 17.05.2012 10:34, schrieb Olivier Galibert: > Piglits test for fragment shaders pass, vertex shaders fail. The > actual failure seems to be in the interpolators, and not the > textureSize query. > > Signed-off-by: Olivier Galibert > --- > src/gal

Re: [Mesa-dev] Release of GLw?

2012-05-17 Thread Brian Paul
On 05/17/2012 04:42 AM, Sven Joachim wrote: Hi, Commit 63720114b42 in mesa removed the GLw source which is now provided in a separate source tree. However, no release has been made from that tree yet, so users of Mesa 8.0+ have to resort to the git tree to obtain GLw. I don't personally care a

[Mesa-dev] [PATCH] mesa: add GLSL_REPORT_ERRORS debug flag

2012-05-17 Thread Brian Paul
If the MESA_GLSL env var contains "errors", GLSL compilation and link errors will be reported to stderr. --- src/mesa/main/mtypes.h|1 + src/mesa/main/shaderapi.c | 14 ++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/m

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-17 Thread Brian Paul
On 05/17/2012 07:20 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 6:59 PM, Brian Paul wrote: On 05/14/2012 10:44 AM, Marek Olšák wrote: On Mon, May 14, 2012 at 4:40 PM, Brian Paulwrote: On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not

Re: [Mesa-dev] [PATCH] mesa: initialize renderbuffer fields even if AllocStorage fails

2012-05-17 Thread Marek Olšák
On Mon, May 14, 2012 at 6:59 PM, Brian Paul wrote: > On 05/14/2012 10:44 AM, Marek Olšák wrote: >> >> On Mon, May 14, 2012 at 4:40 PM, Brian Paul  wrote: >>> >>> On 05/12/2012 10:11 AM, Marek Olšák wrote: It may fail with an unsupported format, but that's not an allowed case wh

Re: [Mesa-dev] [PATCH] mesa: Only undefine _P on IRIX.

2012-05-17 Thread Brian Paul
On 05/17/2012 12:32 AM, Vinson Lee wrote: Per the comment _P is a macro on IRIX, so only undefine it on IRIX. This fixes a compiler error on Cygwin, which has a _P symbol defined and used in ctypes.h. Signed-off-by: Vinson Lee --- src/mesa/main/compiler.h |2 ++ 1 file changed, 2 inserti

Re: [Mesa-dev] [PATCH] gallium/tgsi/text: Ensure ret is initialized in parse_immediate_data.

2012-05-17 Thread Brian Paul
On 05/17/2012 12:50 AM, Vinson Lee wrote: Fix uninitialized scalar variable defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/tgsi/tgsi_text.c |4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c b/src/gallium/auxili

[Mesa-dev] Release of GLw?

2012-05-17 Thread Sven Joachim
Hi, Commit 63720114b42 in mesa removed the GLw source which is now provided in a separate source tree. However, no release has been made from that tree yet, so users of Mesa 8.0+ have to resort to the git tree to obtain GLw. I don't personally care about GLw, but in Debian there are still a few

Re: [Mesa-dev] Loading and executing an R600 program

2012-05-17 Thread Miguel Ramos
2012/5/16 Alex Deucher : > Initial OpenCL support is starting to fall into place in mesa, but > it's focused on evergreen and newer asics as they have a dedicated > compute pipeline in addition to the 3D pipeline.  The compute pipeline > is a lot simpler to set up compared to the 3D pipeline.  See:

Re: [Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Olivier Galibert
On Wed, May 16, 2012 at 05:34:25PM +0200, Roland Scheidegger wrote: > For the hw it will definitely be easier. [...] Well, you know what? A good night's sleep helps immensely. It works out, I think. Check the patch I've sent, it's even more readable :-) OG. _

[Mesa-dev] [PATCH] llvmpipe: Implement TXQ.

2012-05-17 Thread Olivier Galibert
Piglits test for fragment shaders pass, vertex shaders fail. The actual failure seems to be in the interpolators, and not the textureSize query. Signed-off-by: Olivier Galibert --- src/gallium/auxiliary/draw/draw_llvm_sample.c | 23 ++ src/gallium/auxiliary/gallivm/lp_bld_sample.c

[Mesa-dev] [PATCH] llvmpipe: Don't mess with the provoking vertex when inverting a triangle.

2012-05-17 Thread Olivier Galibert
Fixes a bunch of piglit tests related to flat interpolation of floats. Signed-off-by: Olivier Galibert --- src/gallium/drivers/llvmpipe/lp_setup_tri.c | 45 --- 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_setup_tri.c b