Re: [Mesa-dev] [PATCH] intel:i915:i965: enable mipmap layout right mode

2012-03-18 Thread Yuanhan Liu
On Fri, Mar 16, 2012 at 11:13:23AM -0700, Eric Anholt wrote: > On Thu, 15 Mar 2012 14:42:53 +0800, Yuanhan Liu > wrote: > > There are two mipmap layout modes: below and right. And we currently just > > use _below_ mode. And in some cases, like height is greater than width, > > it would be better

Re: [Mesa-dev] [PATCH 1/6] glx: Convert to automake.

2012-03-18 Thread Matt Turner
On Sun, Mar 18, 2012 at 10:17 PM, Matt Turner wrote: > On Mon, Mar 5, 2012 at 9:37 PM, Eric Anholt wrote: >> On Thu, 1 Mar 2012 19:18:50 +0100, Marek Olšák wrote: >>> On Thu, Mar 1, 2012 at 5:28 PM, Eric Anholt wrote: >>> > On Thu, 1 Mar 2012 16:50:40 +0100, Marek Olšák wrote: >>> >> Hi Eric,

Re: [Mesa-dev] [PATCH 1/6] glx: Convert to automake.

2012-03-18 Thread Matt Turner
On Mon, Mar 5, 2012 at 9:37 PM, Eric Anholt wrote: > On Thu, 1 Mar 2012 19:18:50 +0100, Marek Olšák wrote: >> On Thu, Mar 1, 2012 at 5:28 PM, Eric Anholt wrote: >> > On Thu, 1 Mar 2012 16:50:40 +0100, Marek Olšák wrote: >> >> Hi Eric, >> >> >> >> this commit breaks StarCraft II running on Wine

Re: [Mesa-dev] [PATCH] softpipe: set max cube texture size to 4Kx4K

2012-03-18 Thread Yuanhan Liu
On Sun, Mar 18, 2012 at 10:49:00AM -0600, Brian Paul wrote: > The max size was 16Kx16K so a 4 byte/pixel, six-sided cube would require > 6 GBytes of memory. If mipmapped, 8 GB. Reduce the max size to 4K to > make the total size more reasonable. > > Fixes a crash with the new piglit max-texture-s

Re: [Mesa-dev] [PATCH 3/6] intel: Handle devid overrides using libdrm.

2012-03-18 Thread Yuanhan Liu
On Fri, Mar 16, 2012 at 04:26:43PM -0700, Eric Anholt wrote: > --- > src/mesa/drivers/dri/intel/intel_screen.c | 23 --- > 1 files changed, 4 insertions(+), 19 deletions(-) > > diff --git a/src/mesa/drivers/dri/intel/intel_screen.c > b/src/mesa/drivers/dri/intel/intel_scree

Re: [Mesa-dev] [PATCH 2/6] intel: Ask libdrm to dump an AUB file if INTEL_DEBUG=aub.

2012-03-18 Thread Yuanhan Liu
On Fri, Mar 16, 2012 at 04:26:42PM -0700, Eric Anholt wrote: > It also asks for BMPs in the aub file at SwapBuffers time. > --- > src/mesa/drivers/dri/intel/intel_context.c |4 +++ > src/mesa/drivers/dri/intel/intel_context.h |1 + > src/mesa/drivers/dri/intel/intel_screen.c | 32 > +++

Re: [Mesa-dev] [PATCH 1/6] glx: Convert to automake.

2012-03-18 Thread Marek Olšák
On Tue, Mar 6, 2012 at 3:37 AM, Eric Anholt wrote: > On Thu, 1 Mar 2012 19:18:50 +0100, Marek Olšák wrote: >> On Thu, Mar 1, 2012 at 5:28 PM, Eric Anholt wrote: >> > On Thu, 1 Mar 2012 16:50:40 +0100, Marek Olšák wrote: >> >> Hi Eric, >> >> >> >> this commit breaks StarCraft II running on Wine

[Mesa-dev] [Bug 47478] New: [wine] Passing 0xffffffff as GLX_DRAWABLE_TYPE

2012-03-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47478 Bug #: 47478 Summary: [wine] Passing 0x as GLX_DRAWABLE_TYPE Classification: Unclassified Product: Mesa Version: git Platform: Other OS/Version: All Status: NE

Re: [Mesa-dev] unpack functions showing up highly in profiles

2012-03-18 Thread Henri Verbeet
On 18 March 2012 17:47, Matt Turner wrote: > SC2's call chain for unpack_uint_z_X8_Z24 is > > unpack_uint_z_X8_Z24 >  - _mesa_unpack_uint_z_row >  - _mesa_readpixels >   - intelReadPixels >    - copy_tex_sub_image.isra.3 >     - intelCopyTexSubImage2D >      - copyteximage >       - shared_dispatc

[Mesa-dev] [PATCH 13/13] mesa: add integer texture completeness check

2012-03-18 Thread Brian Paul
Per the spec, only nearest filtering is supported for integer textures. Otherwise, the texture is incomplete. --- src/mesa/main/mtypes.h |1 + src/mesa/main/texobj.c |6 ++ src/mesa/main/texobj.h |8 3 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 11/13] mesa: add _mesa_is_mipmap_filter() helper

2012-03-18 Thread Brian Paul
--- src/mesa/main/samplerobj.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/samplerobj.h b/src/mesa/main/samplerobj.h index c22d025..0bfda43 100644 --- a/src/mesa/main/samplerobj.h +++ b/src/mesa/main/samplerobj.h @@ -37,6 +37,15 @@ _mesa_get_sampl

[Mesa-dev] [PATCH 10/13] mesa: use _mesa_dirty_texobj() in glTexParameter code

2012-03-18 Thread Brian Paul
--- src/mesa/main/texparam.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index 9a2ec51..205f51f 100644 --- a/src/mesa/main/texparam.c +++ b/src/mesa/main/texparam.c @@ -41,6 +41,7 @@ #include "main/mtypes.h" #incl

[Mesa-dev] [PATCH 09/13] mesa: use _mesa_dirty_texobj() function

2012-03-18 Thread Brian Paul
To mark the texture object as incomplete. --- src/mesa/main/teximage.c | 17 + 1 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index cf0a0cb..c541182 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/texi

[Mesa-dev] [PATCH 12/13] mesa: rework texture completeness testing

2012-03-18 Thread Brian Paul
Instead of gl_texture_object::_Complete there are now two fields: _BaseComplete and _MipmapComplete. The former indicates whether the base texture level is valid. The later indicates whether the whole mipmap is valid. With sampler objects, a single texture can appear to be both complete and inco

[Mesa-dev] [PATCH 08/13] mesa: rewrite/consolidate code in _mesa_test_texobj_completeness()

2012-03-18 Thread Brian Paul
Merge the mipmap level checking code that was separate cases for 1D, 2D, 3D and CUBE before. --- src/mesa/main/texobj.c | 183 1 files changed, 45 insertions(+), 138 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 5

[Mesa-dev] [PATCH 07/13] mesa: use new baseImage var to simplify _mesa_test_texobj_completeness()

2012-03-18 Thread Brian Paul
--- src/mesa/main/texobj.c | 51 +-- 1 files changed, 27 insertions(+), 24 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 2f2223a..535ea74 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -426,6 +426

[Mesa-dev] [PATCH 06/13] mesa: add comments in _mesa_test_texobj_completeness() related to the spec

2012-03-18 Thread Brian Paul
--- src/mesa/main/texobj.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 3d89ca1..2f2223a 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -497,9 +497,9 @@ _mesa_test_texobj_completeness( const s

[Mesa-dev] [PATCH 05/13] mesa: better debug message in _mesa_test_texobj_completeness()

2012-03-18 Thread Brian Paul
--- src/mesa/main/texobj.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 9934f2a..3d89ca1 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -454,7 +454,7 @@ _mesa_test_texobj_completeness( const str

[Mesa-dev] [PATCH 04/13] mesa: move some code in _mesa_test_texobj_completeness()

2012-03-18 Thread Brian Paul
Move the simple MaxLevel < BaseLevel test earlier to be closer to where we error-check BaseLevel. Also, use the local baseLevel var in more places. --- src/mesa/main/texobj.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/ma

[Mesa-dev] [PATCH 03/13] mesa: use switch(target) in _mesa_test_texobj_completeness()

2012-03-18 Thread Brian Paul
and add missing case for GL_TEXTURE_BUFFER. --- src/mesa/main/texobj.c | 34 +++--- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index def09e2..1611ba7 100644 --- a/src/mesa/main/texobj.c +++ b/src/me

[Mesa-dev] [PATCH 02/13] mesa: use MAX3() macro for 3D texture in _mesa_test_texobj_completeness()

2012-03-18 Thread Brian Paul
--- src/mesa/main/texobj.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 5905948..def09e2 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -465,9 +465,9 @@ _mesa_test_texobj_completeness( const

[Mesa-dev] [PATCH 01/13] mesa: make _mesa_reference_sampler_object() an inline function

2012-03-18 Thread Brian Paul
To make the no-change case faster, as we do for the other object-reference functions. --- src/mesa/main/samplerobj.c |9 - src/mesa/main/samplerobj.h | 12 +++- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplero

[Mesa-dev] [PATCH] softpipe: set max cube texture size to 4Kx4K

2012-03-18 Thread Brian Paul
The max size was 16Kx16K so a 4 byte/pixel, six-sided cube would require 6 GBytes of memory. If mipmapped, 8 GB. Reduce the max size to 4K to make the total size more reasonable. Fixes a crash with the new piglit max-texture-size test. --- src/gallium/drivers/softpipe/sp_limits.h |1 + src/

Re: [Mesa-dev] unpack functions showing up highly in profiles

2012-03-18 Thread Matt Turner
On Sun, Mar 18, 2012 at 10:13 AM, Brian Paul wrote: > On Sat, Mar 17, 2012 at 7:55 PM, Matt Turner wrote: >> Hey >> >> On my i965/SNB system I profiled some games in WINE and saw that some >> unpack_* functions in src/mesa/main/format_unpack.c show up very >> highly. >> >> In Day of Defeat: Sourc

Re: [Mesa-dev] unpack functions showing up highly in profiles

2012-03-18 Thread Brian Paul
On Sat, Mar 17, 2012 at 7:55 PM, Matt Turner wrote: > Hey > > On my i965/SNB system I profiled some games in WINE and saw that some > unpack_* functions in src/mesa/main/format_unpack.c show up very > highly. > > In Day of Defeat: Source and Counter Strike: Source, the > _mesa_unpack_uint_z_row fu