Re: [Mesa-dev] nvfx assertion and XvMC state tracker.

2011-09-05 Thread Younes Manton
On Mon, Sep 5, 2011 at 11:35 PM, Andrew Randrianasulu wrote: > Hello. > > Just tested http://repo.or.cz/w/mesa/nouveau-pmpeg.git/ (commit > 25363beccacc70a514045283bbe14951262f7b1f, "nouveau video fixup") with my nv43. > > At first, i got only nv40_fragtex.c:50: nv40_sampler_view_init: Assertion >

Re: [Mesa-dev] [PATCH 08/13] r600g: always decompress all mipmaps and layers, slices, or faces of zbuffers

2011-09-05 Thread Dave Airlie
On Mon, Sep 5, 2011 at 10:44 PM, Marek Olšák wrote: > This fixes piglit/fbo-depth-array. > --- >  src/gallium/drivers/r600/r600_blit.c    |   63 > +-- >  src/gallium/drivers/r600/r600_texture.c |   14 +++ >  2 files changed, 49 insertions(+), 28 deletions(-) Revie

Re: [Mesa-dev] [PATCH 07/13] r600g: fix texture array filtering

2011-09-05 Thread Dave Airlie
On Mon, Sep 5, 2011 at 10:44 PM, Marek Olšák wrote: > This fixes piglit/fbo-generatemipmap-array. > > It looks like SQ_TEX_SAMPLER_WORD0_0.TEX_ARRAY_OVERRIDE should be set > for array textures in order to disable filtering between slices, > which adds a dependency between sampler views and sampler

Re: [Mesa-dev] [PATCH 04/13] u_blitter: add texture array support

2011-09-05 Thread Dave Airlie
On Mon, Sep 5, 2011 at 10:44 PM, Marek Olšák wrote: I nearly wrote this once, and this looks like the correct version of it, http://cgit.freedesktop.org/~airlied/mesa/commit/?h=r600g-texture-array&id=949278f48bea4aa4da0ec70d2ebf03b2884908a9 Reviewed-by: Dave Airlie > --- >  src/gallium/auxilia

[Mesa-dev] nvfx assertion and XvMC state tracker.

2011-09-05 Thread Andrew Randrianasulu
Hello. Just tested http://repo.or.cz/w/mesa/nouveau-pmpeg.git/ (commit 25363beccacc70a514045283bbe14951262f7b1f, "nouveau video fixup") with my nv43. At first, i got only nv40_fragtex.c:50: nv40_sampler_view_init: Assertion `tf->fmt[4] >= 0' failed. Then I disabled this assertion, and got some

[Mesa-dev] [RFC 3/3] i965: emit_depthbuffer: fix segfault, rhbz#735794

2011-09-05 Thread Alon Levy
Signed-off-by: Alon Levy --- src/mesa/drivers/dri/i965/brw_misc_state.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index 479cf82..f102bc6 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [RFC 2/3] i965: prepare_depthbuffer: don't update NULL region'ed surface, rhbz#735794

2011-09-05 Thread Alon Levy
--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index ad90978..abaed60 100644 --- a/src/mesa/drivers/dri/i965/brw_wm_

[Mesa-dev] [RFC 1/3] i965: prepare_depthbuffer: fix segfault, rhbz#735794

2011-09-05 Thread Alon Levy
Also fixes a segfault immediatelly after in the same case, i.e. srb->region is also NULL in the run of virtualbox described in the bug report in the subject. Signed-off-by: Alon Levy --- src/mesa/drivers/dri/i965/brw_misc_state.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) dif

[Mesa-dev] [RFC 0/3] Fix several segmentation faults related to depth buffer

2011-09-05 Thread Alon Levy
Fixes three segmentation faults where it is wrongly assumed the depth buffer's renderbuffer's region is not NULL. 735794 - verified to be fixed by these three patches (these three apply to 7.11 almost cleanly, just the second requires minor changes). Related RHBZs (maybe solved as well, didn't re

[Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
Fix the constant interpolation enable bit mask for flat light mode. FRAG_BIT_COL0 attribute bit might be 0, in which case we need to shift one more bit right. This would fix the oglc specularColor test fail on both Sandybridge and Ivybridge. Signed-off-by: Yuanhan Liu Signed-off-by: Xiang, Haiha

Re: [Mesa-dev] new-vs on gen4

2011-09-05 Thread Paul Berry
On 5 September 2011 14:25, Eric Anholt wrote: > On Fri, 2 Sep 2011 21:21:10 -0700, Paul Berry > wrote: > Non-text part: multipart/alternative > > On 2 September 2011 18:37, Eric Anholt wrote: > > > > > This series gets gen4 to be non-regressing for the new vertex shader. > > > I'd be fine with

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
On Mon, Sep 05, 2011 at 10:41:03AM -0700, Eric Anholt wrote: > On Mon, 5 Sep 2011 15:59:32 +0800, Yuanhan Liu > wrote: > > Fix the constant interpolation enable bit mask for flat light mode. > > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > > shift one more bit right. > > >

[Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
Fix the constant interpolation enable bit mask for flat light mode. FRAG_BIT_COL0 attribute bit might be 0, in which case we need to shift one more bit right. This would fix the oglc specularColor test fail on both Sandybridge and Ivybridge. v2: move the constant interp bitmask setup code into fo

[Mesa-dev] Advanced apitrace usage for GL driver development

2011-09-05 Thread José Fonseca
FYI, I documented examples of more advanced debugging techniques using apitrace, meant specifically for GL driver development (as opposed to GL application development). In particular: - how to prepare a regression test case (*) - how to automate git bisect to find a commit which introduced a reg

Re: [Mesa-dev] [PATCH 05/13] ir_to_mesa: fix shadow2DArray comparison

2011-09-05 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/05/2011 02:44 PM, Marek Olšák wrote: > The depth should be in W. > --- > src/mesa/program/ir_to_mesa.cpp | 15 --- > 1 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/pro

Re: [Mesa-dev] [PATCH] mesa: add a UniformBooleanTrue option

2011-09-05 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/05/2011 12:59 PM, Bryan Cain wrote: > Drivers supporting native integers set UniformBooleanTrue to the integer value > that should be used for true when uploading uniform booleans. This is ~0 for > Gallium and 1 for i965. I was going to suggest

Re: [Mesa-dev] [PATCH 2/3] glsl/builtins: Fix invalid float constant in noise4 built-in.

2011-09-05 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/05/2011 12:24 PM, Kenneth Graunke wrote: > This is probably wrong, but ought to replicate the existing behavior. > I don't know what the right patch is. Ian? I think this is correct. At the very least, it matches the pattern of the vec3 and ve

[Mesa-dev] [PATCH 13/13] r600g: fix shadow samplers with rectangle textures

2011-09-05 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_shader.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index b7dbb92..09b26fa 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++ b/src/gallium/

[Mesa-dev] [PATCH 12/13] r600g: use SAMPLE_LB for OPCODE_TXB

2011-09-05 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_shader.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 64f8b5c..b7dbb92 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++ b/src/gallium/

[Mesa-dev] [PATCH 11/13] r600g: enable texture arrays

2011-09-05 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_pipe.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index e02da6e..6a6f4d8 100644 --- a/src/gallium/drivers/r600/r600_pipe.c +++ b/src/gallium/drivers

[Mesa-dev] [PATCH 08/13] r600g: always decompress all mipmaps and layers, slices, or faces of zbuffers

2011-09-05 Thread Marek Olšák
This fixes piglit/fbo-depth-array. --- src/gallium/drivers/r600/r600_blit.c| 63 +-- src/gallium/drivers/r600/r600_texture.c | 14 +++ 2 files changed, 49 insertions(+), 28 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/driver

[Mesa-dev] [PATCH 09/13] r600g: implement texture arrays for evergreen

2011-09-05 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_state.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c index d29a30e..6545bcc 100644 --- a/src/gallium/drivers/r600/everg

[Mesa-dev] [PATCH 10/13] r600g: add support for shadow array samplers

2011-09-05 Thread Marek Olšák
I had to guess & verify how some of the SAMPLE instructions work. --- src/gallium/drivers/r600/r600_shader.c | 37 +++-- src/gallium/drivers/r600/r600d.h | 39 +++- 2 files changed, 57 insertions(+), 19 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 07/13] r600g: fix texture array filtering

2011-09-05 Thread Marek Olšák
This fixes piglit/fbo-generatemipmap-array. It looks like SQ_TEX_SAMPLER_WORD0_0.TEX_ARRAY_OVERRIDE should be set for array textures in order to disable filtering between slices, which adds a dependency between sampler views and sampler states. This patch reworks sampler state updates such that t

[Mesa-dev] [PATCH 06/13] glsl_to_tgsi: fix shadow2DArray comparison

2011-09-05 Thread Marek Olšák
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 9394bea..9457eb2 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi

[Mesa-dev] [PATCH 05/13] ir_to_mesa: fix shadow2DArray comparison

2011-09-05 Thread Marek Olšák
The depth should be in W. --- src/mesa/program/ir_to_mesa.cpp | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 9813c4a..f705dc7 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa

[Mesa-dev] [PATCH 04/13] u_blitter: add texture array support

2011-09-05 Thread Marek Olšák
--- src/gallium/auxiliary/util/u_blitter.c | 52 +--- 1 files changed, 41 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index d8e46f0..d69fb1a 100644 --- a/src/gallium/auxiliary/util/u_bli

[Mesa-dev] [PATCH 03/13] st/mesa: convert shadow array samplers to TGSI

2011-09-05 Thread Marek Olšák
--- src/mesa/state_tracker/st_mesa_to_tgsi.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_mesa_to_tgsi.c index f4263c6..b4111b0 100644 --- a/src/mesa/state_tracker/st_mesa_to_tgsi.c +++ b/src/mesa/st

[Mesa-dev] [PATCH 02/13] gallium: add shadow 1D and 2D array samplers to TGSI

2011-09-05 Thread Marek Olšák
And filling in all the switch statements in auxiliary. Mostly untested. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c |6 +++ src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c |6 +++ src/gallium/auxiliary/tgsi/tgsi_dump.c |4 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c

[Mesa-dev] [PATCH 01/13] gallium: add PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS

2011-09-05 Thread Marek Olšák
--- src/gallium/include/pipe/p_defines.h |1 + src/mesa/state_tracker/st_extensions.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 19c0cab..9a9ce2e 100644 --- a/src/gallium/includ

[Mesa-dev] [PATCH 00/13] Gallium texture array and r600g support

2011-09-05 Thread Marek Olšák
Hi everybody, I have been recently trying to finish up the EXT_texture_array support for r600g. The most notable missing feature in Gallium was shadow array samplers. So with that done now, I think EXT_texture_array is complete, isn't it? I have written some tests for the shadow samplers that I

Re: [Mesa-dev] GLSL builtins constant constructor

2011-09-05 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/04/2011 03:03 PM, Paul Berry wrote: > On 4 September 2011 14:49, Ian Romanick > wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/04/2011 08:35 AM, Paul Berry wrote: > > On 4 Sept

Re: [Mesa-dev] new-vs on gen4

2011-09-05 Thread Eric Anholt
On Fri, 2 Sep 2011 21:21:10 -0700, Paul Berry wrote: Non-text part: multipart/alternative > On 2 September 2011 18:37, Eric Anholt wrote: > > > This series gets gen4 to be non-regressing for the new vertex shader. > > I'd be fine with not pushing the last patch and letting Paul's patches > > lan

[Mesa-dev] [PATCH] mesa: add a UniformBooleanTrue option

2011-09-05 Thread Bryan Cain
Drivers supporting native integers set UniformBooleanTrue to the integer value that should be used for true when uploading uniform booleans. This is ~0 for Gallium and 1 for i965. --- src/mesa/drivers/dri/i965/brw_context.c |4 +++- src/mesa/main/mtypes.h |6 ++ src/m

Re: [Mesa-dev] [PATCH 3/4] mesa/vbo: add ARB_vertex_type_2_10_10_10_rev APIs.

2011-09-05 Thread Dave Airlie
>> + >> +#define ATTRUI10N_1( A, UI ) ATTR( A, 1, conv_ui10_to_norm_float((UI) & >> 0x3ff), 0, 0, 1 ) >> +#define ATTRUI10N_2( A, UI ) ATTR( A, 2, \ >> +                                conv_ui10_to_norm_float((UI) & 0x3ff), \ >> +                                conv_ui10_to_norm_float(((UI) >> 10)

[Mesa-dev] [PATCH 3/3] glsl/ir_reader: Make sure constants have the right number of components.

2011-09-05 Thread Kenneth Graunke
The list of numbers in (constant type ()) needs to contain exactly type->components() numbers (16 for a mat4, 3 for a vec3, etc.) Signed-off-by: Kenneth Graunke --- src/glsl/ir_reader.cpp |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_reader.cpp b/src/gl

[Mesa-dev] [PATCH 2/3] glsl/builtins: Fix invalid float constant in noise4 built-in.

2011-09-05 Thread Kenneth Graunke
This is probably wrong, but ought to replicate the existing behavior. I don't know what the right patch is. Ian? Cc: Ian Romanick Signed-off-by: Kenneth Graunke --- src/glsl/builtins/ir/noise4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/builtins/ir/nois

[Mesa-dev] [PATCH 1/3] glsl/builtins: Fix invalid vecN constants in hyperbolic functions.

2011-09-05 Thread Kenneth Graunke
Each of these vecN constants only provided one component, which is illegal. The printed IR is meant to contain exactly as many components as are necessary; the IR reader does not splat single values. Signed-off-by: Kenneth Graunke --- src/glsl/builtins/ir/acosh |6 +++--- src/glsl/builtins/

Re: [Mesa-dev] [PATCH 4/4] mesa/varray: add interface support for ARB_vertex_type_2_10_10_10_rev

2011-09-05 Thread Eric Anholt
On Sun, 4 Sep 2011 15:05:05 +0100, Dave Airlie wrote: > From: Dave Airlie > > This just adds all the API check for vertex arrays using 2101010 types. > > 2101010 is also useable with GL_BGRA. Except for one tiny nit, this (along with 2/4) is: Reviewed-by: Eric Anholt > Signed-off-by: Dave

Re: [Mesa-dev] [PATCH 3/4] mesa/vbo: add ARB_vertex_type_2_10_10_10_rev APIs.

2011-09-05 Thread Eric Anholt
On Sun, 4 Sep 2011 15:05:04 +0100, Dave Airlie wrote: > From: Dave Airlie > > This adds the vertex processing paths for the 2101010 types. It converts > the attributes to floats for all the immediate entry points, some entrypoints > are normalised and the attrib APIs take a normalized parameter

Re: [Mesa-dev] [PATCH] gallium: add missing formats for ARB_vertex_type_2_10_10_10_rev

2011-09-05 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > From: Dave Airlie > > This just reorgs one define in csv file, and adds all the new formats > that are needed for this extension. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/util/u_format.csv |9 - > src/galli

Re: [Mesa-dev] [PATCH] gallivm: fix build with LLVM 3.0svn

2011-09-05 Thread Jose Fonseca
The /* HAVE_LLVM .. */ comments were inverted. I fixed them and pushed. Thanks. Also thanks to Johannes Obermayr which submited a similar patch later. Jose - Original Message - > LLVM 3.0svn moved TargetRegistry.h and TargetSelect.h. > See revision 138450 of LLVM. > > Signed-off-by: T

Re: [Mesa-dev] [PATCH 1/4] glapi: add ARB_vertex_type_2_10_10_10_rev entrypoints.

2011-09-05 Thread Eric Anholt
On Sun, 4 Sep 2011 15:05:02 +0100, Dave Airlie wrote: > From: Dave Airlie > > These are the new API entrypoints for ARB_vertex_type_2_10_10_10_rev > extension, along with the new INT_2_10_10_10_REV enum. > > Signed-off-by: Dave Airlie > + > + > + > + > + Goo

Re: [Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Eric Anholt
On Mon, 5 Sep 2011 15:59:32 +0800, Yuanhan Liu wrote: > Fix the constant interpolation enable bit mask for flat light mode. > FRAG_BIT_COL0 attribute bit might be 0, in which case we need to > shift one more bit right. > > This would fix the oglc specularColor test fail on both Sandybridge and

[Mesa-dev] [Bug 40633] [wayland-drm] struct wl_visual has been dropped

2011-09-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40633 ojab changed: What|Removed |Added CC||o...@ojab.ru -- Configure bugmail: https://bugs.

[Mesa-dev] [Bug 40633] New: [wayland-drm] struct wl_visual has been dropped

2011-09-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40633 Summary: [wayland-drm] struct wl_visual has been dropped Product: Mesa Version: git Platform: All OS/Version: Linux (All) Status: NEW Severity: normal Priority: med

[Mesa-dev] [PATCH] i965: fix the constant interp bitmask for flat mode

2011-09-05 Thread Yuanhan Liu
Fix the constant interpolation enable bit mask for flat light mode. FRAG_BIT_COL0 attribute bit might be 0, in which case we need to shift one more bit right. This would fix the oglc specularColor test fail on both Sandybridge and Ivybridge. Signed-off-by: Yuanhan Liu Signed-off-by: Xiang, Haiha