On Sun, 4 Sep 2011 15:05:02 +0100, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > These are the new API entrypoints for ARB_vertex_type_2_10_10_10_rev > extension, along with the new INT_2_10_10_10_REV enum. > > Signed-off-by: Dave Airlie <airl...@redhat.com> > + <function name="MultiTexCoordP1ui" offset="assign"> > + <param name="texture" type="GLenum"/> > + <param name="type" type="GLenum"/> > + <param name="coords" type="GLuint"/> > + </function>
Goofy indentation here -- open and close not aligned, not aligned to neighboring blocks. > + > + <function name="MultiTexCoordP2ui" offset="assign"> > + <param name="texture" type="GLenum"/> > + <param name="type" type="GLenum"/> > + <param name="coords" type="GLuint"/> > + </function> > + > + <function name="MultiTexCoordP3ui" offset="assign"> > + <param name="texture" type="GLenum"/> > + <param name="type" type="GLenum"/> > + <param name="coords" type="GLuint"/> > + </function> > + <function name="VertexAttribP1ui" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="GLuint"/> > + </function> Weird indentation of middle params here. > + > + <function name="VertexAttribP2ui" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="GLuint"/> > + </function> > + > + <function name="VertexAttribP3ui" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="GLuint"/> > + </function> > + > + <function name="VertexAttribP4ui" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="GLuint"/> > + </function> > + > + <function name="VertexAttribP1uiv" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="const GLuint *"/> > + </function> > + <function name="VertexAttribP2uiv" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="const GLuint *"/> > + </function> > + <function name="VertexAttribP3uiv" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="const GLuint *"/> > + </function> > + <function name="VertexAttribP4uiv" offset="assign"> > + <param name="index" type="GLuint"/> > + <param name="type" type="GLenum"/> > + <param name="normalized" type="GLboolean"/> > + <param name="value" type="const GLuint *"/> > + </function> > +</category> Lack of whitespace. But other than style, I've reviewed these entrypoints against the spec, and it'll get a: Reviewed-by: Eric Anholt <e...@anholt.net>
pgpYYcZ2xH30B.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
