Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/12 01:21, Lars Gullik Bjønnes a écrit : Anyhow... I am going to ditch the hole series. Pick what you want from it if anything. I just cannot stand the hostility. Come on. André is bored and he feel happy to be rude like in the good old days. Nothing really personnal :) Apart from t

Re: Ad. "using namespace std" - ref prob in c9b9748c

2012-10-23 Thread Abdelrazak Younes
On Tue, Oct 23, 2012 at 1:12 AM, Lars Gullik Bjønnes wrote: > Abdelrazak Younes writes: >>> >>> You mean using std::string everywhere? That does not sound nice. >> > | +1 >> >>> I agree though that using std:: on other less used things is not a bad idea. >> > | Not even that. The style is consist

Re: changeset/e94e9e41 makes trunk uncompilable

2012-10-23 Thread Kornel Benko
Am Dienstag, 23. Oktober 2012 um 00:57:16, schrieb Uwe Stöhr > Kornel, > > your commit > http://www.lyx.org/trac/changeset/e94e9e415f4a6ea074ea8ee34deee57b2b5d4d17/lyxgit > > breaks for the the compilation using the > build.bat > in development/cmake/. Can you please have a look? > > thanks and

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/12 01:21, Lars Gullik Bjønnes a écrit : >> Anyhow... I am going to ditch the hole series. Pick what you want from >> it if anything. >> >> I just cannot stand the hostility. > | Come on. André is bored and he feel happy to be rude like in the good | old day

Re: #8387: use nicer fonts in splash.lyx

2012-10-23 Thread Liviu Andronic
Hello I proposed to use Latin Modern fonts in splash.lyx as: - the default choice of fonts in LyX is bitmap, and ugly - splash.lyx is is what a new user encounters first after installing LyX - I mistakenly thought would be uncontroversial Since there was no recent discussion on the subject, I'm op

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/2012 14:27, Lars Gullik Bjønnes a écrit : C++11 would make the code look a lot nicer, esp. thru the use of range based for, and auto: std::vector::iterator at = somevec.begin(); std::vector::iterator end = someved.end(); for (; at != end; ++at) { ... } woul

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/2012 14:27, Lars Gullik Bjønnes a écrit : | What I think you should do is to remove the "using namespace std", and | add std:: wherever needed except for on string, as that really is all | over, and use "using std::string" for that. A patch that does exactly that is attached. I would

Re: noweb-article and article class with "noweb" module

2012-10-23 Thread Jean-Marc Lasgouttes
Le 22/10/2012 19:32, Kayvan Sylvan a écrit : Hi guys, I'm trying to see if I can stop using literate-article and instead use the article class (or any other layout) with the "noweb" module instead. However, when I use the "noweb" module, the Scrap layout is not defined. Did you really add the

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Abdelrazak Younes
On Tue, Oct 23, 2012 at 3:12 PM, Jean-Marc Lasgouttes wrote: > Le 23/10/2012 14:27, Lars Gullik Bjønnes a écrit : > >> | What I think you should do is to remove the "using namespace std", and >> | add std:: wherever needed except for on string, as that really is all >> | over, and use "using std::

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Abdelrazak Younes
On Tue, Oct 23, 2012 at 2:27 PM, Lars Gullik Bjønnes wrote: > C++11 would make the code look a lot nicer, esp. thru the use of range > based for, and auto: > > std::vector::iterator at = somevec.begin(); > std::vector::iterator end = someved.end(); > for (; at != end; ++at) { >

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/2012 15:41, Abdelrazak Younes a écrit : I really don't understand the rationale, sorry. I'd consider very bad style to create our own lyx::vector or lyx::iostream, so what's the point? FWIW, we already define lyx::assert, lyx::shared_ptr, lyx::bind. I do not have a strong view on this

Re: changeset/e94e9e41 makes trunk uncompilable

2012-10-23 Thread Uwe Stöhr
Am 23.10.2012 10:17, schrieb Kornel Benko: your commit http://www.lyx.org/trac/changeset/e94e9e415f4a6ea074ea8ee34deee57b2b5d4d17/lyxgit breaks for the the compilation using the build.bat in development/cmake/. Can you please have a look? I need more info. This is the standard way to use cmake

Re: [LyX master] Add support for the URW Classico (Optima) LaTeX font

2012-10-23 Thread Georg Baum
Juergen Spitzmueller wrote: > The branch, master, has been updated. > > - Log - > > commit db1c1389e3caff69477a597d2e499a8115058150 > Author: Juergen Spitzmueller > Date: Sun Oct 21 18:55:24 2012 +0200 > > Add support for th

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/2012 14:27, Lars Gullik Bjønnes a écrit : >> C++11 would make the code look a lot nicer, esp. thru the use of range >> based for, and auto: >> >> std::vector::iterator at = somevec.begin(); >> std::vector::iterator end = someved.end(); >> for

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/2012 15:41, Abdelrazak Younes a écrit : >> I really don't understand the rationale, sorry. I'd consider very bad >> style to create our own lyx::vector or lyx::iostream, so what's the >> point? > | FWIW, we already define lyx::assert, lyx::shared_ptr, lyx::

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes writes: | On Tue, Oct 23, 2012 at 2:27 PM, Lars Gullik Bjønnes wrote: >> C++11 would make the code look a lot nicer, esp. thru the use of range >> based for, and auto: >> >> std::vector::iterator at = somevec.begin(); >> std::vector::iterator end = someved.end(); >>

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread André Pönitz
On Tue, Oct 23, 2012 at 02:27:14PM +0200, Lars Gullik Bjønnes wrote: > lar...@gullik.org (Lars Gullik Bjønnes) writes: > > | Jean-Marc Lasgouttes writes: > > > | | Le 23/10/12 01:21, Lars Gullik Bjønnes a écrit : > >>> Anyhow... I am going to ditch the hole series. Pick what you want from > >>> i

Ubuntu PPA for daily trunk and branch builds of LyX

2012-10-23 Thread Liviu Andronic
Dear all Rob and I have set up an Ubuntu PPA [1] providing daily builds of 2.1 master (trunk) and 2.0.x (branch) GIT code. The packaging is still considered experimental, so it would be great if those interested could test the new set up and report any problems that might arise. (From local testing

Re: [PATCH 13/13] boost: changes to make it compile cleanly with gcc 4.8

2012-10-23 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | --- | boost/boost/lexical_cast.hpp | 1 - | boost/boost/math/special_functions/fpclassify.hpp | 4 | boost/boost/math/special_functions/sign.hpp | 2 -- | boost/boost/regex/v4/regex_format.hpp | 2 -- |

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/12 21:21, Lars Gullik Bjønnes a écrit : | FWIW, we already define lyx::assert, lyx::shared_ptr, lyx::bind. To note: the lyx::shared_ptr is there _because_ of the "using namespace std", and the pollution that drags in on some compilers. I know :) JMarc

[PATCH 2/5] src/Format.cpp: use make_pair

2012-10-23 Thread larsbj
From: Lars Gullik Bjønnes Use make_pair(...) instead of pair(...). --- src/Format.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Format.cpp b/src/Format.cpp index f031b68..71699d6 100644 --- a/src/Format.cpp +++ b/src/Format.cpp @@ -476,7 +476,7 @@ bool Formats::isZi

[PATCH 3/5] src/lyxfind.cpp: cleanup formatting

2012-10-23 Thread larsbj
From: Lars Gullik Bjønnes Remove some eol space re-indent where required make some ?: constructs a bit easier to read. --- src/lyxfind.cpp | 177 ++-- 1 file changed, 96 insertions(+), 81 deletions(-) diff --git a/src/lyxfind.cpp b/src/lyxfind

[PATCH 4/5] src/lyxfinc.cpp: use make_pair

2012-10-23 Thread larsbj
From: Lars Gullik Bjønnes Use make_pair(...) instead of pair(...). --- src/lyxfind.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp index dba41d7..a19724b 100644 --- a/src/lyxfind.cpp +++ b/src/lyxfind.cpp @@ -240,12 +240,12 @

[PATCH 5/5] src/lyxfind.cpp: use local typedef to simplify

2012-10-23 Thread larsbj
From: Lars Gullik Bjønnes Use a local typedef pair P to avoid having to repeat that multiple times. --- src/lyxfind.cpp | 72 - 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp index a19724b.

[PATCH 1/5] tests/boost.cpp: remove using namespace std

2012-10-23 Thread larsbj
From: Lars Gullik Bjønnes Trivial to remove the namespace injection. --- src/frontends/tests/boost.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/frontends/tests/boost.cpp b/src/frontends/tests/boost.cpp index 09d701d..6151f1f 100644 --- a/src/frontends/tests/b

Re: [PATCH 1/5] tests/boost.cpp: remove using namespace std

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/12 23:14, lar...@gullik.org a écrit : From: Lars Gullik Bjønnes Trivial to remove the namespace injection. I think that patches 2-5/5 are no brainers and you should commit them. For this one, I would wait until someone makes a decision. JMarc

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/12 21:18, Lars Gullik Bjønnes a écrit : | Concerning auto, I am still not sure that I like it. Liking it took me some 5 seconds. Auto suddenly makes it nice to work with the complex types you get in C++. Imagine: auto func = [](){}; func(); try to figure out what type func really is

Re: [PATCH 13/13] boost: changes to make it compile cleanly with gcc 4.8

2012-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/12 23:05, Lars Gullik Bjønnes a écrit : lar...@gullik.org (Lars Gullik Bjønnes) writes: | --- | boost/boost/lexical_cast.hpp | 1 - | boost/boost/math/special_functions/fpclassify.hpp | 4 | boost/boost/math/special_functions/sign.hpp | 2 -- | boost/boo

Re: [PATCH 11/13] Use make_shared to create shared_ptr

2012-10-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes writes: | Le 23/10/12 21:18, Lars Gullik Bjønnes a écrit : >> | Concerning auto, I am still not sure that I like it. >> >> Liking it took me some 5 seconds. >> >> Auto suddenly makes it nice to work with the complex types you get in >> C++. >> >> Imagine: >> >> auto func = []

FYI: compiling with gcc 4.8

2012-10-23 Thread Lars Gullik Bjønnes
-l ./src/lyx 169405554 ./src/lyx gcc 4.8.0 (4.8.0 20121023 (experimental)): time make -j6 real3m9.445s user11m53.000s sys 0m51.485s size src/lyx text databss dec hexfilename 11348213 31352 44504 11424069 ae5145 src/lyx ls -l ./src/lyx 172783951 ./src

Re: [PATCH 5/5] src/lyxfind.cpp: use local typedef to simplify

2012-10-23 Thread André Pönitz
On Tue, Oct 23, 2012 at 11:14:42PM +0200, lar...@gullik.org wrote: > From: Lars Gullik Bjønnes > > Use a local typedef pair P to avoid having to repeat > that multiple times. > --- > src/lyxfind.cpp | 72 > - > 1 file changed, 40 insertion

Re: #8387: use nicer fonts in splash.lyx

2012-10-23 Thread Uwe Stöhr
Am 23.10.2012 11:59, schrieb Liviu Andronic: I proposed to use Latin Modern fonts in splash.lyx as: - the default choice of fonts in LyX is bitmap, and ugly This is not true anymore. Please show me a screenshot where the font look pixeld in normal magnification. So are there good reasons _

Re: [PATCH 5/5] src/lyxfind.cpp: use local typedef to simplify

2012-10-23 Thread Lars Gullik Bjønnes
André Pönitz writes: | On Tue, Oct 23, 2012 at 11:14:42PM +0200, lar...@gullik.org wrote: >> From: Lars Gullik Bjønnes >> >> Use a local typedef pair P to avoid having to repeat >> that multiple times. >> --- >> src/lyxfind.cpp | 72 >> -

Re: FYI: compiling with gcc 4.8

2012-10-23 Thread Lars Gullik Bjønnes
lar...@gullik.org (Lars Gullik Bjønnes) writes: | gcc 4.8.0 (4.8.0 20121023 (experimental)): > | time make -j6 | real3m9.445s | user11m53.000s | sys 0m51.485s > | size src/lyx | text databss dec hexfilename | 11348213 31352 44504 11424069 ae5145 s

[PATCH 2/2] config/lyxinclude.m4: add support for --enable-cxx11

2012-10-23 Thread Lars Gullik Bjønnes
Using --enable-cxx11 turns on C++11 mode in gcc. --- config/lyxinclude.m4 | 16 1 file changed, 16 insertions(+) diff --git a/config/lyxinclude.m4 b/config/lyxinclude.m4 index e532c54..2e529ea 100644 --- a/config/lyxinclude.m4 +++ b/config/lyxinclude.m4 @@ -232,6 +232,10 @@ AC_AR

[PATCH 1/2] support/Messages.cpp: add space to not be taken as user defined literal

2012-10-23 Thread Lars Gullik Bjønnes
In C++11 you are not allowed to have non-literal specifiers right after a string literal. --- src/support/Messages.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/support/Messages.cpp b/src/support/Messages.cpp index ca5c110..fdcaf66 100644 --- a/src/support/Messages.cp