Re: Master: Undo crash with change of document language

2017-12-20 Thread Kornel Benko
Am Mittwoch, 20. Dezember 2017 um 15:03:16, schrieb Jürgen Spitzmüller > Am Mittwoch, den 20.12.2017, 14:46 +0100 schrieb Jean-Marc Lasgouttes: > > Le 20/12/2017 à 10:05, Jürgen Spitzmüller a écrit : > > > > Shall we add a special casing to DocumentClass:addLayoutIfNeeded, > > > > or > > > > just

Re: Master: Undo crash with change of document language

2017-12-20 Thread Kornel Benko
Am Mittwoch, 20. Dezember 2017 um 16:06:18, schrieb Jean-Marc Lasgouttes > Le 20/12/2017 à 10:05, Jürgen Spitzmüller a écrit : > >> Shall we add a special casing to DocumentClass:addLayoutIfNeeded, or > >> just fix tex2lyx so that it creates correct files? > > > > I'd suggest the latter. > > te

Re: Master: Undo crash with change of document language

2017-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/2017 à 10:05, Jürgen Spitzmüller a écrit : Shall we add a special casing to DocumentClass:addLayoutIfNeeded, or just fix tex2lyx so that it creates correct files? I'd suggest the latter. tex2lyx is fixed in master at 40a3a44aa2. Of course this makes our tex2lyx tests fail (with the

Re: Master: Undo crash with change of document language

2017-12-20 Thread Jürgen Spitzmüller
Am Mittwoch, den 20.12.2017, 14:46 +0100 schrieb Jean-Marc Lasgouttes: > Le 20/12/2017 à 10:05, Jürgen Spitzmüller a écrit : > > > Shall we add a special casing to DocumentClass:addLayoutIfNeeded, > > > or > > > just fix tex2lyx so that it creates correct files? > > > > I'd suggest the latter. >

Re: Master: Undo crash with change of document language

2017-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/2017 à 10:05, Jürgen Spitzmüller a écrit : Shall we add a special casing to DocumentClass:addLayoutIfNeeded, or just fix tex2lyx so that it creates correct files? I'd suggest the latter. I guess the right question was: should be do both, for the sake of existing files? JMarc

Re: Master: Undo crash with change of document language

2017-12-20 Thread Jürgen Spitzmüller
Am Montag, den 18.12.2017, 18:14 +0100 schrieb Jean-Marc Lasgouttes: > The Flex: prefix is wrong and we do not use it anymore since at least > 3 > years ago (cfeddb92). Jürgen, Richard, do you remember the details? I don't. > Should tex2lyx skip the Flex: when writing files? I think we did not >

Re: Master: Undo crash with change of document language

2017-12-18 Thread Jean-Marc Lasgouttes
Le 18/12/2017 à 17:44, Jean-Marc Lasgouttes a écrit : We will know that once we understand what happens (and if the file is correct). What happens is that the file src/tex2lyx/test/test-insets.lyx.lyx, created by tex2lyx, contains: \begin_inset Flex Flex:URL status collapsed \begin_layout P

Re: Master: Undo crash with change of document language

2017-12-18 Thread Kornel Benko
Am Montag, 18. Dezember 2017 um 17:44:35, schrieb Jean-Marc Lasgouttes > Le 18/12/2017 à 17:27, Kornel Benko a écrit : > >> My point is that I am not sure that I had a valid reason to add the > >> assertion at the time. I just thought it was a good idea, as far as I > >> remember. > > > > I stil

Re: Master: Undo crash with change of document language

2017-12-18 Thread Jean-Marc Lasgouttes
Le 18/12/2017 à 17:27, Kornel Benko a écrit : My point is that I am not sure that I had a valid reason to add the assertion at the time. I just thought it was a good idea, as far as I remember. I still think, it is. My thinking now is that we had an error dialog already. Does the assertion a

Re: Master: Undo crash with change of document language

2017-12-18 Thread Kornel Benko
Am Sonntag, 17. Dezember 2017 um 23:10:35, schrieb Jean-Marc Lasgouttes > Le 17/12/2017 à 20:29, Kornel Benko a écrit : > > And the point is, that lyx crashes on an (innocent?) Undo. > > > >> This is not something that appears in production builds anyway. > > > > We have asserts exactly because

Re: Master: Undo crash with change of document language

2017-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2017 à 20:29, Kornel Benko a écrit : And the point is, that lyx crashes on an (innocent?) Undo. This is not something that appears in production builds anyway. We have asserts exactly because we want to make lyx robust. Am I misunderstanding something? My point is that I am not su

Re: Master: Undo crash with change of document language

2017-12-17 Thread Kornel Benko
; (Ignore warnings about undefined flex inset Flex:Flex:URL) > > 3.) Use menu "Back" (e.g. Undo) ==> crash > > Actually, the error _is_ the problem (see LATTEST at the end): > > // The error list is not supposed to be helpful here. > Error

Re: Master: Undo crash with change of document language

2017-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2017 à 19:14, Kornel Benko a écrit : Reliably. 1.) Open src/tex2lyx/test/test-insets.lyx.lyx 2.) Change document language to 'Slovak' (Ignore warnings about undefined flex inset Flex:Flex:URL) 3.) Use menu "Back" (e.g. Undo) ==> crash Actually, the

Master: Undo crash with change of document language

2017-12-17 Thread Kornel Benko
Reliably. 1.) Open src/tex2lyx/test/test-insets.lyx.lyx 2.) Change document language to 'Slovak' (Ignore warnings about undefined flex inset Flex:Flex:URL) 3.) Use menu "Back" (e.g. Undo) ==> crash support/lassert.cpp (51): ASSERTION el.empty() VIOLATED IN /u

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-12 Thread Jean-Marc Lasgouttes
Le 12/12/2012 09:50, Scott Kostyshak a écrit : Unfortunately, when I run LyX under gdb (or valgrind), I cannot reproduce anymore :( Why is this a problem? Can't you use the core file that was dumped or is that not the same? I guess you can't use "next" to work interactively in a core file. My

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-12 Thread Scott Kostyshak
On Tue, Dec 11, 2012 at 4:17 AM, Jean-Marc Lasgouttes wrote: > Le 08/12/12 08:08, Scott Kostyshak a écrit : > >> I'm hoping others can reproduce this. I can reproduce in current trunk >> with Ubuntu 12.04 as follows: >> >> - Enable "spellcheck continuously" >> - Insert a table, say 4x4. >> - Click

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-12 Thread Scott Kostyshak
On Mon, Dec 10, 2012 at 6:49 AM, Jean-Marc Lasgouttes wrote: > Le 08/12/2012 08:08, Scott Kostyshak a écrit : > >> I'm hoping others can reproduce this. I can reproduce in current trunk >> with Ubuntu 12.04 as follows: >> >> - Enable "spellcheck continuously" >> - Insert a table, say 4x4. >> - Cli

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-11 Thread Jean-Marc Lasgouttes
Le 11/12/2012 15:38, Stephan Witt a écrit : Can you try again to see whether it is checked? In general, there are other things for which I am not sure whether they should be kept in CursorData (that is, restored by Undo). For example, should we restore the transient mark setting? On my system i

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-11 Thread Stephan Witt
Am 11.12.2012 um 10:17 schrieb Jean-Marc Lasgouttes : > Le 08/12/12 08:08, Scott Kostyshak a écrit : >> I'm hoping others can reproduce this. I can reproduce in current trunk >> with Ubuntu 12.04 as follows: >> >> - Enable "spellcheck continuously" >> - Insert a table, say 4x4. >> - Click on the

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-11 Thread Jean-Marc Lasgouttes
Le 08/12/12 08:08, Scott Kostyshak a écrit : I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. - Enter "a". - Undo twice, then redo twice, then undo on

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Stephan Witt
Am 11.12.2012 um 02:12 schrieb Pavel Sanda : > Jean-Marc Lasgouttes wrote: >> This last undo step can be replaced by anything here (clicking anywhere, >> inserting text...). >> >> Unfortunately, when I run LyX under gdb (or valgrind), I cannot reproduce >> anymore :( > > Backtrace: > #0 0x08c

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > This last undo step can be replaced by anything here (clicking anywhere, > inserting text...). > > Unfortunately, when I run LyX under gdb (or valgrind), I cannot reproduce > anymore :( Backtrace: #0 0x08c9d30b in typeinfo for QMimeData () #1 0x0810a9ba in lyx::Do

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Richard Heck
On 12/10/2012 06:49 AM, Jean-Marc Lasgouttes wrote: Le 08/12/2012 08:08, Scott Kostyshak a écrit : I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. -

Re: Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-10 Thread Jean-Marc Lasgouttes
Le 08/12/2012 08:08, Scott Kostyshak a écrit : I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. - Enter "a". - Undo twice, then redo twice, then undo

Undo crash in InsetTabular with "spellcheck continuously" enabled

2012-12-07 Thread Scott Kostyshak
I'm hoping others can reproduce this. I can reproduce in current trunk with Ubuntu 12.04 as follows: - Enable "spellcheck continuously" - Insert a table, say 4x4. - Click on the upper-left cell. - Enter "a". - Undo twice, then redo twice, then undo once. I get a SIGSEGV. I can also reproduce wit

Re: insert note, undo, crash.

2010-05-09 Thread Vincent van Ravesteijn
Op 9-5-2010 11:19, Kevin Brubeck Unhammer schreef: 2010/5/9 Kevin Brubeck Unhammer: 2010/5/7 Pavel Sanda: Kevin Brubeck Unhammer wrote: Sorry for the late reply. I seem to have lost my bug :-( I had to do a restart before checking out from svn, and now I can't get it to cras

Re: insert note, undo, crash.

2010-05-09 Thread Kevin Brubeck Unhammer
2010/5/9 Kevin Brubeck Unhammer : > 2010/5/7 Pavel Sanda : >> Kevin Brubeck Unhammer wrote: >>> Sorry for the late reply. I seem to have lost my bug :-( >>> >>> I had to do a restart before checking out from svn, and now I can't >>> get it to crash again (neither svn nor release). I'll let you know

Re: insert note, undo, crash.

2010-05-09 Thread Kevin Brubeck Unhammer
2010/5/7 Pavel Sanda : > Kevin Brubeck Unhammer wrote: >> Sorry for the late reply. I seem to have lost my bug :-( >> >> I had to do a restart before checking out from svn, and now I can't >> get it to crash again (neither svn nor release). I'll let you know if >> I find it again. > > btw do you us

Re: insert note, undo, crash.

2010-05-07 Thread Pavel Sanda
Kevin Brubeck Unhammer wrote: > Sorry for the late reply. I seem to have lost my bug :-( > > I had to do a restart before checking out from svn, and now I can't > get it to crash again (neither svn nor release). I'll let you know if > I find it again. btw do you use outliner? i fight similar bug,

Re: insert note, undo, crash.

2010-05-07 Thread Kevin Brubeck Unhammer
2010/5/7 Pavel Sanda : > Jean-Marc LASGOUTTES wrote: >> Kevin Brubeck Unhammer writes: >> > when I just add a note, and then immediately undo (whether with >> > keyboard shortcuts or with menu items/toolbar button). This crash is >> > as non-intermittent as it gets. I'm not 100% sure it's the same

Re: insert note, undo, crash.

2010-05-07 Thread Pavel Sanda
Jean-Marc LASGOUTTES wrote: > Kevin Brubeck Unhammer writes: > > when I just add a note, and then immediately undo (whether with > > keyboard shortcuts or with menu items/toolbar button). This crash is > > as non-intermittent as it gets. I'm not 100% sure it's the same as > > http://www.lyx.org/tr

Re: insert note, undo, crash.

2010-05-07 Thread Jean-Marc LASGOUTTES
Kevin Brubeck Unhammer writes: > when I just add a note, and then immediately undo (whether with > keyboard shortcuts or with menu items/toolbar button). This crash is > as non-intermittent as it gets. I'm not 100% sure it's the same as > http://www.lyx.org/trac/ticket/6678 > though since that see

insert note, undo, crash.

2010-05-07 Thread Kevin Brubeck Unhammer
Hi, I was about to comment on http://www.lyx.org/trac/ticket/6678 but Trac keeps asking me to verify my email over and over... anyway, I get lyx: SIGSEGV signal caught Sorry, you have found a bug in LyX. Please read the bug-reporting instructions in Help->Introduction and send us a bug report, if

Re: [PATCH 1.4.x] bug 3019: Undo crash with nested font changes in math

2006-12-29 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> This patch fixes the following crash recipe: Jean-Marc> How to reproduce: - Open a (new) LyX document - Insert -> Jean-Marc> Math -> Inline Formula - Toggle emphasis twice - Undo Jean-Marc> The problem was that undo

[PATCH 1.4.x] bug 3019: Undo crash with nested font changes in math

2006-12-27 Thread Jean-Marc Lasgouttes
This patch fixes the following crash recipe: How to reproduce: - Open a (new) LyX document - Insert -> Math -> Inline Formula - Toggle emphasis twice - Undo The problem was that undo was called with the cursor at the wrong level. Testing welcome. I will commit tomorrow. JMarc Index: src/mathe

undo crash

2004-03-10 Thread Alfredo Braunstein
z z then select the two paragraphs (from top to bottom) and overwrite with 'a'. C-z C-z -> crash A cursor problem it would seem. Alfredo

Re: [patch] fix lockpath + undo crash

2004-02-02 Thread Alfredo Braunstein
On Monday 02 February 2004 09:25, Andre Poenitz wrote: > > 2) eliminating some (bogus) redundant cursor positioning code in > > undo > > Ah good. This was a _really_ old hack in undo as far as I can tell. I know... hopefully we can remove this ugly sort of things in more that one place thanks to

Re: [patch] fix lockpath + undo crash

2004-02-02 Thread Alfredo Braunstein
On Saturday 31 January 2004 12:32, Lars Gullik Bjønnes wrote: > It it works it works. Seems to ;-) > As long as it does not introduce more errors go for it. okeydokey. Alfredo

Re: [patch] fix lockpath + undo crash

2004-02-02 Thread Andre Poenitz
On Sat, Jan 31, 2004 at 11:50:19AM +0100, Alfredo Braunstein wrote: > zz > > gives a crash. > > This patch solves that by 1) fixing lockPath (the CursorSlice at level 0 was > missing) Thanks. > 2) eliminating some (bogus) redundant cursor positioning code in > undo Ah good. This was a _really_

Re: [patch] fix lockpath + undo crash

2004-01-31 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | zz > | gives a crash. > | This patch solves that by 1) fixing lockPath (the CursorSlice at level 0 was | missing) 2) eliminating some (bogus) redundant cursor positioning code in | undo > | Ok? It it works it works. As long as it does not introduc

[patch] fix lockpath + undo crash

2004-01-31 Thread Alfredo Braunstein
zz gives a crash. This patch solves that by 1) fixing lockPath (the CursorSlice at level 0 was missing) 2) eliminating some (bogus) redundant cursor positioning code in undo Ok? Alfredo ? PosIterator.C-save ? PosIterator.h-save ? bfri.C ? textcursor.C-save ? textcursor.h-save Index: iterators.C

Re: [patch] fix undo crash

2003-10-27 Thread Alfredo Braunstein
Angus Leeming wrote: > I think you should keep the dynamic_cast for now, get Christian to > try it out and if it doesn't work for him then change it. Thanks Angus. Applied as is. Alfredo

Re: [patch] fix undo crash

2003-10-27 Thread Angus Leeming
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> Good. >> >> [Note that Angus recently had some problems related to >> [dynamic_cast...] > > What kind of problems? In the practical side, should I apply or > wait? Maybe real problems with an old gcc 2.95-ish compiler (Christian's). Maybe

Re: [patch] fix undo crash

2003-10-27 Thread Andre Poenitz
On Mon, Oct 27, 2003 at 10:39:41AM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Good. > > > > [Note that Angus recently had some problems related to dynamic_cast...] > > What kind of problems? I did not follow too closely but I got the impression on some architectures dynamic_c

Re: [patch] fix undo crash

2003-10-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Good. > > [Note that Angus recently had some problems related to dynamic_cast...] What kind of problems? In the practical side, should I apply or wait? Alfredo

Re: [patch] fix undo crash

2003-10-27 Thread Andre Poenitz
On Mon, Oct 27, 2003 at 10:33:34AM +0100, Alfredo Braunstein wrote: > This fixes two undo crashes. > > Explanation: we have a sort of dead-lock between setCursor and fullRebreak. > setCursor (or setCursorIntern == setCursor - DESM) need to have rows. > fullRebreak does the rebreaking and then cal

[patch] fix undo crash

2003-10-27 Thread Alfredo Braunstein
This fixes two undo crashes. Explanation: we have a sort of dead-lock between setCursor and fullRebreak. setCursor (or setCursorIntern == setCursor - DESM) need to have rows. fullRebreak does the rebreaking and then calls redoCursor, who needs to have a decent cursor position. So the workaround

preparation for watching for the undo crash?

2002-10-11 Thread Dr. Richard E. Hawkins
I haven't been bit for a couple of weeks, but knowing that it's a hard to solve problem, I assume that it will byte again. I'm already running lyx in a debugger all the time (I've aliased ly to xterm -iconic -n lyxterm -e gdb /usr/local/bin/lyx -x ~/.scripts/lyxrun & and the script is merely "ru

Undo crash

2002-10-10 Thread Andre Poenitz
Just seen: Program received signal SIGSEGV, Segmentation fault. 0x403ba128 in main_arena () from /lib/libc.so.6 (gdb) bt #0 0x403ba128 in main_arena () from /lib/libc.so.6 #1 0x0817ec7a in Paragraph::isRightToLeftPar (this=0x8ba9550, bparams=@0x8782ef0) at ../../lyx-devel/src/paragraph.C