Re: r37704 - lyx-devel/trunk/src/insets

2011-02-17 Thread Abdelrazak Younes
On Thu, Feb 17, 2011 at 11:22 AM, Enrico Forestieri wrote: > On Thu, Feb 17, 2011 at 09:33:44AM +0100, Edwin Leuven wrote: > > as discussed in another thread, the problem was that only the 1st > > argument got checked, and that was just an arbitrary one (the one > > which just happened to be adde

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-17 Thread Enrico Forestieri
On Thu, Feb 17, 2011 at 09:33:44AM +0100, Edwin Leuven wrote: > as discussed in another thread, the problem was that only the 1st > argument got checked, and that was just an arbitrary one (the one > which just happened to be added first in the frontend code). which is > prone to errors as we saw.

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-17 Thread Edwin Leuven
On Thu, Feb 17, 2011 at 01:26, Enrico Forestieri wrote: > On Thu, Feb 17, 2011 at 01:09:04AM +0100, Pavel Sanda wrote: >> Vincent van Ravesteijn wrote: >> >> Which has no effect at all. >> >> >> > It does. >> >> can both of you please come back to this point and in more than one sentence >> put do

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Enrico Forestieri
On Thu, Feb 17, 2011 at 01:09:04AM +0100, Pavel Sanda wrote: > Vincent van Ravesteijn wrote: > >> Which has no effect at all. > >> > > It does. > > can both of you please come back to this point and in more than one sentence > put down your arguments/analysis? I am sorry, this is a behavioural pr

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Pavel Sanda
Vincent van Ravesteijn wrote: >> Which has no effect at all. >> > It does. can both of you please come back to this point and in more than one sentence put down your arguments/analysis? and if possible no reverts while flaming, otherwise we might have correct code but two developers left... than

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Enrico Forestieri
On Thu, Feb 17, 2011 at 12:29:18AM +0100, Vincent van Ravesteijn wrote: > > This is basically saying that SET_TABULAR_WIDTH should be allowed > for longtables, because tabular_width is zero by definition for > longtables. > >>>It works just fine. > >>> > >>It does not. It allows you to

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Vincent van Ravesteijn
This is basically saying that SET_TABULAR_WIDTH should be allowed for longtables, because tabular_width is zero by definition for longtables. It works just fine. It does not. It allows you to execute "inset-modify tabular set-tabular-width 7cm" for a longtable, and it happily changes the tabl

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Enrico Forestieri
On Thu, Feb 17, 2011 at 12:20:49AM +0100, Vincent van Ravesteijn wrote: > Op 17-2-2011 0:17, Enrico Forestieri schreef: > >On Wed, Feb 16, 2011 at 11:57:22PM +0100, Vincent van Ravesteijn wrote: > >> Op 16-2-2011 23:19, for...@lyx.org schreef: > >>>Author: forenr > >>>Date: Wed Feb 16 23:19:49 20

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Vincent van Ravesteijn
Op 17-2-2011 0:17, Enrico Forestieri schreef: On Wed, Feb 16, 2011 at 11:57:22PM +0100, Vincent van Ravesteijn wrote: Op 16-2-2011 23:19, for...@lyx.org schreef: Author: forenr Date: Wed Feb 16 23:19:49 2011 New Revision: 37704 URL: http://www.lyx.org/trac/changeset/37704 Log: Don't disable

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Enrico Forestieri
On Wed, Feb 16, 2011 at 11:57:22PM +0100, Vincent van Ravesteijn wrote: > Op 16-2-2011 23:19, for...@lyx.org schreef: > >Author: forenr > >Date: Wed Feb 16 23:19:49 2011 > >New Revision: 37704 > >URL: http://www.lyx.org/trac/changeset/37704 > > > >Log: > >Don't disable apply button if one (or more

Re: r37704 - lyx-devel/trunk/src/insets

2011-02-16 Thread Vincent van Ravesteijn
Op 16-2-2011 23:19, for...@lyx.org schreef: Author: forenr Date: Wed Feb 16 23:19:49 2011 New Revision: 37704 URL: http://www.lyx.org/trac/changeset/37704 Log: Don't disable apply button if one (or more) of vertical alignment, rotation, or long table settings are changed. Fixes bug #7308. Modi