On Mon, 2002-10-21 at 06:22, John Levon wrote:
> On Mon, Oct 21, 2002 at 06:13:23AM +0930, Darren Freeman wrote:
>
> > BTW you should get yourself a wheel mouse if you can.. They're really
>
> I should...
>
> > Well, if you like them, then you will add them. Am I right? Well then I
> > would lik
On Mon, Oct 21, 2002 at 02:54:34PM +0100, John Levon wrote:
> > But seriously, if my questions or comments get me flamed by the core
> > team then I won't put in the effort.
>
> Ignore André, he's a pussycat really ;)
Oh, I wasn't flaming. Not even trying ;-)
Andre'
--
Those who desire to give
On Mon, 2002-10-21 at 23:03, Andre Poenitz wrote:
> On Mon, Oct 21, 2002 at 10:50:27PM +0930, Darren Freeman wrote:
> > > But surely not by inserting two blank lines between parts of code in the
> > > body of a function?
> >
> > Well I like it, you don't have to. I'm waiting to see the "official"
On Mon, Oct 21, 2002 at 11:22:13PM +0930, Darren Freeman wrote:
> But seriously, if my questions or comments get me flamed by the core
> team then I won't put in the effort.
Ignore André, he's a pussycat really ;)
john
--
"What will we do with a DTD ? Print it out and frame it on the wall ?"
On Mon, 2002-10-21 at 16:43, Juergen Spitzmueller wrote:
> John Levon wrote:
> > Everybody with wheel
> > mice, please test current tip.
Looking at the code, yes it looks more complete but I think you made a
mistake:
// Restrict to a valid value
int new_first_y = std::min(t->heigh
On Tue, Oct 22, 2002 at 12:48:18AM +0930, Darren Freeman wrote:
> // Restrict to a valid value
> int new_first_y = std::min(t->height - 4 * line_height, disp);
> new_first_y = std::max(0, disp);
How embarrassing. Thanks
john
On Mon, Oct 21, 2002 at 04:03:14PM +0100, John Levon wrote:
> > Concerning coding style (i.e. whitespace and braces) the current code is in
> > pretty good shape. It's certainly much better than a few years ago. And we
> > were talking about this kind of stylistic issues.
>
> // set the co
John Levon <[EMAIL PROTECTED]> writes:
| On Mon, Oct 21, 2002 at 04:17:51PM +0200, Andre Poenitz wrote:
>
>> Concerning coding style (i.e. whitespace and braces) the current code is in
>> pretty good shape. It's certainly much better than a few years ago. And we
>> were talking about this kind of
On Mon, Oct 21, 2002 at 05:08:32PM +0200, Lars Gullik Bjønnes wrote:
> so did you fix it? I didn't see the patch?
It's in my tree. I haven't submitted it because it qualifies as a
"dangerous" change.
fyi, I attach my entire tree in 1.3
john
--
"What will we do with a DTD ? Print it out and fr
On Mon, Oct 21, 2002 at 10:41:02PM +0930, Darren Freeman wrote:
> Well actually if I had put more effort into it the comment block above
> the function would have described quite a bit, like what the return
> values are, what the parameters do, what to look out for, who should
> call it, etc.
>
>
On Tue, 2002-10-22 at 01:33, Juergen Spitzmueller wrote:
> Darren Freeman wrote:
> > Fixed in the attached patch
>
> Confirmed.
> Many thanks, Darren!
Awww, shucks =) I only did half of it anyway, but as I have the wheel, I
have the *power*!
Now what to do with this newfound power... wheelies!
John Levon <[EMAIL PROTECTED]> writes:
| On Mon, Oct 21, 2002 at 04:21:48PM +0200, Lars Gullik Bjønnes wrote:
>
>> | I'm talking as someone who just removed a hand-coded *linked list* in
>> | buffer.C !!
>>
>> what linked list was that?
>
| DEPCLEAN. It's really a std::map
Did you fix this?
(and
On Mon, Oct 21, 2002 at 04:17:51PM +0200, Andre Poenitz wrote:
> Concerning coding style (i.e. whitespace and braces) the current code is in
> pretty good shape. It's certainly much better than a few years ago. And we
> were talking about this kind of stylistic issues.
// set the correct
Andre',
On Mon, 2002-10-21 at 18:51, Andre Poenitz wrote:
> On Mon, Oct 21, 2002 at 05:20:51AM +0930, Darren Freeman wrote:
> > I would still like to do that, but by doing so I would be compelled to
> > increase the amount of whitespace somewhat.
>
> But surely not by inserting two blank lines be
On Mon, Oct 21, 2002 at 02:53:46PM +0100, John Levon wrote:
> God no !
>
> "either development/Code_Rules/* tells something or if not, do what
> we want the rest of the LyX sources to look like"
>
> I'm talking as someone who just removed a hand-coded *linked list* in
> buffer.C !!
Concerning c
On Sun, Oct 20, 2002 at 09:22:15PM +0100, John Levon wrote:
> Hold on to your hat: lyx cannot easily scroll by non-row based amounts.
> This is because we use setCursorByCoordinates() which works on a
> row-level not pixel level. Since Headings are tall rows, you end up
> scrolling "faster".
>
> T
John Levon <[EMAIL PROTECTED]> writes:
| I'm talking as someone who just removed a hand-coded *linked list* in
| buffer.C !!
what linked list was that?
I thought I had gotten rid of all now...
--
Lgb
On Mon, Oct 21, 2002 at 10:41:02PM +0930, Darren Freeman wrote:
> I take it you applied the patch in some form? Or am I taking your
> feedback and finishing it myself?
I applied it. But it doesn't work for Juergen S - you two need to talk
it out to find out why :)
john
> Darren
>
--
"What wil
Darren Freeman wrote:
> Fixed in the attached patch
Confirmed.
Many thanks, Darren!
Jürgen.
On Mon, Oct 21, 2002 at 05:20:51AM +0930, Darren Freeman wrote:
> I would still like to do that, but by doing so I would be compelled to
> increase the amount of whitespace somewhat.
But surely not by inserting two blank lines between parts of code in the
body of a function?
I've 25 lines on the
On Mon, Oct 21, 2002 at 05:42:10AM +0930, Darren Freeman wrote:
> No I mean that as I turn the wheel, the scroll rate changes as I go
> past, say, lots of headings or bigger writing.
Hold on to your hat: lyx cannot easily scroll by non-row based amounts.
This is because we use setCursorByCoordina
On Mon, Oct 21, 2002 at 05:50:21AM +0930, Darren Freeman wrote:
> Yes, CMM doesn't refer to the code itself but the organisation producing
> the code.
Right.
> By the time you get to CMM level 4 though, you've got some
> pretty hardcore software engineering going on.
Or you know how to fake it
John,
On Mon, 2002-10-21 at 02:09, John Levon wrote:
> On Sun, Oct 20, 2002 at 09:58:21PM +0930, Darren Freeman wrote:
>
> > The result is that I could scroll down, although it was a bit slow for
> > my liking. Would need something in the lyxrc file to control that as
> > everybody has a differ
On Mon, 2002-10-21 at 05:32, John Levon wrote:
> On Mon, Oct 21, 2002 at 05:29:28AM +0930, Darren Freeman wrote:
>
> > Ahem! Well if the code you got came from Motorola TCG then I wouldn't
> > blame you for booting me right now... But before you do, I was working
> > at MASC where we operated at C
John,
On Mon, 2002-10-21 at 02:09, John Levon wrote:
> On Sun, Oct 20, 2002 at 09:58:21PM +0930, Darren Freeman wrote:
>
> > Basically my thoughts are that the code is really poorly documented and
>
> Useful comments are most definitely wanted. We know about the poor
> documentation and are slow
On Mon, 2002-10-21 at 03:53, Lars Gullik Bjønnes wrote:
> Darren Freeman <[EMAIL PROTECTED]> writes:
>
> | John,
> |
> | On Mon, 2002-10-21 at 02:09, John Levon wrote:
> | > On Sun, Oct 20, 2002 at 09:58:21PM +0930, Darren Freeman wrote:
> | >
> | > > Basically my thoughts are that the code is r
On Mon, Oct 21, 2002 at 05:20:51AM +0930, Darren Freeman wrote:
> Based solely on my inspection of BufferView_pimpl.[Ch] and no other
> files (I stayed away from them..) I would say that the justification is
> that they are pretty compact and hard to follow.
It is best to be specific. Believe me
On Mon, Oct 21, 2002 at 06:13:23AM +0930, Darren Freeman wrote:
> BTW you should get yourself a wheel mouse if you can.. They're really
I should...
> Well, if you like them, then you will add them. Am I right? Well then I
> would like to refresh whatever you have done to the tree.
right. just d
On Mon, 2002-10-21 at 05:21, John Levon wrote:
> On Mon, Oct 21, 2002 at 05:16:40AM +0930, Darren Freeman wrote:
>
> > I assume for the moment it is measured in lines.
>
> I don't think so. default is 100, that's a lot of lines. I do not know
> its units.
>
> > I get this from the lines in text
John,
On Mon, 2002-10-21 at 05:52, John Levon wrote:
> On Mon, Oct 21, 2002 at 05:42:10AM +0930, Darren Freeman wrote:
>
> > No I mean that as I turn the wheel, the scroll rate changes as I go
> > past, say, lots of headings or bigger writing.
>
> Hold on to your hat: lyx cannot easily scroll by
On Mon, Oct 21, 2002 at 03:44:37AM +0930, Darren Freeman wrote:
> I would like to help document the code. First I have to understand it
> for myself.
And we are happy to help you with that, as much as we can.
> At the minimum I would be happy to go through some of it and
> reformat it to the sta
On Mon, Oct 21, 2002 at 05:16:40AM +0930, Darren Freeman wrote:
> I assume for the moment it is measured in lines.
I don't think so. default is 100, that's a lot of lines. I do not know
its units.
> I get this from the lines in text3.C:
> text3.C:bv->scroll(-lyxrc.wheel
On Mon, Oct 21, 2002 at 05:42:10AM +0930, Darren Freeman wrote:
> Doing... done!
I've applied your patch, after I re-worked it. Everybody with wheel
mice, please test current tip.
thanks
john
--
"It's a cardboard universe ... and if you lean too hard against it, you fall
through."
-
On Mon, 2002-10-21 at 04:35, John Levon wrote:
> On Mon, Oct 21, 2002 at 03:44:37AM +0930, Darren Freeman wrote:
>
> > I would like to help document the code. First I have to understand it
> > for myself.
>
> And we are happy to help you with that, as much as we can.
>
> > At the minimum I would
Darren Freeman <[EMAIL PROTECTED]> writes:
| John,
|
| On Mon, 2002-10-21 at 02:09, John Levon wrote:
| > On Sun, Oct 20, 2002 at 09:58:21PM +0930, Darren Freeman wrote:
| >
| > > Basically my thoughts are that the code is really poorly documented and
| >
| > Useful comments are most definitely
On Mon, Oct 21, 2002 at 05:29:28AM +0930, Darren Freeman wrote:
> Ahem! Well if the code you got came from Motorola TCG then I wouldn't
> blame you for booting me right now... But before you do, I was working
> at MASC where we operated at CMM level 4 (level 5 was the goal).
So did we, contracted
I actually made a few more posts but due to a bug in Evolution they
disappeared without being sent.
Basically my thoughts are that the code is really poorly documented and
could do with some whitespace just about everywhere =)
It took a comparatively long time to reverse-engineer the code, but I
On Sat, Oct 19, 2002 at 07:29:13PM +0930, Darren Freeman wrote:
> I'll have a poke around in the source, someone mentioned the lines that
> are the problem and asked for a wheel user to fix it.
Great. Here's some hints :
defaultHeight() is the standard height of one text row
height() is the hei
I have just compiled the 1.3.0CVS version.
Mouse wheel works perfectly throughout my system.
But LyX mousewheel support is now broken, was working in 1.2.1
I can scroll down one line from the top of the document with the wheel,
then it stops responding to the wheel. If I move the cursor back
On Fri, Oct 18, 2002 at 12:28:12PM +0200, Lars Gullik Bjønnes wrote:
> same in both xforms and qt, the scroll wheel does not seem to work...
I'm afraid I broke it (it's on bugzilla). My blind attempts to fix it
did not work. Can you or somebody who actually has a mouse wheel please
look at it. Th
Kuba Ober <[EMAIL PROTECTED]> writes:
>> >> same in both xforms and qt, the scroll wheel does not seem to work...
>
>> | Are you sure it works in other qt apps on your system? (i.e. is this
>> | configured in your X config file)?
>>
>> Not sure about qt apps, but it certanly works in other apps. e
> >> same in both xforms and qt, the scroll wheel does not seem to work...
> | Are you sure it works in other qt apps on your system? (i.e. is this
> | configured in your X config file)?
>
> Not sure about qt apps, but it certanly works in other apps. emacs,
> mozilla, konsole (which is kde and th
Kuba Ober <[EMAIL PROTECTED]> writes:
| On piÄ
tek 18 październik 2002 06:28 am, Lars Gullik Bjønnes wrote:
>> same in both xforms and qt, the scroll wheel does not seem to work...
>
| Are you sure it works in other qt apps on your system? (i.e. is this
| configured in your X config file)?
Not
On piÄ
tek 18 październik 2002 06:28 am, Lars Gullik Bjønnes wrote:
> same in both xforms and qt, the scroll wheel does not seem to work...
Are you sure it works in other qt apps on your system? (i.e. is this
configured in your X config file)?
Cheers, Kuba Ober
same in both xforms and qt, the scroll wheel does not seem to work...
--
Lgb
45 matches
Mail list logo
