On Mon, 2002-10-21 at 03:53, Lars Gullik Bjønnes wrote: > Darren Freeman <[EMAIL PROTECTED]> writes: > > | John, > | > | On Mon, 2002-10-21 at 02:09, John Levon wrote: > | > On Sun, Oct 20, 2002 at 09:58:21PM +0930, Darren Freeman wrote: > | > > | > > Basically my thoughts are that the code is really poorly documented and > | > > | > Useful comments are most definitely wanted. We know about the poor > | > documentation and are slowly trying to fix it. > | > | I would like to help document the code. First I have to understand it > | for myself. At the minimum I would be happy to go through some of it and > | reformat it to the standards I learned while working for Motorola (which > | I now choose to use all the time!) > > I can asure you that reformatting without good justification is out of > the question.
Based solely on my inspection of BufferView_pimpl.[Ch] and no other files (I stayed away from them..) I would say that the justification is that they are pretty compact and hard to follow. If new coders can't follow the code, they might move on to a project where they can. I don't mean to be rude but it's reality. > But help in making the commenting better would certainly be > appreciated. I would still like to do that, but by doing so I would be compelled to increase the amount of whitespace somewhat. > Lgb Have fun, Darren
