Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-09 Thread Huang Ying
> Ad. the glade files: > > I think those should be placed in the gtk directory, but be installed > in the lib dir. I think that is the right way, and I have done that. Huang Ying.

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 06:41:17PM +0200, Lars Gullik Bjønnes wrote: > | Lars> | Delete the ./configure.{ac,in} that it just created. > | > | Lars> Why? (and won't the dependency machinery have some problems with > | Lars> that?) > | > | OK, so a better idea is to get rid of ac213 support and mov

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> | Delete the ./configure.{ac,in} that it just created. | | Lars> Why? (and won't the dependency machinery have some problems with | Lars> that?) | | OK, so a better idea

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> | Delete the ./configure.{ac,in} that it just created. Lars> Why? (and won't the dependency machinery have some problems with Lars> that?) OK, so a better idea is to get rid of ac213 support and move the files in their proper

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Rob Lahaye <[EMAIL PROTECTED]> writes: | Huang Ying wrote: | >>The "mm" extension doesn't seem to have a port on FreeBSD either. | >>What is actually the difference between gtk+ and gtkmm ? | >> | > | > gtk+ is a toolkit with C api, and gtkmm is a language binding of gtk+ | > that provide the C++

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Rob Lahaye
Huang Ying wrote: >>The "mm" extension doesn't seem to have a port on FreeBSD either. >>What is actually the difference between gtk+ and gtkmm ? >> > > gtk+ is a toolkit with C api, and gtkmm is a language binding of gtk+ > that provide the C++ api of gtk+. I remember there is gtkmm 2.0 port in >

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> Should delete what? | | Delete the ./configure.{ac,in} that it just created. Why? (and won't the dependency machinery have some problems with that?) -- Lgb

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Should delete what? Delete the ./configure.{ac,in} that it just created. JMarc

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Ssshhh... my secret thingie is to not update configure.in and Lars> only do configure.in if somebody complains. Lars> That said, I'd be happy to ditch 2.13 right away. I think we should do it. JMarc

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: | | Andre> On Tue, Jul 08, 2003 at 03:48:22PM +0200, Lars Gullik Bjønnes | Andre> wrote: | >> | shouldn't go to config/configure.in. configure.ac seems to be | >> re-build | each time ./a

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 04:01:07PM +0200, Lars Gullik Bjønnes wrote: > note: config/configure.ac... not ./configure.ac Ah! Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Tue, Jul 08, 2003 at 03:48:22PM +0200, Lars Gullik Bjønnes Andre> wrote: >> | shouldn't go to config/configure.in. configure.ac seems to be >> re-build | each time ./autogen.sh runs. >> >> No. It should to to config/configure.ac

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Huang Ying
> The pkg-config commands are most probably not going to work with FreeBSD: > $ pkg-config --modversion gtkmm-2.0 > No package 'gtkmm-2.0' found > $ pkg-config --modversion libglademm-2.0 > No package 'libglademm-2.0' found > > However, instead, this works on FreeBSD: > $ pkg-config --mo

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: | | Andre> On Mon, Jul 07, 2003 at 11:58:45PM +0800, Huang Ying wrote: | >> The patch contains the the main form, ie the LyXView and Aboutlyx | >> dialog. Just a begining with gtk fronten

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Rob Lahaye <[EMAIL PROTECTED]> writes: | The pkg-config commands are most probably not going to work with FreeBSD: | $ pkg-config --modversion gtkmm-2.0 | No package 'gtkmm-2.0' found | $ pkg-config --modversion libglademm-2.0 | No package 'libglademm-2.0' found | | However, instead, this

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Jul 08, 2003 at 03:48:22PM +0200, Lars Gullik Bjønnes wrote: | > | shouldn't go to config/configure.in. configure.ac seems to be re-build | > | each time ./autogen.sh runs. | > | > No. It should to to config/configure.ac | | Here it looks a

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Mon, Jul 07, 2003 at 11:58:45PM +0800, Huang Ying wrote: >> The patch contains the the main form, ie the LyXView and Aboutlyx >> dialog. Just a begining with gtk frontend. The render system is >> based on xft including the math t

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 03:48:22PM +0200, Lars Gullik Bjønnes wrote: > | shouldn't go to config/configure.in. configure.ac seems to be re-build > | each time ./autogen.sh runs. > > No. It should to to config/configure.ac Here it looks as though configure.ac is rebuild from time to time. At

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Rob Lahaye
Huang Ying wrote: > diff -u -r -N lyx-1.4.0cvs/configure.ac lyx-1.4.0cvs_gtk/configure.ac > --- lyx-1.4.0cvs/configure.ac 2003-07-01 17:51:21.0 +0800 > +++ lyx-1.4.0cvs_gtk/configure.ac 2003-07-07 19:15:25.0 +0800 > @@ -182,6 +184,15 @@ > dnl FRONTEND_INCLUDES="-I\${srcdir

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Jul 07, 2003 at 11:58:45PM +0800, Huang Ying wrote: | > The patch contains the the main form, ie the LyXView and Aboutlyx | > dialog. Just a begining with gtk frontend. The render system is based on | > xft including the math things. So making su

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Andre Poenitz
On Mon, Jul 07, 2003 at 11:58:45PM +0800, Huang Ying wrote: > The patch contains the the main form, ie the LyXView and Aboutlyx > dialog. Just a begining with gtk frontend. The render system is based on > xft including the math things. So making sure that you have configure > the math xft font prop

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Huang Ying
> - you use std::string in many places. The current way of doing things > in LyX is to use '#include "LString.h"' and later 'string' without > std:: qualifier. This is because we provide a lighter std::string > replacement. ok, I will replace them. > - it seems that your code for menus and t

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
Huang> The patch contains the the main form, ie the LyXView and Huang> Aboutlyx dialog. Just a begining with gtk frontend. Hello, The patch looks nice indeed. A few things to consider: - you use std::string in many places. The current way of doing things in LyX is to use '#include "LString.h

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Huang Ying
> Ok, but gtk must have something that works for projects like lyx as > well? I think the gtk+ stuff is not appropriate for lyx, using xft directly is better. This is my idea. And I have sent a mail to gtk devel mailing list to listen their advice. Huang Ying

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Huang Ying <[EMAIL PROTECTED]> writes: | > If possible pango should be used with gtk, since then a dependency on | > X will be avoided. (gtk/gtkmm exists for Win as well, right?) | > | > Also if pango is used directly it seems to be possible to do without | > freetype fonts. Is this the case with

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Huang Ying
> If possible pango should be used with gtk, since then a dependency on > X will be avoided. (gtk/gtkmm exists for Win as well, right?) > > Also if pango is used directly it seems to be possible to do without > freetype fonts. Is this the case with Xft? The problem about pango is that It is a high

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Lars Gullik Bjønnes
Huang Ying <[EMAIL PROTECTED]> writes: | > o Why are we using Xft directly ? Doesn't gtk+ abstract the actual font | > loader away ? | I think the gtk+ render system(i.e. pango) is a rather high level | render system and they work efficient only on long text, such as a | paragraph. I have try i

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-08 Thread Jean-Marc Lasgouttes
> "Huang" == Huang Ying <[EMAIL PROTECTED]> writes: >> o Why are we using Xft directly ? Doesn't gtk+ abstract the actual >> font loader away ? Huang> I think the gtk+ render system(i.e. pango) is a rather high Huang> level render system and they work efficient only on long text, Huang> such a

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Rob Lahaye
Huang Ying wrote: >>Any special reason why you put the files in gtk instead of gnome? > > I use the gtkmm and libglademm to implement the frontend, but not > anything about gnome. Because the gnome develop platform is so big > and not as portable as gtk, So I base my work on gtk not gnome. Th

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Huang Ying
> | This is a minor issue, but I think the *.glade files should go rather to > | frontends/gtk/dialogs than to lib/glade (all frontend specific stuff should > | be in /frontends AFAIK). > > Depends a bit... are these glade files precompiled into C++/C code or > are the glade files used as is and

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Huang Ying
> o 2 blank lines between functions in .C files please (I guess you can > script this change) ok, I will do it. > o you have too many inline functions. Please make them out of line ok, I will check all the inline functions. Make ones not necessary out of line. > o a couple of points had functions b

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Huang Ying
> Any special reason why you put the files in gtk instead of gnome? I use the gtkmm and libglademm to implement the frontend, but not anything about gnome. Because the gnome develop platform is so big and not as portable as gtk, So I base my work on gtk not gnome. And I write the gtk frontend

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Juergen Spitzmueller) writes: | Huang Ying wrote: | > The Advice is welcome. | | This is a minor issue, but I think the *.glade files should go rather to | frontends/gtk/dialogs than to lib/glade (all frontend specific stuff should | be in /frontends AFAIK). Depends a bit...

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Juergen Spitzmueller
Huang Ying wrote: > The Advice is welcome. This is a minor issue, but I think the *.glade files should go rather to frontends/gtk/dialogs than to lib/glade (all frontend specific stuff should be in /frontends AFAIK). Regards, Juergen.

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread John Levon
On Mon, Jul 07, 2003 at 11:58:45PM +0800, Huang Ying wrote: > The patch contains the the main form, ie the LyXView and Aboutlyx > dialog. Just a begining with gtk frontend. The render system is based on > xft including the math things. So making sure that you have configure > the math xft font pro

Re: gtk patch against 1.4.0cvs on July 1st.

2003-07-07 Thread Lars Gullik Bjønnes
Huang Ying <[EMAIL PROTECTED]> writes: | The patch contains the the main form, ie the LyXView and Aboutlyx | dialog. Just a begining with gtk frontend. The render system is based on | xft including the math things. So making sure that you have configure | the math xft font properly. I think I have