Huang> The patch contains the the main form, ie the LyXView and
Huang> Aboutlyx dialog. Just a begining with gtk frontend.
Hello,
The patch looks nice indeed. A few things to consider:
- you use std::string in many places. The current way of doing things
in LyX is to use '#include "LString.h"' and later 'string' without
std:: qualifier. This is because we provide a lighter std::string
replacement.
- it seems that your code for menus and toolbars (I looked at that
because it is what I know best) is based on 1.3.x code. In 1.4.0cvs,
many common functions have been recoded in the frontend-independent
source. Examples include:
xpmNameOfAction (use ToolbarBackend::getIcon)
Menubar::Pimpl::submenuDisabled (the information is given by
MenuItem::status())
in Menubar::Pimpl::onSubMenuActivate, the code can somewhat be
simplified by the use of MenuItem::status(). In particular you do
not have to worry about optional() and unknown(), since this is
automatically taken care of.
JMarc
