Re: [PATCH] more xforms cleanup

2006-07-13 Thread Lars Gullik Bjønnes
Michael Gerz <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | | >On Mon, Jul 10, 2006 at 09:39:39PM +0200, Michael Gerz wrote: | > | >>Subject says it all. | >> | >>Michael | >> | >>Index: SConstruct | >>=== | >>--- SConstruct (

Re: [PATCH] more xforms cleanup

2006-07-12 Thread Michael Gerz
Andre Poenitz wrote: On Mon, Jul 10, 2006 at 09:39:39PM +0200, Michael Gerz wrote: Subject says it all. Michael Index: SConstruct === --- SConstruct (Revision 14416) +++ SConstruct (Arbeitskopie) @@ -122,7 +122,7 @@ opts.Add

Re: [PATCH] more xforms cleanup

2006-07-12 Thread Bo Peng
> -allowed_values = ('xform', 'qt2', 'qt3', 'qt4', 'gtk') ), > +allowed_values = ('qt2', 'qt3', 'qt4', 'gtk') ), qt2 looks odd. Unless you want to rename src/frontends/qt2 in the 1.4.x branch to qt3. The existence of that directory, by the way, is a signature for scons to tell 1

Re: [PATCH] more xforms cleanup

2006-07-12 Thread Jose' Matos
On Tuesday 11 July 2006 18:22, Andre Poenitz wrote: > qt2 looks odd. And it is wrong for 1.5.x, I only support qt3+ there. > Andre' -- José Abílio

Re: [PATCH] more xforms cleanup

2006-07-12 Thread Andre Poenitz
On Mon, Jul 10, 2006 at 09:39:39PM +0200, Michael Gerz wrote: > Subject says it all. > > Michael > > Index: SConstruct > === > --- SConstruct (Revision 14416) > +++ SConstruct (Arbeitskopie) > @@ -122,7 +122,7 @@ > opts.AddOptions(

[PATCH] more xforms cleanup

2006-07-10 Thread Michael Gerz
Subject says it all. Michael Index: SConstruct === --- SConstruct (Revision 14416) +++ SConstruct (Arbeitskopie) @@ -122,7 +122,7 @@ opts.AddOptions( # frontend EnumOption('frontend', 'Main GUI', default_frontend, -

Re: PATCH small xforms cleanup

2000-10-14 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | The attached patch removes those "conversion to integral type of smaller | size" warnings from a couple of files in frontends/xforms. This directory is | now clean! One small comment: when you know the type to be "large enough" we can use this style

Re: PATCH small xforms cleanup

2000-10-13 Thread Angus Leeming
On Fri, 13 Oct 2000, Angus Leeming wrote: > > The attached patch removes those "conversion to integral type of smaller > size" warnings from a couple of files in frontends/xforms. This directory > is now clean! > > A Oops! Forgot to include combox.[Ch] in that patch. Index: src/combox.C ===

PATCH small xforms cleanup

2000-10-13 Thread Angus Leeming
The attached patch removes those "conversion to integral type of smaller size" warnings from a couple of files in frontends/xforms. This directory is now clean! A patchFri13Part4.bz2

Re: XForms cleanup

2000-08-04 Thread Lars Gullik Bjønnes
Baruch Even <[EMAIL PROTECTED]> writes: | On Fri, 4 Aug 2000, Allan Rae wrote: | | > Firstly, Baruch, I like your RadioButtonGroup. Very neat and clever. | | Thanks. | | I considered another implementation for this as a template in order to | avoid the conversion int<-->enum that caused warni

Re: XForms cleanup

2000-08-04 Thread Baruch Even
On Fri, 4 Aug 2000, Allan Rae wrote: > Firstly, Baruch, I like your RadioButtonGroup. Very neat and clever. Thanks. I considered another implementation for this as a template in order to avoid the conversion int<-->enum that caused warnings and found to require a static_cast to overcome a prob

Re: XForms cleanup

2000-08-04 Thread Angus Leeming
Angus> The user hits Cancel and we revert to the original Angus> contents and to buttons 1 JMarc> I'm not sure I like that. For most applications, Cancel closes the JMarc> form. Hmmm! Good point! Idea scratched.

Re: XForms cleanup

2000-08-04 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> The user hits Cancel and we revert to the original Angus> contents and to buttons 1 I'm not sure I like that. For most applications, Cancel closes the form. JMarc

Re: XForms cleanup

2000-08-04 Thread Angus Leeming
Allan> We should probably change the Cancel label to Close once someone has Allan> pressed Apply since this more accurately reflects reality. I did this in Allan> the old tree and advocate it in the GUII doc. It's pretty easy to Allan> implement. Allan, I like this idea, but think we can do bett

Re: XForms cleanup

2000-08-04 Thread Angus Leeming
Allan> ### Allan> The rest is mainly for Angus. I took a quick look at FormCitation.C and Allan> noticed something which will be a problem when we move to having multiple Allan> LyXViews (ie. multiple main windows): Allan> static vector citekeys; Allan> ... Allan> Allan> These 3 variables at fi

Re: XForms cleanup

2000-08-03 Thread Allan Rae
Firstly, Baruch, I like your RadioButtonGroup. Very neat and clever. ### The rest is mainly for Angus. I took a quick look at FormCitation.C and noticed something which will be a problem when we move to having multiple LyXViews (ie. multiple main windows): static vector citekeys;

Re: XForms cleanup

2000-08-02 Thread Allan Rae
On Wed, 2 Aug 2000, Allan Rae wrote: > Angus, I also noticed some comments in the copied/modified files for > Citations etc. that need cleaning out. I haven't looked at your latest > patch so you may have done it already. There may be a few other > inconsistencies between our various files we s

XForms cleanup

2000-08-01 Thread Allan Rae
This is mainly meant for Angus. Now that you have the main InsetCommand dialogs GUII we should probably try to make sure we are doing the best possible implementation: since it's our reference platform and we have two other ports ready to take off. I just noticed Lars has a comment in ChangeLog