On Wed, 2 Aug 2000, Allan Rae wrote:
> Angus, I also noticed some comments in the copied/modified files for
> Citations etc. that need cleaning out. I haven't looked at your latest
> patch so you may have done it already. There may be a few other
> inconsistencies between our various files we should try to
> cleanup. Policies mainly, like controlling the Ok and Apply keys that
> sort of thing.
Just found what one of those inconsistencies was:
Always initialise everything in your constructors.
Perhaps a small oversight but not initializing dialog_ is fatal (or any
other pointer for that matter). I had noticed last week that you had a
few things missing from the contructor but forgot to mention it (or fix it
myself).
The biggest problem for us at the moment will be the
delete-an-inset-with-an-open-dialog problem. Hmmm... why don't we just
write our own copy constructor and assignment operator that ignore (don't
try to copy) the Signal? That gets us out of the "who owns the dialog"
mess and keeps the correct inset and dialog together. Yeah that sounds
like the way to go.
Objections?
Allan. (ARRae)
