This is mainly meant for Angus.
Now that you have the main InsetCommand dialogs GUII we should probably
try to make sure we are doing the best possible implementation: since it's
our reference platform and we have two other ports ready to take off.
I just noticed Lars has a comment in ChangeLog saying we can't use
Signals for the hiding of deleted insets because Signals aren't copyable.
Lars? why is this important? IIRC assigning a Signal hands over the
connection list to the new signal and the old signal now has an empty
connection list. Hmmm.. That could be a problem if the dialog is
visible and after copying we deleted the old one. I'll have to think
about that one. I'm sure I never encountered any problems with the scheme
in the old tree but then that used a different Signals implementation.
Angus, I also noticed some comments in the copied/modified files for
Citations etc. that need cleaning out. I haven't looked at your latest
patch so you may have done it already. There may be a few other
inconsistencies between our various files we should try to
cleanup. Policies mainly, like controlling the Ok and Apply keys that
sort of thing.
I've been looking at how to reset values to default in the preferences
dialog and attempted to allow resetting individual values. This works up
to point. I was trying to use a right mouse click in an input box to
trigger the resetting of the value. Mouse clicks don't trigger the
callback for input boxes however (except middle mouse when its pasting
something in). I don't want to add an individual reset button for each
entry so I think I'll just have a button labelled "Reset" or "Default"
near the Ok, Apply and Cancel buttons that resets the open tabfolder or on
double-click resets the entire form. What to reset the values to though:
loaded and subsequent Apply'd lyxrc (the equivalent of Cancel and reopen)
or to system lyxrc settings (or the option of both: single click gives one
double click the other)?
I did modify xforms/forms/makefile in the process to create an enum of the
various widgets so it was easy to use symbolic names for the callback
return values. If someone can suggest a way of triggering the reset of an
individual input box without having a separate "Reset" button for each one
I'd be most interested otherwise I won't commit my enum creation code
(maybe as a comment).
We should probably change the Cancel label to Close once someone has
pressed Apply since this more accurately reflects reality. I did this in
the old tree and advocate it in the GUII doc. It's pretty easy to
implement.
I also really need to get that bloody GUII documentation updated. It's
not that far out of whack but far enough that nobody reads it. Although
could be a matter of out of reach or out of mind since it's not in the
distribution.
Allan. (ARRae)
P.S. This latest patch seems to have totally f%&ked up cvs.
