Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-03 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > I'll commit this. I take it that's a sort of OK. You forgot to update status.15x. JMarc

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-03 Thread Bo Peng
> I'll commit this. I take it that's a sort of OK. Thanks. I will close the bug after I (re)test it under windows. Bo

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-03 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes wrote: >> Richard Heck <[EMAIL PROTECTED]> writes: >> >>> I'll commit this. I take it that's a sort of OK. >>> >> You forgot to update status.15x. >> > Sorry, I'm not used to doing that yet. No problem it is my (temporary)

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-03 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: I'll commit this. I take it that's a sort of OK. You forgot to update status.15x. Sorry, I'm not used to doing that yet. Richard -- == Richard G Hec

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-03 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: Here is the most up-to-date version of the patch, with all comments and such. Bo and I agree it should go into both trunk and branch, as it solves the problem. ;-) We need one more OK. Am I right that the changes to se

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-03 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > Here is the most up-to-date version of the patch, with all comments > and such. Bo and I agree it should go into both trunk and branch, as > it solves the problem. ;-) We need one more OK. Am I right that the changes to setBuffer are not really needed? W

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-02 Thread Richard Heck
Bo Peng wrote: On 8/2/07, Richard Heck <[EMAIL PROTECTED]> wrote: Here is the most up-to-date version of the patch, with all comments and such. Bo and I agree it should go into both trunk and branch, as it solves the problem. ;-) We need one more OK. + //Now that all the

Re: [PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-02 Thread Bo Peng
On 8/2/07, Richard Heck <[EMAIL PROTECTED]> wrote: > > Here is the most up-to-date version of the patch, with all comments and > such. Bo and I agree it should go into both trunk and branch, as it > solves the problem. ;-) We need one more OK. + //Now that all the updating of the old

[PATCH] Bug 4096, ChildDoc/TOC Crash

2007-08-02 Thread Richard Heck
Here is the most up-to-date version of the patch, with all comments and such. Bo and I agree it should go into both trunk and branch, as it solves the problem. ;-) We need one more OK. Richard -- == Richard G Heck, Jr Professor

Re: [Updated PATCH 2] Child TOC Crash, Again

2007-06-19 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Hi Richard, I've done that and did a bit more simplifications. Patch attached (not tested yet). Here is a patch that actually compiles and works for all use cases. Whoops. I just committed the other one, per your suggestion. If you want to revert

Re: [Updated PATCH 2] Child TOC Crash, Again

2007-06-19 Thread Richard Heck
Abdelrazak Younes wrote: Hi Richard, I've done that and did a bit more simplifications. Patch attached (not tested yet). Here is a patch that actually compiles and works for all use cases. Whoops. I just committed the other one, per your suggestion. If you want to revert and commit this one,

[Updated PATCH 2] Child TOC Crash, Again

2007-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but may

[Updated PATCH] Child TOC Crash, Again

2007-06-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Richard Heck wrote: The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but maybe that could wait. Mayb

Re: [PATCH] Child TOC Crash, Again

2007-06-18 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but maybe that

Re: [PATCH] Child TOC Crash, Again

2007-06-18 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but maybe that could wait. Maybe y

Re: [PATCH] Child TOC Crash, Again

2007-06-16 Thread Abdelrazak Younes
Richard Heck wrote: The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but maybe that could wait. Maybe yes. What I've done i

[PATCH] Child TOC Crash, Again

2007-06-16 Thread Richard Heck
The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but maybe that could wait. What I've done is add an optional argument to LFUN_

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_cast(buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_cast(buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one automatically for me but

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_cast(buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one automatically for me but I'll do the change a

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: What follows has to be const_cast(buffer).dispatch(). No, I want rather to use the global dispatch method. So that would be: +lyx::dispatch(FuncRequest(LFUN_BUFFER_CHILD_OPEN, MSVC chose this one automatically for me but I'll do the change a

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abd

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Ric

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysi

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Richard! The solution is

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. Of course you are right but I don't want to do that now because it will involves much more intrusive changes in Bu

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Richard! The solution

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Abdelrazak Younes
Stefan Schimanski wrote: Tried it a bit with child documents. Looks fine. OK, thanks. Abdel.

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Abdelrazak Younes
Richard Heck wrote: Idea for fix: Since the buffer_func.cpp version of loadLyXFile() is called from LyXView::loadLyXFile(), anyway, all the child doc stuff could be moved there. But I don't know this code terribly well. Abdel? Very good analysis Richard! The solution is to use the LFUN instead

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Richard Heck wrote: Richard Heck wrote: Second problem: Now, with the TOC open, close the master document. BOOM. Backtrace below. I'm guessing that the problem here is related to the first problem. This bug may have been revealed by my "don't close buffer dependent dialogs" patch: http://w

Re: [PATCH] Bug 3860 Toc crash WITH child documents

2007-06-15 Thread Richard Heck
Richard Heck wrote: Abdelrazak Younes wrote: I won't be able to commit it this week-end so could anyone show a little bit of interest please? I've patched and am compiling now. This patch does fix that crash, but I'm seeing some other odd behavior, and I'm getting another crash. I don't know t

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Stefan Schimanski
Tried it a bit with child documents. Looks fine. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Stefan Schimanski
Abdelrazak Younes wrote: I won't be able to commit it this week-end so could anyone show a little bit of interest please? I've patched and am compiling now. Me too. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread José Matos
On Friday 15 June 2007 18:57:44 Richard Heck wrote: > I've patched and am compiling now. > > rh If it fixes the crash you have my OK. :-) -- José Abílio

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Richard Heck
Abdelrazak Younes wrote: I won't be able to commit it this week-end so could anyone show a little bit of interest please? I've patched and am compiling now. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http

Re: [PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: http://bugzilla.lyx.org/show_bug.cgi?id=3860 SVN Log: Polish the Toc and labels updating when loading a child document. Fix Bug 3860: Toc crash when loading a child documents. * BufferView::loadLyXFile(): simplify, transfer last part to LyXView::loadLyXFile

[PATCH] Bug 3860 Toc crash when loading a child documents

2007-06-14 Thread Abdelrazak Younes
http://bugzilla.lyx.org/show_bug.cgi?id=3860 SVN Log: Polish the Toc and labels updating when loading a child document. Fix Bug 3860: Toc crash when loading a child documents. * BufferView::loadLyXFile(): simplify, transfer last part to LyXView::loadLyXFile() * LyXView: - setBuffer

Re: TOC crash

2001-12-14 Thread Andre Poenitz
On Fri, Dec 14, 2001 at 11:51:32AM +0100, Juergen Vigna wrote: > Well it seems Andre's disease is highly infective, the only missing thing > is the starting 'Hrmpf' on sending the real patch! But it looks like our "computing center" (I wonder where they got that name from...) is actively tring to

Re: TOC crash

2001-12-14 Thread Juergen Vigna
On 14-Dec-2001 John Levon wrote: >> But sadly the unattached fix doesn't work for me. > > frankly pathetic. here you go, since you whiny types seem to need patches ... Well it seems Andre's disease is highly infective, the only missing thing is the starting 'Hrmpf' on sending the real patch!

Re: TOC crash

2001-12-14 Thread John Levon
On Fri, Dec 14, 2001 at 10:13:43AM +0100, Jean-Marc Lasgouttes wrote: > > "John" == John Levon <[EMAIL PROTECTED]> writes: > > John> frankly pathetic. here you go, since you whiny types seem to > John> need patches ... > > If I may whine, not that you left some debug statements in there. y

Re: TOC crash

2001-12-14 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> frankly pathetic. here you go, since you whiny types seem to John> need patches ... If I may whine, not that you left some debug statements in there. JMarc

Re: TOC crash

2001-12-14 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> frankly pathetic. here you go, since you whiny types seem to John> need patches ... I don't need patches, I don't have bugs. Applied anyway. JMarc

Re: TOC crash

2001-12-14 Thread John Levon
On Fri, Dec 14, 2001 at 05:42:29PM +1000, Allan Rae wrote: > My case is a multipart document and chapters are in separate docs. So > this is the same as an empty doc? dunno, does the current document not contain any entries ? > But sadly the unattached fix doesn't work for me. frankly pathetic

Re: TOC crash

2001-12-13 Thread Allan Rae
On Fri, 14 Dec 2001, John Levon wrote: > > > Anyone else noticed a crash when opening a TOC dialog in current CVS? > it crashes on an empty document. fix attached. My case is a multipart document and chapters are in separate docs. So this is the same as an empty doc? But sadly the unattached fi

Re: TOC crash

2001-12-13 Thread John Levon
> > Anyone else noticed a crash when opening a TOC dialog in current CVS? it crashes on an empty document. fix attached. regards john -- "Of all manifestations of power, restraint impresses the most." - Thucydides

Re: TOC crash

2001-12-13 Thread Herbert Voss
Allan Rae wrote: > Anyone else noticed a crash when opening a TOC dialog in current CVS? no problem here, latest cvs Herbert -- http://www.lyx.org/help/

Re: TOC crash

2001-12-13 Thread John Levon
On Fri, Dec 14, 2001 at 03:33:42PM +1000, Allan Rae wrote: > Anyone else noticed a crash when opening a TOC dialog in current CVS? looks like my bad code. will fix ... john -- "Of all manifestations of power, restraint impresses the most." - Thucydides

TOC crash

2001-12-13 Thread Allan Rae
Anyone else noticed a crash when opening a TOC dialog in current CVS? Allan. (ARRae)

Re: toc crash

2001-06-07 Thread Dekel Tsur
On Thu, Jun 07, 2001 at 03:13:24PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Hansen <[EMAIL PROTECTED]> writes: > > Martin> My lyx version is 1.1.5fix1 When i open the accompanying FAQ, > Martin> and the click on the toc menu lyx crashes and closes. And the > Martin> terminal

Re: toc crash

2001-06-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Hansen <[EMAIL PROTECTED]> writes: Martin> My lyx version is 1.1.5fix1 When i open the accompanying FAQ, Martin> and the click on the toc menu lyx crashes and closes. And the Martin> terminal where lyx is started from says: I believe it is fixed in more recent LyX versio

toc crash

2001-06-06 Thread Martin Hansen
My lyx version is 1.1.5fix1 When i open the accompanying FAQ, and the click on the toc menu lyx crashes and closes. And the terminal where lyx is started from says: _ lyx: SIGSEGV signal caught Sorry, you have found a bug in LyX.