Richard Heck wrote:
The attached patch builds on Abdel's earlier work and, I think, solves the remaining problems. Whether this is the best way to do it, I'm not sure. Abdel was talking about a more major re-organization of the code, but maybe that could wait.
Maybe yes.
What I've done is add an optional argument to LFUN_BUFFER_CHILD_OPEN indicating whether the file is being auto-loaded. (Contrary to what I said before, this is ok, since we're expecting a valid LyX filename, and one isn't going to end with "|true".) There are also corresponding booleans in LyXView::loadLyXFile and BufferView::loadLyXFile.
At this point BufferView::loadLyXFile() do not need to be a member of BufferView so please put that in buffer_func.cpp along the other loadLyXFile().
Abdel, I'll leave it up to you to decide what's best here.
I am fine with your addition and as it looks like I won't have time to do more work on this before RC2, I'd say put it in (Jose and Stefan already gave their OK). Please re-use my SVN log posted with the patch.
But either way, please see the long FIXME at the end of LyXView::loadLyXFile(). It looks to me as if we're doing a lot of things twice.
Yes and that's what I was going to cleanup but you're probably right, this can wait :-)
Thanks, Abdel.
