Guidelines (Was: request for SVN commit access [was: Re: Refocus: Bidi Cursor Movement])

2007-05-18 Thread christian . ridderstrom
On Fri, 18 May 2007, Jürgen Spitzmüller wrote: [EMAIL PROTECTED] wrote: Sounds like a good idea. I prepared a place for this on the wiki http://wiki.lyx.org/Devel/Guidelines Thanks. I added the proposals. But the discussion should continue to reach consensus. In practice that may b

Re: request for SVN commit access [was: Re: Refocus: Bidi Cursor Movement]

2007-05-17 Thread Jürgen Spitzmüller
[EMAIL PROTECTED] wrote: > Sounds like a good idea. I prepared a place for this on the wiki > http://wiki.lyx.org/Devel/Guidelines Thanks. I added the proposals. Jürgen

Re: request for SVN commit access [was: Re: Refocus: Bidi Cursor Movement]

2007-05-17 Thread christian . ridderstrom
On Thu, 17 May 2007, Andre Poenitz wrote: On Thu, May 17, 2007 at 12:12:14AM +0300, Dov Feldstern wrote: If I get access, could you please just send me a short refresher on the procedure --- do we still have to update anything besides the commit log? No, we do not maintain ChangeLog files any

Re: request for SVN commit access [was: Re: Refocus: Bidi Cursor Movement]

2007-05-16 Thread Jürgen Spitzmüller
Andre Poenitz wrote: > There are no strict rules, but maybe we should set up a few guidelines > when more people get write access. Maybe we should document these on the wiki (once it's reachable again). > My personal recommendation for 'newcomers' (i.e. people that have been > around for a while

Re: request for SVN commit access [was: Re: Refocus: Bidi Cursor Movement]

2007-05-16 Thread Andre Poenitz
On Thu, May 17, 2007 at 12:12:14AM +0300, Dov Feldstern wrote: > If I get access, could you please just send me a short refresher on the > procedure --- do we still have to update anything besides the commit > log? No, we do not maintain ChangeLog files anymore. Just write a descriptive log mess

request for SVN commit access [was: Re: Refocus: Bidi Cursor Movement]

2007-05-16 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> I'm willing to accept commit access, of course, and I'm even Dov> willing to be in charge of this stuff, at least for now. But I Dov> have very little time that I can actually put into LyX --- this Dov> week I'v

Re: Refocus: Bidi Cursor Movement

2007-05-16 Thread Abdelrazak Younes
Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: I'm also attaching another version of it (v3), which is functionally equivalent, but where I made the reverseDirections method a static method of Bidi. I committed this version but replaced the static method with a simple he

Re: Refocus: Bidi Cursor Movement

2007-05-15 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: I'm also attaching another version of it (v3), which is functionally equivalent, but where I made the reverseDirections method a static method of Bidi. I committed this version but replaced the static method with a simple helper function reverseD

Re: Refocus: Bidi Cursor Movement

2007-05-15 Thread Abdelrazak Younes
Dov Feldstern wrote: I'm also attaching another version of it (v3), which is functionally equivalent, but where I made the reverseDirections method a static method of Bidi. I committed this version but replaced the static method with a simple helper function reverseDirectionNeeded(). Maybe we

Re: Refocus: Bidi Cursor Movement

2007-05-14 Thread Andre Poenitz
On Tue, May 15, 2007 at 01:07:43AM +0300, Dov Feldstern wrote: > Andre Poenitz wrote: > >>Index: src/Bidi.cpp > >>=== > >>--- src/Bidi.cpp(revision 18314) > >>+++ src/Bidi.cpp(working copy) > >>@@ -12,6 +12,7 @@ > >> > >> #inc

Re: Refocus: Bidi Cursor Movement

2007-05-14 Thread Dov Feldstern
Andre Poenitz wrote: Index: src/Bidi.cpp === --- src/Bidi.cpp(revision 18314) +++ src/Bidi.cpp(working copy) @@ -12,6 +12,7 @@ #include "Bidi.h" #include "Buffer.h" +#include "BufferView.h" #include "Font.h" #i

Re: Refocus: Bidi Cursor Movement

2007-05-14 Thread Andre Poenitz
> Index: src/Bidi.cpp > === > --- src/Bidi.cpp (revision 18314) > +++ src/Bidi.cpp (working copy) > @@ -12,6 +12,7 @@ > > #include "Bidi.h" > #include "Buffer.h" > +#include "BufferView.h" > #include "Font.h" > #include

Re: Refocus: Bidi Cursor Movement

2007-05-14 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: I think it is possible :-) The problem is simple really and I think you are misleading because you focus on the inset. When you think about it, entering

Re: Refocus: Bidi Cursor Movement

2007-05-14 Thread Abdelrazak Younes
Dov Feldstern wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: I think it is possible :-) The problem is simple really and I think you are misleading because you focus on the inset. When you think about it, entering or leaving an inset shou

Re: Refocus: Bidi Cursor Movement

2007-05-12 Thread Dov Feldstern
Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: I think it is possible :-) The problem is simple really and I think you are misleading because you focus on the inset. When you think about it, entering or leaving an inset should not be special; con

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: I think it is possible :-) The problem is simple really and I think you are misleading because you focus on the inset. When you think about it, entering or leaving an inset should not be special; continuous navigation is

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Abdelrazak Younes
Dov Feldstern wrote: Abdelrazak Younes wrote: I think it is possible :-) The problem is simple really and I think you are misleading because you focus on the inset. When you think about it, entering or leaving an inset should not be special; continuous navigation is possible when LTR snippet

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Dov Feldstern
Abdelrazak Younes wrote: I think it is possible :-) The problem is simple really and I think you are misleading because you focus on the inset. When you think about it, entering or leaving an inset should not be special; continuous navigation is possible when LTR snippet is embedded in an RTL

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Abdelrazak Younes
Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: Anyhow, back to the point: Basically, within the framework of logical movement, it's a question of whether we prefer the cursor to get stuck at insets, but to move "correctly" (i.e., the way the arrows point) inside them; or

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Anyhow, back to the point: Basically, within the framework of logical movement, it's a question of whether we prefer the cursor to get stuck at insets, but to move "correctly" (i.e., the way the arrows point) inside them; or we prefer that the cu

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Abdelrazak Younes
Dov Feldstern wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: Using the current version (with Elazar's patch already in), try moving the cursor in the attached document (a math inset inside a footnote). It gets stuck again in the math inset, even after Elazar's pa

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Abdelrazak Younes
Dov Feldstern wrote: Dov Feldstern wrote: It does not get stuck here... The cursor correclty move in and out the math inset. Abdel. This is very strange. Does it work in both directions? Do you have the RTL option set? Just to make sure that we're talking about the same thing: what

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Abdel, you're so touchy! I wasn't saying that we're not getting Dov> any help, and I really do appreciate your help, on all kinds of Dov> issues. And Thank you for committing Elazar's patch! It's just Dov> that

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: >> You could maybe try to look at the paragraph that is just one step >> under, instead of bottom(). Dov> What I think you guys are not understanding is that bidi user's Dov> don't even *expect* predictability on this issue! I've been Dov>

Re: Refocus: Bidi Cursor Movement

2007-05-10 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Abdel, you're so touchy! I wasn't saying that we're not getting Dov> any help, and I really do appreciate your help, on all kinds of Dov> issues. And Thank you for committing Elazar's patch! It's just Dov> that we always need even more

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Dov Feldstern wrote: So how do we decide? If you like, I can send a questionnaire to the user's list (and to everyone I know who uses LyX in Hebrew), and we'll see what they say. But what do we do if it's a tie? This is what I would send out: Dear LyX Bidi users! This is your chance to p

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Dov Feldstern wrote: Abdelrazak Younes wrote: Dov Feldstern wrote: Using the current version (with Elazar's patch already in), try moving the cursor in the attached document (a math inset inside a footnote). It gets stuck again in the math inset, even after Elazar's patch, just because the

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Using the current version (with Elazar's patch already in), try moving the cursor in the attached document (a math inset inside a footnote). It gets stuck again in the math inset, even after Elazar's patch, just because the math inset is now one

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: I'll add fix this and add it to my suggested patch, I'll also fix the spacing issues that Andre' pointed out, we can wait to hear Elazar's opinion if you want --- but I really think that what I'm suggesting is the way that most bidi users would pre

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Dov Feldstern wrote: It does not get stuck here... The cursor correclty move in and out the math inset. Abdel. This is very strange. Does it work in both directions? Do you have the RTL option set? Just to make sure that we're talking about the same thing: what we want to be able t

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Using the current version (with Elazar's patch already in), try moving the cursor in the attached document (a math inset inside a footnote). It gets stuck again in the math inset, even after Elazar's patch, just because the math inset is now one

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Abdel, you're so touchy! It was not meant to sound touchy, sorry :-) :) I'm willing to accept commit access, of course, and I'm even willing to be in charge of this stuff, at least for now. But I have very little time that I can actually pu

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Abdelrazak Younes
Dov Feldstern wrote: Using the current version (with Elazar's patch already in), try moving the cursor in the attached document (a math inset inside a footnote). It gets stuck again in the math inset, even after Elazar's patch, just because the math inset is now one level deeper! It does no

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Abdelrazak Younes
Dov Feldstern wrote: Abdelrazak Younes wrote: I had comments about the goto about which I asked others to state their opinion. I implemented the isRTL() method specifically for Elazar's patch; so it's not like we don't help at all... If you want more Dov, you should be proactive and ask for comm

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> *) Martin asked: "don't you think that cursor movement depending Dov> only on the local language (i.e., the deepest inset on the cursor Dov> stack) is easier and more transparent to implement?" Dov> Well yes, b

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Hi! *) Abdel said: "I personally tend to think that the only clear option, one that does not leave room for complicated interpretation is to go for screen oriented movement: right is right and left is left. Of course supporting both mode would be be

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> *) Martin asked: "don't you think that cursor movement depending Dov> only on the local language (i.e., the deepest inset on the cursor Dov> stack) is easier and more transparent to implement?" Dov> Well yes, but only trivially so. In

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, May 09, 2007 at 12:58:12AM +0300, Dov Feldstern wrote: [...] So how do we move ahead with this? 1. Since the current implementation is of logical movement, I strongly urge that we stick with that. And in order to fix the problem with that (of the cursor getting st

Re: Refocus: Bidi Cursor Movement

2007-05-09 Thread Abdelrazak Younes
Dov Feldstern wrote: Hi! *) Abdel said: "I personally tend to think that the only clear option, one that does not leave room for complicated interpretation is to go for screen oriented movement: right is right and left is left. Of course supporting both mode would be better." +1. Yes, I agree t

Re: Refocus: Bidi Cursor Movement

2007-05-08 Thread Andre Poenitz
On Wed, May 09, 2007 at 12:58:12AM +0300, Dov Feldstern wrote: > [...] > So how do we move ahead with this? > > 1. Since the current implementation is of logical movement, I strongly > urge that we stick with that. And in order to fix the problem with that > (of the cursor getting stuck within i

Re: Refocus: Bidi Cursor Movement

2007-05-08 Thread Martin Vermeer
On Wed, May 09, 2007 at 12:58:12AM +0300, Dov Feldstern wrote: > Hi! ... > Visual mode in both applications means that LEFT moves left, and RIGHT > moves right, regardless of the language, and the movement is visual and > not logical (so that the cursor may actually be jumping back and forth

Refocus: Bidi Cursor Movement

2007-05-08 Thread Dov Feldstern
Hi! This issue seems to have generated a lot of discussion, and I think we sort of lost our focus. So I'm going to try to respond to the various issues raised, and then I'll sketch out a plan for moving ahead with this. *) Andre asked about how other programs deal with this: I took a look at