Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Juergen Vigna
On 03-Jul-2001 Lars Gullik Bjønnes wrote: > Only the GUI specific code will ever access the XFormsView all other > code will acces it through the base pointer as: LyXView. Well I don't really care as long as it will work :), but I still think for this type of stuff we should have the names as t

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Tuesday 03 July 2001 10:47, Lars Gullik Bjønnes wrote: | > Juergen Vigna <[EMAIL PROTECTED]> writes: | > | > | On 03-Jul-2001 Lars Gullik Bjønnes wrote: | > | | > | >| > - adds a LyXViewBase that is the GUII of LyXView. | > | | > | Very go

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 03-Jul-2001 Lars Gullik Bjønnes wrote: | | > And I want to rename LyXViewBase to LyXView and LyXView to XFormsView | > or something. (Less changes to the code) | | Why? IMO the names are good as they are now! Would you call the Qt2 port | then also

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Angus Leeming
On Tuesday 03 July 2001 10:47, Lars Gullik Bjønnes wrote: > Juergen Vigna <[EMAIL PROTECTED]> writes: > > | On 03-Jul-2001 Lars Gullik Bjønnes wrote: > | > | >| > - adds a LyXViewBase that is the GUII of LyXView. > | > | Very good move! Just to be curious shouldn't the LyXView.* and Pai

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Juergen Vigna
On 03-Jul-2001 Lars Gullik Bjønnes wrote: > And I want to rename LyXViewBase to LyXView and LyXView to XFormsView > or something. (Less changes to the code) Why? IMO the names are good as they are now! Would you call the Qt2 port then also XFormsView? IMO this class names should stay equal for

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 03-Jul-2001 Lars Gullik Bjønnes wrote: | | >| > - adds a LyXViewBase that is the GUII of LyXView. | | Very good move! Just to be curious shouldn't the LyXView.* and Painter.* | be moved to the frontends directory? Which directory structure

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 03-Jul-2001 Lars Gullik Bjønnes wrote: | | >| > - adds a LyXViewBase that is the GUII of LyXView. | | Very good move! Just to be curious shouldn't the LyXView.* and Painter.* | be moved to the frontends directory? Which directory structure

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Juergen Vigna
On 03-Jul-2001 Lars Gullik Bjønnes wrote: >| > - adds a LyXViewBase that is the GUII of LyXView. Very good move! Just to be curious shouldn't the LyXView.* and Painter.* be moved to the frontends directory? Which directory structure would you propose, or would you just drop it into the

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | On Mon, Jul 02, 2001 at 03:37:49PM +0200, Lars Gullik Bjønnes wrote: | > | > But you should anyway... | > | > - changes a lot of method names to begin with lowercase. | > - adds a LyXViewBase that is the GUII of LyXView. | > - mov

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Dekel Tsur
On Mon, Jul 02, 2001 at 03:37:49PM +0200, Lars Gullik Bjønnes wrote: > > But you should anyway... > > - changes a lot of method names to begin with lowercase. > - adds a LyXViewBase that is the GUII of LyXView. > - move ProhibitInput and Allowinput into LyXView >

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Juergen Vigna
On 03-Jul-2001 Andre Poenitz wrote: >> We can go on discussing this for as much time as you like and every time >> I have to write a mail that is less time I can work on LyX, just select >> what you like more! > > I guess you are lucky that it is not Friday yet ;-) Well maybe I was a bit nervou

Re: huge patch that nobody really enjoys looking at...

2001-07-03 Thread Juergen Vigna
On 02-Jul-2001 Lars Gullik Bjønnes wrote: >| One more stuff Lars I REALLY would apreciate if you would leave the >| 'if ((expr == oexpt) || some_bool)' parentesis untouched. I think we >| already discussed this and at least in the files I have to work with >| "A LOT", I'm faster to see what happ

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Andre Poenitz
> We can go on discussing this for as much time as you like and every time > I have to write a mail that is less time I can work on LyX, just select > what you like more! I guess you are lucky that it is not Friday yet ;-) Andre' -- André Pönitz . [E

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 02-Jul-2001 Lars Gullik Bjønnes wrote: | | > InsetText::deleteLyXText, InsetText::resizeLyXText | | I'll look at this again as soon as you stop makeing a lot of unnecessary | changes to the file. Please commit "reformat" patches as what t

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | One more stuff Lars I REALLY would apreciate if you would leave the | 'if ((expr == oexpt) || some_bool)' parentesis untouched. I think we | already discussed this and at least in the files I have to work with | "A LOT", I'm faster to see what happens i

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Lars Gullik Bjønnes
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 02-Jul-2001 Jean-Marc Lasgouttes wrote: | | > If you had separated the renaming stuff from the rest, it would | > probably have been easier to follow. | | Well Lars you don't follow your own rules, one thing one patch ;) I know I know... that is w

RE: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Juergen Vigna
On 02-Jul-2001 Lars Gullik Bjønnes wrote: > InsetText::deleteLyXText, InsetText::resizeLyXText I'll look at this again as soon as you stop makeing a lot of unnecessary changes to the file. Please commit "reformat" patches as what they are. What I've seen so far you just move more stu

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Juergen Vigna
One more stuff Lars I REALLY would apreciate if you would leave the 'if ((expr == oexpt) || some_bool)' parentesis untouched. I think we already discussed this and at least in the files I have to work with "A LOT", I'm faster to see what happens if I have the parentesis in place. We can go on di

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Juergen Vigna
On 02-Jul-2001 Jean-Marc Lasgouttes wrote: > If you had separated the renaming stuff from the rest, it would > probably have been easier to follow. Well Lars you don't follow your own rules, one thing one patch ;) I'll have a look at the insttext patch. Certainly you know on what I'm working a

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | | What are we supposed to say about it? | | Lars> "Ok, great. another patch that is impossible to grok." | | Hmm, it does not look so terrible, it is just a bit large. yes...

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | What are we supposed to say about it? Lars> "Ok, great. another patch that is impossible to grok." Hmm, it does not look so terrible, it is just a bit large. Lars> | Are you worried it could break | some things? Lars> Yes. If

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> But you should anyway... - changes a lot of method names to | Lars> begin with lowercase. - adds a LyXViewBase that is the GUII of | Lars> LyXView. - move ProhibitInput an

Re: huge patch that nobody really enjoys looking at...

2001-07-02 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> But you should anyway... - changes a lot of method names to Lars> begin with lowercase. - adds a LyXViewBase that is the GUII of Lars> LyXView. - move ProhibitInput and Allowinput into LyXView - Lars> removes some friends from