Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
| >>>>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
|
| | What are we supposed to say about it?
|
| Lars> "Ok, great. another patch that is impossible to grok."
|
| Hmm, it does not look so terrible, it is just a bit large.
yes... the changes are fairly simple.
| Lars> | Are you worried it could break | some things?
|
| Lars> Yes.
|
| If you had separated the renaming stuff from the rest, it would
| probably have been easier to follow.
I know... but I didn't have net during the weekend... so the different
changes all got done in the same tree.
| Lars> | My only problem is that you seem to comment out some | things
| Lars> related to lyxlookup.h, and we still need that for xforms 0.88 |
| Lars> compatibility (0.89.6 does not exist on all architectures).
|
| Lars> Hmm... I knew someone would notice that...
|
| What did you do exactly?
Just commented out the inclusion of those header files.
I am not sure if I need them in both LyXViewC and in LyXViewBase.C.
| Lars> anyway the changes to InsetText speeds up the getLyXText a lot
| Lars> (50%).
|
| You do one lookup instead of two, right?
yes, and in some cases even less.
(i.e. one instead of three)
--
Lgb
