Re: Tabular: call for help

2010-03-04 Thread Uwe Stöhr
Am 04.03.2010 09:34, schrieb Abdelrazak Younes: You somehow broke the connection between InsetTabular and GuiTabular: Yes, there is no such connection anymore. The dialog will be enabled only if the cursor is _within_ an InsetTabular. Maybe you moved your cursor outside of it? Or maybe you are

Re: Tabular: call for help

2010-03-04 Thread Abdelrazak Younes
On 03/04/2010 04:31 AM, Uwe Stöhr wrote: In case you didn't notice in the commit logs, I committed a big patch that changed quite fundamentally how the tabular inset and its dialog works. There is still a lot of room for improvement but I believe we are now in a much saner situation. This code wa

Re: Tabular: call for help

2010-03-03 Thread Uwe Stöhr
In case you didn't notice in the commit logs, I committed a big patch that changed quite fundamentally how the tabular inset and its dialog works. There is still a lot of room for improvement but I believe we are now in a much saner situation. This code was so broken and complicated that it was al

Re: Tabular: call for help [reproducible crash report]

2010-02-21 Thread Pavel Sanda
Manoj Rajagopalan wrote: > Should I file a bug report? I could provide a GDB backtrace. the usual approach is to put it there when its not fixed in a very few days. pavel

Re: Tabular: call for help [reproducible crash report]

2010-02-21 Thread Manoj Rajagopalan
I'm getting a crash with formulas in table cells and I wonder if it is due to these changes. It is always reproducible with the following steps: 1. Create new document 2. Create table from the toolbar button (I create 2x2) 3. Enter a cell (I choose top left) 4. Ctrl-M to create formula 5. Enter

Re: Tabular: call for help

2010-02-21 Thread Uwe Stöhr
Am 21.02.2010 09:04, schrieb Abdelrazak Younes: - create a new document - insert a table - view PDF Result: Crash with this message: Qt Concurrent has caught an exception thrown from a worker thread. This is not supported, exceptions thrown in worker threads must be caught before control return

Re: Tabular: call for help

2010-02-21 Thread Abdelrazak Younes
On 20/02/2010 01:21, Uwe Stöhr wrote: > Oups, sorry, I didn't check that... now fixed. This works now, but LyX crashes (don't know which of today's commits causes this): - create a new document - insert a table - view PDF Result: Crash with this message: Qt Concurrent has caught an exception

Re: Tabular: call for help

2010-02-19 Thread Uwe Stöhr
> Oups, sorry, I didn't check that... now fixed. This works now, but LyX crashes (don't know which of today's commits causes this): - create a new document - insert a table - view PDF Result: Crash with this message: Qt Concurrent has caught an exception thrown from a worker thread. This is no

Re: Tabular: call for help

2010-02-19 Thread Abdelrazak Younes
On 19/02/2010 18:26, Abdelrazak Younes wrote: On 19/02/2010 14:36, Vincent van Ravesteijn - TNW wrote: So, please hard test this dialog and try to fix remaining bugs (which is now way easier than before). I find it very strange that the Apply button changes to New if you check auto-apply. The

Re: Tabular: call for help

2010-02-19 Thread Abdelrazak Younes
On 19/02/2010 14:36, Vincent van Ravesteijn - TNW wrote: So, please hard test this dialog and try to fix remaining bugs (which is now way easier than before). I find it very strange that the Apply button changes to New if you check auto-apply. These two functions are not related in a

RE: Tabular: call for help

2010-02-19 Thread Vincent van Ravesteijn - TNW
>So, please hard test this dialog and try to fix >remaining bugs (which is now way easier than before). I find it very strange that the Apply button changes to New if you check auto-apply. These two functions are not related in any sense. Besides, why would I only be able to insert a new table i

Re: Tabular: call for help

2010-02-19 Thread Abdelrazak Younes
On 02/19/2010 01:06 PM, Uwe Stöhr wrote: Abdelrazak Younes schrieb: I appreciate your effort in the code cleanup but now nearly everything is broken: - setting/unsetting lines doesn't work - settung multicoumns and -rows doesn't work Both things were working when I tested, weird... Didn't yo

Re: Tabular: call for help

2010-02-19 Thread Uwe Stöhr
Abdelrazak Younes schrieb: I appreciate your effort in the code cleanup but now nearly everything is broken: - setting/unsetting lines doesn't work - settung multicoumns and -rows doesn't work Both things were working when I tested, weird... Didn't you forget to click on the [Apply] button?

Re: Tabular: call for help

2010-02-19 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > In case you didn't notice in the commit logs, I committed a big patch > that changed quite fundamentally how the tabular inset and its dialog > works. There is still a lot of room for improvement but I believe we are > now in a much saner situation. This code was so br

Re: Tabular: call for help

2010-02-19 Thread Abdelrazak Younes
On 02/19/2010 12:00 AM, Uwe Stöhr wrote: Hi Abdel, I appreciate your effort in the code cleanup but now nearly everything is broken: - setting/unsetting lines doesn't work - settung multicoumns and -rows doesn't work Both things were working when I tested, weird... Didn't you forget to clic

Re: Tabular: call for help

2010-02-18 Thread Uwe Stöhr
Hi Abdel, I appreciate your effort in the code cleanup but now nearly everything is broken: - setting/unsetting lines doesn't work - settung multicoumns and -rows doesn't work - setting a width breaks the table lines - setting an alignment is no longer possible Edwin and I were on bugfixing the