On 03/04/2010 04:31 AM, Uwe Stöhr wrote:
In case you didn't notice in the commit logs, I committed a big patch
that changed quite
fundamentally how the tabular inset and its dialog works. There is
still a lot of room for
improvement but I believe we are now in a much saner situation. This
code was so broken and complicated that it was almost funny :-)

So, please hard test this dialog and try to fix remaining bugs (which
is now way easier than before).

You somehow broke the connection between InsetTabular and GuiTabular:

Yes, there is no such connection anymore. The dialog will be enabled only if the cursor is _within_ an InsetTabular. Maybe you moved your cursor outside of it? Or maybe you are in a caption in the table? In which case that would be a bug.



- create a table
- open the table dialog and use the option "apply immediately"
- set the checkbox to make the table a longtable

Result: All longtable settings are still greyed out. (Before your
changes, these options were correctly enabled.)

I cannot figure out the problem because the GuiTabular code wasn't
changed and this code is absolutely correct.

The "connection" is in Dialog::inset(InsetCode code), maybe there is something to be adjusted here for long table.



Can you please have a look?

I'll try.

Abdel.

Reply via email to