Re: [patch] Re: RFC: Use Author hash value to identify tracked changes

2009-07-30 Thread Andre Poenitz
On Thu, Jul 30, 2009 at 03:05:10AM +0100, Gregory Jefferis wrote: > [ second patch series ] A few more nits: > + authorindex=-1; Common LyX style uses spaces around binary operators > + if(it != bp.author_map.end()) ... and after if, while etc (but not after function names) > +

Re: [patch] Re: RFC: Use Author hash value to identify tracked changes

2009-07-30 Thread Andre Poenitz
On Thu, Jul 30, 2009 at 03:05:10AM +0100, Gregory Jefferis wrote: > After a long hiatus, I returned to this problem, editing my previous patch > series to respond to the helpful comments from various people on the list. > Vincent made the most detailed response so I responded below point by point >

[patch] Re: RFC: Use Author hash value to identify tracked changes

2009-07-29 Thread Gregory Jefferis
Hello all, After a long hiatus, I returned to this problem, editing my previous patch series to respond to the helpful comments from various people on the list. Vincent made the most detailed response so I responded below point by point and attached the v2 patch series for comment. This complete e

Re: RFC: Use Author hash value to identify tracked changes

2009-06-29 Thread Vincent van Ravesteijn
Gregory Jefferis schreef: This patch identifies the author of tracked changes written out to lyx file with a hash value constructed from author+email That way the author id never changes on write, allowing painless merging of files containing tracked changes. Comments very welcome - this is not

Re: RFC: Use Author hash value to identify tracked changes

2009-05-22 Thread Pavel Sanda
Gregory Jefferis wrote: > This patch identifies the author of tracked changes written out to lyx file > with a hash value constructed from author+email - if i understand your changes you put hash by default in any .lyx file. it is not possible easily get name and mail back from this kind of has

Re: RFC: Use Author hash value to identify tracked changes

2009-05-22 Thread Vincent van Ravesteijn
Gregory Jefferis schreef: This patch identifies the author of tracked changes written out to lyx file with a hash value constructed from author+email That way the author id never changes on write, allowing painless merging of files containing tracked changes. Comments very welcome - this is not

Re: RFC: Use Author hash value to identify tracked changes

2009-05-21 Thread Andre Poenitz
On Thu, May 21, 2009 at 05:42:00PM +0100, Gregory Jefferis wrote: > This patch identifies the author of tracked changes written out to lyx file > with a hash value constructed from author+email > > That way the author id never changes on write, allowing painless merging of > files containing track