On Thu, Jul 30, 2009 at 03:05:10AM +0100, Gregory Jefferis wrote: > [ second patch series ]
A few more nits: > + authorindex=-1; Common LyX style uses spaces around binary operators > + if(it != bp.author_map.end()) ... and after if, while etc (but not after function names) > + bufferparams::authormap::const_iterator > it(bp.author_map.find(authoridentifier)); Use ... it = bp. ... instead of function-style initialization if it does not make a practical difference. It's slightly easier to read and reduces the likelihood to define a function instead of a variable. There's typically no overhead. > + (boost::uint32_t) fullauthorasstring[i] Use at least 'function-style casts' instead of C-style casts for trivial conversions: boost::uint32_t(fullauthorasstring[i]) A slightly more personal issue: > boost::int32_t All the platforms LyX currently supports have 8-bit-bytes and sizeof int == 4. So boost::int32_t == int for all practical reasons. In order to keep 'external' dependencies at a minimum (especially in headers) I'd prefer using 'int' and possibly a static assert on its size and a comment in one of the implementation files to make it 'future-proof' Andre'
