Gregory Jefferis wrote: > This patch identifies the author of tracked changes written out to lyx file > with a hash value constructed from author+email
- if i understand your changes you put hash by default in any .lyx file. it is not possible easily get name and mail back from this kind of hash, right? (there is a consensus we shouldn't leak name and mail into the file unless explicitly requested by the user.) hash collisions are resolved (i havent read the code carefully...)? > That way the author id never changes on write, allowing painless merging of > files containing tracked changes. > > Comments very welcome - this is not final. - i see your changes are done in 1.6 branch. move your work to trunk, introduced filformat change can't be put into 1.6.x series. - fileformat changes need some bits around - eg see r29775. - is uint32_t portable thing? lyx is compiled on various compilers and OS'ses. - isn't return abs((int32_t)hash); somewhat less dangerous? - header of the attachments should be another like text/x-patch, Encoding: quoted-printable so we can directly reply to the attachments code. welcome here :) pavel
