Re: Lyx1.5 crashes in preferences

2006-11-09 Thread Edwin Leuven
Abdelrazak Younes wrote: and that's good. Most of the patch is reformatting so I think you should put it in. done

Re: Lyx1.5 crashes in preferences

2006-11-09 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Then I suggest that you commit that part. it's in Concerning the other reorganisation patch. Please post it again afterward, we will discuss then if it makes sense or not to reorganise that stuff now (I didn't look at this patch yet so I don't kn

Re: Lyx1.5 crashes in preferences

2006-11-09 Thread Edwin Leuven
Abdelrazak Younes wrote: Then I suggest that you commit that part. it's in Concerning the other reorganisation patch. Please post it again afterward, we will discuss then if it makes sense or not to reorganise that stuff now (I didn't look at this patch yet so I don't know if the change are

Re: Lyx1.5 crashes in preferences

2006-11-09 Thread Abdelrazak Younes
Edwin Leuven wrote: Edwin Leuven wrote: i think i tracked down the troubles in the updating while reorganizing (simplifying) the code a bit. attached the subset that fixes the crashes... Then I suggest that you commit that part. Concerning the other reorganisation patch. Please post it agai

Re: Lyx1.5 crashes in preferences

2006-11-09 Thread Edwin Leuven
Edwin Leuven wrote: i think i tracked down the troubles in the updating while reorganizing (simplifying) the code a bit. attached the subset that fixes the crashes... Index: frontends/qt4/QPrefsDialog.C === --- frontends/qt4/QPrefs

Re: Lyx1.5 crashes in preferences

2006-11-08 Thread Edwin Leuven
i think i tracked down the troubles in the updating while reorganizing (simplifying) the code a bit. the patch is not very readable but here is what it does: the first problem was due to qlistview emitting currentRowChanged(int) signals when refilling it (and then triggering swicht_converter(in

Re: Lyx1.5 crashes in preferences

2006-11-07 Thread Edwin Leuven
i've been trying to look into this weird crash and have added the following to see which converters are there: void PrefConverters::updateButtons() { lyxerr << "UPDATEBUTTONS START" << std::endl; Converters::const_iterator ccit1 = form_->converters().begin(); Converters:

Re: Lyx1.5 crashes in preferences

2006-11-06 Thread Peter Kümmel
Michael Gerz wrote: > Peter Kümmel wrote: > >> I've fixed it: >> >> Index: QPrefsDialog.C >> === >> --- QPrefsDialog.C (revision 15726) >> +++ QPrefsDialog.C (working copy) >> @@ -938,10 +938,13 @@ >> >> void PrefConverters:

Re: Lyx1.5 crashes in preferences

2006-11-05 Thread Michael Gerz
Peter Kümmel wrote: I've fixed it: Index: QPrefsDialog.C === --- QPrefsDialog.C (revision 15726) +++ QPrefsDialog.C (working copy) @@ -938,10 +938,13 @@ void PrefConverters::switch_converter(int nr) { - if (nr<0) +

Re: Lyx1.5 crashes in preferences

2006-11-04 Thread Kornel Benko
Am Samstag, 4. November 2006 14:09 schrieb Peter Kümmel: ... > I've fixed it: Confirmed. Works now as expected. > > BTW the dialog is strange, I have to click modify and save to change the > value. I second that. On the other hand, its was there for ages ... Kornel -- Kornel Benko [EM

Re: Lyx1.5 crashes in preferences

2006-11-04 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Kernel Benko wrote: >>> Start LyX >>> >>> go to Tools->Preferences...->File Format >>> change e.g. Viewer >>> click Modify >>> crash >>> ... >>> >>> This happens independent of content of my old (1.4) preferences file. >>> I can provide a dump too,

Re: Lyx1.5 crashes in preferences

2006-11-04 Thread Abdelrazak Younes
Peter Kümmel wrote: Kernel Benko wrote: Start LyX go to Tools->Preferences...->File Format change e.g. Viewer click Modify crash ... This happens independent of content of my old (1.4) preferences file. I can provide a dump too, but since it is so easy to reproduce here, there may be no need

Re: Lyx1.5 crashes in preferences

2006-11-04 Thread Peter Kümmel
Kernel Benko wrote: > Start LyX > > go to Tools->Preferences...->File Format > change e.g. Viewer > click Modify > crash > ... > > This happens independent of content of my old (1.4) preferences file. > I can provide a dump too, but since it is so easy to reproduce here, there > may > be no nee