Edwin Leuven wrote:
Abdelrazak Younes wrote:
Then I suggest that you commit that part.
it's in
Concerning the other reorganisation patch. Please post it again
afterward, we will discuss then if it makes sense or not to reorganise
that stuff now (I didn't look at this patch yet so I don't know if the
change are safe or not).
atttached.
the modify/new functions in the formats and converter modules share most
of their code, the patch basically makes them share the common code
(that's how i found the missing call
form_->converters().update(form_->formats()))
Yes, and that will potentially help to discover other bugs.
it also removes rid the pointer to PrefConverters in the
formats module
that's all
and that's good. Most of the patch is reformatting so I think you should
put it in.
Abdel.
